From: Huan Yang <link@vivo.com>
To: Yu Zhao <yuzhao@google.com>, Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Huan Yang <link@vivo.com>, Suren Baghdasaryan <surenb@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-mm@kvack.org
Cc: opensource.kernel@vivo.com
Subject: [PATCH 0/2] check MGLRU promoted without hold page lock
Date: Fri, 20 Oct 2023 16:43:49 +0800 [thread overview]
Message-ID: <20231020084358.463846-1-link@vivo.com> (raw)
This patchset add a new reclaim_stat named nr_promote to observe
number folios which MGLRU promoted before shrink touch, and then
show in mm_vmscan_lru_shrink_inactive. Also, fix nr_scanned in MGLRU
trace into nr_taken. (patch1)
Base this trace, here are many folio promoted before shrink touch,
so, due to the high frequence, move this check before hold page lock
is better.(patch2)
Due to we will not actually touch this folio, nr_promote trace is
unnecessary, remove this trace.
This patchset based on link:
https://lore.kernel.org/all/20231018082104.3918770-1-link@vivo.com/
Which have many mistake pointed by Yu Zhao.(thanks)
Huan Yang (2):
tracing: mm: multigen-lru: fix mglru trace
mm: multi-gen LRU: move promoted folio out of lock
include/trace/events/vmscan.h | 3 ++-
mm/vmscan.c | 31 ++++++++++++++++++++++---------
2 files changed, 24 insertions(+), 10 deletions(-)
--
2.34.1
next reply other threads:[~2023-10-20 8:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 8:43 Huan Yang [this message]
2023-10-20 8:43 ` [PATCH 1/2] tracing: mm: multigen-lru: fix mglru trace Huan Yang
2023-10-20 8:43 ` [PATCH 2/2] mm: multi-gen LRU: move promoted folio out of lock Huan Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231020084358.463846-1-link@vivo.com \
--to=link@vivo.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=rostedt@goodmis.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox