From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAED9CDB474 for ; Fri, 20 Oct 2023 04:47:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F0848D01BD; Fri, 20 Oct 2023 00:47:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 579F48D001C; Fri, 20 Oct 2023 00:47:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4412D8D01BD; Fri, 20 Oct 2023 00:47:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3192C8D001C for ; Fri, 20 Oct 2023 00:47:38 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id F368D120553 for ; Fri, 20 Oct 2023 04:47:37 +0000 (UTC) X-FDA: 81364606554.29.DAAF957 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf16.hostedemail.com (Postfix) with ESMTP id 142E018000A for ; Fri, 20 Oct 2023 04:47:35 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf16.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697777256; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LF/2pXiEqY9+EtDuDwgJ7ilyeXl3GU4Y+S83WH/N+Zw=; b=n/IQO6T2UOrR3bOQt29PgoLAoan0eJAKtFxf1QkBsL4DE8AduP5rq6UppkfkNHx4JVyPaD RnOF304AGOgsz1e5d03tmklyq7w/W/TBeCdy9gtmijJ9ONnvJ8Lu0j4siq8bPAGbaRIrYk tbMNres2DRz00su1RB556H4JxNNrnZY= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf16.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697777256; a=rsa-sha256; cv=none; b=oVxKbOclce3Gu4w3nfsRBUzohCH7eqgUSTGAwJVxoHwGNuyvnVOfeOoByixIh1vQiMM6Uu z5wKOB4UUZvx1zJ5OGqxz6vh3Z881L+hbfRmSXuSHvb0jcVyBxibiszhMh15BCuhsOIIuQ e3XtusFMTFSpSiCq586fXhRPqtq09sY= Received: by verein.lst.de (Postfix, from userid 2407) id 3C79D67373; Fri, 20 Oct 2023 06:47:32 +0200 (CEST) Date: Fri, 20 Oct 2023 06:47:31 +0200 From: Christoph Hellwig To: Kefeng Wang Cc: Christoph Hellwig , Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH] mm: cma: report correct node id Message-ID: <20231020044731.GD11984@lst.de> References: <20231019013253.2792048-1-wangkefeng.wang@huawei.com> <20231019050229.GA13957@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 142E018000A X-Stat-Signature: osmnnugdzppaiakemofrgx3zsdywn46g X-HE-Tag: 1697777255-552770 X-HE-Meta: U2FsdGVkX18ybRG+2VhOeBZAXghYu9BEIR1zMLI6mXgSaH0IUZqaWtk5hvnVTzTqG/mIOyLL0l5QcoQGoJgSMkN2KxouIi9EtJxfJWaGRbXyPBrym4hu8gdfnC0L0WrePPzhiehHMhdYFw6ozYjJkhiTMDnJ1AZtrxO28k1RH34sIpQZd1X8uKybWK6N6u1f7zBiz7Oc7ieo7/h7geLLkMsMziQ5vhvFMGWw1h3hSWAmKaeFGlHXIP8lBRDMmnYswohCuX99v63WqquTEn2mAuLkQzeSX2oWW5eOuVjiADUtwDBdIBY0aUaOpEm3jZaefcKal9DDZKdDeH41zEs0K32B41wMmpEGZl3neVS3RW7Oub8mnBUERWpeS3X6wvyS/wqMegWSoB4rpjUIy09BQNFVye3kDOMQ9Z1fwP0SuXDKILkmpaGsgEM91cv1dKXB/Bk41dBOrpFk+6Ghaxs1TiiiNVW99C+GogSAzOwM+BR+k1k8qaLoU3tV9GaUbI9RDh9eICXu7pdp5AVsOOD4o6pq9XAwXJGRHP3m8GcUzmGq52Cn4j8NhFzPHrIz6lyZocveOT/BulcSPxs2E4x+oAec6gE/S4DnoTNVVhL8brYx9QpyMbGg0w5R4sOYQv19mmGkunop6b6diB5TxYcVU3Uef/M+wypcDZH2RCTZbF5ToUpibPg8DxckVT2l3xuHJC0r7QezP43Yv2KLWHI8JlDt25oymd2PKXKIaKl5LOkS0wXKMmyEUcfEHZ1I2fMD/vWHJBcplYifWd2qAxmWkD0VMe7IEqr3+sy0qvzC62KLv6Fe3OVrnKp0j8F7+Dq16Sh6FQD25xl3F+XMvBrHb48SDl7LVVz1B1R1ukY16zFtcGkxwRTcnJqZaiPnc96Vipitv++Le+hczod2XGFFYz+Cft602p76RPf5hyZfyrfkKSZeKorMU24iGa8FiRo/Fhtw5ia97VKjteMnwXo 4o+l96C7 f7nD7LoDst5tYu7gV5ccG5MBncioFpO4iR+CV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 19, 2023 at 03:02:10PM +0800, Kefeng Wang wrote: >>> Use early_pfn_to_nid() to get correct node id from base instead of >>> the default NUMA_NO_NODE in cma_declare_contiguous_nid(). >> >> Why? > > before: > cma: Reserved 32 MiB at 0x00000000fe000000 on node -1 > after: > cma: Reserved 32 MiB at 0x00000000fe000000 on node 0 > > I think the real nid 0 is better than -1, but yes, it is not > a big deal. So please document that in your commit log.