From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07F3FCDB483 for ; Thu, 19 Oct 2023 18:36:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 92B65800A3; Thu, 19 Oct 2023 14:36:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DBFF8D0087; Thu, 19 Oct 2023 14:36:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A3E9800A3; Thu, 19 Oct 2023 14:36:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 699958D0087 for ; Thu, 19 Oct 2023 14:36:33 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 313E3140FA4 for ; Thu, 19 Oct 2023 18:36:33 +0000 (UTC) X-FDA: 81363066666.22.3553697 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 36A281C001B for ; Thu, 19 Oct 2023 18:36:31 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=LGlDCYd4; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697740591; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bZ2lGPpq+wa3iVSxjFUEYW16Jfk6V0kS+B+5yIHbqA4=; b=FOzZMz217Ug2x7OuG0bsH8Eb1Vpe4/mONERbLGUXS/5zOslgusDSF3Cd10/F3+q43faemd c60VMgkBr396cxtGspI6FqhizXSnDosUhzvCv9oaeZ49Su94EHtiLoQSxsFFRZkiDVmSgq MN1AB0tRUJnmbkBVO65/INQRJHRemjI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697740591; a=rsa-sha256; cv=none; b=Rxx4zHOp0j+By4FG7MO/0ur8rAm7rrcLT4YqaeQ5ZlV1wmsD6fannxrptA5lV3YLXD6ntX Qj3iGJ0GSHMvEjYvJX2FiB0eSIJMYlaqIi/smwI8cbW1tijNpeHKAqrw+xFVbdCHMsLWGm XMvQYh/FLv2Ia6IpOqjrHgQBm03zuz8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=LGlDCYd4; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9819B61CE3; Thu, 19 Oct 2023 18:36:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1524C433C8; Thu, 19 Oct 2023 18:36:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1697740589; bh=N5tbmRas55JfDzqhMXJ+i0cestblFrOR68Qefmyv6Js=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LGlDCYd4Nntn7LhHdPQuYjW/eGfDfTuVBVSCrJlDqDeOF/YO+GnAdgUvf9jSv4You NMKgzBNirl/kQp/oEaeVXfXQ6Bq5IblCnq7A1ftavZtS/XiG/8RgNOXGbgzjBiHkVt ve0G4xUTvQ7Q1kV3o3fhddvZ3BoAXxcf2XNu3hfM= Date: Thu, 19 Oct 2023 11:36:27 -0700 From: Andrew Morton To: Nhat Pham Cc: Yosry Ahmed , hannes@cmpxchg.org, cerasuolodomenico@gmail.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah@kernel.org, Hugh Dickins Subject: Re: [PATCH v3 0/5] workload-specific and memory pressure-driven zswap writeback Message-Id: <20231019113627.bca226b1ac17fe9c3beecb21@linux-foundation.org> In-Reply-To: References: <20231017232152.2605440-1-nphamcs@gmail.com> <20231019101204.179a9a1d2c7a05b604dad182@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 36A281C001B X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: wiuetpzw5eghuefz8miumcemnqp51x6g X-HE-Tag: 1697740591-646181 X-HE-Meta: U2FsdGVkX1+M+U1eSNvL+gFi5QqLOf/R4IE9YP4nMFtm8+sSLaLz5XJ17eC0gXJeLpjNKgBVZpjh7guPBsClPzZJPoFmWCTasywdvIChVSIOeiTdKAcgkyhpjHYGKUCa4soltUISoA1rfmwUWzf8DsTzuFJh5SbGh5hxJ+ya//a/g72oZFxc+5/OSZSfEF97SZ4odjVaT/P/sJFGbg4MFlt9ZwI9G6tSu83jMdoIIuTVHXFccJZvI4+J4IcpjYHhNjyDj5mNWfWv329PC4/yynZ30DmHTAWvb8xkNt9ABLgqxQDSkUUXbyS/Uk7T4J2ijYL9/GsqypYjJS52ih70a5ZR1ci9AMpSnZNEFfvvSFipVhkArqfkHTDxuuCalnxjqMQEyu5Eqnc2TavgpU2ojUlQl3XjBGyjXuMljRiPhJgdOIFkAC3t3GNXkFdNpFgN3BHljWuITfgQdb8wEmQxXWwnDFEYyE6pMmeTFXtBfMI2hLmOKhUupL8yrhS0n+9M1QXpZwJjClRlryyBdoiTH11rOuEX4euURXf2RbB65T/Ord8mp36uymTOAVlrKFsomnh/N71s8xIfMarEcnKp4vaS7n9/EGRZtIJ2bx7GtR6daSHhwbC9r3a+IzoMdYB7r4cKpTaYlhl3drq6Nw/zKUCp4Ub/iS365/IEDCcylNVzP51ZtlOtyXoke25ImH3D5G5r/1rb/hNj87q3r38aFMHfRMV5PgC/SHv6oP6gSuT6Pkw5Nn6HKyVy4nrjLmekBKT5qqmwj6Kf9kYSgrQ4ckkxIHsboot5/XIsQ3P158KxlygJA9vierzbrqpTtBTTSddrqdxF1ray+a19hhSdhh04xU/IomlrZ71Q6vzojoJvjburCX++e/tgG3yEZFA5cboqIxX5SUEentsTqWMSkHba4zFL3Jiu2IbgGutPtlXLf3fRf0E6Icjncgs3upGV0e/nI3xBtUsjF9dCVtT yvlylduA dUW2x+M+LpOjJLTbY13xrWnwTr1UKVMA6ieYwo9ifwCfhFOBQtZGgHKpW7Bvt9WisP8dPoPMWaFKyXsKAojg1CpxXwEUOhTpGhxJl6H58y27CfP1KP+LmZf9I0pQoKUcdVB9msUeZcFom2JfT9a2OrUg/bsA5NidEL6AXI+cUAU7iIjc8E/kBPHaMvadmZBTvuKf7c5kxgUyUlS31xmKMLy1dCH309CC0vSp4YdxLvO9N7XgBfcCC0HGx7nQNxEYRCDhY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 19 Oct 2023 11:31:17 -0700 Nhat Pham wrote: > > There are parts of the code that I would feel more comfortable if > > someone took a look at (which I mentioned in individual patches). So > > unless this happens in the next few days I wouldn't say so. > > > > I'm not super familiar with the other series. How big is the dependency? > Looks like it's just a small part in the swapcache code right? > > If this is the case, I feel like the best course of action is to rebase > the mempolicy patch series on top of mm-unstable, and resolve > this merge conflict. OK, thanks. Hugh, do you have time to look at rebasing on the mm-stable which I pushed out 15 minutes ago? > I will then send out v4 of the zswap shrinker, > rebased on top of the mempolicy patch series. > > If this is not the case, one thing we can do is: > > a) Fix bugs (there's one kernel test robot it seems) > b) Fix user-visible details (writeback counter for e.g) > > and just merge the series for now. FWIW, this is an optional > feature and disabled by default. So performance optimization > and aesthetics change (list_lru_add() renaming etc.) can wait. > > We can push out v4 by the end of today and early tomorrow > if all goes well. Then everyone can review and comment on it. >