From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6ABDCDB465 for ; Thu, 19 Oct 2023 16:50:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CEF08D01A8; Thu, 19 Oct 2023 12:50:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 57F098D001A; Thu, 19 Oct 2023 12:50:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 448848D01A8; Thu, 19 Oct 2023 12:50:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 34E878D001A for ; Thu, 19 Oct 2023 12:50:36 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 085BB120587 for ; Thu, 19 Oct 2023 16:50:36 +0000 (UTC) X-FDA: 81362799672.04.8095A85 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf29.hostedemail.com (Postfix) with ESMTP id 226CE12000B for ; Thu, 19 Oct 2023 16:50:33 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=BnG+Idv8; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697734234; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lQweQwwpGWkIMbApVgMDhxYexLyt5MEybIY7O6WupmA=; b=Knd3XWGWFS1yOnmOMj0JuNKma2GmNCGlXn73aZZtPsh82AbMTqE2hxroK7qy+xM8iE6ecj ClXMnoVXFd4gtvM8XqmNDzVVKoymSsP6utXYuUMnmRjQ/crzZEY911TMS9kLK6SVlRwzyH gElGh54TmZ0dbAITbxV+k0l1g2puPng= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697734234; a=rsa-sha256; cv=none; b=h2dHx0cWiEeMtsp466/fnVEmrVqD7BP/ipxgo6aMpGBNjAXMazptuqK8XSCLPbG4KS2vK9 M29B2mhnHs/XD01A86FVqDEbiG6wFCJXoyl7qzg/us7t2EEBmoh7yXP8xPm9qsDK3vAvxa 2CeIJKwmfbSESEWSwZSINrXYzH8KYgI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=BnG+Idv8; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 356BFB82B82; Thu, 19 Oct 2023 16:50:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B14CC433C7; Thu, 19 Oct 2023 16:50:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1697734231; bh=FXh21OoAGR8XHVEBB81BE7UVszOS/EKxof6T4KL6Nl4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BnG+Idv8nNr0gcKnCyQpK3n/ViH2zsIUK+GNsyvYWvaNLLRkuhA3s6xv1G6OP5uEJ z8+9ayy43IEQoWYNVfjdT9j5RzedEbnOiqaC9LsPyfeKYpLo32AhxWtG1lYZdAId81 oVxmwWcFznV37Idq+XTw28lf/Vy534RnOGktF4do= Date: Thu, 19 Oct 2023 09:50:30 -0700 From: Andrew Morton To: Baoquan He Cc: Dan Carpenter , Philip Li , oe-kbuild@lists.linux.dev, Lorenzo Stoakes , lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Linux Memory Management List Subject: Re: mm/vmalloc.c:3689 vread_iter() error: we previously assumed 'vm' could be null (see line 3667) Message-Id: <20231019095030.7a1f3c93bc18511f52524aa8@linux-foundation.org> In-Reply-To: References: <89caf59a-d3b9-409d-b1ae-9e370cb9ee7d@kadam.mountain> <20231018085248.6f3f36101cbdfe0990c8b467@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 226CE12000B X-Rspam-User: X-Stat-Signature: 4guimgzjw1uh68zmqyxzk4ho9y5kttpy X-Rspamd-Server: rspam03 X-HE-Tag: 1697734233-966533 X-HE-Meta: U2FsdGVkX1/i6pm9K80egbBRyPkPZtaNqNQYBAPzpgw/z1PE1HRE/E2Qe4U3l3ZB3S8K9ZnjBI+X5iIReSOxurVo8DuI4bS9LnWcgfyRYUWK/3S9SkLX/GRrArP3fzVoMfkA0X0F+niY9yyDJBlI9Hy6BWZdQE5Olf9Pnkp3qWv9UDgtDi9hkb1ydPypP+L9lLL6bKcdhHqkuR0SHSjtvc+Stn9S4//rBOhuVl+GEfjPnIwHvAxhQDMpCpAUqOX0nrJvsR6Yl9+7BDEoR47tE2SdnT5KoxqrazXS3wyXFXKerzGAOj/xo9XUwUcvAPrcsiSkUaWK/GNlhZbRWziA9fbW2OkE5JFVu38UujeyyOpBezmgj91kj8Y/FFtJ84pyfNOp1yOyIEWUqjWKByc0KHMt0uUbv3Eq5ey9NT0Ly97O/EQJSwtQPPMfGv2iviqlsVxIPR8F8Xi3O/1f0VBmoU05jGjKrzfS7xPd/oz9NQTaQlcJZG5fYpiMgRUm3kJ5xb1LhD+tMlXGgvK/STFX4kno1N4qMX+3zjt3dHyCeOREBv40xOM4aq0b9BKvvuPfwl90mZ8f+a7HLV8rsOg9kq1uk2WVOXVOd4RThbnSZvrgphIoBxN2sxGANBPxQxjO1z5x6KPgNbRVJWvjR4+sf1fSwDdLR1slwB7L60eghPwYRDqJb7gMHgRMCH9E/wK9Bkb7hkKgNo/mgi8H4TiMuNNTUZDdpfQx+/dsuYk57N7C7V3Z7hQfWZUhPAvH1c0fp1CEUqgL87/yXQOrgdLj5aFZ69p0M92ZlccE1NSPO7a8eNGADWULdZlRGxZKkGthbbro0H295okmLdQ6+HnFRMoMZibYIWhhy0icCiu7koPtvcih1gLhrc+BMPSXqS4t6sYGIesteDAcSQZx4/iSfVA54uAZ0u4qSF7YB+OCo1i4tbb5QkfV+06cGRRsYoej25uILltLmCA8kqq3kDh ZRh6/npQ zbC7lrorPt9un1XkahWuQYN90f8QKqMKDI/WWXlzkYTrPJkU/TfVEbqzDT4GFLX4JPwpvkZ5Af2V3aQlf+Y1+1s3puzM7odHSiCaRdrT9Goo2jiQgiVFKDjDvyPASfVU3ygSVKzkyabWIJ5+pjwVTre/D23+IKIodB4i/OmPfRmsSlxL9G2jOQLssGUWChpuUz1Wy4PxjejjwOIuGGb8XZwl9xqaOzYv2tSv0zmdVpo0OFhXm+EMhuFNblw5lC3WHvD5ysZcEJwCI/Yft2GHa7lzGw2Vksiit7PMwq/Gr641SPvg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 19 Oct 2023 10:28:21 +0800 Baoquan He wrote: > I think this is not a real runtime bug. The only chance it can hapen is > when (flags == VMAP_BLOCK) is true. That has been warned and could never > happen. I updated patch log and paste v2 here. Thanks, I updated the changelog in-place.