From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82538C46CA1 for ; Wed, 18 Oct 2023 21:26:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1550A8004C; Wed, 18 Oct 2023 17:26:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1055F8D0016; Wed, 18 Oct 2023 17:26:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0EAD8004C; Wed, 18 Oct 2023 17:26:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E2F418D0016 for ; Wed, 18 Oct 2023 17:26:32 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AF80DB6201 for ; Wed, 18 Oct 2023 21:26:32 +0000 (UTC) X-FDA: 81359866224.28.EC95C21 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by imf12.hostedemail.com (Postfix) with ESMTP id 4C52340006 for ; Wed, 18 Oct 2023 21:26:29 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=JJ8Gvp+8; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf12.hostedemail.com: domain of lkp@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697664389; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=d4XmD+ynozoBChPFv+Rge3bghCQD8Kliih2tnNtrT3E=; b=jZnl+cUoQWIDKjstD1D3JbVT2YzHA5ndk16nmgn4DXKZz4zrazywRZKU5nya2J2R5T4OfH rgFD6XSwJ8UjGaVfK+IjnARtkZgbIPVjsBFVAE4kxH672bezxy04AwcZoIlj2tHCsDjKfg 6UIGf97BDtNuuNgDv09mOxFNAiEgFmM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=JJ8Gvp+8; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf12.hostedemail.com: domain of lkp@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697664389; a=rsa-sha256; cv=none; b=ZJlseeWeem0gB8ia2gpGWry5BrgXBSS6mPlKfydhHgTBifCpfY12XqRdkQp1BKkd/9pM3M 6FG9Z/uKBJOEUhYal5OiR5C+58HNogx9P5UyaGYgNrYz7b9gL/eVXBqhr2HpVtjuX5633e mkRPaAKwTlAjirUYBlWKuXb4ygZ+pVQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697664389; x=1729200389; h=date:from:to:cc:subject:message-id:mime-version; bh=iWXvx4OLdp9Gm3y9lHlrMQ58aF1ADMsDLMa6ofSLprA=; b=JJ8Gvp+8255Mo/0mkEWrzEbBjubGm1qfowbWX/fYzpwruNK2br7fFSx2 Y8zvJiL33RCAq4jmlA+8uUty/qC+YQfXvAym4SpdY85WM/z5SdM+Oi+LT QYn2BJNfIXHLC84BZHUEXfMKbsSvIw0wtME6vTJgb2hh+67wUe8Hh/qfj TueW4nPnZUt5tOBFeDPP91G/vHCcLA7ZmRFAvBeLrDrAgaCQG2aVcMXnx /5zFFLhTr8AucdWGbtPADzMq4XZZyYpgfH2+ZcoJDE6ce27qIMe41XvhK YEFFNYQ8Fkxlr+IiO8E72EpeUy6CDExkbIYOHGX7dNYbU8nj6tmEdnSVH g==; X-IronPort-AV: E=McAfee;i="6600,9927,10867"; a="388975279" X-IronPort-AV: E=Sophos;i="6.03,236,1694761200"; d="scan'208";a="388975279" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2023 14:26:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,236,1694761200"; d="scan'208";a="4507723" Received: from lkp-server01.sh.intel.com (HELO 8917679a5d3e) ([10.239.97.150]) by orviesa001.jf.intel.com with ESMTP; 18 Oct 2023 14:25:18 -0700 Received: from kbuild by 8917679a5d3e with local (Exim 4.96) (envelope-from ) id 1qtE3b-000152-2u; Wed, 18 Oct 2023 21:26:23 +0000 Date: Thu, 19 Oct 2023 05:25:34 +0800 From: kernel test robot To: Gerhard Engleder Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List Subject: [linux-next:master 12128/13299] drivers/net/ethernet/engleder/tsnep_main.c:470:25: warning: argument 2 null where non-null expected Message-ID: <202310190541.U0K7h90n-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Queue-Id: 4C52340006 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: iwbrr3aza1oembfnuojyzhpjci61cq3r X-HE-Tag: 1697664389-705498 X-HE-Meta: U2FsdGVkX1/PFTKZPsfLOjCNrFqmOAyHDyDOszjaUdvQNjj4064Miwdxyqmt+PT1rsvB+3alZtr/wIkuY7e8vKb5fo4Z+7bfnkkg4sFptniSSh4KtH7vR41C4BvWsIzXFsM0VvzScMnUkXnnYMxS1Vj0ZuBi7lBINzmazFiuTQ494fIY7SC/Kwzmi6tlJmh4BKjc14fyq3TQgBws9mz64ksWiRP//uMU4yl4km0j2CFVoIGNExyumDFp7CQOBoPUMy9kATOSLK/Vx6azHzmLjn7YodhrSRgJK/3Ltg/ZfMgQPmQWPM+P1SZ0BUDiySaAOjOqkM/YvXXYbZUZ86U0s/ra4fr+bMqdrXI7Z0CTkIikkzW2FawHHqEIGjtQYiAhfHE9j/iwhSGC7Wq2MeMVyxwa8yxtiwfdDY/ljbA2UylJdoP4mQSawRZdoWL+GsUGaD91uctLsjyZhOqYwgkXnrr2wirNYbTdElyyUThFQhqES3a5knSjYYz9UstQZ6ubxvbF2dzbi0S1PNU93xW57VrpJ3h2jMOeZGyt6PTKbduA35G/72QMzO52V5siPYwI6nQhKTba0UDWfxW13oYVGExyI+kKP13EI3AVYWC2Dg57Dzq9yo9bZGd0phOa1gwI7PMS1vcF7VITjJs55Ckz5iEPMcUTQTYlkSvK4Hn5fFCeJMk3/rvIhUxhAEzp0HVBKwbQEZyYGlcbz2CEsv2PGkQ+uL7JWbtW6jmDm5Ja4R5d9tEFLBTPAETKv7HVYmAOaY6mYosBKl1pqxx78/om6yBRBXXgwtezrs++83J9zTZvu+Vw7FNhS+NglCBV+x9z0zPS0YT5kyFtzjRDwPWKQ7OBj1Y2f0W6VrKQNycZwls7ydfEMYPWH2UEo9FRlGURlINMkFmIBfx+tMiByJS6wJiLVG27Ccx3AeCHFysC5OMfW32umXBxqd5Axx7yCnjH+32poSsZJUtc0mURD8a pnSxaOEj 7FZy/vCDEkYHKaexFGR5VHOFspGefg97lMOUljHUL3LWaLAUUjIXqsXOXps19cbB7i+LD25wPRcp7qagpVpq/0XnmA0vYGiPyhwYB74fQm6G6+rlhOVT38tDrjR0uSDRn1lBtVSmsoye2UGp9tC7qD3GaFd2L4TKcBZ0myJCBE7wJ7O956ZbC+nrkssdhrlSMf06YgWQYY6c3LyzrU4IDaAe6PaXKAizDdAlmA/cLTRlclpapntZhAH39qbWlWR81pgHhW3uWZP+w4VNPkos3fp56gQU+/bwXqWu0aX5GgBN20AR4u3XCHUuHTT1J+Cqoz3wiFJOs5PTD/lmaOiECgSKXIxsASDKBYlll X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 2dac75696c6da3c848daa118a729827541c89d33 commit: dccce1d7c04051bc25d3abbe7716d0ae7af9c28a [12128/13299] tsnep: Inline small fragments within TX descriptor config: powerpc64-randconfig-r033-20220404 (https://download.01.org/0day-ci/archive/20231019/202310190541.U0K7h90n-lkp@intel.com/config) compiler: powerpc64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231019/202310190541.U0K7h90n-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202310190541.U0K7h90n-lkp@intel.com/ All warnings (new ones prefixed by >>): In function 'tsnep_tx_map_frag', inlined from 'tsnep_tx_map' at drivers/net/ethernet/engleder/tsnep_main.c:511:13: >> drivers/net/ethernet/engleder/tsnep_main.c:470:25: warning: argument 2 null where non-null expected [-Wnonnull] 470 | memcpy(&entry->desc->tx, fragdata + skb_frag_off(frag), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 471 | len); | ~~~~ In file included from include/linux/string.h:20, from arch/powerpc/include/asm/paca.h:16, from arch/powerpc/include/asm/current.h:13, from include/linux/sched.h:12, from include/linux/ratelimit.h:6, from include/linux/dev_printk.h:16, from include/linux/device.h:15, from include/linux/platform_device.h:13, from drivers/net/ethernet/engleder/tsnep.h:9, from drivers/net/ethernet/engleder/tsnep_main.c:18: arch/powerpc/include/asm/string.h: In function 'tsnep_tx_map': arch/powerpc/include/asm/string.h:27:15: note: in a call to function 'memcpy' declared 'nonnull' 27 | extern void * memcpy(void *,const void *,__kernel_size_t); | ^~~~~~ vim +470 drivers/net/ethernet/engleder/tsnep_main.c 447 448 static int tsnep_tx_map_frag(skb_frag_t *frag, struct tsnep_tx_entry *entry, 449 struct device *dmadev, dma_addr_t *dma) 450 { 451 unsigned int len; 452 int mapped; 453 454 len = skb_frag_size(frag); 455 if (likely(len > TSNEP_DESC_SIZE_DATA_AFTER_INLINE)) { 456 *dma = skb_frag_dma_map(dmadev, frag, 0, len, DMA_TO_DEVICE); 457 if (dma_mapping_error(dmadev, *dma)) 458 return -ENOMEM; 459 entry->type = TSNEP_TX_TYPE_SKB_FRAG_MAP_PAGE; 460 mapped = 1; 461 } else { 462 void *fragdata = skb_frag_address_safe(frag); 463 464 if (likely(fragdata)) { 465 memcpy(&entry->desc->tx, fragdata, len); 466 } else { 467 struct page *page = skb_frag_page(frag); 468 469 fragdata = kmap_local_page(page); > 470 memcpy(&entry->desc->tx, fragdata + skb_frag_off(frag), 471 len); 472 kunmap_local(fragdata); 473 } 474 entry->type = TSNEP_TX_TYPE_SKB_FRAG_INLINE; 475 mapped = 0; 476 } 477 478 return mapped; 479 } 480 481 static int tsnep_tx_map(struct sk_buff *skb, struct tsnep_tx *tx, int count) 482 { 483 struct device *dmadev = tx->adapter->dmadev; 484 struct tsnep_tx_entry *entry; 485 unsigned int len; 486 int map_len = 0; 487 dma_addr_t dma; 488 int i, mapped; 489 490 for (i = 0; i < count; i++) { 491 entry = &tx->entry[(tx->write + i) & TSNEP_RING_MASK]; 492 493 if (!i) { 494 len = skb_headlen(skb); 495 if (likely(len > TSNEP_DESC_SIZE_DATA_AFTER_INLINE)) { 496 dma = dma_map_single(dmadev, skb->data, len, 497 DMA_TO_DEVICE); 498 if (dma_mapping_error(dmadev, dma)) 499 return -ENOMEM; 500 entry->type = TSNEP_TX_TYPE_SKB_MAP; 501 mapped = 1; 502 } else { 503 memcpy(&entry->desc->tx, skb->data, len); 504 entry->type = TSNEP_TX_TYPE_SKB_INLINE; 505 mapped = 0; 506 } 507 } else { 508 skb_frag_t *frag = &skb_shinfo(skb)->frags[i - 1]; 509 510 len = skb_frag_size(frag); > 511 mapped = tsnep_tx_map_frag(frag, entry, dmadev, &dma); 512 if (mapped < 0) 513 return mapped; 514 } 515 516 entry->len = len; 517 if (likely(mapped)) { 518 dma_unmap_addr_set(entry, dma, dma); 519 entry->desc->tx = __cpu_to_le64(dma); 520 } 521 522 map_len += len; 523 } 524 525 return map_len; 526 } 527 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki