From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D642CDB47E for ; Thu, 19 Oct 2023 02:15:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF54580075; Wed, 18 Oct 2023 22:15:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA53E80074; Wed, 18 Oct 2023 22:15:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A93BF80075; Wed, 18 Oct 2023 22:15:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 989A680074 for ; Wed, 18 Oct 2023 22:15:41 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5593D81087 for ; Thu, 19 Oct 2023 02:15:41 +0000 (UTC) X-FDA: 81360594882.27.AC3F99D Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf13.hostedemail.com (Postfix) with ESMTP id 6F6B020016 for ; Thu, 19 Oct 2023 02:15:39 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=VGjRvPZ4; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf13.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.182 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697681739; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=niLjjAUj5a4EXQp0TXTLkkgUyeeKsYWhUxQ9/gmkyLQ=; b=IuIFXGJmyeRfxez25E0h8krhb3NJ0oRvyy7TneZ50U8ZTS4CXIzSgmbGMKUCkFUrRweM7L +/evz5E/0Su4U9ruyEuEPCfreivBCaxb7MeMKZvpdczCyuks+EzdJeIGO0JH4y8pAXHazD LtgZ2lfdECvSnopjoy9Z5Ol3CKet+Is= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=VGjRvPZ4; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf13.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.182 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697681739; a=rsa-sha256; cv=none; b=SvIMIwzmU4MUxFOuNdSxVGKnjeDEb0GuoZQAYhRtKk9J91X7OsbHNfPAFUseOFCtxvNrH9 vG2m4qRRsqh5YOVl0tNtcB2oF5Soihd9N19MrwgEiQxsCgyPHtk9gZTMYslWoMFdkLJ6aL jLCmgy8nSWRiGExOnk84qQEvb6GKvGc= Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1bdf4752c3cso48875725ad.2 for ; Wed, 18 Oct 2023 19:15:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1697681738; x=1698286538; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=niLjjAUj5a4EXQp0TXTLkkgUyeeKsYWhUxQ9/gmkyLQ=; b=VGjRvPZ4zcivMqQfeuxr/Lm3pyu6Ta76C7PWvC5mMZ5ZEuX7Mq1hRKvLFtcoSEzN9w t07t9IMo1EnGtlvfJaOvCI/uGRiXF9XESVaQyhFC+ONkziMNBeqjsC0SIA72QO5xWjM3 kHBluBMEusfQU8H4Dp1ZKQElBbGHCExpNh4oM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697681738; x=1698286538; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=niLjjAUj5a4EXQp0TXTLkkgUyeeKsYWhUxQ9/gmkyLQ=; b=c7om7q2YzjyCdrYSI7++5A4IlALGOtUVS9Cobe1U17CHKyqhjqzzD4K0d6WPrTYMId u/rYs7Gf21zJUkrUx4AG4qhglX9QmZ/QOWqSTujHqxQ5GifdycHVnU1nrSXr9/w0m/Os FvCdUrBmxEs/bShO0FDlM9ptZ192YodtIrwHALpN8ZU7MPqA9EZSaZDaJMR9TwyVev5I fePM4SBn1tZmC9FOhpWuYaYMRNWQWkVHk62f+3KJX0SDg8tt5/8kKLS929797/XOArTI 3duYXyGyBbFAepEoYwalIlvJaiq9IMZEE9gUwGne7NIPtLyXiqynx0sjDkq6CzImG6yF je7A== X-Gm-Message-State: AOJu0YzlAVyLBlICPP7Aks9J4+to2MQp2CwXX/PZLPT/y5pgJv23Mn7E 0g7Uxu68WDjyWr6CUOgI2TO4kHYNaR08BcLNKuM= X-Google-Smtp-Source: AGHT+IGBufB2sRx44xEVb94mH1ssc3le8I0CPEOyROcc2uKW7JkZCh0i1+WbmHF3ddLS0KMnCiP6pQ== X-Received: by 2002:a17:902:f685:b0:1c8:791c:d797 with SMTP id l5-20020a170902f68500b001c8791cd797mr1168062plg.56.1697681738067; Wed, 18 Oct 2023 19:15:38 -0700 (PDT) Received: from google.com (KD124209175111.ppp-bb.dion.ne.jp. [124.209.175.111]) by smtp.gmail.com with ESMTPSA id jh1-20020a170903328100b001c9ab91d3d7sm624470plb.37.2023.10.18.19.15.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 19:15:37 -0700 (PDT) Date: Thu, 19 Oct 2023 11:15:32 +0900 From: Sergey Senozhatsky To: Mike Kravetz Cc: Sergey Senozhatsky , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song , Joao Martins , Konrad Dybcio , Oscar Salvador , David Hildenbrand , Miaohe Lin , David Rientjes , Anshuman Khandual , Naoya Horiguchi , Barry Song <21cnbao@gmail.com>, Michal Hocko , Matthew Wilcox , Xiongchun Duan , Andrew Morton Subject: Re: Bisected: [PATCH v7 2/8] hugetlb: restructure pool allocations Message-ID: <20231019021532.GA14965@google.com> References: <20231006032012.296473-1-mike.kravetz@oracle.com> <20231006032012.296473-3-mike.kravetz@oracle.com> <20231011064756.GB2866435@google.com> <20231018224422.GC5181@monkey> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231018224422.GC5181@monkey> X-Rspamd-Queue-Id: 6F6B020016 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 9n747qnjngn8zkhn588r6aaxabx8fbre X-HE-Tag: 1697681739-83782 X-HE-Meta: U2FsdGVkX1+UHxxvobCnq1AqAdc0MvfkyUgeoFR71y78SpH0/q20hMO0zpEf0hlayiDZvWYNwtDKLH6rRTp521byanTYNqNopVxRRUrzn8UueN//C3EhfcOxm7s5/r0EYtg7JBeFiN67a1V+mVlrPvqjTxEwcUVXVYWNrsEeqXBxtbMXJpzk5w+vKAMBVJIcO8CpdZDQ0wCDXJOKVuJIWBe8chC+6bEP51GfRJ4H0n8dldbByY7eVRx2LdjoXYOwexo+46za//xy5Ln2zhuVl7WZrqM5jgsMC6qpKRu+Fe3alHnCI0s7SSmqpnPWCegWHRIt0DT39wsuoerk4VMphM9t6ZPDAL41jnWaTQHzpJl3LYP8aJLFPTidNxTzVLF5EeqEmED3v+HVlmaQ/w2DP9yPgSnEG7cwVZpbcsA8hvYTzZjYc6YYPfANqyXGwJUo1J78rqs/n6eUypC38hTIDYB1EIQJkwjqGx2m5yY4UYeJBk5IAKHWAL6TCuHkEwP5YSUr7ezwA36UH5XwzzMpwDSaVM1HXbK/Cb9gqezX2aojJvNBER16olmAa2ZUsWbJHFKAkw/7dLO7Cy7V1YR6xIaUckCCFZcsnTixr0zBo/A60DU6uIu67DbcTPCvf8H+mr2pfNcuwLYSax6irIbH1Oj33vtb0OgLyEIPIWjfyfS2iZCPCbQ/isfCEnDbpXbilik3lyKDx2a5HmDqGPpIRKv69j3ptaWr2hkrajyspcF6gbG0u3+L0JcUsRC+7Q3iILXezjyVd1HxooKdThrHT4f4sY71EViSdFAoGoI4dul/hNx1SzchiiVXGpSkVNY5GL17KgmMjV/Sfv4F3atyGQalcgz+sV4yvjRRE+DncDDMd0sNj/nhh77xJp3Lm6+31XTLbyDx4g1Dc9hYhdHs3h6WI1fyfFtv8ajTcUjUCL+QEQdpPX7ca06SAYj+q/E7v/BT7ehEBpzUEt8TdR4 dE1Zy4gZ WAyOpXXqLyEabthBuC3HSFEVZilyKRbT1ZhOKjf8a4MGL3TOvbI0MbaASQpokmSPxXt3g0mkEDtTuYvCNJVaIkfIJmwwM8fcVaOJQxEsMAwFsRMwubaGs7HN2Yy9KZh9VH5mCrvElanmFKE8KHGgO0IxG5s6CclUddj4IG4pfhwu6XI+gdcVFTTQJ2/NrVbimI8x75ZLP6Hox803p/iF7Pp7rDfFjmk6yLzqDNmgLPXmACt3h/A3AnY8Gj4kOfm612W72E+dFZIEgb/64utsJh6H4ZwrTVSR13/eRNmNj51Pe9x2sERQ5MYbTUfd9JgY90qAb1icJh3vvgRMShZ+IzWv4g0Ojy8ytxfymBZFxRAgn8bHHUGGOAgrXUOxFKsNUUfgjLGGjVNsLXhRyHxYsucB7h9ReJ/wUdL0YIzTcQC6YLKWMEcikj0gOkA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/10/18 15:44), Mike Kravetz wrote: > Hi Sergey, > > Sorry for the delay. Not ignoring your report but chasing this in > another thread. Hi Mike, no worries. > https://lore.kernel.org/linux-mm/20231018222003.GA21776@monkey/ Oh, interesting. I just read the article the other day about some of unexpected optimizations that clang can do [1]. Setting h to NULL seems to be fixing the problem for me. > Quick question. > Are you using LLVM/clang in your builds? Yes, clang 14.0.6 The kernel compiled with gcc does not BUG_ON(). > My guess is that you are hitting the same issue. That BUG at mm/hugetlb.c:3180 > should not be checked/executed unless you allocate gigantic hugetlb pages on > the kernel command line. Suspect you are not doing this, and loop code is > being run when it should not. Looks very similar indeed. [1] https://research.swtch.com/ub