From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7A89CDB47E for ; Wed, 18 Oct 2023 21:12:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 36CA58D016C; Wed, 18 Oct 2023 17:12:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31CC58D0016; Wed, 18 Oct 2023 17:12:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E4878D016C; Wed, 18 Oct 2023 17:12:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0EF5C8D0016 for ; Wed, 18 Oct 2023 17:12:20 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D767516051A for ; Wed, 18 Oct 2023 21:12:19 +0000 (UTC) X-FDA: 81359830398.07.D0A57C1 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf10.hostedemail.com (Postfix) with ESMTP id 161E3C0014 for ; Wed, 18 Oct 2023 21:12:16 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Lu1T455u; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697663537; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rq7udZNLEIIE+sCA+FkTkPvL/hqhHQc+DqACAhfjrmA=; b=Q4ZLkF4ym3NBpTh+JUm5wVB6VJFTPoU5Q5gFFBLsiqVIuyggDnbZclIAmQ2O/hJEX5Kw7p x6MbfrD24wE4UViNf/I7fFexCQnmwLic+uuN2pzu3r3LEAYmBP4OyQPfAgmHnRz/o4ue8e 3DpmZPiEsiM1p/FTBZmHZDUgeITU6Kg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697663537; a=rsa-sha256; cv=none; b=QuHWl54l//YlmBuUAoDO5BxvAKGIR1TK0Yna9xbPWO9vRbOPMZMwUWfNl5SDiV0oukwJPt QHSSpmzxWKsJCPfF85/wr5yjD/mIUen7YiY2J0LKEg38rIMSSxrtJD30m1WjLxyrVl9KTS wvIN2J2foH4nu2lgX1TfTevSCxBK6e4= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Lu1T455u; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 5D4BBB82477; Wed, 18 Oct 2023 21:12:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36D02C433C8; Wed, 18 Oct 2023 21:12:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1697663534; bh=v0mycPn3E3zjUT2kT9+qpZamlgS19LMrA2IlGjIHwWw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Lu1T455un28uaa0f21CJNoJiCVebBrEeT+s1wLlK947EmPR8JPfQuJuyu8/OfEnSo i9o59Rm6NviZT5byWy9C3pPKUwE7IB6jy1iBtFTUJT4m0W6E3t6AN8dOcphCMwMK4Y 7qG1XlNzgpJZbL6n3xQT3tSym36HYNrpcmkYhywE= Date: Wed, 18 Oct 2023 14:12:13 -0700 From: Andrew Morton To: Yosry Ahmed Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Ivan Babrou , Tejun Heo , =?ISO-8859-1?Q?"Michal_?= =?ISO-8859-1?Q?Koutn=FD"?= , Waiman Long , kernel-team@cloudflare.com, Wei Xu , Greg Thelen , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/5] mm: memcg: subtree stats flushing and thresholds Message-Id: <20231018141213.b80ad9742d41dd11fb122e10@linux-foundation.org> In-Reply-To: <20231010032117.1577496-1-yosryahmed@google.com> References: <20231010032117.1577496-1-yosryahmed@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 161E3C0014 X-Rspam-User: X-Stat-Signature: rd4m8wy1jpf15ftpjintsbj31yntwrac X-Rspamd-Server: rspam03 X-HE-Tag: 1697663536-459491 X-HE-Meta: U2FsdGVkX1/1X6Ambn2WN5P9zZMF3Dos3oYFnFe7RoDh957/MbGwPYOwar9qFvAHFxQiDnnFQbb0OhgCF1UvOjjj3LB84+q1iHHmgDhCCCjTNZT/wnnkboQuhU8lmAbVNgZ6gEPunB0RT2PrWnU85PREuT6tNT5uxxYmxtesplLOt4LBRDPQroN/LazLfuoR5ZlPFRT4LqDUFtUN0Zttd0ajzsNQxCsivmUKJD54zvqvoTK3CqTMqT1OSKdc/VIL3EecwZi1EorrXW+FeWTvqeAuHidMLDIrXuaEPSHrcMku4Lf569nbGNQB5BinvHyw30QDgTsQTtj2NIBMI0GWqjNr9/n55Zr6Nvz7Bx0vv5k6403vOyOsM2usfA5JTX/XwdWfamUv6T8J8Zz0hEAMgZnMLyYkIQ5bjKwJKOPHFEXykgWXvtmFxp2MDyYvZMX6zTozpY4FFu0gvUdzSNeiFBx0JE2QYSUTo2l7osQqWyA/3wJ7DxB1jJKMZggl7m4gTveVx9T8WtNE10X6jaUvDGFXFrlJJiRy0ZiU5hjxwLC6H3D94h+nr2oFDB9DraM32pHCKsr4yAcLUkhrCE7Vx4PxUfgZhF8AnVGw7SX8k8RMxKxhwpKahmj6V5+dij7TNLD+txamDB5qucQHhZ+Sq5bhIbhSbDp9saOjfWQPt/B2fz/CbsYaWRHa7IeGLFfFe7783IdsiBYg4qKzEbqbv9pgksnBD3hk2h6Nly8Zw5G4Sej2N2UK/T9W6WgxyHV3mA7l44OX/mEP+9KOa94EiHoyd063tvp2HpFTK5CA1O17CqiIUzgy4nS61VOOHLITYvaiR5jY/RxUCaj+eyC0ZrkP3xW7W1+Kp9XrfA7NO6lWEfpyOGRdNt9wk9NlOd70p276L0UiZxWKy8vY6mUnsB2ow9pQzP6bpy8KwisKUCKCzMKIS846tPpyDn6dV21o2J867ruZk+wJZSoT/jK +RMv+g3E a1yN/JGq7mjRlN6dQ7D+FbSIqJmtfYw81TreysVn7dv80HKLvLTFieAmHdu+W+X+1bMiAfxEuzrMg5uTM3rYXc8LQfgPNQW46xb3yWZ+FECwhU9q+OHtAV+SKWvgVO9PzX+FUfvvB3cK/0/KmCkauPxQ1q38GUITA0czs+JJFDWDuPUxalKYidloNL+hlBSSgQq3P/sjzdzrMXIrfZgXE4kJETTXXWQMKqiMOsvH0fIxaYzuQuCXrnUVVEA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 10 Oct 2023 03:21:11 +0000 Yosry Ahmed wrote: > This series attempts to address shortages in today's approach for memcg > stats flushing, namely occasionally stale or expensive stat reads. The > series does so by changing the threshold that we use to decide whether > to trigger a flush to be per memcg instead of global (patch 3), and then > changing flushing to be per memcg (i.e. subtree flushes) instead of > global (patch 5). > > Patch 3 & 5 are the core of the series, and they include more details > and testing results. The rest are either cleanups or prep work. > > This series replaces the "memcg: more sophisticated stats flushing" > series [1], which also replaces another series, in a long list of > attempts to improve memcg stats flushing. It is not a new version of > the same patchset as it is a completely different approach. This is > based on collected feedback from discussions on lkml in all previous > attempts. Hopefully, this is the final attempt. Seems that Shakeel's performance concerns have largely been set aside. It would be good to have some affirmative input on this patchset from the memcg developers, please?