From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92E2ACDB47E for ; Wed, 18 Oct 2023 19:27:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C67A08001C; Wed, 18 Oct 2023 15:27:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C17FE8D0016; Wed, 18 Oct 2023 15:27:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADF7F8001C; Wed, 18 Oct 2023 15:27:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9F2088D0016 for ; Wed, 18 Oct 2023 15:27:53 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 64C7E40482 for ; Wed, 18 Oct 2023 19:27:53 +0000 (UTC) X-FDA: 81359567226.05.D0A4EC0 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf13.hostedemail.com (Postfix) with ESMTP id 8C8FF2001C for ; Wed, 18 Oct 2023 19:27:51 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=C+Tu235f; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697657271; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ReEL7S8QLhrptmnYzcUYW6/caEAkomjD+pKymVuamzU=; b=mQ9EEOSfoaF1rPg0W8NIsqaiYRcOVApAxmfXUMNywL39uKuaSce77cudZF2duV7l2eH6vM g2KAGDDZv9r9xNG/MtCzhjDte57v3TLJUgVh/ORVgrXtYT+4eDF7cTW7qB7DMK9UstAysV BGQGqthb1CroGTVHqlHm+zXNrhRNErk= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=C+Tu235f; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697657271; a=rsa-sha256; cv=none; b=dU6S4ziEQibTAfB2h3CD/ai7+CLVr6NNMeQPOgCx86HQlN7W5Mdsj4saoYCK5A8CJw9oZi /b4KKX1KSZZb4QqfrDruT+YfRvPMWmIHQ4CJFmbaB7RPjUt/uDUh/YHXKDbaVtPJSs2UrZ rD0jd20gEAQcCH6OP3UusSg2N8jpy1s= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 28D9AB82470; Wed, 18 Oct 2023 19:27:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22244C433C8; Wed, 18 Oct 2023 19:27:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1697657257; bh=1rqOwZjRE1nbagNyIX9i1zuz/F+kupl3lvfqaew4Dl4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=C+Tu235fFZ9ShVy1YAybs9EPC7bM8MDFacJsq5th4+oYT8RpPrUNEGKRnllQfBjNd tswotbPOIfdrDpHPMfTpCIsSF2Fjzo7dLnS28BR6NqqUjGTNupAWlpBf6EK1oIUAo0 PnYCoah04uvXQ9UbUW/isQiAsUWKJXjrwFucbmZk= Date: Wed, 18 Oct 2023 12:27:36 -0700 From: Andrew Morton To: Yosry Ahmed Cc: Michal =?UTF-8?B?S291dG7DvQ==?= , Johannes Weiner , Shakeel Butt , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm: memcg: refactor page state unit helpers Message-Id: <20231018122736.9a2b6abd4f0a1112144503ae@linux-foundation.org> In-Reply-To: References: <20230922175741.635002-1-yosryahmed@google.com> <20230922175741.635002-2-yosryahmed@google.com> <20231004183619.GB39112@cmpxchg.org> <542ggmgjc27yoosxg466c6n4mzcad2z63t3wdbzevzm43g7xlt@5l7qaepzbth6> <4h5uae72ti6jyiibcyfg2bytooy6d6ggtkrgod5a6rmpateyra@4setu5jmd5kn> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 8C8FF2001C X-Rspam-User: X-Stat-Signature: qdost8efgcqaabbcatp8zhuy4j48yd4i X-Rspamd-Server: rspam01 X-HE-Tag: 1697657271-545289 X-HE-Meta: U2FsdGVkX1/FOJ0lmplxGZ1hVQHCUW1MIi2Zun7MC70TgEZrvfIca9Po/Tg9qNUqYOocIj9ns0CLQsGETdieyBMGXTW/koF4sJcDmv9OiuKyGdNqmEypoaonbXD/XesxMU9YXD8qIRdRU4B1ctUgwX1Jmyk0wdRjupp94JlTBglMdcn346c91Z3UoMEu3MlhBxa6bqjSdR1Ko048gwj4Ez00pctF/0yF+O5kDBYA3JQ82CkCrytNiFQIGDWtKyMhnJoXZY6U7vlF1crYLiFXxWO/VToR+2yRkyvFmYHXCyvOYXEcH54MtoQDBKY4mfceHGNWt46Zefj7cI2eYhQUvV1GUKUeQmH2CKbNH9YfQ29jbjwfZPSaYBdFyG8+K/0xK5wYM2d67douBP41AvPA5gp1OPXlzKiitawOxIMt/ISU7hc/nwI6g/jSBc3DwJGQqz1IyFrVcm9lk8oc8izyGiWvkW09X3mHHUEGwLwITClEm1fHmuWJvxhZmw6wDfC6hCTOLUfQpo66S5pRLGN6QckKtncg+PXa6obBXa7tg1Lj+XXsBcA7G/TlzTQyUwImqjDNYrKpWRsx7/Ymwx1XL57q89gL9P2rg7K9rn9k9jCZuk5J6r7vNnwM4xjTMCVCkT29nNxjGmc5PkNG2fjIbk3eRsgAlviF4gWkV1nq4FkCh+7GOgOtL9Sf9iNgBDgcnVaLUB5mCjhLBMHPMrJMeBpLeFe6a9XGUWQPNhX9xOFosVT9ShzNQdPDu9mju+UqghQKXGfsZOBCAhGCybaYzjzwEZzKKymUt7cckysyS87eWofK1iVdIkM+6kc6LVFQrFECOxmGHT5YAzC/aStyDPoWlQE9pnMcTjD+OWr1aRCSMPD9y8Tl4qmYbf/gyxX5bYNO5yoJxNNmN+1zgqZN4wkOwSSgqJ3L9LM8X9PGnAd/bmyRwKiOnAuJuQeEe5Np29ZtA7AVb3XtKVb6/8x zzb5AhGe 1iBjOQwcnoivI7VSM3/39oL7+ZSNPzBZQfEmH7Owr7GQNjgV6trl7T/Av1CfG8FqEWJvpR+aAU8Yxc1WW7zVh7U5LSZ3doA9BCiX8JHQy9545x63PQNnX8S7h1/sDwTkr34r63xVxQBLbcxSEe818fJnkUhsLxv3AqySHa7+ZcNAS93e9zNZPnWiusYj2Y6O73ewR6iNvxyrzjhMVQNxLDUxrfQRMnvFMvknvs7+bLis7KmwKlnskh/LYnxvRObm670GjNyY2ZRxVX/UdMImRXcicKlsaZmAbePJgXyokX1j2q0hHAq1WNEDrqQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 5 Oct 2023 10:30:36 -0700 Yosry Ahmed wrote: > On Thu, Oct 5, 2023 at 9:30 AM Michal Koutný wrote: > > > > On Thu, Oct 05, 2023 at 02:31:03AM -0700, Yosry Ahmed wrote: > > > I am not really sure what you mean here. > > > > My "vision" is to treat WORKINGSET_ entries as events. > > That would mean implementing per-node tracking for vm_event_item > > (costlier?). > > That would mean node_stat_item and vm_event_item being effectively > > equal, so they could be merged in one. > > That would be situation to come up with new classification based on use > > cases (e.g. precision/timeliness requirements, state vs change > > semantics). > > > > (Do not take this as blocker of the patch 1/2, I rather used the > > opportunity to discuss a greater possible cleanup.) > > Yeah ideally we can clean this up separately. I would be careful about > userspace exposure though. It seems like CONFIG_VM_EVENT_COUNTERS is > used to control tracking events and displaying them in vmstat, so > moving items between node_stat_item and vm_event_item (or merging > them) won't be easy. I like the word "separately". This series has been in mm-unstable for nearly a month, so I'll move it into mm-stable as-is,