From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B24ECDB47E for ; Wed, 18 Oct 2023 11:52:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 999528D0155; Wed, 18 Oct 2023 07:51:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 948818D0016; Wed, 18 Oct 2023 07:51:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 838F78D0155; Wed, 18 Oct 2023 07:51:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7869E8D0016 for ; Wed, 18 Oct 2023 07:51:59 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3D851120250 for ; Wed, 18 Oct 2023 11:51:59 +0000 (UTC) X-FDA: 81358418358.14.91D83B1 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf20.hostedemail.com (Postfix) with ESMTP id B0DF11C000A for ; Wed, 18 Oct 2023 11:51:56 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; spf=none (imf20.hostedemail.com: domain of houtao@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=houtao@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697629917; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0oZIS4Z8kaNH2PfIAwk0ZndzVLhRGzdWxa8CJFilL/Q=; b=BmQBxnQGed7NfCNcMT2wimWuYRlOtJsztJdBM1DgEJ7NT5f57Aib9NQrK/XtjNLyomcy2J HzjbzJZKtzFI+0yd2GTZ+ALENH4YfazTHA6u9SNkUOZdG8Zu3dXmcd3BWqzZPzsurX95Dr IyFpMogjDJAxx9xv3vhsJ/jGiBvUZvs= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; spf=none (imf20.hostedemail.com: domain of houtao@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=houtao@huaweicloud.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697629917; a=rsa-sha256; cv=none; b=K/jw1ywvyM1BBOckVzCmktf+FGEx+tcv3QdZITX0oVUEJhb0M2+vZNKGVBOe+5jFH0Hf2o Qc74JDxU8vSR1sGwp8bq+D9kiwC5hE2c/kAIl0bH7Xxt99SUSMGEWrMT1Q8gep+gyZ2P18 Bky3+Lcy/sCJDUBvVuLlPLvOc7S9dhA= Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4S9TGj3GWTz4f3lW9 for ; Wed, 18 Oct 2023 19:32:29 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgDnfd1Mwi9l9jYmDQ--.41845S5; Wed, 18 Oct 2023 19:32:32 +0800 (CST) From: Hou Tao To: bpf@vger.kernel.org, linux-mm@kvack.org Cc: Martin KaFai Lau , Alexei Starovoitov , Andrii Nakryiko , Song Liu , Hao Luo , Yonghong Song , Daniel Borkmann , KP Singh , Stanislav Fomichev , Jiri Olsa , John Fastabend , houtao1@huawei.com, Dennis Zhou , Tejun Heo , Christoph Lameter , Andrew Morton Subject: [PATCH bpf-next v2 1/7] mm/percpu.c: don't acquire pcpu_lock for pcpu_chunk_addr_search() Date: Wed, 18 Oct 2023 19:33:37 +0800 Message-Id: <20231018113343.2446300-2-houtao@huaweicloud.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20231018113343.2446300-1-houtao@huaweicloud.com> References: <20231018113343.2446300-1-houtao@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:gCh0CgDnfd1Mwi9l9jYmDQ--.41845S5 X-Coremail-Antispam: 1UD129KBjvdXoWrKFWkJFy8Zw1DZw1xJFW8WFg_yoWDZwb_WF yFvF1DJr43Jw4xKw4Utw13WF1ftwn5Wr4IgrWrAryfAa4fXwn5Jr47Kw1Yvr95CFW5GF1q qw1fCFW7u3ZrGjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbfxYFVCjjxCrM7AC8VAFwI0_Wr0E3s1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l82xGYIkIc2x26280x7IE14v26r18M2 8IrcIa0xkI8VCY1x0267AKxVW8JVW5JwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK 021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r 4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_ GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx 0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWU JVW8JwACjcxG0xvY0x0EwIxGrwACI402YVCY1x02628vn2kIc2xKxwCF04k20xvY0x0EwI xGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480 Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_GFv_WrylIxkGc2Ij64vIr41lIxAIcVC0I7 IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k2 6cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxV AFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07jn9N3UUUUU= X-CM-SenderInfo: xkrx3t3r6k3tpzhluzxrxghudrp/ X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: B0DF11C000A X-Rspam-User: X-Stat-Signature: qnud8zhst9rnyf3j1stdue7nj4nzoqkz X-Rspamd-Server: rspam01 X-HE-Tag: 1697629916-847355 X-HE-Meta: U2FsdGVkX180B8fCFZdXW4D5fJQMcTBPa0LjUr1proAbbTtL+uKp7ZYrCgV/vCB9Tg8g2wSJG5ezXkF38pZ4BofZ57tGWMinAc9GiGX4OVuN53G4GCLTbTorhtMOcL4McrApXDO+KMXIMk31b7zial4AhDFcgp88py76TUcCJLXTCoHgaF69DD7iyeLP1FJ6LdcGyejPZd4exWVGC11uVS2A5lfVkJvi2IUOIuRUBp0uZRrdfxmE2jf/oN2G5bzKs+yavXRGQuqPVh1SUEBLUU6OF7zi1fHeuhpLma9tAyuVmSaxuIvHXIwmSW329jcZYzzUj/oplv1D4JTDxa1OOEdICZH4FyP9+buIR2FL25q4NRp00Of3vyNVK0JO2AHcbyppUkAaAaYVyJ1zkVRa2rQ04W3o/1GhiIPzB4WCEWfIotPH9OtTeuuWMsRb9IhQtV1JGF9O0/ZjQkVH+qEVS2AxSGXcllEybCpq9l3+CzP8NQJ+cZDmPhjw2R2g5lUVR32mbKQr7yqJ1ye4FKdZUF1FnYfF912RvdSOPm+MXSbIrgMdoOokioDh7c3hf8I2rOXy8CnA2fyVAJn0QmlXrjnb53fNQApX17sKUk4qv75Q8MECNtyW4bXSgYBcTjgxZz9G0c287maTGi6hnwJdX+yRlR1+5HKGk2tlpCSpMQZDDEMstJ7Q4di275xQstMDRXxXvlsIM1FDmTOWjI/HZh/n8uDLPnRC2vaK0TTdV1KlxgMXNLVKjgJnkmg73lEzvlUqtyz44Kwx9J9UpLzXHffWjzqN84ECpQBcew6j3EZJbUeIARWOwZJOadNg8jco2s+2qmbmcQK8ZHHnKUu4NnmlikXrwvrpKPj2BQGmydYk/EKmfwK3/CkksVWHBougT/NBQ5RLZlls/57FhG6oWf69UfcuaZFFBaNF/hemOLLIfJ50pkxnTvw1Ta7ggablsM/z1bPFhxzjo2t6DS6 rbDgnrrB vA70JBCBPCovZqVtXfLqI4IGZgAgie84+HmViYQBDTsNdA+/4ffBU2NA8xPo1riIAUnimSYUY3ZSUxiHKmYGr+upt7NiANwS3kIfeF9groHy43AIm/ZnVY2bGt6yCTUtygI+EH1qylYMeU8O1mif/j0PZUbMyBvzbIixwuebnI3Ng3Dinw/40pXduhUzros+WJr6xHeopn3P/fsMPskCUXvpAWu6JbHTXxzcCsL7W+2vHZcRXuVZ8Ckn+0HQxaUH4G3XbH7S8tCgZ1KM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Hou Tao There is no need to acquire pcpu_lock for pcpu_chunk_addr_search(): 1) both pcpu_first_chunk & pcpu_reserved_chunk must have been initialized before the invocation of free_percpu(). 2) The dynamically-created chunk must be valid before the per-cpu pointers allocated from it are freed. So acquire pcpu_lock() after the invocation of pcpu_chunk_addr_search(). Signed-off-by: Hou Tao --- mm/percpu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/percpu.c b/mm/percpu.c index 7b40b3963f10..76b9c5e63c56 100644 --- a/mm/percpu.c +++ b/mm/percpu.c @@ -2267,12 +2267,10 @@ void free_percpu(void __percpu *ptr) kmemleak_free_percpu(ptr); addr = __pcpu_ptr_to_addr(ptr); - - spin_lock_irqsave(&pcpu_lock, flags); - chunk = pcpu_chunk_addr_search(addr); off = addr - chunk->base_addr; + spin_lock_irqsave(&pcpu_lock, flags); size = pcpu_free_area(chunk, off); pcpu_memcg_free_hook(chunk, off, size); -- 2.29.2