From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D965ECDB482 for ; Wed, 18 Oct 2023 06:24:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 20EA38D0131; Wed, 18 Oct 2023 02:24:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BE768D0016; Wed, 18 Oct 2023 02:24:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FB908D0131; Wed, 18 Oct 2023 02:24:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 03E6D8D0016 for ; Wed, 18 Oct 2023 02:24:49 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CB15440144 for ; Wed, 18 Oct 2023 06:24:48 +0000 (UTC) X-FDA: 81357593856.11.B4257EA Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf28.hostedemail.com (Postfix) with ESMTP id F2D87C0009 for ; Wed, 18 Oct 2023 06:24:46 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697610287; a=rsa-sha256; cv=none; b=l14ysbqKlh+uysDsRQwn3P+YUWrUc3TV3bsadhoLaJ0yohOHfsUi7BnSkjcr2603puNFDX yPGfeATMyT+dh39KmkIyNTKM89qgJAZsOeULkSW6Dq3un0nI1RkG42AAQ90Ao68flAF/0J 83op09Zcq05Hkyr1f/Q9RI84U7E3vvM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697610287; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cohyI0KNEzZJLFLnvk5Y6dY9lJOqMqI4H+HkZrUN7Bg=; b=10S+PvuJc4kKORXKG2IBOOva4eY6wZTyrJuFiXJ7m2cZ8jTfFnh8/J7BQzRIgvYBp7IrJq s4TBK+m2gA9UuRBAhRjrE6DcRVI76JMz6QlKgr7LThCWcEehLE43jwnOD7KAvtJzKykNAZ +Qnd+fBKoGRkYkHe7rRxDnNNzwpJrrk= Received: by verein.lst.de (Postfix, from userid 2407) id DB69768BEB; Wed, 18 Oct 2023 08:24:39 +0200 (CEST) Date: Wed, 18 Oct 2023 08:24:39 +0200 From: Christoph Hellwig To: Rick Edgecombe Cc: x86@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, luto@kernel.org, peterz@infradead.org, kirill.shutemov@linux.intel.com, elena.reshetova@intel.com, isaku.yamahata@intel.com, seanjc@google.com, Michael Kelley , thomas.lendacky@amd.com, decui@microsoft.com, sathyanarayanan.kuppuswamy@linux.intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Christoph Hellwig , Marek Szyprowski , Robin Murphy , iommu@lists.linux.dev Subject: Re: [PATCH 06/10] dma: Use free_decrypted_pages() Message-ID: <20231018062439.GA18260@lst.de> References: <20231017202505.340906-1-rick.p.edgecombe@intel.com> <20231017202505.340906-7-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231017202505.340906-7-rick.p.edgecombe@intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: F2D87C0009 X-Stat-Signature: x837w5pfo1xzidnmgbtcjgyqk9aoouop X-HE-Tag: 1697610286-748882 X-HE-Meta: U2FsdGVkX19/MWwshDNZTyBFyyRCQ87lRxz6B0gOrLweql7AqokLLE+WQaR3dJawRTZgGmW+WnEiIT05DO2257jKqfYPYWvgMmYzb3qU3ZKc7yWpS+Ws57HmcccfeeBdRYHbrPS7n4XYE3h0JNgcsrTpqpHnQYOs+/KlLVc/iPVGkjJmB3ym31k9Owne/iBczmzvMMEH6R8qFdR5EvbDhgvWG7c07m9k2mbCycCiJOEJ2rqMpIuDqLVmmABKGOvQxVmQP0EzMBk1mO7cWvkrr1/kzj7O51x8Mofxi/xUTISjDqqx/XRN/haevTIDz+3mr7xrIP3i6+rrjfZ8bcJ2Lvv0rBjaCiP5lXhOKUrOvHEtM3kfR3j1YYD36m3wmhcj+4XElXf3toBIlJsqJUJTbHcpi2uvRDLyJJBPnP7GtjAgS8S/Dxj3tvj+yw4OzOPhg9XT8CDVsMs+37jr7T78gG6VWBW9vzxrRXuzPtmXQd2cVymsWHCBngRrr0MhWQryH0k3LndWwsoViMIIilV1EDovSuo3NJ5yu9FwlRlrQL/ji+8KSDR+ywGBUT/hHtsihsjRH3JllOZRoGC9XFyC92wdJk1jyJeJmwNxMDW/rketU9N00yx51ewNgrsIP4qiKh0X+QXTSm3wf/e9KrkJ1XgboPxPjr99Z6kqjdx5fEjfipRU88RfmK2Hh3ma4SDLfXa6AH5kVqaEz7JU4RkedN8/7hEE8ZF6OsOF3w0feJzsSbvlqUbaGSnOZGe6GyaBMxQzFGG6TWRFAcPYuHNIgXKXqBdJ6ZC8uKMaqfZ7GaaU2GOzIemgV9mLzLvb6xOJvGz4Vl7Uhm2S2StzEyzP6xE98ccUtqzz276+T0mwGwad81rEBQ6/CMq6/Bl0FAZJFTV9BZ39Wt2+E/JqWOfZM9brMz5vgEvTnym/yV2CVWbfCeIhxVl0WXe+zskqhdZJAgm0/zqc8n966mfwTNs wzv5p+RO LIDGW5EWRQDtDenFWmV1fwahcHpaKDoK5EXXdEmsS/sZTwKs59mFDuZ+r9CunlhifqC4FlJ1fWLMVy3puZynYKbkOVw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 17, 2023 at 01:25:01PM -0700, Rick Edgecombe wrote: > struct cma; > > @@ -165,7 +166,7 @@ static inline struct page *dma_alloc_contiguous(struct device *dev, size_t size, > static inline void dma_free_contiguous(struct device *dev, struct page *page, > size_t size) > { > - __free_pages(page, get_order(size)); > + free_decrypted_pages((unsigned long)page_address(page), get_order(size)); CMA can be highmem, so this won't work totally independent of what free_decrypted_pages actually does. Also please avoid the overly long line.