From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66ACDC41513 for ; Tue, 17 Oct 2023 10:17:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBC4D8D000D; Tue, 17 Oct 2023 06:17:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C6C2F8D000C; Tue, 17 Oct 2023 06:17:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5AB08D000D; Tue, 17 Oct 2023 06:17:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A8DD68D000C for ; Tue, 17 Oct 2023 06:17:42 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6E5DF8101E for ; Tue, 17 Oct 2023 10:17:42 +0000 (UTC) X-FDA: 81354551964.19.1A61F6C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id 3DB29140039 for ; Tue, 17 Oct 2023 10:17:40 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=UywmqRqX; dmarc=none; spf=none (imf09.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697537860; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fxvZNgF+It9/pkutyTdBwQ2drZbf8d9h7gItHyVyZtc=; b=8l3dlA+LHq7nDluE5NX1O5mjz4MKK2HK8g6iD3aDoPTkatQasAQC+/qnZ0PQDgmkVu7E8R gEQfmqUxxp319mcjCtY7+qGZPhOY2Sl7PJyuX8hmK0wQSlip63Qbd2tJ51/pqOeGoeF0PM 767OKMP6T7aUI+Ij5BChKWKQONdumes= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=UywmqRqX; dmarc=none; spf=none (imf09.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697537860; a=rsa-sha256; cv=none; b=MGYBQILnhE7ryWC0nfA95TiepdJjHRyGTw2Wi0ArHPlKViSn+r7T0ExpnzRC2m6glEDiXb KYhzh3lpWI/pwdj1cI3198bZPvLwf4BxWxpA4td8HAD6cl4MHSySNcMLHg7iVjvq14D5VE 6dbhib94W+yPN/LPlccwlXtTVXXRqX4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fxvZNgF+It9/pkutyTdBwQ2drZbf8d9h7gItHyVyZtc=; b=UywmqRqXVi95xSI8PqvFWe4u1k Wxct0bmVsIzqbVqHIRow1Dv39c81o8Aw3R57nSINroRmme67pBE39wLzPEoIBW1w8GkpHoGa1GHQ3 VcjF2ANQNyKIzBGqgpppAOdsA6GMmWW5jRSKIjeLzwaUL5YAHroY5o+n7yf4psX+UFP2kKbWX6dLc Ra/qER2vpnnWzDn3DLXaaNkKilQRvyq/tTKXrgLjDnV8ho677Gd8EbhwEh7kkGeDOQFfiyYxxIRI2 SgEWk9gV0FBFju9II/84Bsf0T8uCgzD3NrBSXTtaRYr1HUMMLItbWzWm40hygwym22LIoJY6PaZ4N usMeJ3Xg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qsh8Y-00Bjm7-Nd; Tue, 17 Oct 2023 10:17:18 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 15DE030058D; Tue, 17 Oct 2023 12:17:18 +0200 (CEST) Date: Tue, 17 Oct 2023 12:17:17 +0200 From: Peter Zijlstra To: Ard Biesheuvel Cc: "Kirill A. Shutemov" , Matthew Wilcox , Borislav Petkov , Andy Lutomirski , Dave Hansen , Sean Christopherson , Andrew Morton , Joerg Roedel , Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Paolo Bonzini , Ingo Molnar , Dario Faggioli , Mike Rapoport , David Hildenbrand , Mel Gorman , marcelo.cerri@canonical.com, tim.gardner@canonical.com, philip.cox@canonical.com, aarcange@redhat.com, peterx@redhat.com, x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, stable@kernel.org, Nikolay Borisov Subject: Re: [PATCHv2] efi/unaccepted: Fix soft lockups caused by parallel memory acceptance Message-ID: <20231017101717.GJ33217@noisy.programming.kicks-ass.net> References: <20231016163122.12855-1-kirill.shutemov@linux.intel.com> <20231016213932.6cscnn6tsnzsnvmf@box.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: mc8i6gpnc3hzqkea8bskypgfha4u4ziz X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3DB29140039 X-HE-Tag: 1697537860-808955 X-HE-Meta: U2FsdGVkX18DoWOQoGOBQT+YrBfW5xTUht+ZtKz8+iYE5/y48++TZsq4+caaqO0aN85ngrxY3qdmZGgOwg62lFrA9/u0K8Oys0VQqtIqZp2ESY6Mn3IMz9dY5HpyLhWMP3eJteEz9EH34LjhwRJ/KOuSwr+okjyM0ybRVT+N9SYK71Q6NiIgRppVNKt4C/gXNWrDn8zdD7DkbN7xLVB8kXPas+KPW7gCcpyqtp9GODWGcBoHzC4BTk1wVag1Mqtqrr5AAdqox5qE2FxEN1u0ORRW2llHBmzCia/k/UoL5X4KvAhk2t7dHjc66hrmwfk5sV5cKha4aKdrDyxkU6rc8UXg67MJNGSsd5cCBQGZTzWFdmu1pei28YLozSPdGh8rHzivis4s2EWf0Y3u2Iyr0Ffzy1obIi4R996Scg41uK1BF4cyYYr3WwTiePGgizxM0TPjj2XUnmNY5swnqGUhF2G7OPpoCYiCjTk5lLMEwdndydUHvtRKLABjn3OlkHBrWYLJBMrB8/2qKSC9PVZzywtCoUA0Kd2xUnx/DrTXQ/TYsycvROf1gPuCCfIVli9sqop4t1+pOzKcZwyxoYeZR/UBAstwcH3LvRCgFhrX3JX3Vkhwu+2pyRUpbwB0dcqOCETeVV/AplI2oxrjUuenFsEa5yIuO6vU8bjhQIqGv7opn826gJ8sRgVCTWA1KTzhTHRzcQ05fDSpiOP5MJlME13AWvwhq15iZczFuyTiR8NE4f4RceHJC7r58/jj9YyEbyIC4LBVp7JKqMaYkl1ZtGsWtsb8rOHwLcj+1gwfOYnqOXMGcCUkk8qnG2TF82Zd2UJGTkLb55sdVGlHwBMKlaxqQTx+Fk497/ip0kXHMhSINWcMoZWUnDfYTgtJ0yhT/GCZ0ml8Efgio15jIkRLuiLGX9su7+D/gDXgOkteSJFfTq7MMXe7aFzFIsbWAIc00nAA16tPHPU7q/qnmaK 5xFNahG9 isDKthp0e+N30uuHL27ggdvKMkNbMGAP10KzPm7ttlk+6/wNdIvnseNMrnsyjAg0c2PaEgGam+tz8yMCcmoE2EWrKe+cj5K1kqcOBtD2NkES/TLHAe1QFBPRL2Fit7Z3OAB5FQxDYtX5nREM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 17, 2023 at 09:42:13AM +0200, Ard Biesheuvel wrote: > One question I have is whether the sequence > > spin_lock_irqsave(&unaccepted_memory_lock, flags); > ... > spin_unlock(&unaccepted_memory_lock); > arch_accept_memory(phys_start, phys_end); > spin_lock(&unaccepted_memory_lock); > ... > spin_unlock_irqrestore(&unaccepted_memory_lock, flags); > > is considered sound and is supported by all architectures? Yes.