From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96B4ECDB465 for ; Tue, 17 Oct 2023 00:52:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0BD818D00DF; Mon, 16 Oct 2023 20:52:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 06CBD8D00DE; Mon, 16 Oct 2023 20:52:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E02328D00DF; Mon, 16 Oct 2023 20:52:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D08928D00DE for ; Mon, 16 Oct 2023 20:52:55 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7B2CA160C98 for ; Tue, 17 Oct 2023 00:52:55 +0000 (UTC) X-FDA: 81353128710.03.B88E21E Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf30.hostedemail.com (Postfix) with ESMTP id 3A76E80004 for ; Tue, 17 Oct 2023 00:52:52 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-03-30 header.b=Ihfiv5Yh; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=behhk2gF; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf30.hostedemail.com: domain of mike.kravetz@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697503972; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xUtRM4/izF+de6aMo44VqIvJ+1fKh8kmOR+7FEwga7k=; b=iQofgfiUAgmwwNOjVlxqm1zMzb9rrOIUT9Zvwrf8DsCgpCwPV7YTR1wu6VeQT8UUuXAtXt uI6IlMY8mrbPrulAznuJ2IwiwBoMGmyhfeGT2PtEZOPmDH+WuI37i79TQroGnGdBEReQwy t2Tofk6YNsE/2f2lYs43IA+DoaBeewE= ARC-Authentication-Results: i=2; imf30.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-03-30 header.b=Ihfiv5Yh; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=behhk2gF; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf30.hostedemail.com: domain of mike.kravetz@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1697503972; a=rsa-sha256; cv=pass; b=vwp6MhVY/9NUE+ggGegAorsHtG1nkraI7nIldxv4YaJMeheEBJyf3RB+y+F3hC7Hdj2ppf uqOdh5T3HZ/tZPwxoRl0elJA9F8/K3gPMpL9nFM5If7ZGR884uvpCFDKtWtOvl8zxP48GC TyYMF9imww8XQ1XdnvuZyfHP/uTvJko= Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39GKOBrv017725; Tue, 17 Oct 2023 00:52:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2023-03-30; bh=xUtRM4/izF+de6aMo44VqIvJ+1fKh8kmOR+7FEwga7k=; b=Ihfiv5YhwusNOuXOmWTQM4osksmKzP/MpbgaXkGBBOf5vlzITCRe09RVdAg59vIGkxij 9gJbt5rIfwYyK7Ud+Fd4DPlh0cNho62D6AyLYXg8NiUojUNJe0AdXYkoWH6r/4lIjm19 4TizXWCTjpbP20w23T4XN0Ak3TrUwH0IkoCSNrQE9EHQYgLRDX5t2oj0FW2n8eHa09sn q9a2oSqFYsYLQCYER9qhdfosrjzZeUAlTV5Ryvwa4m0WKfljjrCuWGMO+oWValJKfQru V8QhPmgNUnI0HTceuwnoOGJZAmYdFsYz4d8IQcTVDp0kzIz6A1tO1uNx2aJYdFA9nHsC 3g== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3tqk1cv04e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Oct 2023 00:52:41 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 39GMVu3n009788; Tue, 17 Oct 2023 00:52:40 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2168.outbound.protection.outlook.com [104.47.58.168]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3trg0m3v77-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Oct 2023 00:52:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OW+JxA6KtCrOakvot1iybE8JIoUI7DhsgiD4VA2962QLX2KSO5S67rLWzgoWNrVKqXgOel/T9aO1iKnYXFlSQpSEK/KdW5gw8K9WsIAJxZdQK0AI1d9iVKzEoDLjUAubfiD+sfiZzlpJwmF4uK+008SZHTMgf1XcG07yVz7iJl3VeuRDghytIYPWkWhv5CS+ame4Ke1QytKY4QEbHqTXWjKHYZ1/uTJu2CFIn2vjEgwbaTPbj7CVRNDIVwmFAlVqOzOCRlQ9a0xJRRRGTfz69kv9fVk40ckQPXw5EEkH1R5JYF0HCos6uqh7f0MKW3oMFYIcZPdYRmlh3FzQqMKxvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xUtRM4/izF+de6aMo44VqIvJ+1fKh8kmOR+7FEwga7k=; b=fkNzKrKgR5TDK3yy5M8zBv8zSzLTMcMcVXLfcLV22Fc/OypKvlhLHHHWOgVZ0FptBSc/CbzBkvy4xskAQZpYdOfh9paL3JEqP8XeY2Deh1qWZU34SN1NWc22NLA1fbyOFAhyc0zcZwmImKMhr/OC3qS5pXHYXkm4AVL/vIfPlRxZ8+N+NTR0y7QcqIqsxJzDRu4fPGI/B6qBnQx+0h1by+iRHWWiMch0T7D1m9ah4pNBAbqjXv+2Oyi5vHBUTl3vPmhYQ0D36jDeFPMdX8KY+ZTS1J8Co2ROlHUqw6c0RC942B245HnGFfA9RJWK4N5EeOJQ+/CkVvSZN2brIDHgJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xUtRM4/izF+de6aMo44VqIvJ+1fKh8kmOR+7FEwga7k=; b=behhk2gFRHTS9+HIkvtrPDHx50VgT0VGjM/qDi+F1p1HCA0k9uo/SfHcTZMhEscuoHS8xGhGVKCW3I+zfitmXeYa60DhqFahcg5q14xH5aFEft2V2cucANjngx/B21m2CC2r9Q3GMSz32DVHM/2vcY8JLSje3uQG81PG0Pviq+4= Received: from BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) by DS7PR10MB5085.namprd10.prod.outlook.com (2603:10b6:5:38c::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36; Tue, 17 Oct 2023 00:52:39 +0000 Received: from BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::59f7:ec45:eb41:d8c2]) by BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::59f7:ec45:eb41:d8c2%6]) with mapi id 15.20.6863.032; Tue, 17 Oct 2023 00:52:38 +0000 Date: Mon, 16 Oct 2023 17:52:36 -0700 From: Mike Kravetz To: riel@surriel.com Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, muchun.song@linux.dev, leit@meta.com, willy@infradead.org, Ray Fucillo , Jacklin Kotikian Subject: Re: [PATCH 4/4] hugetlbfs: replace hugetlb_vma_lock with invalidate_lock Message-ID: <20231017005236.GA236970@monkey> References: <20231006040020.3677377-1-riel@surriel.com> <20231006040020.3677377-5-riel@surriel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231006040020.3677377-5-riel@surriel.com> X-ClientProxiedBy: MW3PR06CA0004.namprd06.prod.outlook.com (2603:10b6:303:2a::9) To BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR10MB4196:EE_|DS7PR10MB5085:EE_ X-MS-Office365-Filtering-Correlation-Id: 2987dd48-d764-480c-60ed-08dbceab5c49 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BjMpiPnNAY/LosrX2fuj1q9h/QWM926Vu4pJP6bTJyDj9JMMzT3kmKhZp0ntnNLw/DbJ+QNnkCG+GVa9Djbjyb4coVGlZQXTv7TDGXrvgIlqt4N9P/KHSzEi9ZZvIAwPW8kA5R/aD1HLEr/YTLlPJYbBpFLSQ2dqXKHoBYb79BmLEViwooUuA0wgTVlhDIjcNcqOz4ssRrMOHmQWw5O6+Q+Enc6OJpQ6LOMER7/RWcfBFuLdZkh4vGMhGHEDxlbI2Rnk2tbs64POkF0kbBeMJ63z5L0TVXUk9KQEwtKkNMvPBQUdwvnFPgBnO9Y3UAXDuU4AbShv9kBuU7c86hfs3cMkm3WCVjk01WSLFxW1cTTEUhpyyQeyVZ8e8G12NOvhCYHtwxXjME2LMI7WcJI1xK6/YE3PSnd/0AvtbNoiiQfoGESF7T0yF3N0zV8+b05pKgwVKIdAvwJtTuk06Jn1JjQfsmR4ray2MDaIk9bDOsUAeLIovHJVepydLSG+O25RE+cpf3+R8id4TEEs7zQkf/P0lNlHGSJ4MS3q95tbtcM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4196.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7916004)(396003)(366004)(136003)(376002)(39860400002)(346002)(230922051799003)(64100799003)(186009)(1800799009)(451199024)(33716001)(316002)(86362001)(38100700002)(5660300002)(33656002)(2906002)(44832011)(41300700001)(6506007)(66946007)(478600001)(66556008)(966005)(6486002)(8936002)(83380400001)(4326008)(8676002)(7416002)(1076003)(26005)(6512007)(53546011)(6916009)(9686003)(54906003)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SK4EpSIAPpHn5C2j0z4GMRt6kdpjLKvA03RMtyD12Rf2ueBVea6QGXqCI8JP?= =?us-ascii?Q?5j8ybvIQG+6wlUzOHLIH1HwI7o9vIrvgYHIWtqVmUWFVu2olOj6EmJtj2/ZE?= =?us-ascii?Q?3oPjOfQd5glDvokHwCMgvlLkRP6+NbTISv/lve1WzRhERbNENDkQO+NT5AQv?= =?us-ascii?Q?4HTAL629hra5vbQwdhsa0JQaFgdJOy036ZaO6wHLtjgp+4UTUkn+HJiLXn4m?= =?us-ascii?Q?suu/w7mAA0cvx59VV0J/NhUFmqZ5A52A0lS1aZiQd4mjzb7VhopTxH/GlnqE?= =?us-ascii?Q?mYSUFWBmucI9V4ciuLZAvx7XNe0PGLEZs+ZxZApgd5ppX31p12/auUJdfpsC?= =?us-ascii?Q?MTnA+TQ4IvMajqbtCjZXqeOJ2krhjMZ7Gop+9L6RnFyyV0U/M0SwoVSxeG4r?= =?us-ascii?Q?Owt+ZN4u2QmBlRjrpSe1W6yVFgk3Zg8FU52fbtX03jArN/Jk5kYvsDys37Jz?= =?us-ascii?Q?U/I5I6drGSsRGlKMMr2HDQSjq4pWtmCMwSFARLTcwQ0v06qNZtQA9zBrFC1E?= =?us-ascii?Q?IA0criZJdY5MuIjTxJ75GefMdXXyIpWOuJ2zElzxGS+QrbJOzdUGQSpgjW+X?= =?us-ascii?Q?OOYTQ0hlU/x2TmuJTuUTN+NKTuyFKJJFvNOyaUhatcvB0TYcUH6eB/WuVycW?= =?us-ascii?Q?RndjBy/yoqIqGnZ7OKP+7OTxSnLlk4FI6CCsYr1tZRHwWZlEtKTQu7+y8+LC?= =?us-ascii?Q?t7sv2FhmTZl72qPnD/jsVwiSwA7ESAr+sjCx+ea5NRnGh+dNb7Kxd69ZD+P8?= =?us-ascii?Q?RHt84KsT6pHODIseE3OGJRrGGIF9psJrfSw+R/Ab0jWlXkI8XtDVEiYui0eo?= =?us-ascii?Q?kDnrTl+6TrjsXWzRqyny2IG+qAvrfYJVHhGYolHfLlPnfpscDObxD/hvvFlw?= =?us-ascii?Q?DXUCJiVXwF4bHahkrN5N13glhYSwT9PjA9XXb9B55/mE+ibXy3PSLvDe6sSx?= =?us-ascii?Q?cYiB43PM3JpQ5IC8RwxpeN9UEzY3w/0NKv3FT+JMmA/8eqC/rMvXLfRLBc4h?= =?us-ascii?Q?OQqOcNRBIeOg27ax+as4VJbJxtVoEoqLHfnmovkvd1aazADSixSYAFRoSVVq?= =?us-ascii?Q?jrIesY3+0JyjiEwW5rD/Vcx2EEw+TrXaFYzQnAUEqtVkm5PaY8qRIYNl1gXL?= =?us-ascii?Q?gij4OgRpjtgWqAGNmDTbVB04M03wbRfOrXLIRqr1qhbb0M4FlzRIaJlcqgE1?= =?us-ascii?Q?uz6ZVy400/d40w44THU0bVt70OHJVm1IMYMzboxJvKswW7G5PMmcKm4GRr/6?= =?us-ascii?Q?kDxqi5Uzm2O4OgEtRMo+ysP3r8Y1FJcqfjw7aUuRqiRemuqoxWMNxLvjbOe3?= =?us-ascii?Q?P2xt2MdHQ1TYljh4rI38O5eW5a5tRmI4VU/ZJL+PFf/25IdoWSBasboNKJaZ?= =?us-ascii?Q?24C3Ucj2pGD4FfHnLSpSHnWapyUOgTIiSpAUGRBZUAXY3XxVG+tV8xfR+R8S?= =?us-ascii?Q?HyvB2ZZ/7M7lqWjxthq/7fjZbjDje0175eWVs1BO04h988GA5fmWrHeY4OKN?= =?us-ascii?Q?8MsXYeyxHtqnhCQhri6l0uiRS6P7LaqKnK8kPkEWRh3JaBliDJtk8QaYlUiC?= =?us-ascii?Q?y6yEinYU6hAWtAssY+J4EhKg5MwZA5zueh4CyYLS?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?ul2zzVNVBzyU5JEuMPSTbJdIcH6XhCIMnX7l88UVXDUwIdSERG7et12scA9y?= =?us-ascii?Q?fJd59jdpFALJJ68+B91/xnSV/yxOL2stQP+0a5RVlBCY3ZU2GZ6NRhKvky+j?= =?us-ascii?Q?DL0N+90aP033/U2SIFhGZOyVJYJqnIStowyUD27wlbwZc7myh5YvZzlgIQ3I?= =?us-ascii?Q?DV6TB528KtRzqQ6TC4whPYocvZfyFjFfVjBWxeMsoPIMGEW8xAoYXl+w5ZcC?= =?us-ascii?Q?Ld4es8cNLuD9cIaUuOoWvZUiOmhtw7pQmlZ+MaJTOkfgtTtseJfLFp7ojOzZ?= =?us-ascii?Q?aK7AEKQUtvBDfAUUi34GGGTKOHHkoLCEZztvibVpuf4fvTq9JX1T2m9jvItG?= =?us-ascii?Q?ieAIAgOXsBM3s2qwvIU4Z9xA4mvjaSaTwwPGHpPurkSqZiVTc9s0w1aW1M/F?= =?us-ascii?Q?gXIH3jBLj5ebAL24HUU8J1fj72Cyqqj/b0kIdr28F2/nPdRTzkE5AUt6BOjD?= =?us-ascii?Q?pIjVMM99RtYwr3tOEHpsGWQ7nAs/SCMhrR5J0MCDYzUPzeALZDsWXlBmYmKr?= =?us-ascii?Q?FepaL5+38Y9Aq4HCf7wmT0TO3nyXgrL5cjSLs88/zxPzmhNVCOvDON1Yz9na?= =?us-ascii?Q?dEiMbLsh2DPQh88wv29p4iGjjcmt3/XnskErVwP+ijopENBYXZ/AaoP3jJcW?= =?us-ascii?Q?3tAw5J7+TDCLNxqN6XBuPdAogNj1lk2Ofn3YHnHx0ihPKH+DKseBAH+OD+v+?= =?us-ascii?Q?OODUp5MhXs2GSmQeeieayPr455aqF2qSK+WvbNuQFZrJ0iE/zKskq5qJqZYu?= =?us-ascii?Q?ltVoYevPD7eFlmW7cMnw3c7vOFXn0jFJSirGFmvRrKWel69Nd7aST85DBfAf?= =?us-ascii?Q?QSDiKtlUnjR4zg/t3tgkgPPv2ihTNm8UfW254aocYKJWUbhIu6DJWYW1X/d7?= =?us-ascii?Q?bOaE+ILyxpyy3O4bTunsQayNPZhJ5eTjKHazNbboMbsd1rQrSXGzsXExBTdQ?= =?us-ascii?Q?/9d9GnJr9wsBPll/rbBUXb5l9WOtqwdkJE0YvqcmUr4DPlLnfBfxykPqBdVh?= =?us-ascii?Q?mFbD/OZZf5o/aMgCslbvZpaFGg=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2987dd48-d764-480c-60ed-08dbceab5c49 X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 00:52:38.8829 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fSwckSYzqdJZ02raO3w/6OvlI0breVBSFdn5mdjkA6aU29dIIneOg2YeMk+bTKbxmU+gT682gu+cFOsyzlYbfw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5085 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-16_13,2023-10-12_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=10 phishscore=0 spamscore=10 malwarescore=0 adultscore=0 suspectscore=0 mlxscore=10 mlxlogscore=94 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310170005 X-Proofpoint-GUID: X4REdvEhR5kiNjAxL9vDYXV8j-RjcVU2 X-Proofpoint-ORIG-GUID: X4REdvEhR5kiNjAxL9vDYXV8j-RjcVU2 X-Rspam-User: X-Stat-Signature: ba6yxe84rmon8jcf5cexi3nzepzztnjy X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3A76E80004 X-HE-Tag: 1697503972-625846 X-HE-Meta: U2FsdGVkX1/bZzSUGlG7w0ETAhtMCnR29I6RgFik4cBjlHp62IyFIfOkTVx4SXanWr3ScDO+/M0461lB5APEVVsnVMHWGceYKKChsTSwaupdA1QFn+cp+ZnDCJdg0NxCihglqkhBngd7k1BqoDd0CBJpauUsfjwfZWETDHIxZ3Tv6roptBm6j7sjm3xx0merD+7SteN6bp/1BuispEWqjZTCLNdKiu41NzGe/NotDOaFcu18zHlAUbe+sjw59AhnUi8cJbVjnOOAMel+BVscryuS4OSc8Gt4sXrYZQ5esh/QH7PSdQTwHc0QS+l985kOXFTszR5BR9Z4ofO5FdWtyZvWzWLMt+mU4VctzYiiHwdRqzV2DydljhtFQY5GaemX3DET9t6IiSWndhajeDfq1y5+hplT9wuPNNElxWaauw4jl4q0BtzOd9YmMDtJ+uMLET8cE9QqFLT2V0lXztN/YuS5TApH5w7rTXwbhQ2FO0Ab5MA2KxxHn93Fxo5pjxpYxBiBU7Rm+JtL17hKZH+/PxPGBcqiy2yWeQC4kXiIwvCUHXiSK55OG+vqDGZBZW/kYdY4UBQrJKnJQLC27qM4S4NdrvrE7mAs5QSVQQU3SQYoc3fe3uzL5zO4Jh9N+F9Y4W5oSGv4V/rhb7zq492kiIoP7BsJvFe0YycSEly7tLiT7NaDt1PeTwpbTdMPnxlaFPSQnlUbn4iQJgkI8cOdaWHmtOr1ShCtQ5m+Xa8bG3J+08wvXlJNa5i0izr1JeCJ3dOX9ryZDEIl0JLf3kW5Ce38j2+TvOPYGzY8Q2C2iR8+3QW5Ims0AukCzvNLputINUZiKbQDjwFAUr0bRp8sctyXj/Hf8V8xT1sTWVZHTEiPfDbwETEuQe82qLQsJq+EDKcvlosfecWKDgXIiqymxqIhmZzClfkGw1xWhCKcBCtYMBSzQhLmsmnUybteBkCjz/TwpA6wxN/ipaAK3pR bx/pVmRg 5fK30ulYUGfyfYDED51KhONmOpq9ufJemFhI09/gfpMUn+2ThxNHEnCdHJTs0PAYzEO+jF7RFXp3kofiO/Cr4gCX125+noi8k3ceTFR1ZwEQQFwkjZGYGeX1RSKwRC3MScgnKvnGfM5ot7EDq7UAYMD6UlOT5bKbJGKk5K4HXSmTfDHVx7ErZTn62OFo2hFMv4aTOrBRPwI3yGqRqixMar0mcTqaPZWpta/X0YPivMGm/xJ1xH8F3OxELilok0ksPlbfSFGDKOf0jh+zsZOR5j/U/H7LQzjo0Yt448rRAP6HLagXwLor7p1gy/XF4jtbgJ7R1/mGgfxVonFbIkF5miaRnan42Z/9Lm5/h49HbT2/hW+rjIkyDUpEyEEJcKs8Zg4nHASIrB5lDDTDYLCMixbokXHLr+6xmEB0hAFpOCFHp5e3FQNWDWE+qB/VRudJ8GjrTFZse7F9l1k4AsbhyQzw4z5BEbt3JXgcf/JU0P9uBMDX16EXiaNoqMI6BpoB0te7QeRnEp3oJ6eYFcfcKgxrhoVOYHlappbsuneJ5Cu3rR7TPrUReHOJc5ux2ABegK9ZNi/5NH8PVsaaiXvSvgaZmFw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/05/23 23:59, riel@surriel.com wrote: > From: Rik van Riel > > Replace the custom hugetlbfs VMA locking code with the recently > introduced invalidate_lock. This greatly simplifies things. > > However, this is a large enough change that it should probably go in > separately from the other changes. > > Another question is whether this simplification hurts scalability > for certain workloads. Finally got around to running some performance tests on this. As a reminder, the hugetlb specific vma lock was introduced as a result of this report: https://lore.kernel.org/linux-mm/43faf292-245b-5db5-cce9-369d8fb6bd21@infradead.org/ I do not have access to the database or applications to recreate the issues originally reported. However, while working the issue I did use a simulated workload that showed the regression and improvements moving to a vma specific lock. Here is part of the commit log describing the testing when the vma lock was introduced. "The recent regression report [1] notes page fault and fork latency of shared hugetlb mappings. To measure this, I created two simple programs: 1) map a shared hugetlb area, write fault all pages, unmap area Do this in a continuous loop to measure faults per second 2) map a shared hugetlb area, write fault a few pages, fork and exit Do this in a continuous loop to measure forks per second These programs were run on a 48 CPU VM with 320GB memory. The shared mapping size was 250GB. For comparison, a single instance of the program was run. Then, multiple instances were run in parallel to introduce lock contention. Changing the locking scheme results in a significant performance benefit. test instances unmodified revert vma -------------------------------------------------------------------------- faults per sec 1 393043 395680 389932 faults per sec 24 71405 81191 79048 forks per sec 1 2802 2747 2725 forks per sec 24 439 536 500 Combined faults 24 1621 68070 53662 Combined forks 24 358 67 142 Combined test is when running both faulting program and forking program simultaneously." Ray Fucillo (on Cc) verified the performance regression was removed when the vma lock was introduced. I have run the same benchmark on this patch. test instances before after -------------------------------------------------------------------------- faults per sec 1 385135 386253 faults per sec 24 95922 75665 forks per sec 1 3392 3207 forks per sec 24 683 704 Combined faults 24 76004 30407 Combined forks 24 241 278 The Combined faults number drops by over 50%. This is not nearly as dramatic as the changes originally seen. However, I do expect that there will be a noticeable performance regression. Ray may be able to help running real workloads on real applications and database. I suggest we hold off on adding this change until further, more real world analysis can be performed. The simplification of the code is nice, but I would hate to regress any workloads. -- Mike Kravetz