From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C78EFCDB465 for ; Mon, 16 Oct 2023 21:39:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 489346B017E; Mon, 16 Oct 2023 17:39:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 439416B017F; Mon, 16 Oct 2023 17:39:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D99D6B0180; Mon, 16 Oct 2023 17:39:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 19F376B017E for ; Mon, 16 Oct 2023 17:39:52 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9A059160770 for ; Mon, 16 Oct 2023 21:39:51 +0000 (UTC) X-FDA: 81352642182.05.B38E599 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by imf04.hostedemail.com (Postfix) with ESMTP id E01D840004 for ; Mon, 16 Oct 2023 21:39:48 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IPBOcaoP; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf04.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.55.52.93) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697492389; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BuOLViMR2By0n/joJPuvEB5XQHuDz04EIYJYG8xQG8E=; b=s0RWUIRSitBBxPkgBWJziWajN5g31jvLP2PEkbmy1p/z5yxmtOw/k2oG975fIXkfMQdS6G SPkMi0P2lZvGUOZcxUQQNBzg0tOpwxpU1fO/m2fh3XqR9PeusdPAr2bbBzTaVBFZgloQPC RXs0p4l+riAFzURRMLi8q7HAJleg2tU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IPBOcaoP; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf04.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.55.52.93) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697492389; a=rsa-sha256; cv=none; b=kXTlnZT3QcKg3atzQFHb8NBmyTSkcOdxGxZaya97ag7JBHmVO/t33+ww3lkYulwSYYPGyl /kI8nRqN30PVOZ6l60O1WO/MYoZxQYIhuqK3hTFhUzvC87CRxJ4nUpc+i8s1hfzTaABajy yFUVs3qCxMG6/+Okh7SbwBHc+jTLz5Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697492389; x=1729028389; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ULxm3ALCvLWzeStCPJp9aHPIk/h52vXh0JSPle2l5F8=; b=IPBOcaoPGqr+moQVgHX5WUHoSWyrNEDsRWR59t8vOSrYHYQQTR1HZJ9Q kZbQV0ZMdpicKPzFAjwrvYyYJ2fPMXYR13M+VWLy7oi1sXOo/MF66noTj B8gDpjqMf6mOp2sAnEHI8vm+q+OIN0Tu7f+oLL+8gYQTnEwNUD+AnTPPm weLOqXsX3d78JjcBqEpa8PfcZp4r3mN/DOQWVgdgByHBTbc+P+oDQMdOw eZu2TRsmGtsOzzTwHpKYh1DlGSz0oj1a7ixYTLvonm8KTik060zBzdmO8 2uc7vweGpMy1BFKROLkmWmlxDQfrHQC6NUVDgy3N8CpDeF/8/3cPfy3EF A==; X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="382863484" X-IronPort-AV: E=Sophos;i="6.03,230,1694761200"; d="scan'208";a="382863484" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2023 14:39:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="749425295" X-IronPort-AV: E=Sophos;i="6.03,230,1694761200"; d="scan'208";a="749425295" Received: from ranaelna-mobl.amr.corp.intel.com (HELO box.shutemov.name) ([10.251.208.247]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2023 14:39:35 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id DE88C10A1F3; Tue, 17 Oct 2023 00:39:32 +0300 (+03) Date: Tue, 17 Oct 2023 00:39:32 +0300 From: "Kirill A. Shutemov" To: Matthew Wilcox Cc: Borislav Petkov , Andy Lutomirski , Dave Hansen , Sean Christopherson , Andrew Morton , Joerg Roedel , Ard Biesheuvel , Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Dario Faggioli , Mike Rapoport , David Hildenbrand , Mel Gorman , marcelo.cerri@canonical.com, tim.gardner@canonical.com, philip.cox@canonical.com, aarcange@redhat.com, peterx@redhat.com, x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, stable@kernel.org, Nikolay Borisov Subject: Re: [PATCHv2] efi/unaccepted: Fix soft lockups caused by parallel memory acceptance Message-ID: <20231016213932.6cscnn6tsnzsnvmf@box.shutemov.name> References: <20231016163122.12855-1-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E01D840004 X-Stat-Signature: 1nhadupz7t74kw5e6ijfb1yhn15knpba X-Rspam-User: X-HE-Tag: 1697492388-788014 X-HE-Meta: U2FsdGVkX19M7jzEOEBttpWJ+wpKlFNkz9chJi4kZ/uGKZ0OEeUP5OAskOyD8euu1ue9t9jBgdxVshQjpTk3EQM1GDRSfmbWO/Hdr5iH7+F08H6yYwD7PuTArRralkvbmXyACLWZVUO6gIq4E8Afr7Y5kSjG8kz4YI58DUnC2df0LJajAmZ7q501A3VCckiq14NdIpJNs5HKbWQzl5GQImhd/Mi+cCLVc6lxBkQo8Ej6G+V+KZbaNlSYfST78WqACu2pqvhcAxeKQLDgHUp4KsNfjSbW7Nf01L31LJWUWZL+aVfZeVK3VaEowfBhXhUVF372Vj+pG+oAKTHSc3Mqbwy8orPjSrfO22AAMrajIEgj1VbIHMcpwiCdVfyqsFb3duKCixDrd6gvzn141/C+JJclsJwdWvUMwyYCdfzj8BgRXAmYC5qGEp+ZZCkhcc7c/tANvp/96/PmO/ZA2ko2kG7/xC4WfJDsGFP4GY5fSW+0NJI/lnTznEhF3kZpCWBajep2GvdBpaEQS7OqQYQ6jp+uosEcRweBrMuuLqYLGE2IrrUMCzevVuLOQsaQPVDEbCX6miCc8/Dqr8VlfRn7l9s8LyrotB5SNN3csmMfoFJD3kqS1mPxSu8XNuYWQeKFBxIEe5j9zFW26f9/ZXKsMIIfB9LRE4rIDYkDJcNG2O+BAcFyV8cUBaCwLHC65oDy2RtuyjZ0AxvfpMqUhbnKvbKbDb7Gdhqst4yRiNsjWK3QtBin80My0N6pltx/JiKK6euspUdi7hDTBjtNlY9fkVl1jMHOIk5KZChWIpwoK/a4YCHz/lwlpGx3EvpAIICwr8tW5QWI2P4kkrI6oDGkEJXUy1cpOAO0O/3UX92T+sRo1V8FNoIQp2OUm36f5saOjcWRC709qWvz3yjw/g8tOXLlEKxBt9wBW/sIZ/dWAWAeyDkhCEwdmezFYX39a3XL6ooxs2SIWKhZLOVDKkH 3SKDNYi2 MGZJPMpmC723ihomXikz3h7X6x7CIfongBdaofpqTagnno0EgSVBNkfPhADQbAR84qjK9lnSGvwUXFRajKcyuBEHfw6eR6OmdBdNyjqDhLRgqLRo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 16, 2023 at 06:55:41PM +0100, Matthew Wilcox wrote: > On Mon, Oct 16, 2023 at 07:31:22PM +0300, Kirill A. Shutemov wrote: > > v2: > > - Fix deadlock (Vlastimil); > > - Fix comments (Vlastimil); > > - s/cond_resched()/cpu_relax()/ -- cond_resched() cannot be called > > from atomic context; > > Isn't there an implicit cpu_relax() while we're spinning? Does this > really accomplish anything? You are right. It is useless. I will drop it in v3. -- Kiryl Shutsemau / Kirill A. Shutemov