From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75285CDB474 for ; Mon, 16 Oct 2023 22:40:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E31B68D00C8; Mon, 16 Oct 2023 18:40:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE1378D00B8; Mon, 16 Oct 2023 18:40:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCF918D00C8; Mon, 16 Oct 2023 18:40:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BDCBA8D00B8 for ; Mon, 16 Oct 2023 18:40:03 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 92522C0C64 for ; Mon, 16 Oct 2023 22:40:03 +0000 (UTC) X-FDA: 81352793886.29.CA48CCD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id E6CA710000C for ; Mon, 16 Oct 2023 22:40:01 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=vGzIbEYf; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697496002; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=12Thn3jdVhQ2l+0D+Y5gvrYUZ86BfSQJ+Gkoik/WiQI=; b=CkVEhuSHRPX8bwjjOlnp8DnMLaAWgmFkcGDei4TaXbWvo9k9vkh7U0nmdhGM0Ky/WURgcx dinE9DAMH4H/NsThPvFfj3dUV7enz18z64+fibDPhP1exQmz17uMzLYMx/6WLBNAtCY8FK 3Wzon6DMq5VbulCPpCl+lKd6abEJgEY= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=vGzIbEYf; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697496002; a=rsa-sha256; cv=none; b=rVcyBODpNTgtnU9SjvNg8/9yIJKQ8p0/O0GTAwkBuR5/xKEJgNbuZSUzS+uosEGY8U2Yut QrGYkRSmoR6Qwv1txmw4w+JPaRotQYPoOaLulfTwdofENFzoCpwDECDBlgyl5EshrroUHQ VzBFObKe52vEeT6Wz7Ts8lPGcUxaBIE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E8D7A611EA; Mon, 16 Oct 2023 22:40:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D75BC433C7; Mon, 16 Oct 2023 22:40:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1697496000; bh=V1BRkFF3SiBUx+bZijH3HFIpyiSAqaYK+1MwBJFCW8Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vGzIbEYfJPfxFebbfPS6y0TCzRwc8CO4iz0XFaW46fUfSJGwS8LK/FYoAOlvS/fak X6Z520q7KjmF2IwR+NQOTYOWA/s8L2YY5Hr9OvQ8j2OUnsA7Jm6zKEM+1JRlSujze2 LXn8lFZVrsszFzPTsCPDH0+ggogUlyCzinUHjjas= Date: Mon, 16 Oct 2023 15:39:59 -0700 From: Andrew Morton To: "zhaoyang.huang" Cc: Johannes Weiner , Roman Gushchin , , , Zhaoyang Huang , Subject: Re: [PATCHv6 1/1] mm: optimization on page allocation when CMA enabled Message-Id: <20231016153959.c218e1ae876426b9193eb294@linux-foundation.org> In-Reply-To: <20231016071245.2865233-1-zhaoyang.huang@unisoc.com> References: <20231016071245.2865233-1-zhaoyang.huang@unisoc.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E6CA710000C X-Rspam-User: X-Stat-Signature: dbptms9cjqe1kd1n6rir6f9taug58wik X-Rspamd-Server: rspam01 X-HE-Tag: 1697496001-630982 X-HE-Meta: U2FsdGVkX1+EMZ0jliIVOVKJcHSef13clAzO5hPPR6fbSOMQPx0D6l3dfT5LjZ0QxjPETR1++G0eYcPN0sWH+7oX1Zv2ODTMWp7upi55dj4Qn/pGcIMBmYhkN4ovn2hhhUsYMElP1zfeR/jVyWx4tmFokGje6NJF0L0v90ZRDneHTkvgeY8r31pf27dBgXkDeBYd+6d4gaI5gF1CTscXHMctDARzCXZrtYhNjz4OnzdcWYcDaEsXtLRpNwMY0/syMFxPHoU/PCpKxPDtobrmCjQR39Amt5aJBL5nt1VL69+cKNXXO0B6EJyj19u653xROzXI6x4zm/m2h8eR4eUlbDDnPI9ARr3ZxaphIyn/uzilQcZouAQvTOUmaQk1ibspJTB7hySPkBxi7fKKO1mazDj97Z6LlbR+mFUcANDCFN2OEJkBM4/HdRNWdqmsh54xxfnAf+npQ+yMQ3FO7Ou8yMjeYrQmz5RkjAoEwjZc1dv8jUI1szS3mCbAWV3HN1UWBG7VB7m2kQ1azM3zPEYRk0sNsAwXGPCgptHvmmj4nniEaruGnRY2C6SVbl4byElm5mZD6ahKuVay2cej1PqvKYGI7mAVGutrGitBRJrxfccahJ4y3bpmMXtXYwCOeNQqA8IEH0PsC0lesiQq6ZZJsN52iOUt0J6+WAzibQ1yXeC5GYAgZgGMt/JxHQQmRuNvWI7KppkOmDtwEw8z689TIMO3JvqSCOKWBT1sR1wsu8H+ooDCeWWSYYV7dITw3XUGE7Cu8/ZCZYCiLpq/d47KE7lhe5uC1jTrsIeR15L6MCcHc/9t4e4nJp9TtuJ+BTL2xpxppablyFiWoDO4UpoaqnPMuptnr1xHE5RUBcMGl1HOwZtbLYtf9vvOklSn9K5M3/nyC/pU3Zr/7SJcrfWcotLvO+vwPluAcdVVew9e4jMFFGKGRP96PKRwdlCMLqTa6kgCUp+XkvWROU7bktj lcITij7M pGCvOWD+JGVYkuMQ5gaVj7NjnRI34X8gIYkNfjulD2Kib74U1ZaxuSbXBT5wLzrgMpuciH19peLdcINCeHpmSrIX3vSEKC3dDeATLc5NXb1hLTD7FTA0KRZFwZOGJ2zO2VdiJyQ52g08Bn2YTPSFPnIkWv0m2d5M1doRxcBHrDWVCN8tcbmk2ZKW1u3DBwZEb/OTlC95eHinBHglXIvqTlwiMT8u2oQ5dRQagpDnhy//vxYSh2kHQITxXu5lPcNBYXo+hUKcTtCpIWYURbHRyZtSa/v9EBB2T4elDyehAQIfr51YRo/wWEW7NIdXTLU/hinUfIYZMIMeJ3VtFan/cWc/rAme03Xgu7hIJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 16 Oct 2023 15:12:45 +0800 "zhaoyang.huang" wrote: > From: Zhaoyang Huang > > According to current CMA utilization policy, an alloc_pages(GFP_USER) > could 'steal' UNMOVABLE & RECLAIMABLE page blocks via the help of > CMA(pass zone_watermark_ok by counting CMA in but use U&R in rmqueue), > which could lead to following alloc_pages(GFP_KERNEL) fail. > Solving this by introducing second watermark checking for GFP_MOVABLE, > which could have the allocation use CMA when proper. > > -- Free_pages(30MB) > | > | > -- WMARK_LOW(25MB) > | > -- Free_CMA(12MB) > | > | > -- > > Signed-off-by: Zhaoyang Huang > --- > v6: update comments The patch itself is identical to the v5 patch. So either you meant "update changelog" above or you sent the wrong diff? Also, have we resolved any concerns regarding possible performance impacts of this change?