From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4B87C41513 for ; Mon, 16 Oct 2023 14:55:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48CE98E0001; Mon, 16 Oct 2023 10:55:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43CB78D0001; Mon, 16 Oct 2023 10:55:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 270908E0001; Mon, 16 Oct 2023 10:55:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 127E38D0001 for ; Mon, 16 Oct 2023 10:55:47 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BCD8D1609AC for ; Mon, 16 Oct 2023 14:55:46 +0000 (UTC) X-FDA: 81351623892.23.0CA0DFD Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2068.outbound.protection.outlook.com [40.107.92.68]) by imf14.hostedemail.com (Postfix) with ESMTP id BFB1310001B for ; Mon, 16 Oct 2023 14:55:43 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=c2WWQISv; dmarc=pass (policy=quarantine) header.from=amd.com; spf=pass (imf14.hostedemail.com: domain of Michael.Roth@amd.com designates 40.107.92.68 as permitted sender) smtp.mailfrom=Michael.Roth@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697468143; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nBRF+yaHlkQdPZYDrNYvy8tbtuS7WfnC5aXllUVOfoA=; b=Jrkw5Fjy+q4jk1cn0ZFx2DBqXyW13NCzVlufvLn/Vs5rxE0M1emEdRmcNxNRXNBJ7pUNQL hUoocNm7LGbvWVEPPKVlYDfyx7Y/iGvZ3jkyO4a5vtvqIiKrTODF7VDjqCDfS3RQCzdPn1 9ADwe9WEI0f8JsRYkRdkV+Av0w0QSrI= ARC-Authentication-Results: i=2; imf14.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=c2WWQISv; dmarc=pass (policy=quarantine) header.from=amd.com; spf=pass (imf14.hostedemail.com: domain of Michael.Roth@amd.com designates 40.107.92.68 as permitted sender) smtp.mailfrom=Michael.Roth@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1697468143; a=rsa-sha256; cv=pass; b=4Ef5xNg2NasLrviEQLaIaHS+dM+s1zuTtjQVC4A92Gf3PPAv+wY4shZNQMws9WROkqjAVi ynywvs4hzuH/7fXABakcA8TyAZceqBF94CRyVP0r7FOD4gPUFpi19NbjHwzwsLyv0ESWd4 g/6QkdVHvhIs0G6ga4Shz/U4IPUyxIk= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VJw91vbBA4nVVDqeXRU+H2HpZcXSwYpwkbYzf+0PeiCv9cemEqstq1TBe8/mPWyUCT87c9urmZw/Q+Gz9/X10AP/NQDkORiAzu98PNrDgoYNVb1DYhph+QR4tvHmGOHNXQIYjb8NI8I+RjKlNIyzOLtLTkUkbW80FDUsTqebiDKga2mpf+dh40eyjhmZFw6VpcDg+kqnN/YUSgBdGwfRSs+rr6ZZx8amvQHxRAfdMzs54DW7ShMXbJ2qqQSXWoMAr1R8teYc6M40t2qMzcYgEkPh44traim9cDuOOXQ4JOs0e4MKmz5BxB03ZXjHy8WTYl9kzVVrIZr5E9V1VG1moA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nBRF+yaHlkQdPZYDrNYvy8tbtuS7WfnC5aXllUVOfoA=; b=BrYnm/+2K4mk9B1G8mbcyobrvGaioZzexhnO/RhT5FQM3lPt50UhGwVcyfJpmDFVZexltbi6qFH9qRnhgAhxJV+IwH6Ztt2M9l9bD0fQTNjVTdg00TQJKIlBnPTpkH7H6hNHil8ECYYYB6X19+bAwNNU+Nt1SiV4M8Gx4iLNm7GJzTSM0wqKjLp7Vj4zk1mWz2+nkI+Oyh3HdcSST27fOQki/oec6RWAPdIsJR9KGNGhcJe2GItgxzEHueAnw/aYuT7PwkF9jam89uVzA8fEF4SW+2z6jp+MgIHN6G57BdImSaXYYzm3t+Cqwl/fFPdRK4DzFT5VU4vO6Y7aFQh9zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nBRF+yaHlkQdPZYDrNYvy8tbtuS7WfnC5aXllUVOfoA=; b=c2WWQISvN9nIRd/BMft01V+18WWROI0H5iZqbx6eB2xu36vX4vWJlExZ+shrqeToz+TBSQ2wlF7fJ/Nm4yPM6o788zcV/AJ6uRnro4CtAPOYdyKi9Jb3j+i+hnZ++sHgmWVdgvABZK8bV+GBWQfiahZFyojsUKWX3uUqD4iv5Uw= Received: from CH0PR03CA0247.namprd03.prod.outlook.com (2603:10b6:610:e5::12) by DM4PR12MB5038.namprd12.prod.outlook.com (2603:10b6:5:389::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.35; Mon, 16 Oct 2023 14:55:37 +0000 Received: from DS2PEPF00003441.namprd04.prod.outlook.com (2603:10b6:610:e5:cafe::dc) by CH0PR03CA0247.outlook.office365.com (2603:10b6:610:e5::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36 via Frontend Transport; Mon, 16 Oct 2023 14:55:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS2PEPF00003441.mail.protection.outlook.com (10.167.17.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6838.22 via Frontend Transport; Mon, 16 Oct 2023 14:55:37 +0000 Received: from localhost (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 16 Oct 2023 09:55:37 -0500 Date: Mon, 16 Oct 2023 09:55:18 -0500 From: Michael Roth To: Dave Hansen CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Brijesh Singh Subject: Re: [PATCH v10 09/50] x86/traps: Define RMP violation #PF error code Message-ID: <20231016145518.6vlhsbh5cr2wfzuw@amd.com> References: <20231016132819.1002933-1-michael.roth@amd.com> <20231016132819.1002933-10-michael.roth@amd.com> <1976018d-7173-49b3-9285-38cfa570d573@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1976018d-7173-49b3-9285-38cfa570d573@intel.com> X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF00003441:EE_|DM4PR12MB5038:EE_ X-MS-Office365-Filtering-Correlation-Id: 165e2bc5-b573-412e-2f49-08dbce57f553 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: doAsCouF/lvybte70wjqPEZJTmcmjKOe1oGgdT9KsndiwUdp3Ytn8IimglThwrS58RyPDAlqHdOZUO6bMVyQIdW7MZj7vP8ccv2N9h1O7+FjVHCgeniSjUXzEFfeXTQOM1NKrzFPXvcGvzvHtok1Llg3I2u/okBX9OyJY3Zb1VJgfROul4dpwMVU8Podw2NNM4/uIHzQaYmelyGqd3KhsOwijUpBU9xlh/WJO39Rjgr21RneFLu7xLYAUWVeOhpailBYcB7Zfn1aI3r7vszSaOpvYnGNeyiFBz0EARf7Y2gUiO7vezEgNfM904rfxIC+6vqCamhI+F8n63ymgrU2N6FqgWuKkXozmRslcUK7nQgAaGgxHgZHIZj2IjQ/zejIRDHdSu1t2UKSqCqBKly8o+S2PUJYPmL9XG8mrRHsDTKYYJiAthkhsy61BFDnf51ZhfQFdHXUG/kB6plqeXFZCjZdBomkeKgziUI+1OR8ZJ8Md3GSsl6jN4db/P4XklbFnQX1+E7UrRmR28QoKngq/gh3Zd9iAXwDxHBM8tyZUgNLvct4PY7GVYXZh0O4pkUG9CBGXjFKFBZnvm3IGSG/IA/Rw3+fbI2NSdoklYJDMKB7NWXjx+rDBKD44xWbofB9noRG8Auqn81l6wylN0BNLq/bPNcTqXkmppXtEzJPhvxj9jNzG4wFsM4HEsxvPA2hSZj2RW6V0AqOB0qSkv71w4fgvj2NxamIZXT/0LxwqT5I3zcOcMtWp0qsiYmDK4HsRQ5L6YY5W7AZGoljqqFT8A== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(396003)(39860400002)(376002)(136003)(346002)(230922051799003)(1800799009)(451199024)(82310400011)(186009)(64100799003)(40470700004)(46966006)(36840700001)(47076005)(40460700003)(36860700001)(6916009)(316002)(53546011)(54906003)(70206006)(70586007)(478600001)(5660300002)(8676002)(8936002)(4326008)(86362001)(6666004)(2616005)(7416002)(7406005)(4744005)(41300700001)(44832011)(2906002)(40480700001)(16526019)(82740400003)(81166007)(1076003)(26005)(426003)(336012)(356005)(36756003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 14:55:37.5623 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 165e2bc5-b573-412e-2f49-08dbce57f553 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF00003441.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5038 X-Rspamd-Queue-Id: BFB1310001B X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: a3ge11onmass7r1n9mtnkgx56xt4y75b X-HE-Tag: 1697468143-301181 X-HE-Meta: U2FsdGVkX18SF0qA19O3Q0MPQPGyRhW4a4aU/znpJPrOWoo4TndTvBFh9AHV78Tfj002CbOBuHrLIkauhEtrgORzNe70Vr2l5RMI0sAVpbgKK5vKlmr/QP0+ZiuTqPQwh8OhTcdc4C2zpqAlrDC+lcGPeoyDsITuvsyCKqXpxpSeZDMFINISS0gX+Y/8piNoJJPkQbeRk7m5Yl7BSN5i7q22jqWnSry1cyEAY1uV6UgNe4WI8la1/2Cizw2/5qyBnNX7K+SWrYI6EutTLxTJb8X9aayiPjxThQ/GlMEvG7InyDmHKQ8hEvJp6ARICYn+UjtT04neeW1wR7UDu7lomvwD0dh4yDpQE2teOun+kp7NguQlJx4wGEkxHctx4Sdj6kfYKxpex8EhmFAlb80iVuO3erKb+LQ6yD/Bywb/8eH9jkPDkLq6oyBN4ofB+AjYslF5zjfdb0lF3t0tUB362Fl2GzKqtDt2FRpw29xLpfELzyrXY8NBYx9GNkw5KB9Mw/XQkfqmFamT3E41u/iD1ulpWwDnz/JYp31zEB6nP5DN+qNl/t4Sv7LY3lXr8K6x30lR6x58Y3FPdRa5ki7QV/pRHPb7HUC6cf8IIvywJTUKwA4aawmg17dwj0cpYk6HmbcD5vj0YjDHDMDIXJOmIhPH8Ah6qtWSqCwwx37Bdh6LZAGMoOJr7x2ErFmjHMsRXJTknQ3TvwC2UGGH4PYayq0QnvEyQVi5fBBujEZidSvQ9Xr/rwagyA3I21jRyOjoF2mexuUbJAAxIDTu/AYCsQu2wUf5NMen/MwreaaNWOV1F1yIozyZM6x4AiucmuJ74mSpWkzpJq9KsZBnt2Bw/S3Yz/SCXWD6Z4tN2M4c6+sE4cCR3rac40V/B8Gq83P6NeDi71CgOFbQ5rjk1VX2ksb0b4QG4rXV5cz5B1oSXw9d+xSZ5sZE25D9t/l5TFQ4dgw/D4zdfmYMLGeEvoe BQaj/L8q NUSCV+fIjfIP0+1DiAF/Nuy8uuZ+jPpokV2jlFCfEOxxfQ8LxrafJxl72JBGwms0r4vvgIdwZRuWoanAebJSdZDFpwzGliqSSQxKDXyhVlW4zrJF/Cf9JQI4lqjljjA9s8wJBAT0MyZEtIcQ5rCRrguOHAAz8mEPY6CKsEi+jLyAm2Zsup4WJWGk5mSzKFPb/XCCXv66tKqiN8vNVjX1s2uPdz4pI8xTTWd1tNNEh5K45Ym2XhR2lCOlJlU++BO7Nc7HFrtFpVlmbOuV9xaXofFcosbXFdAtTtQrnsZS3CKMh7Ao4KTy0eLKwRkUoJ435+DA4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000039, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 16, 2023 at 07:14:07AM -0700, Dave Hansen wrote: > On 10/16/23 06:27, Michael Roth wrote: > > Bit 31 in the page fault-error bit will be set when processor encounters > > an RMP violation. While at it, use the BIT() macro. > > Any idea where the BIT() use went? I remember seeing it in earlier > versions. Yah... this patch used to convert all the previous definitions over to using BIT() as part of introducing the new RMP bit. I'm not sure what happened, but a likely possibility is I hit a merge conflict at some point due to upstream commit fd5439e0c9, which introduced this change: X86_PF_SHSTK = 1 << 6, and my brain probably defaulted to using the existing pattern to resolve it. I'll get this fixed up. -Mike