From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C98DCDB482 for ; Mon, 16 Oct 2023 15:06:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 027A88D00A8; Mon, 16 Oct 2023 11:06:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F19CC8D0001; Mon, 16 Oct 2023 11:06:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBB9F8D00A8; Mon, 16 Oct 2023 11:06:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C9A3A8D0001 for ; Mon, 16 Oct 2023 11:06:56 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8D6B0809EE for ; Mon, 16 Oct 2023 15:06:56 +0000 (UTC) X-FDA: 81351652032.22.629D6E4 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id C546CA0032 for ; Mon, 16 Oct 2023 15:06:54 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=DY8wfejm; spf=pass (imf15.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697468815; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JDrJBZYG3xEq8iRoRfNjvUVSesTfQ4U41JLvuRFgNYE=; b=U16sB5r9+IirfV3134z3DYDClUTouZYrcXBUMIC/0UdbSLl2x2hqJUtszL+UAtMhuQDOQL m3oe55qLaiOJWXVahW/R0yDu2lPl8qiYeqvWT30Anb0YgwVDt78/jATZqQmDUoAikPGzmN wmcSdlLmzPM/ZOUZqbiyhST05VepeJk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697468815; a=rsa-sha256; cv=none; b=oQAws8ibThQ/MJfElvBe9uF+6EBQS2Vs0F/mtRj0eOvhHlvwFctW0Uj+IanrRM708XSlg5 lLIcisuANOK2AbbXL6G41w5V3d0r8xigzEK0Ep7ssc9VqEUpwFuHmDnpmiSUshT730VJA3 mI1HKNzZV294zZAwxrO1o3DK1RZpwAQ= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=DY8wfejm; spf=pass (imf15.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7E85960FE3; Mon, 16 Oct 2023 15:06:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9EC7BC433C9; Mon, 16 Oct 2023 15:06:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1697468813; bh=GCcpSZHz166979U6vHgX4cVsCXfd7NMyD8cEsvnOS8E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DY8wfejmM71V/4hCVydHZ+QhMceo63CcT9Ew3cgKYqqokpfzXOO78fC1SLFQ/C1px Fjq/n3TPno7gzRCfzzlYx7PL1xYsjXAGXGHD1NNcTY+iXHT7OkpapmwZbzKEhEUsz3 3yB/5EwhAXNqLjuUsA7lqDt3fEttcxec/ezXdrEY= Date: Mon, 16 Oct 2023 17:05:07 +0200 From: Greg KH To: jeffxu@chromium.org Cc: akpm@linux-foundation.org, keescook@chromium.org, sroettger@google.com, jeffxu@google.com, jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, jannh@google.com, surenb@google.com, alex.sierra@amd.com, apopple@nvidia.com, aneesh.kumar@linux.ibm.com, axelrasmussen@google.com, ben@decadent.org.uk, catalin.marinas@arm.com, david@redhat.com, dwmw@amazon.co.uk, ying.huang@intel.com, hughd@google.com, joey.gouly@arm.com, corbet@lwn.net, wangkefeng.wang@huawei.com, Liam.Howlett@oracle.com, torvalds@linux-foundation.org, lstoakes@gmail.com, willy@infradead.org, mawupeng1@huawei.com, linmiaohe@huawei.com, namit@vmware.com, peterx@redhat.com, peterz@infradead.org, ryan.roberts@arm.com, shr@devkernel.io, vbabka@suse.cz, xiujianfeng@huawei.com, yu.ma@intel.com, zhangpeng362@huawei.com, dave.hansen@intel.com, luto@kernel.org, linux-hardening@vger.kernel.org Subject: Re: [RFC PATCH v1 1/8] Add mseal syscall Message-ID: <2023101614-scarce-discount-d7ff@gregkh> References: <20231016143828.647848-1-jeffxu@chromium.org> <20231016143828.647848-2-jeffxu@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231016143828.647848-2-jeffxu@chromium.org> X-Rspamd-Queue-Id: C546CA0032 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: w1wbi3hcitup4tz6szw7ho7zxudjqg79 X-HE-Tag: 1697468814-222848 X-HE-Meta: U2FsdGVkX1/6Nd6/aN0O9Uy/+Tia6iMSAnjdXUhYs5H4/cj43xeEclCeYhCGEvHbuyYIGPeYkpN+bHWlj1NaIcAfIHJFNGzlDViF9GbLLYjwgIaTMB6wBJ2+3M9Ajojm5NzyeoHBZB3Xaluzlk1QBlxTTpQiNYtQtUgt3jGcsG5KTaf5Pd7kU8PNM+LYB+3OO73zahv1+/LaIedUTZ0sjkje37dt3msdTMDX/WK9vlWufE1ZbWiG9oLi/waI2jEJTE+zIS9Oafwwk+sSQXb+Vgc+he49ew/HcONfPzvDOoiuFZzgUPhQZ45m6XD6syy5/ptEgHEXGUyjMklwf8BToK6q/tCDPiHEsuOP9Pn32HrfruzrgdHH0h7fo5qXZ7RRPoe5PydccLyAZFiejLTH5AbGqHPBqfeOp7vpZmko2czYpCjlEq54AcBYtKBvzDg+ShzCH0R+li91dQ8fLIVc68PK4WsHVvoLIO+OMZCsuLLS1MVkuzfafP1bAOQWhj3EdyorSK/21LJEJ0KeQoN8XzKP9Srf0ih/BLzt66YOsk8UOxv+fUSU27ITi75gLII4P6ZIXKQj68yABQTXCmVX0OS/aCW3AmCVXVuCrPgU6ncjioqcQbc8iYhBtJuGrDzPrmIPydbtLwzhDQrGcjI1NIAIdG5JlVKcU5mTnGxtcVNAV3Bicb+n9Sd6ri4/whnNLrCwjuS60nY68xs5iy4eWfCWEDCWDh6aIvz5sX9PLHWnMDy6f3nZXegWtHE238zhK0SjcJoVybcGoyPPmA1ZbQhpeXO5YX2G8L8HYSXyzPeBOhahB8LQJ7GijqBPvo9o4vRYEabjt3QLu8IzFCmrxhxz6d1bAMYpPKd4ZvfGUWuPMRikV2jMriL53dwJj6rR0dJb6K0MwVr2lxhuicuaISocGTOswBtlE3QREai52mCdg+AtH/gH45QW85NxDT/gkk2av+Q53+kpvOIAmZE v1XVlvV7 KBvvtYeFbnsy96JBzEk91Ifse6vUciLbcmtYwFks0lagH25OJ7pU4UB41/TOKn0FCRLA4vxbrgcpnBCvbDB83/5u9oXeB9me6JEDTLw4vM6mcSsVgob8DkkHV4akXmCNpZ9W1EutWeta0uUJ0zqZSilZhDQb/UOIw9GaPWQNaue23PbIGZkPgXjgDHiAarGE/9R0Uufu+s+fwVlNjvG+Ex8G26B77IDu/NhdZYj0hPB/00VDSoZjvyGe3x0/y6RL/d3qkVcen5DnOc9GEHq+CkaiApA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 16, 2023 at 02:38:20PM +0000, jeffxu@chromium.org wrote: > +#ifdef CONFIG_MSEAL > + /* > + * bit masks for seal. > + * need this since vm_flags is full. > + */ > + unsigned long vm_seals; /* seal flags, see mm.h. */ "unsigned long" and yet: > diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h > index c0cb22cd607d..f574c7dbee76 100644 > --- a/include/linux/syscalls.h > +++ b/include/linux/syscalls.h > @@ -802,6 +802,8 @@ asmlinkage long sys_process_mrelease(int pidfd, unsigned int flags); > asmlinkage long sys_remap_file_pages(unsigned long start, unsigned long size, > unsigned long prot, unsigned long pgoff, > unsigned long flags); > +asmlinkage long sys_mseal(unsigned long start, size_t len, unsigned int types, > + unsigned int flags); "unsigned int"? Why the mis-match? > --- a/include/uapi/linux/mman.h > +++ b/include/uapi/linux/mman.h > @@ -55,4 +55,10 @@ struct cachestat { > __u64 nr_recently_evicted; > }; > > +#define MM_SEAL_MSEAL 0x1 > +#define MM_SEAL_MPROTECT 0x2 > +#define MM_SEAL_MUNMAP 0x4 > +#define MM_SEAL_MMAP 0x8 > +#define MM_SEAL_MREMAP 0x10 I think we can use the BIT() macro in uapi .h files now, it is _BITUL(). Might want to use it here too to make it obvious what is happening. thanks, greg k-h