From: Kartik <kkartik@nvidia.com>
To: <christophe.jaillet@wanadoo.fr>
Cc: <akpm@linux-foundation.org>, <andy@kernel.org>, <arnd@arndb.de>,
<frank.li@vivo.com>, <jonathanh@nvidia.com>,
<keescook@chromium.org>, <kkartik@nvidia.com>,
<linus.walleij@linaro.org>, <linux-hardening@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
<linux-tegra@vger.kernel.org>, <pdeschrijver@nvidia.com>,
<petlozup@nvidia.com>, <pshete@nvidia.com>, <robh@kernel.org>,
<stefank@nvidia.com>, <thierry.reding@gmail.com>,
<ulf.hansson@linaro.org>
Subject: Re: [PATCH v5 4/8] soc/tegra: fuse: Add tegra_acpi_init_apbmisc()
Date: Mon, 16 Oct 2023 15:45:51 +0530 [thread overview]
Message-ID: <20231016101551.7308-1-kkartik@nvidia.com> (raw)
In-Reply-To: <998767cb-1c70-45c2-91cc-858315be1a52@wanadoo.fr>
On Mon, 2023-10-16 at 07:41 +0200, Christophe JAILLET wrote:
> > + /*
> > + * Get required memory resources.
> > + *
> > + * resources[0]: apbmisc.
> > + * resources[1]: straps.
> > + */
> > + resource_list_for_each_entry_safe(rentry, tmp, &resource_list) {
>
> Nit: Is the 'safe' version really needed here?
>
> CJ
No, it seems like the safe version is not required. We do not expect any
modifications to resource_list here.
I've updated this in v6.
Thanks and Regards,
Kartik
next prev parent reply other threads:[~2023-10-16 10:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 5:34 [PATCH v5 0/8] soc/tegra: fuse: Add ACPI support Kartik
2023-10-16 5:34 ` [PATCH v5 1/8] mm/util: Introduce kmemdup_array() Kartik
2023-10-16 19:49 ` Kees Cook
2023-10-16 5:34 ` [PATCH v5 2/8] soc/tegra: fuse: Use dev_err_probe for probe failures Kartik
2023-10-16 5:34 ` [PATCH v5 3/8] soc/tegra: fuse: Refactor resource mapping Kartik
2023-10-16 5:34 ` [PATCH v5 4/8] soc/tegra: fuse: Add tegra_acpi_init_apbmisc() Kartik
2023-10-16 5:41 ` Christophe JAILLET
2023-10-16 10:15 ` Kartik [this message]
2023-10-16 5:34 ` [PATCH v5 5/8] soc/tegra: fuse: Add function to add lookups Kartik
2023-10-16 5:34 ` [PATCH v5 6/8] soc/tegra: fuse: Add function to print SKU info Kartik
2023-10-16 5:34 ` [PATCH v5 7/8] soc/tegra: fuse: Add ACPI support for Tegra194 and Tegra234 Kartik
2023-10-16 5:34 ` [PATCH v5 8/8] soc/tegra: fuse: Add support for Tegra241 Kartik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231016101551.7308-1-kkartik@nvidia.com \
--to=kkartik@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=arnd@arndb.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=frank.li@vivo.com \
--cc=jonathanh@nvidia.com \
--cc=keescook@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pdeschrijver@nvidia.com \
--cc=petlozup@nvidia.com \
--cc=pshete@nvidia.com \
--cc=robh@kernel.org \
--cc=stefank@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox