From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0ADCCDB47E for ; Fri, 13 Oct 2023 07:45:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A7078D015D; Fri, 13 Oct 2023 03:45:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 555CC8D0015; Fri, 13 Oct 2023 03:45:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 444908D015D; Fri, 13 Oct 2023 03:45:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 329958D0015 for ; Fri, 13 Oct 2023 03:45:06 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 02F72160198 for ; Fri, 13 Oct 2023 07:45:05 +0000 (UTC) X-FDA: 81339652212.23.E560D62 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf06.hostedemail.com (Postfix) with ESMTP id E1A07180003 for ; Fri, 13 Oct 2023 07:45:02 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of suruifeng1@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=suruifeng1@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697183104; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=5/zpWM7ArWj/juaBPdaqeUioVNX91UPCg2f+q9y4RJw=; b=X7md+6wcupzJDXjMEBHPA+kPkLtL0uTlGpk6XjCUvlobKCi3konYBKVhakfdaBhLivh2wC XyT/2kE0i08tz8JTsJCN3c1OQVVi5WiEvVjT0Hoqzx31/NS1UkXT7NSM+UgtQ5VXsMMW4u WUCTjsiAcjQJyVWzPzWiO/qu9JoMp+A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697183104; a=rsa-sha256; cv=none; b=dSv9ud6Sd1pgm1x2ZULiiyq+hknJu84S4GopSM3MnRgV+uYLfM2EYHYlvzANQns5x6v3fS M/vJz2mtrI0mVGOO0YfQ1FfWsoL2WGz+NXHjmaroW9LcvhLXxUORT5KOSnrLqVGQyiK8J2 zlmfz9zNSn7NnteIukL0PZkj8mmWUo0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of suruifeng1@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=suruifeng1@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from dggpeml500015.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4S6JMs3Qtqz1kv6J; Fri, 13 Oct 2023 15:40:57 +0800 (CST) Received: from huawei.com (10.174.149.20) by dggpeml500015.china.huawei.com (7.185.36.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Fri, 13 Oct 2023 15:44:57 +0800 From: Ruifeng Su To: CC: , Subject: [PATCH] mm, memcg: avoid recycling when there is no more recyclable memory Date: Fri, 13 Oct 2023 23:40:43 +0800 Message-ID: <20231013154043.1236185-1-suruifeng1@huawei.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.174.149.20] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml500015.china.huawei.com (7.185.36.226) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: E1A07180003 X-Rspam-User: X-Stat-Signature: e596xjjeg3kng9sup4azxpfszq5bruwg X-Rspamd-Server: rspam03 X-HE-Tag: 1697183102-647853 X-HE-Meta: U2FsdGVkX1/uAkJZ+EFlo7rnfEi1Kf9IVMGqqvXs8FEnx3kTG/63+T8rly2O0xkfaiRrgyMI9epkpyM+SFJubqAEQxeIK52iLnCDkizqKU9C/PJEh2OX3lDgOX7n7xcJnfWK62vDHaVSRnqTkcK8rk3i5WnEu3yNIwvTgj00dSOplaujaNL4JAXAefCIhBPdwqIGRaMQbZi1QVJGgNbWxSW5lOvhu9IJ7TztmY1OqyuDLJMJWTJ95HPLtOs0frGfmlpYOxrhzZ3Iiha1a7AB8IfjQTuOy/M9/O+x4DINwUscqJcgUGHcAvsktlwm/HWqVzt0lYXJjsccztZ/Czzg+pCoS5GWaLapD8FXwGF8DD1fYI1zxtL/7QyJAj6LzTmRvqA3lPPRAMlYWukl4UB0WJDUP4VyqeB8GRXR/xkDOmIWK/APtrYfHqcisIE1uv0mXI87Sp4BSk3QfW4W6iTQZl9jNI0V1P6u8HkbHTUBKvdnRfEYZZiOk2oTeekSKU83TTeA+nynZQOsj9qOzDwz5aSzumbfR/ayy8TFchVAKara5Ho4UvMW7s7KZX9WFXAyoZx2ZEWqN2Ugr9Dx4MIZEiASnbiZogtlhWLOz4w1q1VYRc8THV2Z1WRjb+/YZOg2P8xlkF9hP1XuvhzHTJ+z5MsZMvmwqTCj+oZ4x1W18zCVItY/BRi5Tgu1KExX4PPT2LA5f83GdgY6OuJvJUORzNd7Hx++Iids4r9XVGdTBuSiPrwxby/+ToyKrIcLwfrseebaulTqinrxaxK4WajIVmrYYnCvSGpzDhU0A8PoTP930ppSHMoKgIDxGbJujvF9Qw+19ovfHMg8hN3qIT7BAereA3Pb0CyRKJnB1gnsiDnWynAhow+mt3HlqsDjvJuQ6QL9/SUropGW32hrSz2y0Ak6oSSY8RScLwSOY+sbTq/HAeTkPE7E3CW6aT5WHO+VUbC6y28dYKHShfzjQhU uo548Ir3 wP3Xe3CVUu/4l4lSsLEIq+WJut/JCQ1tWIvJaYXVVmtd6H69Uu0kxc0Z6yyxzib8wyEoNtWOrRQy82eus4ljLSzCmj28WEGXMpI9dCwOr89B9Mt5ggCQtEvqsRDFMhfTvGc80X3fAS16GbDEm+aDH4w08lwYlQcwbnZNJSLINxeQ3FQUqqlSwI/YtXg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When the number of alloc anonymous pages exceeds the memory.high, exc_page_fault successfully alloc code pages, and is released by mem_cgroup_handle_over_high before return to user mode. As a result, the program is trapped in a loop to exc page fault and reclaim pages. Here is an example of test code(do_alloc_memory is static compilation): Execution Procedure: mkdir -p /sys/fs/cgroup/memory/memcg_high_A echo 50M > /sys/fs/cgroup/memory/memcg_high_A/memory.high cgexec -g memory:memcg_high_A ./common/do_alloc_memory anon 100M & Phenomenon: [root@localhost memcg_high_A]# cat memory.usage_in_bytes 53903360 The test result shows that the program frequently sync iCache & dcache. As a result, the number of anon pages requested by the program cannot increase. This patch changes the behavior of retry recycling. As long as the number of successfully reclaimed pages is less than the target number of reclaimed pages, memory reclamation exits, indicating that there is no more memory to reclaim directly. Signed-off-by: Ruifeng Su --- mm/memcontrol.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 5b009b233ab8..e6b5d2ddb4d2 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -2561,7 +2561,6 @@ void mem_cgroup_handle_over_high(gfp_t gfp_mask) unsigned long pflags; unsigned long nr_reclaimed; unsigned int nr_pages = current->memcg_nr_pages_over_high; - int nr_retries = MAX_RECLAIM_RETRIES; struct mem_cgroup *memcg; bool in_retry = false; @@ -2616,7 +2615,7 @@ void mem_cgroup_handle_over_high(gfp_t gfp_mask) * memory.high, we want to encourage that rather than doing allocator * throttling. */ - if (nr_reclaimed || nr_retries--) { + if (nr_reclaimed >= (in_retry ? SWAP_CLUSTER_MAX : nr_pages)) { in_retry = true; goto retry_reclaim; } -- 2.33.0