* [linux-next:master 448/11653] drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c:292 dcn35_update_clocks() warn: inconsistent indenting
@ 2023-10-12 21:56 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-10-12 21:56 UTC (permalink / raw)
To: Qingqing Zhuo; +Cc: oe-kbuild-all, Linux Memory Management List, Alex Deucher
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: f9a6bea131849702d591d18d5c8b8a0eda6f62b3
commit: 8774029f76b9806f2f3586bb0502408076767fd5 [448/11653] drm/amd/display: Add DCN35 CLK_MGR
config: i386-randconfig-141-20230905 (https://download.01.org/0day-ci/archive/20231013/202310130514.sHgTzh5P-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231013/202310130514.sHgTzh5P-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310130514.sHgTzh5P-lkp@intel.com/
New smatch warnings:
drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c:292 dcn35_update_clocks() warn: inconsistent indenting
drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c:919 dcn35_clk_mgr_construct() warn: inconsistent indenting
drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c:980 dcn35_clk_mgr_construct() warn: variable dereferenced before check 'ctx->dc_bios' (see line 913)
drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c:980 dcn35_clk_mgr_construct() warn: variable dereferenced before check 'ctx->dc_bios->integrated_info' (see line 913)
Old smatch warnings:
drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c:921 dcn35_clk_mgr_construct() warn: inconsistent indenting
vim +292 drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c
213
214 void dcn35_update_clocks(struct clk_mgr *clk_mgr_base,
215 struct dc_state *context,
216 bool safe_to_lower)
217 {
218 union dmub_rb_cmd cmd;
219 struct clk_mgr_internal *clk_mgr = TO_CLK_MGR_INTERNAL(clk_mgr_base);
220 struct dc_clocks *new_clocks = &context->bw_ctx.bw.dcn.clk;
221 struct dc *dc = clk_mgr_base->ctx->dc;
222 int display_count;
223 bool update_dppclk = false;
224 bool update_dispclk = false;
225 bool dpp_clock_lowered = false;
226
227 if (dc->work_arounds.skip_clock_update)
228 return;
229
230 /*
231 * if it is safe to lower, but we are already in the lower state, we don't have to do anything
232 * also if safe to lower is false, we just go in the higher state
233 */
234 if (safe_to_lower) {
235 if (new_clocks->zstate_support != DCN_ZSTATE_SUPPORT_DISALLOW &&
236 new_clocks->zstate_support != clk_mgr_base->clks.zstate_support) {
237 dcn35_smu_set_zstate_support(clk_mgr, new_clocks->zstate_support);
238 dm_helpers_enable_periodic_detection(clk_mgr_base->ctx, true);
239 clk_mgr_base->clks.zstate_support = new_clocks->zstate_support;
240 }
241
242 if (clk_mgr_base->clks.dtbclk_en && !new_clocks->dtbclk_en) {
243 dcn35_smu_set_dtbclk(clk_mgr, false);
244 clk_mgr_base->clks.dtbclk_en = new_clocks->dtbclk_en;
245 }
246 /* check that we're not already in lower */
247 if (clk_mgr_base->clks.pwr_state != DCN_PWR_STATE_LOW_POWER) {
248 display_count = dcn35_get_active_display_cnt_wa(dc, context);
249 /* if we can go lower, go lower */
250 if (display_count == 0)
251 clk_mgr_base->clks.pwr_state = DCN_PWR_STATE_LOW_POWER;
252 }
253 } else {
254 if (new_clocks->zstate_support == DCN_ZSTATE_SUPPORT_DISALLOW &&
255 new_clocks->zstate_support != clk_mgr_base->clks.zstate_support) {
256 dcn35_smu_set_zstate_support(clk_mgr, DCN_ZSTATE_SUPPORT_DISALLOW);
257 dm_helpers_enable_periodic_detection(clk_mgr_base->ctx, false);
258 clk_mgr_base->clks.zstate_support = new_clocks->zstate_support;
259 }
260
261 if (!clk_mgr_base->clks.dtbclk_en && new_clocks->dtbclk_en) {
262 dcn35_smu_set_dtbclk(clk_mgr, true);
263 dcn35_update_clocks_update_dtb_dto(clk_mgr, context, clk_mgr_base->clks.ref_dtbclk_khz);
264 clk_mgr_base->clks.dtbclk_en = new_clocks->dtbclk_en;
265 }
266
267 /* check that we're not already in D0 */
268 if (clk_mgr_base->clks.pwr_state != DCN_PWR_STATE_MISSION_MODE) {
269 union display_idle_optimization_u idle_info = { 0 };
270
271 dcn35_smu_set_display_idle_optimization(clk_mgr, idle_info.data);
272 /* update power state */
273 clk_mgr_base->clks.pwr_state = DCN_PWR_STATE_MISSION_MODE;
274 }
275 }
276 if (dc->debug.force_min_dcfclk_mhz > 0)
277 new_clocks->dcfclk_khz = (new_clocks->dcfclk_khz > (dc->debug.force_min_dcfclk_mhz * 1000)) ?
278 new_clocks->dcfclk_khz : (dc->debug.force_min_dcfclk_mhz * 1000);
279
280 if (should_set_clock(safe_to_lower, new_clocks->dcfclk_khz, clk_mgr_base->clks.dcfclk_khz)) {
281 clk_mgr_base->clks.dcfclk_khz = new_clocks->dcfclk_khz;
282 dcn35_smu_set_hard_min_dcfclk(clk_mgr, clk_mgr_base->clks.dcfclk_khz);
283 }
284
285 if (should_set_clock(safe_to_lower,
286 new_clocks->dcfclk_deep_sleep_khz, clk_mgr_base->clks.dcfclk_deep_sleep_khz)) {
287 clk_mgr_base->clks.dcfclk_deep_sleep_khz = new_clocks->dcfclk_deep_sleep_khz;
288 dcn35_smu_set_min_deep_sleep_dcfclk(clk_mgr, clk_mgr_base->clks.dcfclk_deep_sleep_khz);
289 }
290
291 // workaround: Limit dppclk to 100Mhz to avoid lower eDP panel switch to plus 4K monitor underflow.
> 292 if (new_clocks->dppclk_khz < 100000)
293 new_clocks->dppclk_khz = 100000;
294
295 if (should_set_clock(safe_to_lower, new_clocks->dppclk_khz, clk_mgr->base.clks.dppclk_khz)) {
296 if (clk_mgr->base.clks.dppclk_khz > new_clocks->dppclk_khz)
297 dpp_clock_lowered = true;
298 clk_mgr_base->clks.dppclk_khz = new_clocks->dppclk_khz;
299 update_dppclk = true;
300 }
301
302 if (should_set_clock(safe_to_lower, new_clocks->dispclk_khz, clk_mgr_base->clks.dispclk_khz)) {
303 dcn35_disable_otg_wa(clk_mgr_base, context, true);
304
305 clk_mgr_base->clks.dispclk_khz = new_clocks->dispclk_khz;
306 dcn35_smu_set_dispclk(clk_mgr, clk_mgr_base->clks.dispclk_khz);
307 dcn35_disable_otg_wa(clk_mgr_base, context, false);
308
309 update_dispclk = true;
310 }
311
312 if (!new_clocks->dtbclk_en) {
313 new_clocks->ref_dtbclk_khz = 600000;
314 }
315
316 /* clock limits are received with MHz precision, divide by 1000 to prevent setting clocks at every call */
317 if (!dc->debug.disable_dtb_ref_clk_switch &&
318 should_set_clock(safe_to_lower, new_clocks->ref_dtbclk_khz / 1000, clk_mgr_base->clks.ref_dtbclk_khz / 1000)) {
319 /* DCCG requires KHz precision for DTBCLK */
320 dcn35_smu_set_dtbclk(clk_mgr, true);
321
322 dcn35_update_clocks_update_dtb_dto(clk_mgr, context, clk_mgr_base->clks.ref_dtbclk_khz);
323 }
324
325 if (dpp_clock_lowered) {
326 // increase per DPP DTO before lowering global dppclk
327 dcn35_update_clocks_update_dpp_dto(clk_mgr, context, safe_to_lower);
328 dcn35_smu_set_dppclk(clk_mgr, clk_mgr_base->clks.dppclk_khz);
329 } else {
330 // increase global DPPCLK before lowering per DPP DTO
331 if (update_dppclk || update_dispclk)
332 dcn35_smu_set_dppclk(clk_mgr, clk_mgr_base->clks.dppclk_khz);
333 dcn35_update_clocks_update_dpp_dto(clk_mgr, context, safe_to_lower);
334 }
335
336 // notify DMCUB of latest clocks
337 memset(&cmd, 0, sizeof(cmd));
338 cmd.notify_clocks.header.type = DMUB_CMD__CLK_MGR;
339 cmd.notify_clocks.header.sub_type = DMUB_CMD__CLK_MGR_NOTIFY_CLOCKS;
340 cmd.notify_clocks.clocks.dcfclk_khz = clk_mgr_base->clks.dcfclk_khz;
341 cmd.notify_clocks.clocks.dcfclk_deep_sleep_khz =
342 clk_mgr_base->clks.dcfclk_deep_sleep_khz;
343 cmd.notify_clocks.clocks.dispclk_khz = clk_mgr_base->clks.dispclk_khz;
344 cmd.notify_clocks.clocks.dppclk_khz = clk_mgr_base->clks.dppclk_khz;
345
346 dm_execute_dmub_cmd(dc->ctx, &cmd, DM_DMUB_WAIT_TYPE_WAIT);
347 }
348
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-10-12 21:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-12 21:56 [linux-next:master 448/11653] drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c:292 dcn35_update_clocks() warn: inconsistent indenting kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox