From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C7B3CDB47E for ; Fri, 13 Oct 2023 09:58:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 19C938D0161; Fri, 13 Oct 2023 05:58:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 120D08D0015; Fri, 13 Oct 2023 05:58:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB6028D0161; Fri, 13 Oct 2023 05:58:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D78A18D0015 for ; Fri, 13 Oct 2023 05:58:20 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A48101A017B for ; Fri, 13 Oct 2023 09:58:20 +0000 (UTC) X-FDA: 81339987960.26.4547EC8 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf09.hostedemail.com (Postfix) with ESMTP id C2704140008 for ; Fri, 13 Oct 2023 09:58:17 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=ventanamicro.com header.s=google header.b=Pwy3ML29; dmarc=none; spf=pass (imf09.hostedemail.com: domain of ajones@ventanamicro.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=ajones@ventanamicro.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697191097; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nlysa/0HAt7XwTL7Sd4FpaqX2JsJYLCn7DORbQofqo8=; b=7j4qBjkEdtX0kwyNJmcMQ56n1qE2baBnN95t3Cvkud5oSn2Uuz9YShgqfzS2mA9aKW+OSo MSfwYm07EQVWaXltXRX986CsyWb+mFGGQaQQw6W6TzVJJqBrahtVHvR1BffqG9TRXhTJDu +H/yVTcA/WLpnQo4G2ef1sN6GHff+g4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=ventanamicro.com header.s=google header.b=Pwy3ML29; dmarc=none; spf=pass (imf09.hostedemail.com: domain of ajones@ventanamicro.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=ajones@ventanamicro.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697191097; a=rsa-sha256; cv=none; b=qMVrVA8LELOJEfP3OkBb11CMoQfxs7jNdLi58HrPXGPmnq88kRsM2BVl9F3uxPs93R0r/g DRIeC0ErsN+aAU1rOrx7xNIRiNgeZd7rHWL8Ahn6OdfyT5oH+tcJxvn9BtgF8dBodl+rvE aKn7fXOp8IWCp8qbMdiPS+ea0mdQcD4= Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-53df747cfe5so3533240a12.2 for ; Fri, 13 Oct 2023 02:58:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1697191096; x=1697795896; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nlysa/0HAt7XwTL7Sd4FpaqX2JsJYLCn7DORbQofqo8=; b=Pwy3ML295gOBeNx/mJRwt6eqiC6EhzAVbGngAxllJE3PV2bn1kGZFXUQ3a73JWIFBy X30P8Zl5Ed6Je5UwTUXDmFK0FSAfAakac2yTl30enbFsH03a3T/N40n9TX3A2xzXo38e 2HxZUvC0lN/Eba2y0SanSoCIyaXyRBRYty90lkwv8udBniN+5I/RkSky0vgb04/oFDkc 3mTIE36vzHmud+7i/SxpZm6b2h1DkRpkvx1v/gN7UUTPZ6VGuoLK3Vh3IMmhG5wRLUKq rnmkXZBN+B2Z04LOBSU/mSUn+QL2OT2Zh94YIDF+dpAelNrM2bgrsn6Q6DnzL312bCxr R2sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697191096; x=1697795896; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nlysa/0HAt7XwTL7Sd4FpaqX2JsJYLCn7DORbQofqo8=; b=hiqp/8w8c3z5BdWYo7PpFhUrW9F/TOVl8TVcEXMvQdH2SbW8UtkJpFk+k5ZuRMHoaj On+mvlfjCnc0/sNw8+MRcTCEl6MfFXa7mkWMzcKMn+3hGZhN/On556+vSJfQILsjhD+z gKzoKd1OHjHk4H/hZzOH/uNy5f7UcVVzmyDDfUKrmjnEXBnDe6rGwKb3IUZykqp4ZJ9F CXmx5lMrV89KIyDCBoMJaUipI9dQwIFNzIqtb2SJ35aBCidA52qWLgX7/LC/ucja061T MIdA69OwN8BudX6U2DeYKZwl09OqKDYPqHS/vthV5mfWNCDbEWUb4b8yKTC3VxrT7pJR +Y7A== X-Gm-Message-State: AOJu0YwH/c4Xark3vXlKtGUTjtzRH0iqf0LybwfHkkT5M2kMm4vqrL91 xYN5efpBDx6gMv1GgcGyyIGoVw== X-Google-Smtp-Source: AGHT+IEguRhdGJwf0aIebN3fBCeHhRTYBl34+o54X7nhqZBgpclVfefxrGnH7qQH1m05Yq6L5Ya53A== X-Received: by 2002:aa7:c998:0:b0:530:a226:1f25 with SMTP id c24-20020aa7c998000000b00530a2261f25mr21443281edt.17.1697191096257; Fri, 13 Oct 2023 02:58:16 -0700 (PDT) Received: from localhost (cst2-173-16.cust.vodafone.cz. [31.30.173.16]) by smtp.gmail.com with ESMTPSA id u19-20020a50d513000000b0053e408aec8bsm650498edi.6.2023.10.13.02.58.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 02:58:15 -0700 (PDT) Date: Fri, 13 Oct 2023 11:58:14 +0200 From: Andrew Jones To: Conor Dooley Cc: Alexandre Ghiti , Ryan Roberts , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Paul Walmsley , Palmer Dabbelt , Albert Ou , Anup Patel , Atish Patra , Ard Biesheuvel , Andrey Ryabinin , Andrey Konovalov , Vincenzo Frascino , kasan-dev@googlegroups.com, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-efi@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 4/5] riscv: Suffix all page table entry pointers with 'p' Message-ID: <20231013-19d487ddc6b6efd6d6f62f88@orel> References: <20231002151031.110551-1-alexghiti@rivosinc.com> <20231002151031.110551-5-alexghiti@rivosinc.com> <20231012-envision-grooving-e6e0461099f1@spud> <20231012-exclusion-moaner-d26780f9eb00@spud> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231012-exclusion-moaner-d26780f9eb00@spud> X-Rspamd-Queue-Id: C2704140008 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: z7shm6ocipzmsgoo7on36zjw8398ybif X-HE-Tag: 1697191097-353785 X-HE-Meta: U2FsdGVkX1/c0dC3g+GnZgaorbTaiL/i+ZqAnMpOVhmhCehJEPz5+eTp+1dJG4ge+fFJyUd3pQ1brrVORahbfq1NPa1SMzVK2Wx4Av7jtZlBh1qTRwPp+IEEOyr0oSM59kAMFo+pBqeujM0NN9POVcrtVlNTXPEWzuhaaFbHjiFez2D1WIxxny+i1hSPPEssHd/fiq+LfC7SDzd/dO3fR954KXJ5iKqN8j4XZcZw4zkf4YwT6IwVSmEysMF9EckwKQQGor4R+FTyDlA6HI6DGOKkeuLKEEACnimXDzUP9OMegruE5C+UJXr5mwC4X2uItpb5/fuOOemJUy+Zxh26vs2l/hdrnYLrQ8TPVMS9SG3FMQrhv30EI/J6X4xGS/o7k9IC0mnf9jtg2dAoUyUWLwSS1WJ19k6zfVUYPYXFHR+5VZcJKyvfoyCLChHYMCfFmXnPevkmWFm0p0uLSGfR4SyGis3OpPCf4bkkfQhmWL54PuQm6PuIuyydVTTjm6soQJKjOn5fMgtCckR4F7TVZ+ZEpr27vvic6NDiTLyJRzfyp+Ghyep8Tb77neYC14jqW8qh/U2YoN5KUEAK6dSRn86uGsBZsfyHVi729ICcJpMy7IQPmmQYObJXBW5QAgp31SolLBFUl3JGCSbnd9Bl+4kXdlfxl/jBH1qGKNhzdKbzoUP6GTS9PoEOogU6a1uxYb3AYmBev0++KCHQbYv3Ky+lMauSpungmOOaVPmEX4+d7U/oVhKUJlq+L+KLut8r+st5DWJG/m9gk85hw4sTtZKn+z2XNeohxdLdlhi30FIFgnCmiOsnasC/Kbro9urg49uG6OFflja+yO25CN5gZ7QIBU5LtndJ65H+wjCkgz5denLXGzpkiR1WIjyAjO22TCF80NS4JyTEqnWqN72GHbVKH0vQ5G2xoLkQlrkiFZS7BWwq2z0VatT7D9fJWjwdKJ+c3PkQNWtqo9tpRqj OngGtfQ0 WtXGZJ7IpdyeTiIn1Q+jFkxODDUyCetcrgVAVh/YqXbPrhsWX4Z8O9rZRHgiK6Wfh+RP/ygtXgEIAkle46lnuX79PXoomoBAXNSi1ecE4ylHR8fVWTkFrKbyR3NavVSwm9xdUpZsEGtk1rofHOoZO02iNo0Xk8So10ux/G0RQtB3D8Ap5qBtDjdBQXrTYuObfbZpR3xBOULRyBmdied4nd6DseLNJ+ooMaKL+7YFq7eb55qmAqYwSAG+7ipZwSGdgS2bQS9Vor9FdyBMVLbOjqZFbhV2VQycXTM3mCx6o6w2icE1MN6iVumXHk8WtUvHCqSMAiHJBbwiGSYTjzbDXlh8W3J4rtIexNnpms8LEu5JB9LxDEBiIjBHHAatpqFFKCvm9EZk93XZejtC4hYRWW6hvzrx8+ZbJkGD9wkoIHy2nI7w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000356, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 12, 2023 at 12:35:00PM +0100, Conor Dooley wrote: > On Thu, Oct 12, 2023 at 12:33:15PM +0100, Conor Dooley wrote: > > Hey Alex, > > > > On Mon, Oct 02, 2023 at 05:10:30PM +0200, Alexandre Ghiti wrote: > > > That makes it more clear what the underlying type is, no functional > > > changes intended. > > > > Scanning through stuff on patchwork, this really doesn't seem worth the > > churn. I thought this sort of Hungarian notation-esque stuff was a > > relic of a time before I could read & our docs even go as far as to > > s/go/went/, I see the language got changed in more recent releases of > the kernel! The documentation seems to still be against it, but, despite that and the two very valid points raised by Marco (backporting and git-blame), I think ptep is special and I'm mostly in favor of this change. We may not need to s/r every instance, but certainly functions which need to refer to both the pte and the ptep representations of entries becomes more clear when using the 'p' convention (and then it's nice to have ptep used everywhere else too for consistency...) Anyway, just my 2 cents. Thanks, drew