From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E9F8CDB46E for ; Thu, 12 Oct 2023 19:48:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E9228D014E; Thu, 12 Oct 2023 15:48:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 997A98D0002; Thu, 12 Oct 2023 15:48:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 811A78D014E; Thu, 12 Oct 2023 15:48:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 69C6D8D0002 for ; Thu, 12 Oct 2023 15:48:46 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2CF491CB15C for ; Thu, 12 Oct 2023 19:48:46 +0000 (UTC) X-FDA: 81337847052.10.A95D2C4 Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by imf21.hostedemail.com (Postfix) with ESMTP id 6666A1C0020 for ; Thu, 12 Oct 2023 19:48:44 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ngspxoQI; spf=pass (imf21.hostedemail.com: domain of jim.cromie@gmail.com designates 209.85.166.42 as permitted sender) smtp.mailfrom=jim.cromie@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697140124; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mIhMRd3PEDx8wYJmsgE6KV38zHdcvoV+qxdam6F9QaA=; b=UpqcIIcdSxMgX8G11rd+Jh9dcLYCkuVJCA/ZvN5rTZsZ8ealhXLNECaCuUT1lwywJcg5nY aC1OLeWwm2xO24T9u0/CN1m52XDjHKeit1IFh0DxgoNPj67lS1keuRWx1E/CCYHxyr7+4C /wcksdIQxitC/CSlobyUhinzpPPzITM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697140124; a=rsa-sha256; cv=none; b=ZTMU5iKOLNTXO0FWK22GQATmS61bbH6CdHcRmzhKKncr8Nc5tHoJjKU/WWsK6Fcu458c5s k8KDSEyDZAudYLfwcleVNrEPkpETiqwSlC6yQ2VsR+68MR8AX22JnnF09HLjuF0DIRoOeh PB8eoDFXWMql5U+dUjN5FTO2xXWTPU8= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ngspxoQI; spf=pass (imf21.hostedemail.com: domain of jim.cromie@gmail.com designates 209.85.166.42 as permitted sender) smtp.mailfrom=jim.cromie@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-io1-f42.google.com with SMTP id ca18e2360f4ac-7a5a746e355so34118639f.0 for ; Thu, 12 Oct 2023 12:48:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697140123; x=1697744923; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mIhMRd3PEDx8wYJmsgE6KV38zHdcvoV+qxdam6F9QaA=; b=ngspxoQIzI2tx9TmzyeKMszUzFiCyu8Eox0+hbIBIOTm+buRmcLzgJqTcvXCeOGvCW 2QF3U5ZpmuSnjV2xX9OO2kARp/sMyJ8/qwjCiNFObCkCIYFIE0lYBrxsIdwgo/3de9cN SukjRN1oqBdvF1Sr/UF+9wbrxTX4ZwK0KdUwkrRpEfxYF1djkC8w0mHaDlqlP2EM1+2B 1ywVmQtiQW+XZl/ShLoR0RslXUWjdMbwi221yaz8WdtA+MR48tiR77q7IdyLVwnqWhNc G/eABrlVdqNFRdvU0an9j7IDlMfW0ijqbxdatufNtQY+njxLuQ2u6hU1MnE1EG82J/PK rGQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697140123; x=1697744923; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mIhMRd3PEDx8wYJmsgE6KV38zHdcvoV+qxdam6F9QaA=; b=TlKh5rvzlEt5WaC/9kav4I7mWlW/5oS1gZMLz9lhMzKGySS7pSu8aR4k3TapEsthf/ InXZW/mt5VBCva2PfuV1ya2Aq36x+OHhRLWgLJrCkP+HJ9qaHVbWA1J3Qh27iRm481RV EeToJZrbZOwE/9PN0EyNgFQC3KQHsz3s55Egq+CnWzdfoNcYfOlxG7gIB9zNMlwD48Bu ktySdOcXsoYh4kS9Kqs90Gwtbv+6abVZlC6MOFn0eBugpHKLxaEPuHFtJeK9DDaJ1/KA 6P8bvxFbDeo/sJL40isom3GPzIk9NhjJqDs6tLF6gg9yhbcGfC9p1TedbexUVL7up4jO 0T0Q== X-Gm-Message-State: AOJu0Yw/GPP8k3b41kaXkjAdq7PITPVtegwrKLM43ipSLfavVJIQTmVh ia7+87SVPxOG5bxUyz8yVIg= X-Google-Smtp-Source: AGHT+IHqH6cUbDs8xrXZJT4gDhu6yQsXMA72pQaQVz1Yklqvjqho03n48wy4VfixJtREREl3H41tPA== X-Received: by 2002:a05:6602:2014:b0:791:8f62:31ef with SMTP id y20-20020a056602201400b007918f6231efmr17972840iod.5.1697140123589; Thu, 12 Oct 2023 12:48:43 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id h6-20020a5d9e06000000b007a25540c49bsm4307891ioh.27.2023.10.12.12.48.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Oct 2023 12:48:43 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, jbaron@akamai.com, gregkh@linuxfoundation.org Cc: david@redhat.com, lb@semihalf.com, linux@rasmusvillemoes.dk, joe@perches.com, mcgrof@kernel.org, Liam.Howlett@Oracle.com, linux-mm@kvack.org, Jim Cromie Subject: [RFC PATCH 07/10] dyndbg: wire in __desc_*() functions Date: Thu, 12 Oct 2023 13:48:31 -0600 Message-ID: <20231012194834.3288085-8-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231012194834.3288085-1-jim.cromie@gmail.com> References: <20231012194834.3288085-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: tk7t1xkmc1bo9qfyfyft1r5coathfizz X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 6666A1C0020 X-Rspam-User: X-HE-Tag: 1697140124-77680 X-HE-Meta: U2FsdGVkX18yRLNaJGiiEK6JDSWvW+b1p68dsKNEJKPtbvpZIjSPG8Nfgx8Z+Q/yyBnjm4RC4C0j1wOjLoen5WNlixkTDGxkQ6FL3dv4/OZQkxHSyfSKi0YoOoomhshg7b/b4bEjL+/dp4G6lArh+zyviA0Lub1jydc4Ercrfs0qTUi1P6IDZhFV4KeYogPiZ4PUXMxglIK6lKB1f2q/aVt+fc44IIem5V6d2QsTVnWz7LPQxAvJn2VemIwiKwH/eUQTDaTcCfvaq3ffXmGKBdb+IDtoGcCaMeg2Qz8XAcMq7xkj6e0o8TRuTQTdgyjVDcXhSSomPaIvdoFlbff4FkXdagKJ7iyMnYVdXcf/kNPCmIyROD3Lp9CdW8yyF/a2g5RUBtZC7BWa4VSPt91y5tx5oRLEc4LLEgDyWM7MU9ou2UCyck3LwZ9HXeUNukxuMyZGDboB/Sed0uwfkoKKtY3krJWfOc0osVMBSVkQk/lpMCRdogkG5txS1tnIqR2vKKQHJ9ppfRVwNoust/v/NWZZzFhFffHfchRuMJz0ffthZOcbgE2d7drnguAr+mXB0R/DdGUNoyYnwU3agC5IAYgiQMqgJV7rbckdLnZzOindSjS1SNcUPyAYpHVtJwPRtZdpKsNjyzMRE3pglLxpMGlP+RJIotqmGNw99iue0NBnABYAIU44rj3k0iYRjWnTZvIS+99BQ9O5E+FUmIuEKVhNs4WY1qIPpBOxm2suP7XakakyK93oaMPQ6AwqsEZaWBrHaU864J00DXBAUil+/X3HLVMNyD/74B8i8vc3ABI13Ssg8/mK8lI72vFrUE9x67TFKCwCQfcN8J5SazwNwX+tRM2MTYMpKNfIQ0eVcM5IoJdm1+bG2d6IIiN0EvlA33G6LEILky6O9L1yaOGo6Ibm2olznPUJdnxNA1aBuprY5o5ZiwnIA/ZPAEzjsjwSHahpFoW/TE+e/dhVXzI 7zJKedx2 YO6OzHaQAof/Cnxmgn7iR5uFdrFhKWGseY1Gejmlxf/9uZgVIOxaCSPrQtaWlfIUTIdyDRdOHXClO9WVeFwNTGwP9zht2kArNpL7vV9okEd13Ot4Stna4OO/y3bJe5Ss4tAkkGSIOFDAUKq7wNbMpRkCXl+78ZqDDuORb3tT0F5tF0EKk3e6tqwgHe/3chOoMUmpDggiBw3Y+2ezg+DkH39D3YcAsWItEGGKIDp5xxkUsC9V5/XbjRwplQZQADPk/csrE6stBvkJyQF9AxpJ8/b3XPZsbjCgq+6ezkU3mWqQl+h7m1v4KlXsTh7md0//KQi8R39UDT8H0mft8nUs1sReQe4fun/5SuZpOYbPN3wFkzZgagorF0HhRRkJpQ4XjZGAW7i23E5W3vwxHeDUnO+Yyf33Hehjo+Kep0BPSeuq4X7MoG+VH+zSzisF8U1114P3nKIyJYFQDtokakNTog9K/TTp8G+rJcYibxCIhQ2Jvko5vePuCIBRZZBLtI7M+2evCMyyDwdngsx0Cfu8+V99onhyAVZacp435M9BU6NRjcYDfgrie4jjndCx8kMprGx9gNzDaRjjVpaT1SI2iS1+Z8A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: change desc_*() macros to call __desc_*() functions, and #if 0 the comparisons to the site->_* ref. This makes the _ddebug.site pointer unneccesary. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 48564625a37e..fb72a7b05b01 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -223,9 +223,9 @@ static struct ddebug_class_map *ddebug_find_valid_class(struct ddebug_table cons return NULL; } -#define desc_modname(d) (d)->site->_modname -#define desc_filename(d) (d)->site->_filename -#define desc_function(d) (d)->site->_function +#define desc_modname(d) __desc_modname(d) +#define desc_filename(d) __desc_filename(d) +#define desc_function(d) __desc_function(d) /* * tmp accessors, they cheat and seek a match in builtins. Obviously * this wont work for loaded modules, but doesnt work at all yet. @@ -235,11 +235,11 @@ static const char * __desc_function(struct _ddebug const *dp) struct maple_tree *mt = &mt_funcs; void *ret = mtree_load(mt, (unsigned long)dp); - +#if 0 if (ret != desc_function(dp)) pr_err("mt-load func %lx got %s want %s\n", (unsigned long)dp, (char*)ret, desc_function(dp)); - +#endif return ret; } @@ -248,11 +248,11 @@ static const char * __desc_filename(struct _ddebug const *dp) struct maple_tree *mt = &mt_files; void *ret = mtree_load(mt, (unsigned long)dp); - +#if 0 if (ret != desc_filename(dp)) pr_err("mt-load file %lx got %s want %s\n", (unsigned long)dp, (char*)ret, desc_filename(dp)); - +#endif return ret; } @@ -261,11 +261,11 @@ static const char * __desc_modname(struct _ddebug const *dp) struct maple_tree *mt = &mt_mods; void *ret = mtree_load(mt, (unsigned long)dp); - +#if 0 if (ret != desc_modname(dp)) pr_err("mt-load mod %lx got %s want %s\n", (unsigned long)dp, (char*)ret, desc_modname(dp)); - +#endif return ret; } @@ -1441,7 +1441,7 @@ static void ddebug_condense_sites(struct _ddebug_info *di) i = 0; for (; i < di->num_descs; i++, cur_dd++, cur_ds++) { - BUG_ON(site_function(cur_ds) != desc_function(cur_dd)); + //BUG_ON(site_function(cur_ds) != desc_function(cur_dd)); if (!strcmp(site_function(cur_ds), site_function(func_ds))) continue; -- 2.41.0