From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0C89CDB46E for ; Thu, 12 Oct 2023 19:47:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79FA68D0143; Thu, 12 Oct 2023 15:47:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 74E4F8D0002; Thu, 12 Oct 2023 15:47:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5797A8D0143; Thu, 12 Oct 2023 15:47:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 42C558D0002 for ; Thu, 12 Oct 2023 15:47:31 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 28CDA140892 for ; Thu, 12 Oct 2023 19:47:31 +0000 (UTC) X-FDA: 81337843902.11.42A25B8 Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) by imf14.hostedemail.com (Postfix) with ESMTP id 5658E100024 for ; Thu, 12 Oct 2023 19:47:29 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EvsrfG5g; spf=pass (imf14.hostedemail.com: domain of jim.cromie@gmail.com designates 209.85.166.51 as permitted sender) smtp.mailfrom=jim.cromie@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697140049; a=rsa-sha256; cv=none; b=oITqI+WYxlUKVwdUrx1Ie/NDxfJJK8c8P6L1VDqYdIz9LzsjScyH0KQewovrSAwNd8NPIm S9ZcpHDhpykzDHJ7JADnaSLB6gWD5qqHx465XXUFC6EoQf4KL1I9b1ZWlpoROPgcPubGEy arJCazVfwlpFmolIZBIoQNaZZahq7eg= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EvsrfG5g; spf=pass (imf14.hostedemail.com: domain of jim.cromie@gmail.com designates 209.85.166.51 as permitted sender) smtp.mailfrom=jim.cromie@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697140049; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mIhMRd3PEDx8wYJmsgE6KV38zHdcvoV+qxdam6F9QaA=; b=1GeBCu7kfpGoA5XYj2p2/wSjugtC+8oMrb96wBK8P79g/zxhoz01XW3XcGxJ1DL+NCundC 6Z/mrQL++eKBNK8JTY/cUS8RSDDdzthgY8M685VElHNjdGjKAMW0qEDzoKpSsBQo7bITTr giYXijqAYkZxvh/zpvOE8BQ4VzV/tTU= Received: by mail-io1-f51.google.com with SMTP id ca18e2360f4ac-79fa416b7ffso55132339f.2 for ; Thu, 12 Oct 2023 12:47:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697140048; x=1697744848; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mIhMRd3PEDx8wYJmsgE6KV38zHdcvoV+qxdam6F9QaA=; b=EvsrfG5gUesubdMd0dx13OFtij6WVBj1MnWTQ2sur+q0HbCu95sIFGVExOoyuF0Yu3 zRwfnTi5rF024Yaryf2d2jlnYgz5GN0wwWa8sbgfuDtX+0Aop3sMIkE7Pot12nqbqw1M vpLu3UmU2vr/6cUjaN/bnLKAJSePCA+ofqEDGKzFx5OblLT11BGdxxiS3E/EHKiC1PBO 9DGpHNHsHv4FLSZzRz+3wTTWmAgQn0J96razfd9Fcy/72YFh7dN89IpxAOESAiHc1Ji4 EvaXIkoQY6sAaEjjz4/pY31QibYUJHjkUctm1gBIrxPh2M28x0fomGWZQEOs+9aGS+Wp HHSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697140048; x=1697744848; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mIhMRd3PEDx8wYJmsgE6KV38zHdcvoV+qxdam6F9QaA=; b=OTdGFOJ8smQ9/EXHARpXAJqoNRtXMaezyIjqW/gQ46XWj6gg0JGae6zMmAPEOl3gJk rKRbM/Si7cksByz8qUjkmUZkJurc6HVq0Y0eI2GdqqCT13whJ74pP7j8cPXDQBkey0h0 osa4zlBbQ54T17Aqg4R9jdjSEswpbcHHh1hib/kGRMaBBiodNj5LZgMvYjOPSo3pFZHv +Jgu0+742eehjwkjIYtqy9yrXV/Ew/iMlNe1TJPvrJ4romOHMupXNXPaPyvW7oTXXx94 nmxQpE+8wMk/SrkX2Cbkgm0ji1GJRfGj1SI0nV/DtMsrH96qCe1rxFUvZDFleycIQx3h Thiw== X-Gm-Message-State: AOJu0YwGfvEj8Wol0JSzI9SYaj23xKCwgNxLS4z2CgRN9pHtjeuNwAMW w01wStTeJpj/BkBhjIrdqvg= X-Google-Smtp-Source: AGHT+IHwXqweWhb1lxAAh/8nmrZo53I7KZ+f3cHS+05xFDAlJj11wM8cG2c9g1NHaGlPQ1kNha+MpQ== X-Received: by 2002:a5e:de4a:0:b0:794:eb37:b0c4 with SMTP id e10-20020a5ede4a000000b00794eb37b0c4mr24029604ioq.21.1697140048511; Thu, 12 Oct 2023 12:47:28 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id z7-20020a5ec907000000b0079fbb834232sm4351002iol.19.2023.10.12.12.47.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Oct 2023 12:47:27 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org Cc: david@redhat.com, Liam.Howlett@Oracle.com, linux-mm@kvack.org, Jim Cromie Subject: [RFC PATCH 07/10] dyndbg: wire in __desc_*() functions Date: Thu, 12 Oct 2023 13:47:08 -0600 Message-ID: <20231012194711.3288031-8-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231012194711.3288031-1-jim.cromie@gmail.com> References: <20231012194711.3288031-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 5658E100024 X-Stat-Signature: tk7t1xkmc1bo9qfyfyft1r5coathfizz X-Rspam-User: X-HE-Tag: 1697140049-714675 X-HE-Meta: U2FsdGVkX1//pDnbk1X9zo+Iz2fbOEShUZ8Zf/W82KvQxg8F8+Ghtff/WdQn3IcImISTIeCA3eWxEtPyqx4xKsCizsuGL6p64UHpfW9Lh5iFkALGdB5wa2CVIUa1sGNzqTB75ekjqybQtj71KMwn3oPAaYBSbuaVJuaEfJRuounXWdyflvT3uTUfhnjTBdqLRE2PBYNg5OjQe296TO4DtXZMjovK9qeBmZqFmZJ89BVnXG1+0750o4Dus2ZbXr0DSs0GlLnakLrzuhOGXkyLiBTpH7CAuSG9fpR95W2YJzOIaW8qknOeqKwBF/oIWnRAmdFcEjnsvigj4VUUjPOeJpzPwmEFwnCMYSgasfO9++bM3oaWxiIQ7HLllaVhAK1P/sS5mRTyXk+9WE/p5ulNMpVxkJ8gzfAFMEAIe7M5JgTX7ZUIUNyIF6a5Bv5cNKZP/4hxQTSlkmuAA64s7dP/N3DVgM6vYC0xNiN8b2IewOCD72Y1IQiHIsY+XWROJHZ3Nk0OE9kioemhO6n6FBDmE2eJAwMzVFQtA0SP7cBJ0BhRHLTEG8lh/0oE5Lnv8rvE9xH6HOwQQ/vKlWwr1ZtmAngxjH3acmUAV3KxfN7Mgefdav3mLPqI2rPqbhR1byJiuogz7SmyWaB7Tnwxgefl1sHDdr6FxiUYxRCOTEhBsfa2u8CYlXps7shgMZfxxna8nnBlIqEQZM4aACOznMVnWDvoJPT+ydHH862e1hAH/o13Nb5tr6oDlij26botx/7t4rFWo8iPI87i8yQBGeGeUjc0/bZH+xornQBWTqSGRAPahM649XYepgW0UFx+y/BrysoZsTX0HmKXJ0opLrCXzcSjjzuNSq33K7pd+F8vArZ4nwGFy3iqOsZL5v2/g6tVp/fihW4WTfS1ORON6zOZf+9ITUAE0ePUiWWj48s6MFz2GSWMge3w3RHLy0q63FJ55Cx6gtn4W76Ub0jtgc/ v1KQ3fgc bJyisDIWgP0vv5YiTtn15IfNt+gxW2H8X2FDy0bQIzdRcCsvW/+x9BtO2IR8uvmnYoW1OaPiWTqVAYtWmgd/kfJ/wZpau5BcbkljlV2QOmjDbuqy0SBubB/TnFP0Uy+OmZ5PVkrC4YZ5Uvs8AfnatKRHAN+YI1zBUxLld15RuT5NBQw988TDLr6vMwfc8gbbDakVv/XIlaH5DTmc+6q0DnMySd8WND0ySOi1BX/ybwa0lb8p1tI5G4aG6Yx/9bW/tt57/AIdmzxNv3FwCQLNIMolxO8niVHZcpcamCQrbROlZZc9IFyuatVxbdunoXRN+cOVgYGEiuoMsBpCQI7S/33yrcCtuwNYGLnVkCKpnXcUpMoF97pBEfzYmB1ZanN7XEpuxDCIxOAtDr/G6ExUJrT8iRHa+KBiD5ODBqU6D5EyZS4ijRPovKeCaMs3JNB6MksbFsHSBQC5Q41dwpyE1dod0XjCDOV9PXh8y41pFfNgmbxa7Z7c1/QoZ5TuqIuy05N0rp4zJcsUCuPjNi4nyuW59IKQidXZdJq2pS6f67L0uG1MASI3bwGfojnoAK6WzZzcyedl1OwS/PihnmbbfW9ZRXQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: change desc_*() macros to call __desc_*() functions, and #if 0 the comparisons to the site->_* ref. This makes the _ddebug.site pointer unneccesary. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 48564625a37e..fb72a7b05b01 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -223,9 +223,9 @@ static struct ddebug_class_map *ddebug_find_valid_class(struct ddebug_table cons return NULL; } -#define desc_modname(d) (d)->site->_modname -#define desc_filename(d) (d)->site->_filename -#define desc_function(d) (d)->site->_function +#define desc_modname(d) __desc_modname(d) +#define desc_filename(d) __desc_filename(d) +#define desc_function(d) __desc_function(d) /* * tmp accessors, they cheat and seek a match in builtins. Obviously * this wont work for loaded modules, but doesnt work at all yet. @@ -235,11 +235,11 @@ static const char * __desc_function(struct _ddebug const *dp) struct maple_tree *mt = &mt_funcs; void *ret = mtree_load(mt, (unsigned long)dp); - +#if 0 if (ret != desc_function(dp)) pr_err("mt-load func %lx got %s want %s\n", (unsigned long)dp, (char*)ret, desc_function(dp)); - +#endif return ret; } @@ -248,11 +248,11 @@ static const char * __desc_filename(struct _ddebug const *dp) struct maple_tree *mt = &mt_files; void *ret = mtree_load(mt, (unsigned long)dp); - +#if 0 if (ret != desc_filename(dp)) pr_err("mt-load file %lx got %s want %s\n", (unsigned long)dp, (char*)ret, desc_filename(dp)); - +#endif return ret; } @@ -261,11 +261,11 @@ static const char * __desc_modname(struct _ddebug const *dp) struct maple_tree *mt = &mt_mods; void *ret = mtree_load(mt, (unsigned long)dp); - +#if 0 if (ret != desc_modname(dp)) pr_err("mt-load mod %lx got %s want %s\n", (unsigned long)dp, (char*)ret, desc_modname(dp)); - +#endif return ret; } @@ -1441,7 +1441,7 @@ static void ddebug_condense_sites(struct _ddebug_info *di) i = 0; for (; i < di->num_descs; i++, cur_dd++, cur_ds++) { - BUG_ON(site_function(cur_ds) != desc_function(cur_dd)); + //BUG_ON(site_function(cur_ds) != desc_function(cur_dd)); if (!strcmp(site_function(cur_ds), site_function(func_ds))) continue; -- 2.41.0