From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC864CDB46E for ; Thu, 12 Oct 2023 09:25:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DF678D011B; Thu, 12 Oct 2023 05:25:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68FD38D0002; Thu, 12 Oct 2023 05:25:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57E148D011B; Thu, 12 Oct 2023 05:25:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 45FA08D0002 for ; Thu, 12 Oct 2023 05:25:48 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 11BD912039E for ; Thu, 12 Oct 2023 09:25:48 +0000 (UTC) X-FDA: 81336277176.21.9C62675 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf09.hostedemail.com (Postfix) with ESMTP id F0C8E14000D for ; Thu, 12 Oct 2023 09:25:45 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BAPRudii; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697102746; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ihAj6Jk24JX9AqNS8iIYiu1eql6lQ+G9XokFrQToB5I=; b=XytSl2x0y77Q2q5aiJpIW7NdEcYl6TAGGqM9VgR2nh8foay5nevpyCFo+1mR71MkYOdL1w TweohaVBI8tNouSmBoAn/Wmg7G/33rtsRZtw0upHXSE0CiRHsviShuQZYRvvmpIFF3Br4R uu6Cgl5svdTiYrwrjraOM44uGvpgxEg= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BAPRudii; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697102746; a=rsa-sha256; cv=none; b=I3XjqrddyVFrPmusOCuv9OiV4qEMIg8HUkM5VEBoV1lNg6FrEqhOXThQ9MqeeboVx4AlDm e4RaW3AtGi5qnClx7e0+hZCiGofMYrCT8h2x/cQFLo69ZaMrR+LQNZLv9GkXfOd6kgoFCN bbJzo7yX38Jg3/fVuhKv0K4LVzTIlco= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5F0A0CE275F; Thu, 12 Oct 2023 09:25:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F961C433C7; Thu, 12 Oct 2023 09:25:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697102741; bh=/ItVD3SvDH45EQ0lyeWLvr5gyjqXDrdu9xT+D7zuRD0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BAPRudiiiP/cOB9GJkTQM72oWaMkY96tenGbcfG8VG+P5GydgmeLerzyu+VpHzIyd 7QZQO9or4iA1AYVMmmI3DjcsDnVbRv+sGblFts3DSkTmQLwEKxgyfWBL3YGc+cB/Cy xeN0w+3qf6eFDDSRBq5Oto96UuEENgyBj5oRlaMTtYzAIopZbziUk8NMR6P+he4Y6Q ekG6rEwI5eAcFRTX8iSKPPPeUGlCeQk+CrnHUEFLXfyOWHxH2NQcAJNoz0l2AYOuV+ 0Tzqq1KpeQQBlgbKdLi0hL11z7EDtBgZXyKjrf9BR7kn+C/QVc80BwxrZQ0iRYO9k9 XOpI2q24LiVxQ== Date: Thu, 12 Oct 2023 12:24:42 +0300 From: Mike Rapoport To: Yajun Deng Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] memblock: don't run loop in memblock_add_range() twice Message-ID: <20231012092442.GR3303@kernel.org> References: <20231003163045.191184-1-yajun.deng@linux.dev> <20231005051959.GC3303@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: F0C8E14000D X-Stat-Signature: d96isf5trtzoyrfg4d461qbso98ebs3x X-HE-Tag: 1697102745-663634 X-HE-Meta: U2FsdGVkX184dLRB49U6CJvMok5DsYpZM801uYz9wtKPUYtUR5Q5DM6udUiuHGl5ag1yewe8jl2pMo49rj4/CXIMw1bwGY8k+pWJVfF7sg62dVfrxzyMpLrucb7V9BzBqTnAeqK2I+Cyw4Eo2PrPRnsPLwR5xjR11K1qjaTT46PQQYG1/LivjP2KwwM9mkRg5NgHIUdE9l0HmJ949VyDM9xJLY2vK5tlyUZgsBQVppsutfGDMxM01RTit/xxcV0svQldvrkWT4RkSx/8gC6+gN093bv3CJCdkdXvdGMK+l+McZlST7wgIuAim3RvN9Kgw/xLS/z6iKKllS0xvxhRcWWyGce/UNRSPcLqSQarQazryAWYPg85HsOcOvTsMqqSkmhBIgBZB2GBFrdQ1fDgcNZEE7E1rTB9Mlcw2TpPyvdrEXbXNQLUCc9gJ3cUCN/JZsCJ7SUlkeSNUdSnn/XKrOGuZjHjjVUdMURDG8476QvwwI+O1r5j1RGkZ8uZGNIbp0YhZ7FG8VCTsic9SiI12MeL9MkRvVsDKgGMV+1tHZtnKMAguwe+qIIjy0CRLpNl6S0KsZuSlFc1wt1j+NTZT1AqKWElTbkFLsvUJYThS2sZXw6yaCvqNIjy2yEcjh9O7YFac++7aZFnrhETxyXI4EBBPfnXEo7Khis9TVJ7AOaN8eqfWY8OTcgSsspOesZkSzoRFPLfr61p2QKWjP4Rt3cmGgXvv46YdoVwAEDt9UENN/oJS6o7CEzECz23IBpafWN+s4K07nC3vCuzyRe4kMdojtp7hFog1W60UPElabWvSJgIzMmUB552XuVJIlmhuTpzO0pb1qOZ6esl9v+vMCm1uVFluM53BsXLgcNLoD3tydJcLl9w3Y2yxAIZFrqVOxbxj1sDyNSsE398YnArCg+eRn8g9sYTkiqfpB95iwENHn1hN0JWHsx86+tueDlbzBp+xNTAslaFmyuErLn 0+YVmv8I Yhez6aTTTLC5sNNXMu0itbJAkZH5LEmd+gL+QHrzk5hWJdCPXBHJR8XGOrhsjUMVJaGYJ32Uk6UlQIcSkvmvdvK1MpToNO7U+H9MgWZQaZZEiBJVEuRDgO3OjiywEdDKJzknvkrVb9tcAK76pEeIfVuG70dgoCFA+BWMFuXbwdgGBZJXm4eUg0md1JA11yOzWDEV5u44erpDkDyNDjsWSzf1B2xls+eSr/Qtg0wiflGGasVnVSsTVqNzJJA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.003308, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 05, 2023 at 11:20:19PM +0800, Yajun Deng wrote: > > On 2023/10/5 13:19, Mike Rapoport wrote: > > > I don't see this micro-optimization is worth the churn and potential bugs. > > NAK. > > There are many handouts that tell people it needs to run twice in > memblock_add_range(). > > I think it's time to change this. I'm trying to tell people that running > twice is unnecessary. It might be unnecessary, but it's still simpler than the solutions you proposed. And, again, removing the second loop is not worth the churn and potential bugs. -- Sincerely yours, Mike.