From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2242CDB483 for ; Wed, 11 Oct 2023 19:51:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C4258D00D0; Wed, 11 Oct 2023 15:51:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 671BC8D0002; Wed, 11 Oct 2023 15:51:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 538DE8D00D0; Wed, 11 Oct 2023 15:51:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 40FB28D0002 for ; Wed, 11 Oct 2023 15:51:07 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0DB9F120406 for ; Wed, 11 Oct 2023 19:51:07 +0000 (UTC) X-FDA: 81334224174.29.634F658 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) by imf14.hostedemail.com (Postfix) with ESMTP id 5D61A100029 for ; Wed, 11 Oct 2023 19:51:05 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=4FkNu6As; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of 3qPwmZQgKCG0dSLVPPWMRZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--shakeelb.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3qPwmZQgKCG0dSLVPPWMRZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--shakeelb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697053865; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d+xtwxP2GC6kynmr5TxkkaN6Dd0EQSD998taM6zjmZM=; b=CivYfzzFX/o0rXDvQkDm93g8+HlRogu5AkaInF20X3oeFl7ryOgrb5DSjjP2Ui2zR0rhQe 3vzchpvMDnXKj8waYkII4R97ce1rmuO+T3gVMHfijipuj3XC1ASEek/Ch13GP3VPkrmFhK 4U/ray2jf6Ztz2yM9jfdLv3BlSvwLug= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=4FkNu6As; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of 3qPwmZQgKCG0dSLVPPWMRZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--shakeelb.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3qPwmZQgKCG0dSLVPPWMRZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--shakeelb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697053865; a=rsa-sha256; cv=none; b=I5cOhUaFmD4dLNCZBpHxe0t0Fk+jc90XjvzTkhmLbMqtp2QQwpuMs3qSDEmLWp7CobiaAQ 68gmtrUP9Ktc5b8X6Z16e/u9p/lHWBye+CpusRb6AmkLcUTHGtUQ8S0la3gTNKAem1AkfG WP6fQkjYzZvjJuEh/nd/uDBqFRVZv28= Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-d9a4fb3e096so234133276.1 for ; Wed, 11 Oct 2023 12:51:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697053864; x=1697658664; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=d+xtwxP2GC6kynmr5TxkkaN6Dd0EQSD998taM6zjmZM=; b=4FkNu6AsFTr6VZjvCHv/GiPgZzfWGgvw8QptJkjWkmYvX1yVFndbaQCjgVHA6dpJCD LPJ6qzZa53++zcMSYhqwAe9z0XFc1bfQ1aHGjbSC2vFvZulVyJ+bpLMgcT7pNWdxg8wN RT28bHn4iVe8XvXCpxwloX8HCKZz3yWQ3DcYH5r9cUOOL6Hpgxn/c6Hrh9T+2DXRsoTR 9DvO/mTpl0jqCGVs4/yf4CxkTxGPG2C7sIhjHkgkcJ4IusMf6PNsAZg3akeX3EYQTiOL /yxf0pBCQT4zO67Sv5KYNK79XWT3Cu2Wz+m4GtMt9xje97MwHgf5AgbHm7EbYoSGJpNd Quig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697053864; x=1697658664; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=d+xtwxP2GC6kynmr5TxkkaN6Dd0EQSD998taM6zjmZM=; b=ny6g7P5OAKUxOGbmpQ2uhduO9hqQaOqthiKpoX6q0Xjo/hXWKicGJgEeMtA2pmI12I hs1oxDO1QrB27L5iiQtfsIIpStup3DwFPDGO0LpGB8nmq/WD3pSgegTh+Yy4cmNWJKk9 UL1NPpGjnq2RqtqFy908fS5r/qoossLIc604fuRJb9oAhcmLDrdB+FessuLY9/b8NwrH zC0E3wfnQaVtDT9cg+t/VCr12xF2ZrjOtBbZPvrnACGLjQfD/V/3s9LByaxvpbGNVRWQ 52V3kW3lbkOWvRJ+4ozStavnGGTrSwTpIaz9KBQ1duPjdomL9okOn3sdGc2rP8aSvEzT s1zg== X-Gm-Message-State: AOJu0YzLhv4/lGM+1c5KJIavLlew72KtFXICpIOlpClqVYpd8vWl6DsU DBxMj8pPktrpVfLAUqQRPoiJUHEta3RLcA== X-Google-Smtp-Source: AGHT+IHjew1mpcUCKFj3tFkSQZF7ofzPnjUyZuwxOERyXzmESyX2Xjd1WD47puAaQY5ep5Qx7SzxUmEk0SOM2g== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:262e]) (user=shakeelb job=sendgmr) by 2002:a25:df45:0:b0:d9a:3e96:b549 with SMTP id w66-20020a25df45000000b00d9a3e96b549mr140481ybg.10.1697053864458; Wed, 11 Oct 2023 12:51:04 -0700 (PDT) Date: Wed, 11 Oct 2023 19:51:02 +0000 In-Reply-To: <20231010000929.450702-4-roman.gushchin@linux.dev> Mime-Version: 1.0 References: <20231010000929.450702-1-roman.gushchin@linux.dev> <20231010000929.450702-4-roman.gushchin@linux.dev> Message-ID: <20231011195102.mym2mrgqyavp3n6r@google.com> Subject: Re: [PATCH v2 3/5] mm: kmem: make memcg keep a reference to the original objcg From: Shakeel Butt To: Roman Gushchin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Johannes Weiner , Michal Hocko , Muchun Song , Dennis Zhou , Andrew Morton , David Rientjes , Vlastimil Babka , Naresh Kamboju Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: 5D61A100029 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: bpxcnd1z9e8m55pid3y39wggisuad1t4 X-HE-Tag: 1697053865-260284 X-HE-Meta: U2FsdGVkX18EEuI9FnisY2KOrZNFmGVDmveaKJwB5ru2jcpnFyHxyOJ54doPRZLuLlD3EmKkGTH8xyzgjEqlAt9J8x/gb4hxw5eNGI7qG4ON5KDzZYBLhhCcHXgpdko+XgATsl59vEMXSu8BUOW72/vsAoRm6nPRYBmY3EYex/GYBmUKF4t1VGZYyKpsqOZq2M6rzQ5TqW0ZlRyOXbc/HsiAGxKzUgQimo7ywOzM7C+7RTVbHzks8xUdf0YZuIGrUq7vMO/+T/BsaQFbrcGiavjafBD3hT/0/wWrl+iSJP87jIsnBgi8cdpz9LIu++vYWAnEv5mTthRtkmTEJJWbv6uimcHElZbKoLTVn7OmGxlEhL1bec1Q2TxFrHCTY93HGfpWhBI3OnizWX+HGHYzNqkv72wxC3ub1YYyT15++9ZySyozOBRqQljxKaYp3rbJX5D8AOL2XYt+mXrTSnrMjVm+HTMuJWJBdfSe0NazWNNCc7R+h01vJmZwS+vgR3EVFZJ7Wx1B/7VBnCYOeo/1H09jmOBMXt5O9GQD9f6KCstaqfLyOTx6EBc9nNWo88ZjNhokzsAM7KPvDB0L/upqlFhA/jfWjtWpgrA7YNoqOoiQv4FWI7/+u+DCsZSsLzUqT8TYYyU54yk21AJ3wc67NApOJEinwK+Y5DBqcCxgcJHcQvo9rW0gIvhC8y2kO7A5hHNQyOnPDf/1gqhTiYfG4LOAPNnOEzPpCEOlphuJnRAEvYnnpI8CAlM8OIl3C8sZW1qRFkKdH1bqMV4TL6bTT9T0zqBxLK+iFDAhOLTNWKMGYu0p1F1e1bA6rdStNbzg1QW3Uo9/HUF9v8hOc1+jvrbCcSfX1EQWs47il1Bi24tPqvqto3yLN0OVR1nyNIirjB7Ujgp1OKmwbH1rAkGl1J9gMe5VlCI9eaNXsUk2W5Zf77ybiL5gLD85eaQFopzdKbogzgBF8/4Z7LCSQTh YgpO3oTF khtSU5WA5pLsmYVwcLLT4sHH/PP7U6t3f2XYqU1MQuBmINptkJWDrICzLKeQosM4IWPQADiNSOYZFmxdoF7LHNeQjms2hOIem4BZtfZG8227xTcIYopQVTkG2AsEDfNrdXQkdmEm/OosSnMZ8ckij9JbLCMUDBMpP08bL74vmHxdGpM/PbE4HhwO+f07PgRoxNNbdM9JTug+IJj5/47wcf2h2y5N6tAUVP+jfQfdQZtVOqsZ+8QMgMw10zNDJQGCQZRCT14ZlrzldK0llAB6ymhdONbDj7nUs8wapLa5yjCWY/Qhnrqw5enptOl3jSois6QBnGeEbdF80uporfXRUIeRnTcm2NgYVaEZ4lddOdAjjf4O+KjLpHx37MZvmpdNqMUFRgCbhPLO6e8tkItH2sM+klBEyITA5j89Vqg9bIAHMpaXyIZAmSyhipjiOj9/GTvFyI5IAOP7eSolHkp1lLeNfClgG1lxe0ukwFg+cZh50BnTLQamyXqR8Be4TTmoLxMqjdag9GIcC2LrTs2fyEgyJ022ZfW9JNBi/eV55apnkgxy2hurNWxIcTXGDPXsXznWj2cybS24MaOKmPi6jIg5CLgbkK4o3ePoQQk5CRrVivTp6M94yUgojOQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.003425, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 09, 2023 at 05:09:27PM -0700, Roman Gushchin wrote: > Keep a reference to the original objcg object for the entire life > of a memcg structure. > > This allows to simplify the synchronization on the kernel memory > allocation paths: pinning a (live) memcg will also pin the > corresponding objcg. > > The memory overhead of this change is minimal because object cgroups > usually outlive their corresponding memory cgroups even without this > change, so it's only an additional pointer per memcg. > > Signed-off-by: Roman Gushchin (Cruise) Acked-by: Shakeel Butt