From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 130F1CDB473 for ; Wed, 11 Oct 2023 18:01:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D2AF8D0050; Wed, 11 Oct 2023 14:01:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 782928D0002; Wed, 11 Oct 2023 14:01:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 671138D0050; Wed, 11 Oct 2023 14:01:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5C4718D0002 for ; Wed, 11 Oct 2023 14:01:12 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E81BF402FB for ; Wed, 11 Oct 2023 18:01:11 +0000 (UTC) X-FDA: 81333947142.21.04364C6 Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) by imf21.hostedemail.com (Postfix) with ESMTP id 7CE171C0024 for ; Wed, 11 Oct 2023 18:01:05 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=bmD+U7Mm; spf=pass (imf21.hostedemail.com: domain of 34OImZQgKCHEhWPZTTaQVddVaT.RdbaXcjm-bbZkPRZ.dgV@flex--shakeelb.bounces.google.com designates 209.85.215.202 as permitted sender) smtp.mailfrom=34OImZQgKCHEhWPZTTaQVddVaT.RdbaXcjm-bbZkPRZ.dgV@flex--shakeelb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697047265; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C+DWGMBxP+X45X3NzNtwuI8J+qvPFiJhuYh3mGuN+4Y=; b=ELouNNT4vgqiGkrLoE/rspbvuciKSu/9GXqnBX/HiTDZ2jhvPPKZT+GsPQKDFYOVfPRDvo 4W43dSxhDwu4Wm7YtEv9ycaxrryQ7YAkMvh/e9VL9lMyWnnrhsbfmC1y4BnF/CU9BwSxik 5KDRbRz8KfIpyzmetSRXUIw4zS8Qeo4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697047265; a=rsa-sha256; cv=none; b=7Cm7dDqgUY/2rIgsqaG5kJfpeW7T2xAw7wkRyULKiETfqkqN7tstvh+mKObNRMTMldde8Y xCl16J8BTkvq5ZkShogzL8UXgrybk1SBGvwZpLYp1YckEN//jnWJi2cO/paouI/87heh96 giOoGUN5mtkbKMVtVpT1881KR2kDAS0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=bmD+U7Mm; spf=pass (imf21.hostedemail.com: domain of 34OImZQgKCHEhWPZTTaQVddVaT.RdbaXcjm-bbZkPRZ.dgV@flex--shakeelb.bounces.google.com designates 209.85.215.202 as permitted sender) smtp.mailfrom=34OImZQgKCHEhWPZTTaQVddVaT.RdbaXcjm-bbZkPRZ.dgV@flex--shakeelb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-578fb6bf0d6so62277a12.0 for ; Wed, 11 Oct 2023 11:01:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697047264; x=1697652064; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=C+DWGMBxP+X45X3NzNtwuI8J+qvPFiJhuYh3mGuN+4Y=; b=bmD+U7Mmi8QOrjtYO1r5Efndlb0xCfNIPL4/K/OEnymYwn1XfOEyGAiA9hj5ZKgwcp 2dSVyXM+pburYvgZdMMmlBBsXQJ/SuRrkrBFty12NKuyHgY1XVtZZWNipLv2WRLiYLJe RSQfTsgvg0Gb5u2edjqBVRA46CR96KQHO9vX4jRqYoHzawF056oyZwggN74dWQzbKbtA Ckag2z6u0UyyvB6lbSKPs6d0UDpNu6oao8YFqiFEi/nMPUzonlMXN9COlGbqlyq+sL+o 70NxaR4e1M0QlAdIzRuAwTwUSi+mYoL5LhMOkdrNwVRFajTS2hCkXgbsjJXiQoGZteMZ kEbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697047264; x=1697652064; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=C+DWGMBxP+X45X3NzNtwuI8J+qvPFiJhuYh3mGuN+4Y=; b=TSqMUJomFDE9U02HO6fmxrMPJguUrqZsTRUsnQSnilESlsjECOBnsmcK504R/MF+4B JH0Aqz+j6adPeF3zYfH0eZIRaEUxOnaQDRH7wQNU0YRytcYUOae0cgCXZU5tbwm6ly78 NZI9Nfo/RBEbyMY1t/+932LrtDF945Q0UyAicxhWZpbNzHlEh/7RI1p23sQaCFzxs3JY FtS7VYto2TY1n4emZDCEhUNEG9+N8V40qvKEOD27rVN7g5Dei+ienRtlRJy6RFL7KUMw lWHbMXcxrR7/h49BxaGhNjW0/0j0nWaMkM3COB4nif90G3JXtCNnUHFzAIjyWjodH0y4 j0sA== X-Gm-Message-State: AOJu0YwG/7N4XQeWT8ehdxmtrGa7N7oHj5Wmwi4nn/EewLpVS2N9gGIR rlWffZdffu56/ScwQ4k47jSMmL4k5Fwteg== X-Google-Smtp-Source: AGHT+IGkqLhyk3oyzH+Hu7kZ7pieBGNQ3+eycDmqdFOkXR4RRfzAJ7dTAFgFlQdHrc6gbVBzcW98hymL+VJROQ== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:262e]) (user=shakeelb job=sendgmr) by 2002:a63:704d:0:b0:581:8024:fe01 with SMTP id a13-20020a63704d000000b005818024fe01mr330395pgn.3.1697047264093; Wed, 11 Oct 2023 11:01:04 -0700 (PDT) Date: Wed, 11 Oct 2023 18:01:01 +0000 In-Reply-To: <20231010000929.450702-3-roman.gushchin@linux.dev> Mime-Version: 1.0 References: <20231010000929.450702-1-roman.gushchin@linux.dev> <20231010000929.450702-3-roman.gushchin@linux.dev> Message-ID: <20231011180101.o2ha6awrupojcu6h@google.com> Subject: Re: [PATCH v2 2/5] mm: kmem: add direct objcg pointer to task_struct From: Shakeel Butt To: Roman Gushchin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Johannes Weiner , Michal Hocko , Muchun Song , Dennis Zhou , Andrew Morton , David Rientjes , Vlastimil Babka , Naresh Kamboju Content-Type: text/plain; charset="us-ascii" X-Stat-Signature: jnusfcwxd9tpujdoggqw3x5b9p99mcqd X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 7CE171C0024 X-Rspam-User: X-HE-Tag: 1697047265-304835 X-HE-Meta: U2FsdGVkX19vll1qIIoWvnNo0rUkBiP11gZsqrAXN4ls8SVDrUHr2s9rWb6If+EtJ3hlWJzt2cruj6GQt99RY+9ewwPrX90Ned4SGcWLjIn/cmQoJiZd9QOdN/AAmwNzkgB5nagPSUuBqHj77/Tw83+Pt4hz/FlpdW7V2hzaB5aD0sCC7gjnjccIxcK3aE7yRx1OpHGiA8IiokL1CBxA9KihDPzQv+kHHoz38tR/stmJNMuzfScpdHBTw7uy+ngOrtYgiZQPEtStMkiYEA+gBfLwY8h5bgsWF1xUNorMsLZq0x4lshU3F4pcwOk/ZJ1HJRxVx7wmil5Lu699W0NLlBHbPebMwMMK694KXbSK7pM11XkHdhD0zqiV+0TnV8sC4mJ6NicPof5Q4FN1NnY5xiA4clRGwL0qmWvAiQgHmNgPrWYHM8IrhardZHZ0J2kAoOtyxOWhyXss7ikyPhKUBaB3QlJz2bFhgCz40RFxD7AhJep2NHk1YMGgUcNHR7dI7qlptahyqBAQsvgTtXeHspIp3TL4n2TtwdrXBfEdhu6JmvhxuIVhj0lBeWWU1OVNB1oRFFeS1ky8kCYqrJ10M1lIcJfZ9ErVBsZ1APSM7cjujeh1jaOG9VB03ZELYcjLuJRUkJh2NVEmNbzPYDZqXH76jk3/cSeTAy7ijmt5aIPLNFZNlxgWgsxO84+Xwva96El4dylJiYm/dXqdHIzKVkw1muT5uvbHcy2bnMiX+DieS2Il9tW3V4spPB54DkgR3KQY2/Dm9JrToLQrAyWfw0urjUpHcVSlcsxwy96u2i+Er5Q03wkITIzOHNVleUr6crqckxprrSOYVXAFvsqJGRpEG1OBfwIFDRBVZe/pMBe7NaYS1x294rXNPpunWBFJHkReM1Mx8jlX1pc6XCIttMAQhqpQX7zvMRBwYwbs0JmVCUrM69kVnUPuco9apP4lMxmUwQGYa200GfLcqGy liUmqN4M 8q6epHsj1tUYL/TtsXJeuuLWUlzRAo0ZksoQBxpUZUHdfYQDXq6dtAtUUtTBbhGleVrPq/WIhSiOa97PlpPCYhC0dESvv/zfVYuNksOatIF2mZdQxJLhx+w3Ls9VOy66cuHFIa0Jj51UZ3NWfn8Nv62ZFkmY0N7SgQif2Tacelo/AsHWi+EdERl5dXLOF5H1Zj6CYN0hbjciJZAjNO6sxPwRiQ4BihWVVqTev4eih7/ZXxMEBirvDY8/KSJznF2TScHG0ZpDKtH6ilW5BUf35tvFAOJ8fqP1yfYKUImfkPJWtUIA62jNiOdspBE721XdTW/0xgWDg5pALrvSeSfQmrf6mcZE7Sg5yfbowlK76RpNUFZ2u3bNxL/PY6G2hCvGQq9noFKEjPQGg0nkvRzlklcSZffYsfN6Rg6AnPzPiZ2z92vS0sX7gG/v6XODlhi1sTD1cVQrU2P1NIYrAuFOk1kNPfuljHFuUldJwtyyAMGPX2J08m+ICyKTwWQqLQH8Mq5EWMJSImiTvGsZtPtsfSUwmxdqeMm8OZ8otOuvCDne8+8X9emNiC7baMLu5Qjtz6D0wf4LMEY56dWqD6tLGKTKmfnsgBLPDRLv4jSb7PEKA7lKcv0SOzTvEztH9JcV+IAFh8Q/SopPrm27IJ0HZEk4TNA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.006751, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 09, 2023 at 05:09:26PM -0700, Roman Gushchin wrote: [...] > +static void mem_cgroup_kmem_attach(struct cgroup_taskset *tset) > +{ > + struct task_struct *task; > + struct cgroup_subsys_state *css; > + > + cgroup_taskset_for_each(task, css, tset) { > + /* atomically set the update bit */ > + set_bit(0, (unsigned long *)¤t->objcg); task instead of current ?? > + } > +}