From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62CBACDB468 for ; Wed, 11 Oct 2023 16:36:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA9728D00CB; Wed, 11 Oct 2023 12:36:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D59F08D0050; Wed, 11 Oct 2023 12:36:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C212F8D00CB; Wed, 11 Oct 2023 12:36:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B35E68D0050 for ; Wed, 11 Oct 2023 12:36:04 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 78AEF1A035E for ; Wed, 11 Oct 2023 16:36:04 +0000 (UTC) X-FDA: 81333732648.24.2E6DA3C Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf27.hostedemail.com (Postfix) with ESMTP id 0985840030 for ; Wed, 11 Oct 2023 16:36:00 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697042162; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PpO3DXzktwZk3e1OeNjucOKXp78qz6JIuZIdTv0kdI0=; b=VFy+AWQRo1xuHOZHOT9CZnvY986b0D4zIbGKbJXZF/e5Tv53WxVFhrPutzwhPOgi4KalER cYcysUqttxE0O0JRu0jm5QiSVTg6zH3UFIbzRZ+za1bWRFjnLP53nKgYo7I+rDlNc7AeWc a+27LvBB57x5sSvIHjeRFyGFvbYffeY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697042162; a=rsa-sha256; cv=none; b=q4BdXxJJ3uMw9T4GjQNc5OQplafuwLUOKG8TKLeMHlcPIw/gd2gWe/1ZlSNVYvUpNBSVS/ EvmKNMWAAYMkz0x/864oHmKMkOtdrQ/N8ZlElj8O05F9F5MQyxEuaGNOXVL8lgYrYuIwy/ oUTDUXZtZ6H5zc+9ZhphElO3OxORHaM= Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4S5JGW5d5hz6JB4n; Thu, 12 Oct 2023 00:32:51 +0800 (CST) Received: from localhost (10.126.175.8) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Wed, 11 Oct 2023 17:35:54 +0100 Date: Wed, 11 Oct 2023 17:35:53 +0100 From: Jonathan Cameron To: "Sridharan, Vilas" CC: David Rientjes , Jiaqi Yan , "Luck, Tony" , "Grimm, Jon" , "dave.hansen@linux.intel.com" , "linuxarm@huawei.com" , "shiju.jose@huawei.com" , "linux-acpi@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "rafael@kernel.org" , "lenb@kernel.org" , "naoya.horiguchi@nec.com" , "james.morse@arm.com" , "david@redhat.com" , "jthoughton@google.com" , "somasundaram.a@hpe.com" , "erdemaktas@google.com" , "pgonda@google.com" , "duenwen@google.com" , "mike.malvestuto@intel.com" , "gthelen@google.com" , "tanxiaofei@huawei.com" , "prime.zeng@hisilicon.com" Subject: Re: [RFC PATCH 2/9] memory: scrub: sysfs: Add Documentation entries for set of scrub attributes Message-ID: <20231011173553.00001b39@Huawei.com> In-Reply-To: References: <20230915172818.761-1-shiju.jose@huawei.com> <20230915172818.761-3-shiju.jose@huawei.com> <20230922111740.000046d7@huawei.com> <92f48c1c-3235-49b2-aabd-7da87ad3febc@google.com> <20231006140224.000018a2@Huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.175.8] X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 0985840030 X-Rspam-User: X-Stat-Signature: ruw9ruryrrfxh75bp76jk3zwnkna9sm3 X-Rspamd-Server: rspam01 X-HE-Tag: 1697042160-383934 X-HE-Meta: U2FsdGVkX1/helzCT+eNi1vEetzcTcjTbQtjrukqdn/sglagBBeFSLne1ChVF4U1fyX0IEkYWvjxH+SJtexlnTvWzQYt56I7qWhvjQVrN6TYALgz1RVbcnPO2M+vRUsLl5HpPydLMOzA3ayZkPrTLrZjMiDeSZjOC7Ru2B3C5ZiaQiQenbcPkzOeeJPIL/BMjA3mo9v1c24GBu1MXAmRnkXhS3he+h4Y5ALkxDy593D/ccDhxvunpQvYsOp2ajp/QhIb6f95NdQBebDjldWLmdHn8ZgwIRHPKHs1F5R+WfW50RBZdkpVFTAGmOa9Gb+3zlBljut1QmutpWVYYwfFCNeAjZYe8FonjzJuB63suYPYIZ2DD/39hbT8x7uro2fRdUX7sWwEh0kfBed0IXMHZuMU600wFfApYjXio3d1ARqRq+7lvabWGlFTFcK2bFmzsUC2G990vdqk7EUr0t/DI+ay64ABVq3tURxunpVHk7bBChzwCIWN9P9BFFPhFGGX9cxGDIQMaPtIsehduWJ5BunAMYzVLS1hhix8b4KSYm5Z0H3O114oZAorEjG8+d6ayfSD4y2ZF/5tNINfDqhxGxciwIluLPQUJB8On3NxMYbKzygN8Jj0/sbwAcBSkPLCtgjZAGEfWdhdeMxAmbgyWI6ND5TkY2UuR2DeIM4iUZhA3rL+GYn4wr+5d0xthuvlRPEuJWYrA6eL9mBNMTwIXNJY0jMeaoPRwOGvGKnAVpfvowIl5A+ljgVQQ/H9n54zxDLlmaAl20Q01cVqkJGxX/WA24YJDb6N/ClU+P3FaAz2b95rOmGBbB5b+Nw62ESYes1XbPLJnVmQDX1vX2FesUWEVP+Xk+41ICe4O9QQBH/yVTxsAq4NwnicjZ4CAShkrEB5Tmt4bUBLOTgD6tsfxF1HetxsKMMBj/ISKrWE8Vqvkgp5k0lKkfKIi4jlRoqkRAVp2m5UPXS8czOFhoV 7uXZQbIp gfXHXqXazcyuKaV6Vfl01XSSbebMacsdhXMHcT+SKoU4wUHnBrxXwmJUjk0D2nVy2HrMnatVO572+seCWhhPBjx4HK7JNNNfvR21vX3k2UWZt30M+wkYbNhCD3CnuKoYCPtcASNBEPSwYEg0lDWC/Ymh2z2mtKbmKgP0EkwJdXPiOUYWqyCtQwQPtsbgzeGvaioffByOxvxTaHUj1uC7E05LbrQrkEKOVDTBkahVLNkvy0lk2hvgrTQW6QsffJw4Sc6rq0YDP2/9DycGJijx4w8+CxxpMvUdMsqHH7m7PZ/l+dHuTA4IIvp9GAYHSu5R1dB/vu+546XPWRGOyN2FmQRgE4qRMI+qysfr1puGYsjJAYoqa+R2N+TxvahL/qnwjrs/IbqaP3DH7a5FV0v3ZnEaswmVuoCze4U0pJnESpmcupPP04dXD7hGUocLHNgQ+AeNtLTx7I70crGMgszd64UkNpURZnp4wQ5ZWSw/8hyss6IBZPwG/XwtO5j+cSRC2Sk8bq5R/83dyXQr5gT1chsxO6QjJUqCcOmYPmjwHgoQ3vUM8NaPcnRmzxAsbeaJdoSpiW/yX1KnIBdcMJTizUCBStMtJTC5Wd8QBToDw+3rinPUvOT107twmRL95c2CMfMB/zMXsWLStaEzLaPZrNFew2EJpn2Pcrwlw/F2tNzlyjj8IL6x2U6XdXA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 6 Oct 2023 13:06:53 +0000 "Sridharan, Vilas" wrote: > [AMD Official Use Only - General] > > I do not believe AMD has implemented RASF/RAS2 at all. > > We are looking at it, but our initial impression is that it is insufficiently flexible for general use. (Not just for this feature, but for others in the future.) > > -Vilas Hi Vilas, So obvious question is - worth fixing? I'm not particularly keen to see 10+ different ways of meeting this requirement. Probably not too bad if that's 10+ drivers implementing the same userspace ABI, but definitely don't want 10 drivers and 10 ABIs. Jonathan > > -----Original Message----- > From: Jonathan Cameron > Sent: Friday, October 6, 2023 9:02 AM > To: David Rientjes > Cc: Jiaqi Yan ; Luck, Tony ; Grimm, Jon ; dave.hansen@linux.intel.com; Sridharan, Vilas ; linuxarm@huawei.com; shiju.jose@huawei.com; linux-acpi@vger.kernel.org; linux-mm@kvack.org; linux-kernel@vger.kernel.org; rafael@kernel.org; lenb@kernel.org; naoya.horiguchi@nec.com; james.morse@arm.com; david@redhat.com; jthoughton@google.com; somasundaram.a@hpe.com; erdemaktas@google.com; pgonda@google.com; duenwen@google.com; mike.malvestuto@intel.com; gthelen@google.com; tanxiaofei@huawei.com; prime.zeng@hisilicon.com > Subject: Re: [RFC PATCH 2/9] memory: scrub: sysfs: Add Documentation entries for set of scrub attributes > > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > On Wed, 4 Oct 2023 20:18:12 -0700 (PDT) > David Rientjes wrote: > > > On Wed, 27 Sep 2023, Jiaqi Yan wrote: > > > > > > > 1. I am not aware of any chip/platform hardware that implemented > > > > > the hw ps part defined in ACPI RASF/RAS2 spec. So I am curious > > > > > what the RAS experts from different hardware vendors think about > > > > > this. For example, Tony and Dave from Intel, Jon and Vilas from > > > > > AMD. Is there any hardware platform (if allowed to disclose) > > > > > that implemented ACPI RASF/RAS2? If so, will vendors continue to > > > > > support the control of patrol scrubber using the ACPI spec? If > > > > > not (as Tony said in [1], will the vendor consider starting some future platform? > > > > > > > > > > If we are unlikely to get the vendor support, creating this ACPI > > > > > specific sysfs API (and the driver implementations) in Linux > > > > > seems to have limited meaning. > > > > > > > > There is a bit of a chicken and egg problem here. Until there is > > > > reasonable support in kernel (or it looks like there will be), > > > > BIOS teams push back on a requirement to add the tables. > > > > I'd encourage no one to bother with RASF - RAS2 is much less > > > > ambiguous. > > > > > > Here mainly to re-ping folks from Intel (Tony and Dave) and AMD > > > (Jon and Vilas) for your opinion on RAS2. > > > > > > > We'll need to know from vendors, ideally at minimum from both Intel > > and AMD, whether RAS2 is the long-term vision here. Nothing is set in > > stone, of course, but deciding whether RAS2 is the standard that we > > should be rallying around will help to guide future development > > including in the kernel. > > > > If RAS2 is insufficient for future use cases or we would need to > > support multiple implementations in the kernel for configuring the > > patrol scrubber depending on vendor, that's great feedback to have. > > > > I'd much rather focus on implementing something in the kernel that we > > have some clarity about the vendors supporting, especially when it > > comes with user visible interfaces, as opposed to something that may > > not be used long term. I think that's a fair ask and that vendor > > feedback is required here? > > Agreed and happy to have feedback from Intel and AMD + all the other CPU vendors who make use of ACPI + all the OEMs who add stuff well beyond what Intel and AMD tell them to :) I'll just note a lot of the ACPI support in the kernel covers stuff not used on mainstream x86 platforms because they are doing something custom and we didn't want 2 + X custom implementations... > > Some other interfaces for scrub control (beyond existing embedded ones) will surface in the next few months where RAS2 is not appropriate. > > Jonathan > >