From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF52ACD98EA for ; Wed, 11 Oct 2023 16:14:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 642538D00C6; Wed, 11 Oct 2023 12:14:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F1C38D0050; Wed, 11 Oct 2023 12:14:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 492868D00C6; Wed, 11 Oct 2023 12:14:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 39AA28D0050 for ; Wed, 11 Oct 2023 12:14:31 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 04887C01C8 for ; Wed, 11 Oct 2023 16:14:30 +0000 (UTC) X-FDA: 81333678342.04.B7F5339 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2048.outbound.protection.outlook.com [40.107.244.48]) by imf04.hostedemail.com (Postfix) with ESMTP id C1BED4000D for ; Wed, 11 Oct 2023 16:14:27 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=kSqrEGZ9; spf=pass (imf04.hostedemail.com: domain of kkartik@nvidia.com designates 40.107.244.48 as permitted sender) smtp.mailfrom=kkartik@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697040868; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DxAr48jZWSkVW5eya7hY1V7YgwubjvBsjmNdEpK6cL8=; b=BAMSoywLOr3Gj5MR4ZFX93fDuiusjQsHGM+nHjIH2JnMGx2bBlw7ocoxpk7pTyuhoLeI/r Tf9p8DW6nSElWjGfNnFbGDY8WBDsVb9wRxagUxy5P8m4/CfSu6px1CWPcPhfqxmHTs/Wti oc2frEQNJPBLZFwDENG9Dh4PNVOkOjk= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1697040868; a=rsa-sha256; cv=pass; b=Y3JZCObF9wdBoRAYLHCsGNOipANQy3FksoKQanpoLKvaltjPE8R1FU/DuMSI2cOVwCzLpJ SJaVTB6TLs0rjbPax6uS+zBesqlFOnclVau2Eg5utgEU3TDrs4nsogbBCHsV8hIhv070uS CBzsMfXu0Jp6SKm5Xoal/a3KQlrN2es= ARC-Authentication-Results: i=2; imf04.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=kSqrEGZ9; spf=pass (imf04.hostedemail.com: domain of kkartik@nvidia.com designates 40.107.244.48 as permitted sender) smtp.mailfrom=kkartik@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fHE2HzGWq4IKZAp9wpMoE+PH6V39kqAvcSqEkwUoix1qbyS4IfSEOTec7Urf7bHtBbg3ivRSspbp0jdmICQiUEYJFLqyxJ3pZplvzl5UTiO2JjqzHvTTyBN1No3YuvRuKFefpimVU5d50ZkIz02gGzx7Z03vGA0zs+m540siHQeVmmPpz00r44NiStWxLhwUp3YFna+lQmn29QOY7BLMJwzctnL8ufKh6o8H37XnhmzeoKVvSbNtuslNqF1IcuzOk5WWOQFB1DD6Gj8uzwwbfCpEOrvRafVFWDWUSszsv56nvv++PncWOUhHELSugxGK/vCrrun0uaPBeNomjL4Zvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DxAr48jZWSkVW5eya7hY1V7YgwubjvBsjmNdEpK6cL8=; b=nx0JSRlEQRJ0qgMJFw/D7KulhhaV/K7eh2e9XP1INWlecIiZBQTUgmD0TB9EC3np3KWWtjfFnHaTjUoHfGjAal/5hL3k5d54wgSUOMp0FOHz1GPt6+hinKw6dQYUoAo4ngQ6t6kI8nSiiwh1kpZlJtpJlTMvbRdbuRc2g7SviLEVFmIyB2bQr+FF0W26hmowBdrALD3YuIJcXt2Ic/28wTK3mUyL9VHWu9hJC/5yxGViAtnirqQkBsYWpi8ucQNoOMWvxW0U9VBp69/X8rsR55qn0fMDrmVisq3VnJve4UCQvsE7hDQhvVnKgKm5N3fgmB2ZZxrW4S7X/ujOj9Bp8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=gmail.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DxAr48jZWSkVW5eya7hY1V7YgwubjvBsjmNdEpK6cL8=; b=kSqrEGZ9KjFWRnA6Y9Ei5qUBgUteRwNEkm2VZ8oc2aI78QE2fI780QsMLJeDv+e5qPd+JuzqK57+KDA5+XGhLvswzUHOP43pGp1R4aUBUJxbWJoMdyZsl8icHiUrLeAMqUaG8EewA3Bz7z2kAmv2Il6wqo97P4lBom/SCByhjKVQJ/CeI9HtzeE1SSWrve4SMj9s3Q3hS78gaog5qhunJDGGoTRh067M5jPGlZGHNNwCr3M6G8hfPRQn16k14LRKrRZRRxEkWNm5Q4Dm8X4N/BolrJc4xjAzfvzO+VfjwTST90DxmOvZHFFPHeTxTqC4rCWCWclCsYvkbgil2dt4Cg== Received: from BL0PR03CA0030.namprd03.prod.outlook.com (2603:10b6:208:2d::43) by DM6PR12MB4299.namprd12.prod.outlook.com (2603:10b6:5:223::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.37; Wed, 11 Oct 2023 16:14:25 +0000 Received: from BL6PEPF0001AB56.namprd02.prod.outlook.com (2603:10b6:208:2d:cafe::6f) by BL0PR03CA0030.outlook.office365.com (2603:10b6:208:2d::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.28 via Frontend Transport; Wed, 11 Oct 2023 16:14:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL6PEPF0001AB56.mail.protection.outlook.com (10.167.241.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.22 via Frontend Transport; Wed, 11 Oct 2023 16:14:25 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 11 Oct 2023 09:14:10 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 11 Oct 2023 09:14:09 -0700 Received: from localhost.localdomain (10.127.8.9) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server id 15.2.986.41 via Frontend Transport; Wed, 11 Oct 2023 09:14:03 -0700 From: Kartik To: CC: , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v4 1/8] mm/util: Introduce kmemdup_array() to duplicate an array Date: Wed, 11 Oct 2023 21:43:59 +0530 Message-ID: <20231011161359.1368-1-kkartik@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-NVConfidentiality: public Content-Transfer-Encoding: 8bit X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB56:EE_|DM6PR12MB4299:EE_ X-MS-Office365-Filtering-Correlation-Id: 15bf3596-9416-450e-7a91-08dbca752328 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WSGWuG7PN5iPck+UH+SeUUhs1vsv4Tm7LECToTuhFu46e5E8aJZjmaVIPF4v+q3OzldgJFxl9ErEQdlWIEOU8y6Ka6VPL4GmCEzVrCQSJqCNe0oS/9fQGHi51aVKnlZfHlD/RtY0w5PBUQbidz6/jzDmMrqxAVg2ZKJqib30VnlLxpmQXuTqGon/+QAHftlMUDXnOmzw+F7DYX6+R1CPl9BqjAAyfVptLZKkv1XQ1cDNToJsgkmgG41iO4r4VYlK+TkwGr20sH/hoiSLXlkCmobw5lghJlMjLR/bZ6vUnjzUmjJQ8fcmsNM87PZ13e90FLQ5WPoDKTnMwepXOXuGuUYIpzytZLwJ/rs03kEKV+Zf5YsQAdUNfhxywgZ2aNCWlNcuZOodSCQM5Mqp60qxRNBGPRzAoN7l7/9cpLuJsc73KgdMmPlLBccp6+jYdNsJWCG2havEgs8BP/Qt/MTIvwx1Bod0Z80MEpj7k+6p9pK3VqpUY/AptEr4cr8K8rK4uFkjeqhW1JjAkFOV0ib6gpgWDuosBTN6LJag0Io2Vxs0f9+nYOiVP/DfgdHUANxsyhZJw3qhk334jvGnivQoSgYZCBgVfjvSFv1f89nrjUXD7vbp8WNiydWQ1Vdgvb6eTA4cLmUzIsqIiPF7yHOTNeTzot21hR2+wjcOOVdYz0kFvwYOWzbkjIr/FWOsVK9BZreoKajMr3DF9y+hkBaYGdINjRzi9wSZ6AbqC+2YrJo+HchaBYfn42r1NlZcq7lO X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230031)(4636009)(346002)(376002)(396003)(136003)(39860400002)(230922051799003)(64100799003)(186009)(1800799009)(82310400011)(451199024)(46966006)(36840700001)(40470700004)(40480700001)(4001150100001)(478600001)(40460700003)(426003)(336012)(2616005)(83380400001)(36860700001)(47076005)(1076003)(26005)(70586007)(54906003)(316002)(6916009)(70206006)(7416002)(4326008)(8676002)(5660300002)(41300700001)(53546011)(2906002)(4744005)(8936002)(6666004)(36756003)(356005)(7636003)(86362001)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 16:14:25.0709 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 15bf3596-9416-450e-7a91-08dbca752328 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB56.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4299 X-Rspamd-Queue-Id: C1BED4000D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: z468awpgs9gcgb4wb453rs9puzxi6ddy X-HE-Tag: 1697040867-502924 X-HE-Meta: U2FsdGVkX19pBvVLS48QwTkeR0l2SAhFAKPfRDWvDjBauZFewknUo4RsRikfKZ8Sf6hryud9z8bsjsm9K2MLJfm+KmDFcVitKgNhItG0RMipDLHVWxQ9EHf7y02VxHVEj8wTY695JWQoltz/XUCJxnFVY9SY8NXe/OVtqFDTb99oDTR+VkG70kcZkuJhCaL4Lk3g+kljQ9DutmYV8eNZZ4/4VKoqM7R//+E4e46dPr72jVkT9DjwRtuYSFjN/niwHhLH11J9HOAtbk40pb3C0fSGw3fHF5mhaH1nzjo4JwGuUzKSUUZHO+VZkZqT2ltcmSjaiRLAKTJu378w9lg63MkBRFOsoQ7t4hkNPClKpdh3kfz72SwXSHpT+mp7rHnuFt2M0GsVeUsLNMSKN/E68iSwOXcAlaZ+RvZPfaGu46xZ+otBkCgskLlGStXIYVTJHbjUQyj0fDnddRPO0qsxSBW+5ZKnysARhxpasjQIzo1Bql+swRYG41YhLv7p2nxYwCMOOiY0ISO89hVpwDLlG6gvp20m7ilneoQMxHwMerfEXQwpcTnWLpu33d6CB2xs9r7+D2WulITWgsrtIBpFIsO6Vonk7+o/9kt4jgd4DAZ4s4oDfOwyLXD+CXmgDT1TJFgyShTiCupzxbj5m3Y/OsukzCixihOS2fBgbuq9tQcZFgRCUYGUFJAd+y4OkWf1VOpznYg7Osrys7Cxp6CT0RFLX8BYRrZyCYtyFYvoTmPshis8SkOdphGQmQSh+EH4fYwUeGVUemPaEmFEUuyXHonSwNPb0EXHzeA7DxQ1tqq77ogdK/SlIGZV4KXcmyoWcFtcupuVIHwDw8xX0teP8/AT3/my4UfNBcBB8zpQuIzTEmjQ50RcsZnUox+oymkBYYcaex2e4l7i3xAPGoR8nnuADmxrdRlxA3JJLLp/YPaTGC/xsKyZI/Bn6cFY/DiUIxq1ceg8FDENodDl7sA c5TOlv2X qOVXnFUKsjY4Ppd8Kh7biSIjwogLlcVo1Gp80atRxRwXS0TBdu188kDRnFMjBkzZHFIA1GS680Tic4vUic7xrTMbCDvhn7L8BwX9ZgJn+rZ/Y48bt+c8L9g9axoXYG17YpdMDtQ9bLLdu75fQ+nSK3RqqtnzZg5o+2OzxQMYayUjy1NHypgn/VrGGhzm9SuNR3oAFzHWpFPVDCUP8rQquEn8dA4Jw+NccLeoSPikhFekrykdQ6FNH+ZSqM/AnluopPwsVCpK43xnrhbcTKZD+5hoWF87TKHeGYFAcVJtbbIj8mGIGS6RuoCuBO6Phaz9Io0c2EBss5c3cUdgtFz8uQ5Pjnx/JHySLYQhDJ3hxAh+hHA3jp19KQPSfaIUzjC82z9utKfQIUjd9obo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2023-10-11 at 18:36:11 +0300, Andy Shevchenko wrote: > On Wed, Oct 11, 2023 at 2:17 PM Kartik wrote: > > > > Introduce function kmemdup_array(), that will copy `n` number of > > elements from a given array `src` to `dst`. > > > > On success, kmemdup_array() returns 0 and copy the elements from `src` > > to newly allocated array `dst`, it also stores number of elements > > copied from `src` array to `dst_count` parameter. On failure, this > > returns a negative integer value containing the error value. > > Hmm... Why is it so complicated? > > Can it be as simple as > > return kmemdup(size_mul()); > > ? > > -- > With Best Regards, > Andy Shevchenko The idea was to validate the arguments that are passed to kmemdup_array(). But I agree doing so complicates things here. I will update this in the next patchset. Thanks & Regards, Kartik