From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85D0DCD6E68 for ; Wed, 11 Oct 2023 12:54:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E4C08D0106; Wed, 11 Oct 2023 08:54:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 195F58D0002; Wed, 11 Oct 2023 08:54:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0840F8D0106; Wed, 11 Oct 2023 08:54:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id ED4D88D0002 for ; Wed, 11 Oct 2023 08:54:37 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BFD37B48EF for ; Wed, 11 Oct 2023 12:54:37 +0000 (UTC) X-FDA: 81333174594.30.DC0183F Received: from outbound-smtp58.blacknight.com (outbound-smtp58.blacknight.com [46.22.136.242]) by imf17.hostedemail.com (Postfix) with ESMTP id B15BE4001B for ; Wed, 11 Oct 2023 12:54:34 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf17.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.136.242 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697028875; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2zYtBZtZ9QVuCdfIFnVHKpOyJsqjieVqwcrCNAsI76Y=; b=AwfBK11AvWFsAVgm52fz5S/uyzrLkj0Wg3J0MxEyllGLJFLtFUpAXiZiLxCknfCemzDETG HjYxNtP0n+TEsqH7311czBl8oFGbwBGmA/GXPFYU89ZhOoMbtASuWBAk8E0IzWoxQpc2gE sw0DyU+6u5SzC60lT8oV5aeMfJniaG4= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf17.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.136.242 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697028875; a=rsa-sha256; cv=none; b=N2kS9g+PCC9m8FO7V3f9KzzS1d7l0UHjiR6sBYvtG00awfgDx5d50PNJKbexHjVXeSu4hV NEcs/KcwdyjqoUbK85xo//XEwma/9YcKt7XDvRUDRHHx4meerHJcPYCLQ+SDfKrN+wNo/Q i2bcZ4T08RZTFx9vMR+RfVIwd8wib24= Received: from mail.blacknight.com (pemlinmail04.blacknight.ie [81.17.254.17]) by outbound-smtp58.blacknight.com (Postfix) with ESMTPS id B3293FAFF7 for ; Wed, 11 Oct 2023 13:54:30 +0100 (IST) Received: (qmail 17085 invoked from network); 11 Oct 2023 12:54:29 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.197.19]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 11 Oct 2023 12:54:29 -0000 Date: Wed, 11 Oct 2023 13:54:27 +0100 From: Mel Gorman To: Huang Ying Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Arjan Van De Ven , Andrew Morton , Vlastimil Babka , David Hildenbrand , Johannes Weiner , Dave Hansen , Michal Hocko , Pavel Tatashin , Matthew Wilcox , Christoph Lameter Subject: Re: [PATCH 05/10] mm, page_alloc: scale the number of pages that are batch allocated Message-ID: <20231011125427.dtwr2jerqzehjjxo@techsingularity.net> References: <20230920061856.257597-1-ying.huang@intel.com> <20230920061856.257597-6-ying.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20230920061856.257597-6-ying.huang@intel.com> X-Rspamd-Queue-Id: B15BE4001B X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 8w3x4xc9if5sywe78om1u559r3awnkkg X-HE-Tag: 1697028874-181951 X-HE-Meta: U2FsdGVkX1+6FB2Xrb44FTaoP3vTqV/zjZrShR0ey1m0iARLCzYG4Kn2OsQ+4EC49g56T12RkpyfKysVcKm4L1QamtP2nEZ3PStRJYlVjIDIG0+8o9owvv3rpgrJKu1ePc0ktjw0ugLQRIdx/VzQlvU1TmaNNsexUkJj8nGrK3vGNOSVRHMFJx8tmnqFPgYxvu1gyKitlRVkXCGnoeswHy6KIWnmJu/u7CtB20BsERejfBL9Kq2gQ+f8KlDWvtFuE2+30yHFEFNwMV1u8MDS2k3bOfl6dK8DKSLELRD24Dq7+A/gUq1OhuzNsv0K/h/AuxhZbFtzMIF9Tg4K5PfS5Hfevtjt+dNaeDy7N5D0Tx/ffCK1CjCvriPtfeNVbpTwPVEKLWJAA/CpP+mWcs96ENUf0DsPUZ8D6hhVrccn49U37hTWQ4obhDZoZOEjjyJX3o/z6kUahRPc0ekrJBeczdH89mX/KSpqspuo2QnwD0dmkDNWyRuf/efq/3WZq8OUtkZXNm/3fwK2kmBLqX2Kx8poZlpjZsSMOiqQ+JwXkHt5vLoxkL/u79cKtFcU4BxK9XHsM6r4nFtdAKHmmEVArtMR8UCCYn7TYG5r+/Q6aEwczrzO4Ikt3tke5ADt5EdKANS4FFkzb6hsGA+ni7oXCcYzvWgQYP214mxRzSJ1smNoqXyKEdHAlupFzAnbM2UHAhc8sQnIYlIki7xUo4Hh/4ViaVH0BVcHu5J8ITb63k9vioJJB9k9v4IX8kB5KO61W9l7Zs4DX3FIrIrOpQ6GP1j8peS/5wwVw88fdycXv0k0TdtVhjC8BS2i/yupl7J5hLVBJZaiSyo0kMMA2lKZubMSuTTID3PX5yDbLal44GfXDoBhykej1MLqFZevJPIvR4huWRVuywc1g8K19aCNQ6onVwrFJa2OFYHEsi14uTzuhpOF+JgGcHfkkq3YeFXCTijT4caKeGZjOtE1Uf0 oaSPJcUo Vt2M9nVr7oi62BRnWuEILIwdkbLf3lVX0fJ91/AioelcMl1NgaWSxZ95QImt5adID65k6X8HiV7HukIYof9CcZoE1fJ+K19EFyKEI6hW/MwK+jIE5H1tCIl7/U5vzIL2G+C4VUWgQ/Ia8oaZD1OTSS38Ap5z3VEI0VBwDQirRWgmbvt2qQngwXUQhBGX09Lbr4cLy6CZyyYVcTFwILuwPzdjkamfYdd+YUdIqX1VRu1R9IiqzgTdOVGFWaDP6CvnSj/9j14hw9zT0eaw6WHDvNkTcoaHPHFTdchh6w+8CVRJGH+Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 20, 2023 at 02:18:51PM +0800, Huang Ying wrote: > When a task is allocating a large number of order-0 pages, it may > acquire the zone->lock multiple times allocating pages in batches. > This may unnecessarily contend on the zone lock when allocating very > large number of pages. This patch adapts the size of the batch based > on the recent pattern to scale the batch size for subsequent > allocations. > > On a 2-socket Intel server with 224 logical CPU, we tested kbuild on > one socket with `make -j 112`. With the patch, the cycles% of the > spinlock contention (mostly for zone lock) decreases from 40.5% to > 37.9% (with PCP size == 361). > > Signed-off-by: "Huang, Ying" > Suggested-by: Mel Gorman Acked-by: Mel Gorman -- Mel Gorman SUSE Labs