From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7910CDB46B for ; Wed, 11 Oct 2023 17:16:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 651B28E000B; Wed, 11 Oct 2023 13:16:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 601C38D0050; Wed, 11 Oct 2023 13:16:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F1DD8E000B; Wed, 11 Oct 2023 13:16:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3F3798D0050 for ; Wed, 11 Oct 2023 13:16:50 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0B5004015B for ; Wed, 11 Oct 2023 17:16:50 +0000 (UTC) X-FDA: 81333835380.21.1EF3F49 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf05.hostedemail.com (Postfix) with ESMTP id 8CAE310002F for ; Wed, 11 Oct 2023 17:16:43 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=1J9d6+7z; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697044603; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2op6AOMjCwvz5244AdvWGMzgmCyF6sLIAzm8gLHtTkI=; b=2u7orYYwq/VOwg3Op+25ZoFmvvhIiJhZpOF98s+SyM1iKjxW81UsB5uIdEjt2aRHVBvowW +8kqDwP6/Z3U+x+foLVcileh7u6y+P28Yv0Bh7JhhVTpdoyNo9ndN3Sxjp0FS5KwukY2p2 ZLOTHe3qu2M00TXspU3KQvtW7i78wDI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=1J9d6+7z; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697044603; a=rsa-sha256; cv=none; b=1P4JO6wSgbYlPkdxyBUehmMDN2lHTX8Bf4qNNzuDz3Zp2PSCQ4sX3EqVtGSxaxTPeMoY/2 mof2zjbXVh2reSkmkSMz7CC76BF0zl7jwcig3iOzHcCiTNsaWLpj0cnIZW9tDUIMWxBUR5 og7uS73R0UYJd7zNT5Ene8VtTmzBkWY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id CEAF8B821BF; Wed, 11 Oct 2023 17:16:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65BA2C433C7; Wed, 11 Oct 2023 17:16:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1697044601; bh=TEhjbZnKeCuYcpy8YH4MZnjE3TXkJzgENB/x7EN+cuU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=1J9d6+7zMUgTcVgfTY5jOcVYBvPnpzXdjNrzds9YjcySqZ7KT97+bH1Z6EcIdbmls DgwNkBrZFJMkupYWIiQr5j8JkMR4hP/gCvVZaPjYj79TWFeSas2SDZ0pChVFp8sWkW POoR0ykaPJ4dZmeUAfuvbnpC/+HPLG4piV8DatsA= Date: Wed, 11 Oct 2023 10:16:17 -0700 From: Andrew Morton To: Mel Gorman Cc: Huang Ying , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Arjan Van De Ven , Vlastimil Babka , David Hildenbrand , Johannes Weiner , Dave Hansen , Michal Hocko , Pavel Tatashin , Matthew Wilcox , Christoph Lameter Subject: Re: [PATCH 01/10] mm, pcp: avoid to drain PCP when process exit Message-Id: <20231011101617.2f814633defaa13e77308d9b@linux-foundation.org> In-Reply-To: <20231011124610.4punxroovolyvmgr@techsingularity.net> References: <20230920061856.257597-1-ying.huang@intel.com> <20230920061856.257597-2-ying.huang@intel.com> <20231011124610.4punxroovolyvmgr@techsingularity.net> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8CAE310002F X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 9hkc9stq78tj54s5j15thfnrex9w8sdq X-HE-Tag: 1697044603-526172 X-HE-Meta: U2FsdGVkX19LHrlnYgaLKCTByW6XRQ8MwL+6Vyzoobrx21fgUFXbpEXMK2QLZwSm5hzaOZ1sFa4WB+SwrVS2Fp2/TowjIuL22YPzK7teyZwUipnU/5BcvwuoeOkBfNh6lpygSHceKFrGdMlHnQGAua0bCFl650lNjFBCUY3xgz2aJROM6JmxGhPufgj3nx/MlGXkvHN5Ox4jpXRu6aok4D8h4+rSoBtLUtMF7GF2WqsyxGuga5BZCjrRT2u3eQrdPDukGgq5A5wel63ILrRshgRej7xOplAG7i65fMb9H006kobECwMSVUwLZjXEW8jFcldl7a1VP5weOeMI3CPBmCaLpMfXC47alW9OHy+qfvmeu51LcwilSMD3EzWlZAbXwfWoP2c/I6c0l5Z4saEGRTinR9DCu5hUELrc6LZwKYLmckBlX9ONL94sDLaIkky4mHXx+CGNuXhzyncX1FkSpSuwS38zLLak+FjEUVQ0j9hOr1pjVjW7rbedfuXvIF/F4T3Ly0XQh8aREZIvV48mcS8kvd3Flm5B636FA2NzVe9wXjAuXeiAZiQq+U4jzahQ2xQ9nhXyyYPaNRcDGuHHhBFp/ITnz6mLSzXGtuLXFn//SjsDwSCn20wmw8YDtXIoBHzQzpqRQCdWoINVR1r87JW04z4+SsVnDkPHtVWclhYMku61BVV8/Wei+EWbBzGo9WMD3whLPAByru1TtxLdB9l8CRFxf+7UUt7aBkECmHNvzmSQ1j/V7ARJFgcjZDBeLyBngH8aGvho0i5bFXLV1fQcxhHiqGMAgHoYlND0h0sCR4/tMYDnheycP75PwyVOlLoyDoclt8iUsdjJCR6lIUbSAZjIbdNKr7nRXs7SNSj/B0aIX1gPwHtJGSjBtLrqJ+C65aNvKqXAfd+t96t5WCYPCxjALxhZJ+7tFKO9r/9uO54yHPfGAdbjhHeFzocjvfnpgSQKJu7U7gA7QMq 7ffGbI+l lGYR4+VFnSMUuxPWrT5/eYIvq+3a1fli3SIQX4xZXZcboh78wKA1zwY2cecRHqGHXPDOZSq4CA/04sSKWH6UVvuDWj1DrLjPqYTIcswd7RCbWmowoq1i8ihJhbz34SvELCdxAu14w/rQ+n/Q24leSPYiZwViaSTvH0liEPaAaHcOi1m8QyUtTsf/1f4QXxB1dzCTv7NGeWMIWRo4f/dcxuUjfJpF9RgNIeC0uUVTI6e0ohDAx406pmAvg4N8pQxPcMIAod5OkLQwlqZy+CgvCb69sOouIwIjV5x1rZAqAKG8EkhI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 11 Oct 2023 13:46:10 +0100 Mel Gorman wrote: > > --- a/include/linux/mmzone.h > > +++ b/include/linux/mmzone.h > > @@ -676,12 +676,15 @@ enum zone_watermarks { > > #define high_wmark_pages(z) (z->_watermark[WMARK_HIGH] + z->watermark_boost) > > #define wmark_pages(z, i) (z->_watermark[i] + z->watermark_boost) > > > > +#define PCPF_PREV_FREE_HIGH_ORDER 0x01 > > + > > The meaning of the flag and its intent should have been documented. I need to rebase mm-stable for other reasons. So let's please decide (soon) whether Mel's review comments can be addressed via add-on patches or whether I should drop this version of this series altogether, during that rebase.