From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14BC6CD6E5A for ; Wed, 11 Oct 2023 11:17:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A282D8D00FC; Wed, 11 Oct 2023 07:17:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B20A8D0002; Wed, 11 Oct 2023 07:17:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82A3B8D00FC; Wed, 11 Oct 2023 07:17:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6BDB98D0002 for ; Wed, 11 Oct 2023 07:17:18 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3488B16027F for ; Wed, 11 Oct 2023 11:17:18 +0000 (UTC) X-FDA: 81332929356.12.ACB9ED2 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2043.outbound.protection.outlook.com [40.107.94.43]) by imf03.hostedemail.com (Postfix) with ESMTP id 150142002A for ; Wed, 11 Oct 2023 11:17:14 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=JNUyNRhq; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf03.hostedemail.com: domain of kkartik@nvidia.com designates 40.107.94.43 as permitted sender) smtp.mailfrom=kkartik@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697023035; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uAxNN1B8Aq1rvOj2d6rD47BDQcgdbvf1bV0VdIQGpLo=; b=R3pROjU7qrsDzYgHXVMGGNK8NdJgXdzOTlKeQb+eB9jf+PHub27XC05V9h2410LOATj7cC qUfdMJ4XXb4gX2riWEqui7Zaq12UOx8L+LsHvZcPeDN4HyMNfYTiNVk4oxg4rdVw92FISq XH8+GF54Fq1aA7dzinRKEUgoVUBKKjg= ARC-Authentication-Results: i=2; imf03.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=JNUyNRhq; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf03.hostedemail.com: domain of kkartik@nvidia.com designates 40.107.94.43 as permitted sender) smtp.mailfrom=kkartik@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1697023035; a=rsa-sha256; cv=pass; b=YWPOFtGdfI401mSab52Iow0kRxGTzpWYqodnHGNlUmLPEJqGuvvFuoHU3Xb1m/Mu2E1hEg 3aCbVVESdXt+k/oG/hwqekCl7nI0HKh4RnMMKCSi1F5dcTnix3pLFw9ajOye1KVXTheBDD bU74mHV/ffqzfz7Ev/8UNuXEuTihvN8= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A15J5edtV39g/zg2UvX3slzS0aPXrE9NhAcaPM5zTRQewiIswKcF84pZGGi2AQLQMCldnh3sQrODwhL/gtQNz+E+uYxzf6heEBiA9/7GB7fINyIEw3KSdcjS7crGliX5AQxbEVDz0MOMN5Sk78AnX6Zf3M9WAeXatKm4np5BdrIJnGGlVsOll2kqfdRLlA/1Z/qNf8GWpBUkk2GZR8FXlpowhJo6VdZLhbrJXrWVhZW9+btPfN2K09eoMwY8IIr6zij23uVAOcA60U4A6uNEo8oi8SHe0qADjSARZnIcszUbU2SLvhUVZ4Q8iRfMzzOP7x1zs58k0R98a9v34ps7Uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uAxNN1B8Aq1rvOj2d6rD47BDQcgdbvf1bV0VdIQGpLo=; b=Y1ApsIpVnNjZs1zPfLvVr9AYPdP1IMf7XkUGGKaB4dSeP6pm6LM0RE3FJ+/q3uvep56dxuRNto0gA5Qei4iVxbzumeG6QmHTk3xkSbpjdHrj8xd3IJV/btA4bPYPi1yX/DjBH1C/jRcR8kjqsn0S09IBBhyLUn/D/0RLqkxpFvoGBMkeq1wW9Ixrfxj4cgYtUWhslqoxmVa3i7OLQfc/myN0xgPFGPHnUVbYClYyTh2uKX0jUfJ0XGcqZei3lMGsUl05930X4G9JTt3bTlXVPmjLkROMJMfB5lWDcdc39J+ttI/BF1qNb+pFTg0VbYKwOYClj216QPq+WPNJUVzmJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=gmail.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uAxNN1B8Aq1rvOj2d6rD47BDQcgdbvf1bV0VdIQGpLo=; b=JNUyNRhq5UVrSdtW3SJ6kpNs06kjQkchI/uTWs+UxYxtAVS0a40Mf5oa2pNQSasUVXVSEL43x641wWBcIeaWnLnJAjaFpRyWYAI91oPN7tXyu1EuFEH49YXcCSlnANxSwMqJ6uErMmi423k+phHIVGDgo9Xsvpx6MtbCvIjghVBvlRRDhWDpYBaNIMUHbGb729od57SruUJpcA92QSoQGjzGx0BmuyeIVHaOlBA93fsZqiNTjMdaAGYhzPLBLlr5+LiWL0sz0R9ggAHP0TehF8UArHZDvpr1VLwINf5YVCuBN4wMSLALhxASrePTtez2CuhmNUx33r/ZbEgZaVA95Q== Received: from DS7PR05CA0094.namprd05.prod.outlook.com (2603:10b6:8:56::11) by PH0PR12MB7886.namprd12.prod.outlook.com (2603:10b6:510:26e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.44; Wed, 11 Oct 2023 11:17:11 +0000 Received: from DS1PEPF00017099.namprd05.prod.outlook.com (2603:10b6:8:56:cafe::9e) by DS7PR05CA0094.outlook.office365.com (2603:10b6:8:56::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.27 via Frontend Transport; Wed, 11 Oct 2023 11:17:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS1PEPF00017099.mail.protection.outlook.com (10.167.18.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.22 via Frontend Transport; Wed, 11 Oct 2023 11:17:11 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 11 Oct 2023 04:16:59 -0700 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 11 Oct 2023 04:16:58 -0700 Received: from localhost.localdomain (10.127.8.14) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.986.41 via Frontend Transport; Wed, 11 Oct 2023 04:16:52 -0700 From: Kartik To: , , , , , , , , , , , , , , , , , Subject: [PATCH v4 2/8] soc/tegra: fuse: Use dev_err_probe for probe failures Date: Wed, 11 Oct 2023 15:04:06 +0530 Message-ID: <20231011093412.7994-3-kkartik@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231011093412.7994-1-kkartik@nvidia.com> References: <20231011093412.7994-1-kkartik@nvidia.com> MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017099:EE_|PH0PR12MB7886:EE_ X-MS-Office365-Filtering-Correlation-Id: c8330e9a-3b30-4c8a-4b19-08dbca4b9d5c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b1D9XXqEEDjzDVH8NlzOLxpkWwoN/gnjGsdg5L3hhwdoRYoNfLWJppWPg08zVZ42Kdjvd+LpETi30t3wQV08MGKoyMZWn475qU4kzF+NeKDyiMFlb2/beDqmJBnEn1y+DtCmoN+tfOhL3j9w/oePTAmxCM6/wO1Xdu52U2uGfMMVtOUCtOjD6k8isp+czPolU0nszAtSlQDJFBdqdhyZpYddePQ3yBwNW+zpDI6sh2+3N+psef9+pjwAj0wOmfj7cGhYgexrytxBnLBHA+vDl42nLaTGtsBVYZJ7mUl/IWC0OXjGwNpmwTLErn0XjS1KMR8FXqienkGlSruuQ1uD7fgXdPAvVB8GSfrB1Rc6JM9gITynZQJsRNTpPnXEcEHVL4T3jWh9owr7tGxLH0Nl172z6RjT4dHft8BiXzBogdVVwAQ8qtZ/5NDkkNnsVfY9oGAc/yON7gJOlHVW30XPuXP2lnjawnllNtv+GITWwhdhYrAuaFMnAm9TmWf1TJk6NDcUqFCnTYbmfbxXnlV2F3Lwmrv0d9qToXHp5N9JBN51JOavijSoGOmC6h4P0t0q3a9KqFTugYKYqgy4x0h81L4q5TTKIvXrd0JC9+FPGz4VaOo6FCk/Ze6Fw4q5c5gMFBzb82C89XCFN44cA3xdxjdZ4zZ7Uq7j0FEIMnhcfD1UN3FM9CNErZqP97sYthqk5wtgLL7YCy2gAK+Lsq7bvy4g7eK/OK/wdcKK9XR1VsyOpWIqk3bV6l3I9Nt8lLOm7eMI8suVqhpNOxNEGhv2QvzOipA+ojzqIPyaZ+RiN8E= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230031)(4636009)(396003)(376002)(346002)(39860400002)(136003)(230922051799003)(82310400011)(64100799003)(451199024)(1800799009)(186009)(46966006)(40470700004)(36840700001)(26005)(426003)(336012)(1076003)(83380400001)(2616005)(6666004)(47076005)(478600001)(40480700001)(8936002)(8676002)(36756003)(5660300002)(41300700001)(921005)(82740400003)(7636003)(356005)(86362001)(2906002)(36860700001)(40460700003)(7416002)(110136005)(70586007)(316002)(70206006)(2101003)(83996005);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 11:17:11.2767 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c8330e9a-3b30-4c8a-4b19-08dbca4b9d5c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017099.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7886 X-Rspam-User: X-Stat-Signature: nfzjd8gkhs9x1jwr7azt71ysp5r76p5x X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 150142002A X-HE-Tag: 1697023034-333134 X-HE-Meta: U2FsdGVkX18c05V7Tn/C66K4/bAAy0v6+42D1FgkrT7aiXcTpp7bejHsMySMU3ZeWIm19QkMuBnN4PLmLnjCTAfWge3FVbZaZbgxN4CCAKCcpEweY0BXxEVeKYixc2elLqAMNTNUeMFmFsxl6JtF9hRQ87tRfNOp3eAYYgEC0auU58n8fC8dPmRwuoDlKU+Zs7G+nOhqR3hQix2C0N48v8nCf/PggFNeH610Nbikvc/TCw4Jn7Zo/6Mesb4i9KCN1nYPvnDpSG3TtG3xUXIAnshgI7nq3fRiux207Zp5a2tpIkttPL4QqoGY5mqZw8W/Z1EJgnPdpzMr5uymbFEcLjhtO/KMjaV4qR8e/1DVMWAMwoAUT7m1qUI4BjgP9IWvihGzmHzHBYW4TLxqwoylzXc7sqap+JY+yGLhS7EBtbHa8xe7+rD7ZgPGXbgTkKirWPXLhhYzeBqttMaczNu+XdEcep93BSb6NcYEFvVZ9QbKlQDuG3sBQ2n1Ynnog3b0RghE5Pm/quOKqVO4Fo5ozdduOa0VaVNa6DwNekQhfwxQuANl2EvV2+u0K02M7x5fpXb25fCi013T4LiKH2lsMqM3rRgJtxExp7RIWZb1iHEw74HXRRWWptww75uIx2oHY+U5wj9veT9qcnh3qRPBkbdwPIWJLlhXJYG29lzQf786bEsxz9jepBIhCP/cs4p/sowbtJneemxIXoXSP/4Vw9k9/UNR1Vua2C37uzaPKnIuV6SoXWgKedqss0467GGED3ccVyKys+cA9qKTCrLmshfBGNpYp5ZeOoUh7JuXGjlJvGod6KRy9Y35XJgfn5NSWbt8lDSBfbrhsVn/Dj3/3VlX4Hg+AfkDlLnExWVAkF+Mi9xAth2fgbchF4mwsO7aJVGW9ID61W+GT6pOh5IWH6fuiAnzpLutZPscSRfjQo4fBBvc8Kg65WKNAXBDcVN7UYbu1bvzkJ/Vk/PO1GG dyb8Dm65 QJCze1/luHA0NrFJK1X4U/oLKokHNSYq+rR9RUl1suoila3+7KV1c+2iTT8LwVEWdG0kWDiGZg4Dqxlxn7YbXFIk2WgV0iqAJsVe0Ju1nK+wfVFb3GtphNH/nwGT5nSh/5FL3pf0pr+U8mVpGbb2SYat6f8Op9oY/syjnzEvNaE7Fxlmmv6ovGIMGZyljf7E9n3EjlRhLY0PvqBjYJ/SxIxJJpjjIBBLFr2u+SGODuDNDqEgnq2bjKSTdSTUsGTLalzj1gLz+8Z9Cj3GgCggaPIq+3fLIjFvJ1gaIQYsWkVXhzrAS6EiTnSr5FMKfItb1vIFi1Btzvp0H8BJ0sSTVczqAGQXKL2Qfkz0F7Lpd8U79MGeF2xKTli1xsgh7Ex7k5j1A X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Currently, in tegra_fuse_probe() if clock/reset get fails, then the driver prints an error if the error is not caused by -EPROBE_DEFER. This can be improved by using dev_err_probe() instead. So, return dev_err_probe() if clock/reset get fails. Signed-off-by: Kartik --- drivers/soc/tegra/fuse/fuse-tegra.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/soc/tegra/fuse/fuse-tegra.c b/drivers/soc/tegra/fuse/fuse-tegra.c index a2c28f493a75..98805885158e 100644 --- a/drivers/soc/tegra/fuse/fuse-tegra.c +++ b/drivers/soc/tegra/fuse/fuse-tegra.c @@ -131,13 +131,8 @@ static int tegra_fuse_probe(struct platform_device *pdev) fuse->phys = res->start; fuse->clk = devm_clk_get(&pdev->dev, "fuse"); - if (IS_ERR(fuse->clk)) { - if (PTR_ERR(fuse->clk) != -EPROBE_DEFER) - dev_err(&pdev->dev, "failed to get FUSE clock: %ld", - PTR_ERR(fuse->clk)); - - return PTR_ERR(fuse->clk); - } + if (IS_ERR(fuse->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(fuse->clk), "failed to get FUSE clock\n"); platform_set_drvdata(pdev, fuse); fuse->dev = &pdev->dev; @@ -179,12 +174,8 @@ static int tegra_fuse_probe(struct platform_device *pdev) } fuse->rst = devm_reset_control_get_optional(&pdev->dev, "fuse"); - if (IS_ERR(fuse->rst)) { - err = PTR_ERR(fuse->rst); - dev_err(&pdev->dev, "failed to get FUSE reset: %pe\n", - fuse->rst); - return err; - } + if (IS_ERR(fuse->rst)) + return dev_err_probe(&pdev->dev, PTR_ERR(fuse->rst), "failed to get FUSE reset\n"); /* * FUSE clock is enabled at a boot time, hence this resume/suspend -- 2.34.1