From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39587CD98F3 for ; Wed, 11 Oct 2023 06:25:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FE9E6B0259; Wed, 11 Oct 2023 02:25:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AE586B025F; Wed, 11 Oct 2023 02:25:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79EAE6B0260; Wed, 11 Oct 2023 02:25:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6BDD86B0259 for ; Wed, 11 Oct 2023 02:25:53 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 393B912016F for ; Wed, 11 Oct 2023 06:25:53 +0000 (UTC) X-FDA: 81332194986.10.B2BEDB3 Received: from mail-oo1-f50.google.com (mail-oo1-f50.google.com [209.85.161.50]) by imf15.hostedemail.com (Postfix) with ESMTP id 7014FA0020 for ; Wed, 11 Oct 2023 06:25:51 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=aMWoURhz; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf15.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.161.50 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697005551; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D4ClZHxvE21Enzoh0NDOpqo3NyWl05PNFYEBBDPVGmQ=; b=jA2v/vimzohDwOs5UoMIwIep/rIZA2qvxgh1AJ6gwAO8jc/+fU9202vhsHzL7mG8k/JWSR m1HP15Inei5N0IXXCR3cmY5EPZsGfXvlgZaQLBUNkQQZ5ffthUtJif0uxwrb+U+LzTXsc/ PWl62VqD8/2zpBOEdco3riWkpOXf1Wc= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=aMWoURhz; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf15.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.161.50 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697005551; a=rsa-sha256; cv=none; b=2BOHCb7ao9aLDigDKc3uOqp50H+al1JGk4Wh/cF188pnVeshY2CEeKi52JYd0+1rzJQyXZ icc+0eQbfb1gIRDCNMHB0eSfrj3PQxTQjn9Xk0HfdUWGdcUguMsLR+ABcRpwzKLPKs6Nzw blAAt4ITBoxCdsl0USYs+FyAKMN6W0s= Received: by mail-oo1-f50.google.com with SMTP id 006d021491bc7-57e3c2adbf0so3535725eaf.2 for ; Tue, 10 Oct 2023 23:25:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1697005550; x=1697610350; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=D4ClZHxvE21Enzoh0NDOpqo3NyWl05PNFYEBBDPVGmQ=; b=aMWoURhzLALjTjoSySl0Xuggmd5j7N4A386Lz9Yvps0dVdL+jIAxG/fHGTg6/KyH0i SDKIaSAbT75Cu86UtDIlNV0bLP9uSWFUm7eF5XSrhC8YNGzrAqjBZ3JSO6dSs1JzdkUz JU2TPMzUYG632d/h+yt3af+NTd5x4ArGf4BRw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697005550; x=1697610350; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=D4ClZHxvE21Enzoh0NDOpqo3NyWl05PNFYEBBDPVGmQ=; b=OvnFlrM/An0z9FGwlOCgQWPQB0Z5ZkP1EFEV+GgSAlaODYmQiWxMrhsiGuJ1KVdBz5 /PVcwhNPhsu9UsTd6w7f6iRfWMwi0z3U8QnsIVSOOZVpCKOslaPZrwHDQBuN5JVBmMj/ FriNoxSvgJrfqh58fW93CWoLoMlNqvnGqEWdrQHYDGEwxNqvzBLLEm2EKJDqVc23bAJq QAGtmyt315ZvKDQAdVAG8sKD3cMh7UTnXlgF1qQXhIHxfL+hDbJXD5pTDg2CIWWidVbA 2mXepFP7zWjAjHs4lWksMsuTIti5hH/EQXxZvRXUydHQoJOxTXkjgfnIUz0FTEK0KVUU fWiw== X-Gm-Message-State: AOJu0Yx2WR2VtlI59tVUPcO8KiaNWsizBpJMJvdBo7ZBdW7lehYlKZET yd9LrDZgI7G+Hy2tlEyvpp0tXQ== X-Google-Smtp-Source: AGHT+IFvKf/U5CmXy8Q1+bKrazh4Rpabtdcd9frQEkONxvJ5Wk+J8E6ZqLlvXtpa02YyayHqvr/u6g== X-Received: by 2002:a05:6358:4188:b0:139:d5f0:c027 with SMTP id w8-20020a056358418800b00139d5f0c027mr19171517rwc.30.1697005550426; Tue, 10 Oct 2023 23:25:50 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:6f7e:c4cf:6e5d:fcff]) by smtp.gmail.com with ESMTPSA id v1-20020a63ac01000000b0056428865aadsm11130128pge.82.2023.10.10.23.25.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 23:25:49 -0700 (PDT) Date: Wed, 11 Oct 2023 15:25:45 +0900 From: Sergey Senozhatsky To: Andrew Morton , Jiapeng Chong Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Abaci Robot Subject: Re: [PATCH] mm/list_lru: Remove unused function Message-ID: <20231011062545.GA2866435@google.com> References: <20230922100747.17045-1-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230922100747.17045-1-jiapeng.chong@linux.alibaba.com> X-Rspamd-Queue-Id: 7014FA0020 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 5btukd7nwqwsd74gqqnms6rxwjk3csus X-HE-Tag: 1697005551-112839 X-HE-Meta: U2FsdGVkX19/9TEtvVZUBuvXniETK7bBMT816XJoYqbcsCzAxCgLJf1tPiFTEMJ2LbxUKjQxaNCXetc/VYQ4+Wm9pitPAbtiBP1yXrAdUQFkGlFQLDpiT9Hx3Wu3c2FWrJ0wjNxcfy8V1LLEIKd2Yayo+HcQYjGIkl2Ncxux7LVBzy6fMIWymretAPfh5AJyR9upQwrzhWigE/6iKTdmDcpwHmKIJOpy0Xt+8jOpE8hJ2NSzZsgAj5vWtECFpxSCc6MAEqmqKdChjVfbXZbjXpKJvbZCjsrDf4aw/zL+y172Bz4lvvzka5VysK/zvcYZ1dd/1Ezuty/4M7LhkCWRogw6mcqF+GEPvx6WWOZyGqvtdIRUv6Hw8j9Hz2kO5rtFbhz7WENqFMCgqg+ReAfHL7zwaiKDsjvu6ToF19NQ12IpKFb8WRzj5Q3k+qraFYdscLcSQB8ZJALf0Q83nboCBVzrvcxpWBtubvLelnihKpxkmF+NO+zDqBCYthzuAmWytppbQqjvusHP9oGU9CU8bDWcsdCdI5JTMq4yGV4Mzku+wgSRt+k8nM5/a400ecUS+i4OwpbQD1uqnY0CYDMwNXamheoRocNbIJTM4rdFrVHx1ujyUO2YcbF/VedPhmIfSryMGw8KG1Jf+G2dW6j45XjdiDlRBNEis/jWS6dKcPhUhpXhrxXJuX5o6kXUbP9U6g8GWRQ1ZzcHmHn5E2hZNzIsFc6K6r+AAxgwo1Ydg7wNCpxbdGArvUOwnusOx5S4pYJEA8Nu2+LJWLg8Go1FlDuFGizJVa/8l6gHaXzxJxa+S0pAScEXanuv9GR/QOG+KpfAbukBH1i4IOWCvIEaJcSa5NkYAhUOlSJpT5syUxQEHootBs1IBBguOdB+c7jFKfMmf/pzSlfnWWZzd1/3lWh6kxizO4hI2gI7Ig9HSD13J/lMDrN8GsT/jsJQu6Kn1Y0z6PX7F2dBAZhrHFT TzMzMPXa gqI9Sef+4ayU2rCt7WM0czoMVs4lbPwuHzGd7u9EzJZE7b8/Ecz6zi/9/B/9DHtf5nroM/Mchpkg3yEaRZpJ1uwGVe8NuGnG65nJ+6dA8JbgpVXmuLZ85KIE6bcs1cBCuUKi4NkaQrg9uglYsDtghDLTm049+VuRGhIsTfjf5oo+dZfz3ePutV3hJttAWqV1rMDJOk6U0eZemsqCYQbV9pZw2NMlNYkF/UUkf5oZwH6OWGXxj7RCFOtb0mzpvEyzvOomuaiubeoP+SbDfDroMlAZoWuCtw0n0BNIG91XIdJ1ypvIhg70xLda/tuRlZqo8vSZg1eMOkNv8NDfl65MC0BQkAX6iECDbu8b6p5fxDZGfdY0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000731, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/09/22 18:07), Jiapeng Chong wrote: > The function are defined in the list_lru.c file, but not called > elsewhere, so delete the unused function. > > mm/list_lru.c:64:1: warning: unused function 'list_lru_from_kmem'. It seems that this breaks linux-next bisectability: --- mm/list_lru.c:98:7: error: implicit declaration of function 'list_lru_from_kmem' is invalid in C99 [-Werror,-Wimplicit-function-declaration] l = list_lru_from_kmem(lru, nid, item, &memcg); ^ mm/list_lru.c:98:5: warning: incompatible integer to pointer conversion assigning to 'struct list_lru_one *' from 'int' [-Wint-conversion] l = list_lru_from_kmem(lru, nid, item, &memcg); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ mm/list_lru.c:121:7: error: implicit declaration of function 'list_lru_from_kmem' is invalid in C99 [-Werror,-Wimplicit-function-declaration] l = list_lru_from_kmem(lru, nid, item, NULL); ^ mm/list_lru.c:121:5: warning: incompatible integer to pointer conversion assigning to 'struct list_lru_one *' from 'int' [-Wint-conversion] l = list_lru_from_kmem(lru, nid, item, NULL); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2 warnings and 2 errors generated.