From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DCA9CD6135 for ; Tue, 10 Oct 2023 09:54:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 90CED8D006D; Tue, 10 Oct 2023 05:54:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 896EC8D0002; Tue, 10 Oct 2023 05:54:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 736408D006D; Tue, 10 Oct 2023 05:54:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 601888D0002 for ; Tue, 10 Oct 2023 05:54:38 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2B28D120233 for ; Tue, 10 Oct 2023 09:54:38 +0000 (UTC) X-FDA: 81329092236.16.63B2EE1 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf05.hostedemail.com (Postfix) with ESMTP id 794DE100005 for ; Tue, 10 Oct 2023 09:54:36 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of joey.gouly@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=joey.gouly@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696931676; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ebWyB1gfxhf6CWmmwP/Ai7Pi+cBg66bkztJisSUmyFs=; b=KJ7oMqzGkjY104c9cyATjedtJb2hak5/fnNWSIHAjDxwWmztmK5uuIftg+FlChK/YHyx6j t4MJCSsN7EKLl1Wv1eXcFog1lgyXUNDP4EDbNivJRrMCmLvhnN3xLU0dFR9rZ/EBISDseo FoQ3y75Es08DADzYht150sdgwjpeQ0c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696931676; a=rsa-sha256; cv=none; b=f59Cg3nMtW0OODJ5ca4BrtmdHKNo3sAeLlsPcYXl/BukaZfIsr4f9OZbB3rsbv6d9J5G8e 5cnGsqGCCPgm/AH4ujrcFKLDanC7tx10RkqyQx0snHHU1cJ5dVfreyLGtkeX+K98rdpwgC WQL6kJI4mEUu8ihDLIDoc8Jl/NL8qqs= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of joey.gouly@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=joey.gouly@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 344C01FB; Tue, 10 Oct 2023 02:55:16 -0700 (PDT) Received: from e124191.cambridge.arm.com (e124191.cambridge.arm.com [10.1.197.45]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 96DBF3F762; Tue, 10 Oct 2023 02:54:28 -0700 (PDT) Date: Tue, 10 Oct 2023 10:54:23 +0100 From: Joey Gouly To: Mark Brown Cc: linux-arm-kernel@lists.infradead.org, nd@arm.com, akpm@linux-foundation.org, aneesh.kumar@linux.ibm.com, catalin.marinas@arm.com, dave.hansen@linux.intel.com, maz@kernel.org, oliver.upton@linux.dev, shuah@kernel.org, will@kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v1 05/20] arm64: context switch POR_EL0 register Message-ID: <20231010095423.GA2098677@e124191.cambridge.arm.com> References: <20230927140123.5283-1-joey.gouly@arm.com> <20230927140123.5283-6-joey.gouly@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 794DE100005 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: c54945g816r57u67or8ukggwp9kwep8a X-HE-Tag: 1696931676-26144 X-HE-Meta: U2FsdGVkX1+YVyPDBbZc2P6v3TQ8Zr27DXYnojHuI8Jjo7aTdZ2tnRXH+tNkJVsQaVMy32N5TfCYUMI3QeE4WNMCuaxoOFOLyyGKW4I6p5jKKsxU5f0NipE8g7Ukjse0o46q6lhvEK3tGobk1H6RpQS/xZ6xYLBpw68NBBqEmUQIDRDnVZCqiDKPP4hLPDlFOzEAMqaVbquZ1StjrBwiNrBOjEhifCdPsT5z36jJ7nOonm/smQ422St5lha8yWLT3c1NcfHlUUw+B6m4ml2hWGd6Iaz0wIZN2sWJ1TaTqj5HJ8r8Qyw0lJtOs2uR9eav2pTxXXg0S7/jaF8ltg8V1l176Gin+cNKw9orEudXjYnX352xM+glSSQ8YePpCiWoeng7PxrVonqYUoI76kw/sZnTrCNquB5rF2JyqPyHnBTTQNUD9O3VDGMiEGR/Nx9rN24Yfo+wo8X3+G5lDqjnXZuXDAdYXMTaBrH9bKM/3iG11hhXEg3NWvRT9vGxw35h3V91Y0UZ7KAwzKZ15Nj6mPXnJXVjEpej3d6JRaTnoPCy12PHD5nZEV3RiuewM5CrdvUKYHbQlIlFTV4B0YjoeXYtx46+c1rzeFTj6iR8K8Hyd+5HyYe7E+fl33HR/rMiDVl8LBpwjV5bWuuQAQPCBLzaUTr/g04+vdf8MzZpBNGd7HPAl/9fjQ0A1kjx7Jhv13etRjEniloGO5sM6ZHS9fyHDZekJYPgLqlxpWlV4ulR7cnFvJW31Spv2p6/7tNdj818l9azcamgDk/l7noxE7AQM33EJ061A5DXRTGBoRd97RqT9SqNypUicuxkkpMhr9gFCPlepG0CH1CfsAqKWyndBnEtjH9ev8zoroPpCZPr+VNJxuhK/+PtvwLRcTIpGuYxBKNKvATsek4nf/qgEhJMpVT103JEpvNSVB5oXxNKs1IyUTHXHivETj/+laJqwNBQKX4lDYnbuDrFziN 2jBXngf/ tYPf8mH4r8cc2GXDuwxyepVxo0HHOZv25g2uGvTDEXbUwAmro+Djcfkx2+ubF/XZn280CTKduRYlIhsYmUAGAU6kAnk+FjaZGj4I77rb27/IUc8g/xJ7oL+MfOPUXqOLrUgBDjmeVGO99pb+/wxlc/RZAjAGI9/a5YWLmKGLmnKaC3enNeK6+e3UhisnS+uq5UmL+9O5gkBhteA/xYBS1iov8jw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Mark, On Thu, Oct 05, 2023 at 03:14:50PM +0100, Mark Brown wrote: > On Wed, Sep 27, 2023 at 03:01:08PM +0100, Joey Gouly wrote: > > > +/* Initial value for Permission Overlay Extension for EL0 */ > > +#define POR_EL0_INIT UL(0x7) > > Might be useful to explain why this is the default (and possibly also > define in terms of the constants for POR values)? > > > +static void permission_overlay_switch(struct task_struct *next) > > +{ > > + if (alternative_has_cap_unlikely(ARM64_HAS_S1POE)) { > > Why the _unlikely here? The only options are alternative_has_cap_{likely,unlikely}(). I went with unlikely as currently it is unlikely! Thanks, Joey > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel