From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFDEDCD6117 for ; Mon, 9 Oct 2023 17:30:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 368B380030; Mon, 9 Oct 2023 13:30:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F18680027; Mon, 9 Oct 2023 13:30:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 192EE80030; Mon, 9 Oct 2023 13:30:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 062C880027 for ; Mon, 9 Oct 2023 13:30:20 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C0943A035F for ; Mon, 9 Oct 2023 17:30:19 +0000 (UTC) X-FDA: 81326611758.21.B5EB665 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf20.hostedemail.com (Postfix) with ESMTP id F36AD1C0004 for ; Mon, 9 Oct 2023 17:30:17 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=INX4ASZN; spf=pass (imf20.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696872618; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nqFeXdTsdXnrGEfpMKaOYWvyyqyMyHQmVgLTGloIgo0=; b=uz6tnLetrkp2WFyE3HtCIaxXgp/HTiBpbSR5HT15EFZIy+CTFVCgiRxnPcfakeSx/9EFJ3 bGisbO2Tkh00PZuWvCNScHnF899U0k8B9rH7DiinW0/s6keyAJCVtgQytRr9xlE2thIzNo 2vXpLwOrnB6n6q3SJuRseWlaoO6v2j0= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=INX4ASZN; spf=pass (imf20.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696872618; a=rsa-sha256; cv=none; b=W1jmeQBSURkbHgWiyfhwxB4pvTQyUfmVuvbMLhSx1W6Ed5NqG4SGnbj3+QGYI3FFS6sh8Y Vt8anvM6gtQ8G6bLYEKxVBQqMl74NMNvnST4YibFH5LM8fCulM74m8dK6mKGHziKkCac0B c2ysFjamXdidO9gyGmpPnCZPxZ9j9Is= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 7A6A6B815F9; Mon, 9 Oct 2023 17:30:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2A51C433C7; Mon, 9 Oct 2023 17:30:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696872615; bh=EACK2tmq5+41Js6GZfBr/J8+BuSNLbbDDNpHvCryNec=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=INX4ASZNRg/lD8oCQEsXmK56PSVK/sEm9Mkl83Lf+wu6Pq6XbuVOt8fQHRF/LILAS fvBuviO4505VLsdbEbjKHnZpR9i3YN6+G42buKLgOzK30gks9PtUCHIIpMAGmvnre5 RidVSyLf/g5j7I1uMYVsSeIjpRqPCTh62O5WpvbM= Date: Mon, 9 Oct 2023 19:30:12 +0200 From: Greg Kroah-Hartman To: Max Kellermann Cc: Jens Axboe , "Rafael J. Wysocki" , Ilya Dryomov , Dongsheng Yang , Dmitry Torokhov , Bjorn Helgaas , Rodolfo Giometti , Alessandro Zummo , Alexandre Belloni , Jiri Slaby , Mark Fasheh , Joel Becker , Joseph Qi , Andrew Morton , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ceph-devel@vger.kernel.org, linux-input@vger.kernel.org, linux-pci@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, ocfs2-devel@lists.linux.dev, linux-mm@kvack.org Subject: Re: [PATCH 7/7] block, drivers: make lots of attribute_group globals const Message-ID: <2023100944-sandpit-bronco-3db4@gregkh> References: <20231009165741.746184-1-max.kellermann@ionos.com> <20231009165741.746184-7-max.kellermann@ionos.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231009165741.746184-7-max.kellermann@ionos.com> X-Rspamd-Queue-Id: F36AD1C0004 X-Rspam-User: X-Stat-Signature: smtdkbxq7zu1rn6hb4hww4mfmm6qebmq X-Rspamd-Server: rspam01 X-HE-Tag: 1696872617-993215 X-HE-Meta: U2FsdGVkX19uILG5jM6KHeNS7KTcuHFAxOZ2q3JzR7GIlP8yvHitoQC2XpH6FtTJzYvDqf1yLArC7uAw1IHVRt48D7yOsxd7+A+OpTd+TnHbPDE+07ICYvtngRaqz9zHLKgh1fq8MbPeOzOngMZn2Bdvbx6pTvEqaxUx1C829nYyjvYw1u8UQ3Q0etA1K1l1eqCDfZTgwyutkp+lLSrmUFSVKFzDbzE0sU4RXlI1WuJpETGk6s/+c7fYACJJF9AdnmbI+jvCjbl+mGg6ytKJ/uZ+EuSAUF2Q0fvvPJlVfo+HTPdZeVzYlQpx63Arv4TRQpesD5POfZRGbHPYFYlDiT5O7OP1exjvc1ZGW81UKllY1HUoOYWWM+LmjgpW+KoAZgy2mc8FSxRIjBTn6mM9VKr+OimHtTgT8rSfV1iK/0vk7qBrDTSz1F4JZ5r/zBEwZ6jaNTNlxSVPS+H1tWiQJvqUQ36HRnMVCCqRcwdQVa8CQOM8vlulfMhcSfC9JgZJhFfu912Ku49YY+MFPHQJxeyGkG3gRkQ7REhPKEmk7rK9pL6ikwquWNsNKzsYhkB6QMx11VMIyb70M2r4DxqumGOoEZbqA9hjBiKH7fv/hSWHvu35dAwD2+amNKT4FZcyChVpxG1r+w+zUQGOmXktX9udQ1stgtn6X9wU6XXo9Wd69w2CZZtJlIvB0JrhQsS/zY9uiqS3Ih9kKfwdX18kPPa06qDmUOdmi5Qk0CyZe9W0EaGLqmR2l0TXDXcd5gLp6mUutiYYx0TZ6R8IwZtE1GCS7XuRcWWvkaqvlR1eN7Dpoj87dEWdWLYD2i9nGJHD/qD2LgBVCrxgX3/bZ5q9sALmsZ2HKWt8nHqw4TJA8xKp4ftDjS8hbB4UYMhKR04V8KA9dRyy6FmU7ra8qbknPpiHJngC7b36v9oK4oYnhjZSa9qINfSEcSqcr5Cb8NYgWWAb36O47Nb6KcNMy8t rhQFVrl7 wGTXuYKF7ZvNRRtzUMJkAa5BEAeT5aGOl694qIkutJqWoKOsIa2gqd9PSkI26MJEuzwknkoIQBPrdazoN4c68R5OOoaCEaxMKI65QMAtFsuZK0yBmQnujEHynxJi4b3UnLKCF0mEg4wLGnxtBL/cGYnDbTTQhXMj1HjWlo1S2Xv1DIASbJKrDXPZWpUC61cwnZBBsY0eXp4k30ye1ZTrNszBxuan0N39/Gc5x/gBk1ofM5HtGIfYf/mwcWF2AIPb54vfQCOxty7RWmCD0bNO2HOkIYEbqxcj75uymsdcn/fyGZjWbng5HGR+Z4sgHa77ZBKPvQQFgcp8bdUT4hlU8PpeMxg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 09, 2023 at 06:57:40PM +0200, Max Kellermann wrote: > This moves those variables to the ".rodata" section which reduces the > kernel size a bit and protects the variables by putting them on > read-only pages at runtime. The kernel size should still be the same overall, you are just moving pointers from one section to another, right? If not, what are the numbers, show them please. But step back, are you SURE you can make these attribute group pointers const? They are modified by some subsystems by adding or removing items from the lists, so why does the core need to change for that? thanks, greg k-h