From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A615ECD613C for ; Mon, 9 Oct 2023 22:16:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B939D8D0095; Mon, 9 Oct 2023 18:16:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B439B8D0089; Mon, 9 Oct 2023 18:16:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E3D98D0095; Mon, 9 Oct 2023 18:16:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8F6868D0089 for ; Mon, 9 Oct 2023 18:16:38 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 78748140412 for ; Mon, 9 Oct 2023 22:16:36 +0000 (UTC) X-FDA: 81327333192.11.5AC0714 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2078.outbound.protection.outlook.com [40.107.237.78]) by imf13.hostedemail.com (Postfix) with ESMTP id 94C8A20009 for ; Mon, 9 Oct 2023 22:16:33 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=Qs1sEQsr; spf=pass (imf13.hostedemail.com: domain of jgg@nvidia.com designates 40.107.237.78 as permitted sender) smtp.mailfrom=jgg@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696889793; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v+fb95RthJG0urcwOHSvwbioZb5AozS2rN2Seh3T3HA=; b=0YwyZqBuzwYMSFzVBv1K//P+uVmGAvf9b/f7NO0dHamfPRCFRqqG2Qr6Ro71yxoL2ajbsr IGRr3TDpmE3mJ2GBcUw2+KfHNYKXGyw+2jgWXznAfcSfF+j3VMuPsnjziVObq29yuVxKwI mOy5eOc7KRpZScpxujH6V1IUOch2uHc= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1696889793; a=rsa-sha256; cv=pass; b=FfTNs2fziF5FZnQ3vpf68vVS8pbqWsgVRDCZjfPtmFCbrP/zBL+gyThgLTJBHjUfG92gPA OMqzc5FxYKVQBezaz9TvszkS7EJh03IUZz2HgL4QFOoIT9yRluUmzIBO0mUx7ZfGvJxh10 68wzkNGNIBPX8PvQAd12AFjLGqYZHzo= ARC-Authentication-Results: i=2; imf13.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=Qs1sEQsr; spf=pass (imf13.hostedemail.com: domain of jgg@nvidia.com designates 40.107.237.78 as permitted sender) smtp.mailfrom=jgg@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gsqbqv+uwpVez9RFImjhD+VmSrXuPfgdDFQnqeQ0L1Lm0WteC4HMWLiorquQCsM/TeKN+IYw7/EZrFuwsJyEzGzEa1I/N3SqPlTTs6MTVD4yqQV/ZSgqEYslq8MA/lYUrbCiqmjK8hJonKgjYhsuUZNOZdCaz2IFztJt/xuHW+8jy/6Y+uv0DKpwWhoi2sBsoSdFnl0sY80z9j+gTYE3WpfzARq/u/9XkpCl7vpKY58A+vwPXx8ey852MjrCI8gGvPiUQfvK++GzWwXbl5cxnfSa0V0iSpKjZNXzgQTLkuMofDbZNUQMzE0gxJPdx9+3vRZrHd23/OC1+bhgZXnZ6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v+fb95RthJG0urcwOHSvwbioZb5AozS2rN2Seh3T3HA=; b=mYM1xp61hIGVnQQEcMwDvh5Ho/zzGXVparWRJN5lKE+uCaNdPIMbWqyYa7duKf5ydB0Ls8F93S5YM7U3bDmcjiv9Gv2tKBLRt4kueU2qXpJxxR9z3X4dEmq1NxwrbgruhYvXKROie0h5xig4mdOBIN9FM8shtbVstxDvMHz1P6sSRzgElgZGfqfnE6lwIdj89aayTqHfwehLjSFPeEXUmfyrBGwU6EK4Glblr/JHfH3SWmvP3ZwlTy9vv0ZHTZ0Yo6uI8yoMY/RpvumSDk/8kAszM6+FvZG6tk2/CAdlwjS4sg/JmWEwMey70if1f2DSV7+rz2omySJZOPMZj8uFeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v+fb95RthJG0urcwOHSvwbioZb5AozS2rN2Seh3T3HA=; b=Qs1sEQsrafrYpOrsjPZQAUSZKPpruqgPdzS3mBjIzNLLmnZGSd9ljBMQK/7SPLdVhxP+uKxf756zQqjwdXIjDGYD3MJzakjJAofSnppo0jnh1mC9NnvzkA+/XCSIEnLmSyXbcSGxFc7zewulnQnZg2JuJY3jnO/SaDGYNsIkgS0oNTpWzZforWj3m4k1WVYFvFy6/ut9wzvZV/+JRf2hnRIL/NbkzsIGwpsOpfzfB/8dc87m1xWCy9yRsM1I0/YZKSgwjOcnlp5GMm4PLf+ZE5s4Q3xwsMg1+UUT311fdBhmFZGYBqi+uQVBO2X6PQPsG8QkKuF7iYLiv2sFwZ+kbg== Received: from LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) by CY8PR12MB7243.namprd12.prod.outlook.com (2603:10b6:930:58::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.36; Mon, 9 Oct 2023 22:16:30 +0000 Received: from LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::3f66:c2b6:59eb:78c2]) by LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::3f66:c2b6:59eb:78c2%6]) with mapi id 15.20.6838.040; Mon, 9 Oct 2023 22:16:29 +0000 Date: Mon, 9 Oct 2023 19:16:28 -0300 From: Jason Gunthorpe To: Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Catalin Marinas , Will Deacon , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Oleg Nesterov , Richard Cochran , John Hubbard , Arnd Bergmann Subject: Re: [PATCH 1/4] mm: make __access_remote_vm() static Message-ID: <20231009221628.GB3952@nvidia.com> References: <70436dcf596565770e604a4fc4e8f27a14c85166.1696174961.git.lstoakes@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <70436dcf596565770e604a4fc4e8f27a14c85166.1696174961.git.lstoakes@gmail.com> X-ClientProxiedBy: BL0PR01CA0018.prod.exchangelabs.com (2603:10b6:208:71::31) To LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5869:EE_|CY8PR12MB7243:EE_ X-MS-Office365-Filtering-Correlation-Id: 88792e18-32d2-4f5f-c4ba-08dbc9156303 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t8tlXyGPFuRG6coA/mdsXUQDHLL2ZghWRUkUISRNGT4JbFYcCNCVGhWkclAkwDFovb7tfTx3Kqe0D2Tl2DzHbJbONtiB7B+3yNx/RtznoYTV0GOokmhJ9fxAlLZc9NqY7SBmASDnywuPIVfWUg3X4J2v4pgJJCObf49oMPcpv+pDceWGefVhLXhR8xXWMKEXbloHZ6oJzAjJl5hOW5hgJhvPzeuRwrvBZ8l0Hoaygx8N8FKfodQ2chbj2lOk11AhK7CWg6fwKEnj6A9/p9W28c4FzTXPoWX76vaw8SvZY6I2KnnUWupt6gl/Boutst/gavuQXeTWWEEfRsdoHKmke2nxULsgQIu3AbmEFa6b6LVNikl+eOeeqZpa43aZIq1C5DwQ7XiAPf+Ixos+mTZkyGR02PyhwslU6opZqwviREQAzKKCxs929z07RG/gbM5ANptGl6NVLWx0E8gBDcHEq31n11uVAqF4a0dlYpYan1atqmhlj+wUKRPgJHQ1HbjmJBjDUI/F3rs8XOq+mOCRj9Yce2FLSTQkHI4HZjJTzvgI2oGd9cRVzoXhhaWSlX/4 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5869.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(346002)(376002)(366004)(39860400002)(136003)(230922051799003)(64100799003)(1800799009)(451199024)(186009)(2616005)(1076003)(26005)(4744005)(66476007)(54906003)(66556008)(6916009)(7416002)(2906002)(66946007)(83380400001)(86362001)(36756003)(33656002)(5660300002)(6506007)(478600001)(6486002)(6512007)(8676002)(4326008)(8936002)(316002)(41300700001)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?q5lWqJbNjXSGImesy5kbTpuFiPOWO9p4g4z7sQfGAQL0mJrwzxPa9llcEM/Y?= =?us-ascii?Q?CbQFTiBfq/CD7VwnoyTcUe4nPNJQJyrQj0t5YUgcsT40i4KaPNcqjLpPcZDX?= =?us-ascii?Q?uALj0qiFT7WrPCZJgsiBS8+mp8wINJbeOK4c6fLfvPypHeDA3FeRUjn3tngg?= =?us-ascii?Q?Pva5okLbxHl8y52fxNWMYssRfiWNFilrUCfCEWfImr0kLKH3KCNnte2X+8CM?= =?us-ascii?Q?/eDQ6/rlSD1109YopO6CFhdp68ug/UuOOUSwUlMx33i6JyFcffcnGLgNHR+S?= =?us-ascii?Q?Kuu/26UKAC79a3xZmLDSDsI8KZnUwSgLBcegcBuXViVgo2EzOEYvGDIFq5gF?= =?us-ascii?Q?lyIDM5zGhmVVGDqQBXAhMC2z6zjUHuFyz5k1AQ0W/wsrXWyrXOZuNJuOe15u?= =?us-ascii?Q?fL/Oqc3cfhHj8KFlUINiZYOsy5Lpx9ZK95aJS77M738TXr0R/Pt3j7tPBwFd?= =?us-ascii?Q?W9nc8iWboDaik+ZfYUqx+QNVa7rxqCRFmAq1pWRQFl81w5Mc0RR6vscE1+kE?= =?us-ascii?Q?Bn+gVgc5IErRsYosS2Vdgrr2X/Cpui45mWhJBkKqcRqJC7OAhZY7vC/Ro/3e?= =?us-ascii?Q?OO0OB9+CELcfo6jD9HQXJ9U+zPq6Uu3XwhCBi816CSMLn/BVrUJFHdHwx8IE?= =?us-ascii?Q?bkjz8QgjchBueSVBbryA1fuv0EQzlXDDfb1ehNuks2K/ppIxKjiIZsca+Zcv?= =?us-ascii?Q?Njib7WzV9byxFgPfdKbIcqvr+rgnnbX/P6p73+Xi4vGzpafyf7uYjHysoDf/?= =?us-ascii?Q?+XcOw0Fum3iCl236+Z947hH/skxkzEbXJxuY6wvMgSKZBAO+aBDn0ETkgzQx?= =?us-ascii?Q?NYx9xE2bz5yhdeJdwiwlAS3HtcVsFgzTRprfCwQViwLdvgMjx5AUXaZRPk7G?= =?us-ascii?Q?EL99ZnARTnJkr1pBa0LnL7QnIW/ExFGj1TbQMQbOQfCHqJCEwG944EE4pSCt?= =?us-ascii?Q?omWqz33RP1jYJI3SnuA4Ire9TZpLIS2Mt7o2HSIBa2aUcDP3MgY8aW+mapYn?= =?us-ascii?Q?6SqfSEPYKct5lQUC2AA0+ooa4jpzbH8ZDtoi1SVw3tEGA+yPURV2ndXQIrHQ?= =?us-ascii?Q?BZKpNCGKpfqMezviz7gDCAH2tPARsfNyP4cYKvAWHRw+J0SlL69RhB9KjI0c?= =?us-ascii?Q?J1+Lk/n4uebZiPpKEYbdmGFs+ZBxWNY39iWav64/sZbhLIGdoc+6+qZMFSQp?= =?us-ascii?Q?PZwjy4rbFPbVjwiitOXQ1wWX/GRMunXh0Qj59bUltlOZs9vffbDE7w4X3iHN?= =?us-ascii?Q?V6YLK/vjW5M/g26/eCxERnYAZuJbDGylcfpiW4fj6OzwzzGsnfIpf6H8N9Or?= =?us-ascii?Q?tU11KoF0ZoESmnYUFTGZ4GD3dY5v4XcrraKqeanwysRqANBpsAwmZ1R/dXEP?= =?us-ascii?Q?hmX+RwRff7w18SdA5CmbVWnxoDdwkwJQr1Dr7OCwgeaIO7Q2R5vhK7nwzBHZ?= =?us-ascii?Q?P49lD6Tn0oo7qBcmSBMNyQwd+ryE1aOzxnorGltmxCQHAkoD3zRZKThYGPR6?= =?us-ascii?Q?mU6EnQtaM9BV2fT5sUy4ww/y5EjPkPSNnQDg6e9kFJUKZk9wEbGNBSXzlOtL?= =?us-ascii?Q?gP4fPf2bSSBckz4KX94=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88792e18-32d2-4f5f-c4ba-08dbc9156303 X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2023 22:16:29.7737 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6vrjoiN3uqATtwiXxFSvhza9ZjO5ggyl7xX2lykrzAacYY2ST1M2jzdhAKGYyGmE X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7243 X-Rspamd-Queue-Id: 94C8A20009 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: k57srti8bqxhrrir47duj7he7e4paock X-HE-Tag: 1696889793-741791 X-HE-Meta: U2FsdGVkX184Wn8P4rc9cC5Q3vtxsYoaRuLbYSpiuj4Knh56z+bToTD/EfpwkNdgvBDOZxXnTedSbZzxJmTKeQuj+R42R/jDrpqcvQMvYNY3r+jAOIvabRomh9ajxFwu6zLyUDRFU4902mHXSXolMlRugMXcENBtGgZpJCZLtzXIURXIg33Ghkl64soS9LjnB8YtOJEZgfhGib4ixKIcm8QONWM223OGMW/TMVjNhLgQiyVadgVYW72iDWF2N/+JuRPWAVZkco71eUvAoegNEsT3Ko1UTUAR/zrEHLjrJa8fYsorMKQ/iSHofDf4s8Abg/TH+DrWxjW+0NQzl2OJohvp0sumwYKQPNalV63rgnJQdvXHqicBq863qMo7avxmTZI/HF+KwLWmRL95JQDzHffIErHY06ZL3M0RlsppXjFhoSsKb0WBOCnII3szYJNDAwd+Px1k+tjHidVUQyt7fXsHgUk064xocf+f4etZ7vHQbMTFKBF4hrV/TP5nZlPSs12OiTk4ENR44UDpvOsBTZ/HuhMzQ/J1isBWn+IDzoLBz/Bv9YciyfoonYmHa+dAdXKlNr5oH4I5KbYAxnE82b2UD2x9E/SVIXVoyNFQOdnQYLLCH3pfk+nzQCTlNjJ9urY0cVr1k9a2A6i36Sjg8P/NRYDtjxoUasGrhDiLR34Z++b7gONcdngP7Caaocz0CG7kZukuq4OUcHdUkRhJfZPj8ShzezsSLAM5FQzvvlImVZMr8Km0Wb9/7pxyzStZLQ2dSVcoDua76bzze1FoeWSpnPbZTFXtGuOS4UQrvNE45fXkD44+JGsyD4S5N5a/fV+IGh8iV9dY7DPBZs4xfqUXMpyYGsbD2Lqz0CsrkGiNmPsiC9cuBf1fIQQhPrcmd6Sno5rvjoPj4QyNevaGa+i3ZEMRx0BL7uYsgJ+g+golTW6JpRSdQjqkN3ZLuSklpAp2cQ9BL5E3M5/8i+t 1ht+I0pS YFdSITQBFzaAKlOj+7fKt0688r0oYWmBTI+O4s0MqZjBMpqXXbV3sApZGhy+vVaRis86y4K50YHCvQhXVfI98dOIDCgUaUQhEs5P8xyrU0LlkdOFrzLNRyfJy5DT3KoG93lUW1nbsYjcKpxx9SAqU0eFiWFluf73CEAOgdT1H++WjpzDTPFKu63ni7GIxGHeU2ckq6n8INT9t/MKn84L9dYd5URl7uyU3Zuz1bz/jIeowrCRYoCiPNYcjzZaL1WNa+tUQImcXDgzez23vD15dMFJOLB1+bbPaRga7WUzO8FuqQotPQOPcEpJLqEutnIsRoFrvPgfJi4LaxPg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Oct 01, 2023 at 05:00:02PM +0100, Lorenzo Stoakes wrote: > access_remote_vm() passes through parameters to __access_remote_vm() > directly, so remove the __access_remote_vm() function from mm.h aand use > access_remote_vm() in the one caller that needs it (ptrace_access_vm()). > > This allows future adjustments to the GUP-internal __access_remote_vm() > function while keeping the access_remote_vm() function stable. > > Signed-off-by: Lorenzo Stoakes > --- > include/linux/mm.h | 2 -- > kernel/ptrace.c | 2 +- > mm/memory.c | 4 ++-- > mm/nommu.c | 4 ++-- > 4 files changed, 5 insertions(+), 7 deletions(-) Why do we even have two versions? Reviewed-by: Jason Gunthorpe Jason