From: Sidhartha Kumar <sidhartha.kumar@oracle.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
maple-tree@lists.infradead.org
Cc: akpm@linux-foundation.org, willy@infradead.org,
liam.howlett@oracle.com, zhangpeng.00@bytedance.com,
Sidhartha Kumar <sidhartha.kumar@oracle.com>
Subject: [PATCH 3/3] maple_tree: use preallocations in mas_erase()
Date: Mon, 9 Oct 2023 13:16:39 -0700 [thread overview]
Message-ID: <20231009201639.920512-4-sidhartha.kumar@oracle.com> (raw)
In-Reply-To: <20231009201639.920512-1-sidhartha.kumar@oracle.com>
Preallocate the number of needed nodes before mas_wr_store_entry().
Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
---
lib/maple_tree.c | 21 +++++++++++++++++++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 25ae66e585f4..ef8d4b6b4456 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -6191,6 +6191,7 @@ void *mas_erase(struct ma_state *mas)
{
void *entry;
MA_WR_STATE(wr_mas, mas, NULL);
+ int request;
if (mas_is_none(mas) || mas_is_paused(mas))
mas->node = MAS_START;
@@ -6200,14 +6201,30 @@ void *mas_erase(struct ma_state *mas)
if (!entry)
return NULL;
-write_retry:
/* Must reset to ensure spanning writes of last slot are detected */
mas_reset(mas);
mas_wr_store_setup(&wr_mas);
+ wr_mas.content = mas_start(mas);
+
+ request = mas_prealloc_calc(&wr_mas);
+ if (!request)
+ goto store_entry;
+
+ mas_node_count_gfp(mas, request, GFP_KERNEL);
+ if (unlikely(mas_is_err(mas))) {
+ mas_set_alloc_req(mas, 0);
+ mas_destroy(mas);
+ mas_reset(mas);
+ return NULL;
+ }
+ mas->mas_flags |= MA_STATE_PREALLOC;
+
+store_entry:
mas_wr_store_entry(&wr_mas);
if (mas_nomem(mas, GFP_KERNEL))
- goto write_retry;
+ goto store_entry;
+ trace_ma_write(__func__, mas, 0, entry);
return entry;
}
EXPORT_SYMBOL_GPL(mas_erase);
--
2.41.0
prev parent reply other threads:[~2023-10-09 20:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 20:16 [PATCH 0/3] align maple tree write paths Sidhartha Kumar
2023-10-09 20:16 ` [PATCH 1/3] maple_tree: introduce mas_prealloc_calc() Sidhartha Kumar
2023-10-09 22:25 ` kernel test robot
2023-10-10 22:13 ` Sidhartha Kumar
2023-10-10 11:06 ` kernel test robot
2023-10-18 2:53 ` kernel test robot
2023-10-09 20:16 ` [PATCH 2/3] maple_tree: use preallocations in mas_store_gfp() Sidhartha Kumar
2023-10-10 3:03 ` Peng Zhang
2023-10-11 0:17 ` Sidhartha Kumar
2023-10-11 7:40 ` Peng Zhang
2023-10-10 18:15 ` Liam R. Howlett
2023-10-25 9:52 ` kernel test robot
2023-10-26 17:16 ` Liam R. Howlett
2023-10-09 20:16 ` Sidhartha Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231009201639.920512-4-sidhartha.kumar@oracle.com \
--to=sidhartha.kumar@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=willy@infradead.org \
--cc=zhangpeng.00@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox