From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62983CD68E0 for ; Tue, 10 Oct 2023 00:50:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDDFE8D00A8; Mon, 9 Oct 2023 20:50:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D8F348D0089; Mon, 9 Oct 2023 20:50:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7CFC8D00A8; Mon, 9 Oct 2023 20:50:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B8F028D0089 for ; Mon, 9 Oct 2023 20:50:27 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 72D8CB4B0E for ; Tue, 10 Oct 2023 00:50:27 +0000 (UTC) X-FDA: 81327720894.02.CA90D0A Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf08.hostedemail.com (Postfix) with ESMTP id 85F1C160012 for ; Tue, 10 Oct 2023 00:50:25 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=aE58UT4S; dmarc=none; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696899025; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gt3nEPLKBeu5myuBADDAfroy83No+B2wMJbzpxU1DS4=; b=S7bg9Y9gcaIQZsuROpFjsCihdoZMuDyZ9TejM7HHWXTQmR4WKCLL/nXR4nwWDL7fDoyi/D atHKfQm+PKnO+BrvLI0vnp0UPKR1oeSd8MMWw9awFLG2KuaCsGQ0PU3uCW1pRd5O3hmlKK YZiGMzrcFYrW4GnRGxll61mi82ErbuM= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=aE58UT4S; dmarc=none; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696899025; a=rsa-sha256; cv=none; b=8KDLyNhUMk/Nqs4vbhKgHtfqcek8zdj33dMeIc2hAEa/OvomivnXtSheb3gkhH6YEg5cnR XIArcgHPWjI85+OzvidLJJhArhZ0Vb5fqFMsumfj4hR6rhWh8qxtA/Wp9qu28fOneGYb6l QMjROt6MdIiQjPlDt5SQOKUcMV+mjzk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 05B03B816F6; Tue, 10 Oct 2023 00:50:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98410C433C8; Tue, 10 Oct 2023 00:50:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1696899023; bh=brn88RJjJuKKgJQGW/M890oBv/KfzhxS4pbmrlft3p0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aE58UT4SGSfG/ipnw4qwYpdepUogGvd/+lQgfqMw1jGWPxKSVT1pULPO95KuUXzRk eQMuDQHjcnpAyXF9J2ZOVmJpnevzvGDeSlSByfZXgmd+41wBDeldv/sni8bzRkFhU7 f7isjEh5+wjndBzMnONhoN3EqFiqGLvFhJRRsmeg= Date: Mon, 9 Oct 2023 17:50:06 -0700 From: Andrew Morton To: Lucy Mielke Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Qi Zheng Subject: Re: [PATCH] mm: add printf attribute to shrinker_debugfs_name_alloc Message-Id: <20231009175006.326e61e6c0e46e6ce78699ff@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 85F1C160012 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: a6un7trj5qoqtr7jfu5w9gkx4ypdhzd6 X-HE-Tag: 1696899025-347771 X-HE-Meta: U2FsdGVkX192Mry9+0GdT5kWbsgPoTnyV0aLwoF8H8qJi7nTwpqjya/V3Ij/uHOBv9wIPcb6T6nVmvjYmcaBvbYxZGR+/nCKDImhFc6YzMxcI3zMONn2EzJuDVaaKnDGm28vQQSZwY3cpvGLZJj7vusyWflFj7mMi9ilXf6SHxmMF5dbp/bcz5E/HipGEXoc/oax2VRp3GvR9qt3NyTWRKeXT8MocAyP73P7/pf+TLlKxYRfV4X7pHUEe8My9eYL+BM8zFqU5ahmyLSxFNDWvtzHqgnBrc8Be2QqJDXImeBcMYsviyNrA1aq9F1I8Wdmr18hKPc7f6AVUbBXe8pENsG0FVD0qkMlQFojK7lPG69p3V1lawaTfHrc3/nKb1vPczn3sVbcJUe3TvD8DdjLUpi2HEM6iaTFcTIcoBBP13UlYT3isSbF62VtynoqlmGd2+29U6APSj6xAI64a78ZqEU5Ck4bDE0ehiOC7pebOnrAHKPVrH7TmeBRAAzvsnjyqnGfyjkYCG27eo0HcYqupGKNdtEwPS22BKLjg8FS1HTyaZMAAhcKIGNutDzbXaFrHxEQV7r02kBrX+puzCDf5moY4AW6f2HMkPO24AcNTLSW2zLTtYlwwhig1K6FkNgZ6JbpxozCbTnX7jsimFNJDOASeSvmrPGIVu6Fw62Tdc4Pp6/TOvxnoNkCjWMhLfxdTh6YmSGI1F0EYQx5foXVlTHDs++WVh0aLx+nTW53mslb+gCQMdzoLZrDHn0aY7oa00IF0WsBScsboTjkxzEVTgjEGu/3p1SxltB/4W0By+ijolmySAVSkxxK5KMpWGUi14/FmugW+DRPPyDGzOZ26BLChKQ36auOrVKtJT1siav6j3qKXCXS55IHpcz2UGajTO6aKkojPtGsx1oyYM/ntzi5k6p6jc4viHAxYpnYJEDSoA7okBSBOfMSPO+YkWduHUnbNgniHke+Nhkb/Gv FObcJHx1 6y0p2GYnOSMwXf+wMmKOMIe/1shj5SMjq1ct2/CeLPg3nyQEhrJXMw8+CFUHQD8JJeHOYstR45mQS9GBYVUkQp0GH8g1l+0WQi/owU92ssRuY4ZYg8Yiz2hDZPJHT++5FB3uvHdVTKk0f298o+40Kk7/4mM8GZpvguxQ70bsuQ0PJb5b1S2FNP1Gas7jqOzHoObezhxEPNyZcBIUnXO8tG0jsGTScdgp3OawAj/xw1o0hNjE+F3lfBwefzNqJEQEzLChQX9BBP8GFt6vsLW0udzB4NLBJF981NAUNXIp942eeE+OQyMykPEEahg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 6 Oct 2023 22:30:51 +0200 Lucy Mielke wrote: > This fixes a compiler warning when compiling an allyesconfig with W=1: > > mm/internal.h:1235:9: error: function might be a candidate for ‘gnu_printf’ > format attribute [-Werror=suggest-attribute=format] Thanks. I added Fixes: c42d50aefd17 ("mm: shrinker: add infrastructure for dynamically allocating shrinker") to this. > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -1229,8 +1229,8 @@ unsigned long shrink_slab(gfp_t gfp_mask, int nid, struct mem_cgroup *memcg, > int priority); > > #ifdef CONFIG_SHRINKER_DEBUG > -static inline int shrinker_debugfs_name_alloc(struct shrinker *shrinker, > - const char *fmt, va_list ap) > +static inline __printf(2, 0) int shrinker_debugfs_name_alloc( > + struct shrinker *shrinker, const char *fmt, va_list ap) > { > shrinker->name = kvasprintf_const(GFP_KERNEL, fmt, ap); > > -- > 2.42.0