From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 713D8E95A8D for ; Tue, 10 Oct 2023 00:00:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A0F3D8D009A; Mon, 9 Oct 2023 20:00:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9982A8D0089; Mon, 9 Oct 2023 20:00:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8926D8D009A; Mon, 9 Oct 2023 20:00:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7AF758D0089 for ; Mon, 9 Oct 2023 20:00:58 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 463F4160414 for ; Tue, 10 Oct 2023 00:00:58 +0000 (UTC) X-FDA: 81327596196.04.86F9128 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf04.hostedemail.com (Postfix) with ESMTP id 525944000A for ; Tue, 10 Oct 2023 00:00:56 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=RryLjpiV; dmarc=none; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696896056; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m8wElF7g5syQ7ht8CtQXj+FlFUUWeOsXPs0gqy6jQ4o=; b=6EWFQKNxwGCJ1Wxu5qc1XCiKkI1ZQyzn8D/9Edl9O6g7vsrZ7A9/ntp0a6K5EEUCoKSD0x Dz8kkQxRWgvAShN14HpkVXP8jzbObgjkxi14xv9FFJdAIcuULb9BMkA169Ux6BErducGCq NbQBrMNI6P9jMpwwHD81v4Kdkjfu01k= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=RryLjpiV; dmarc=none; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696896056; a=rsa-sha256; cv=none; b=5kmUHL66qhwAiV4DN7vgRdFwhMZsx73oi9MaDYdpMgYKlnZKrsFyRoLWuklXO+vkcHRuQT +mn31PZg6YDPA5Zsu75zwHuat794tdgXvLCIEKJBoEBu4L9YeagMlsywcOzfFzetLS0GQX CHk+tLuzWIPjE3t+5lNE3d87pOk2we0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id ADB56B8092E; Tue, 10 Oct 2023 00:00:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7362C433C7; Tue, 10 Oct 2023 00:00:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1696896054; bh=YKS8Y/7EmqBXYuLK/9MivE+xNPfZVkeyEmaZhaCyW+E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RryLjpiV4EvbXtkF6jCKy71S0MNAG5dgMqH2ypf7KUcH8JxcCO2Az3wr4Fop2QoZB 3vUic30DMWobAmFZ3NSBupUnzR8oiCFyzwCFCRMhVbHe34pG+kprS/MS9qoywVGkBA VSZqLNIVRk+B/g6HIw4aYkQXMV018pdZOysyJ0yw= Date: Mon, 9 Oct 2023 17:00:31 -0700 From: Andrew Morton To: Haibo Li Cc: , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Matthias Brugger , AngeloGioacchino Del Regno , , , , , Subject: Re: [PATCH v2] kasan:print the original fault addr when access invalid shadow Message-Id: <20231009170031.a294c11575d5d4941b8596a9@linux-foundation.org> In-Reply-To: <20231009073748.159228-1-haibo.li@mediatek.com> References: <20231009073748.159228-1-haibo.li@mediatek.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 525944000A X-Stat-Signature: juz6k6dtayn34yohaysqsif9eefhhtwh X-HE-Tag: 1696896056-700387 X-HE-Meta: U2FsdGVkX1+FUbn5sNvJFekca/QOv/78GChjUG8h7dYynJyigY/9RHBgTxYpxPRE2hFJru4BMjnXHccfZmUnB4a6VEIKJJMVjQkxM8uVGZPs03TEmuuyDsziIFHhpHcp2dCm0yX8wkQFkONOxmA53fPM7WEXXcRn1pEla9oq1d6LB8fIRU98hdMs1xLp/VRWgNjbnXpsHy9UG0dlSDh/JwiAxD3bheb+f66amNapASU0OkqVTGD16iVWgGroypOV1hGNowY0NFWTJGZsMOXmpazxXODt75i6nw9/NqCpkSf+WdwUCJbeBUnUhi+ZEEf78zJ3yLDHZSWJ7xZT4qd7ZIR4CfDxlG6i1Ke+5opfc6Zxs5qwDWEx7a52z2vPeN2TXWrkyzO9cy45Re9hWUdOsRngRDlx6W51mZ+2b549/sp2drOG3kAWQd0q6xYGj6F8DrU7pH1bzDNwJRs/eD1z/MdbioFnkuET1/N9IofYYgyJRSyLjO22Glv4oiZuUE6MIMWgwzPbnwGGUz2APRPKm6zgPVLbunjS0wHatUOmCKwYbSc2tObOBjoVH4EGPwjN27gumoPTk5Q984j4szz9G5tlmuH80sUSndt+JU1NsPvikG1f6SQMWWb9K0RDNi52Zln/C+WwLzmS3e116LniQeoTfInZ1z7apksN6cvfL2lEirDSOb45vCJUMuxEXou8g9fzyt0KFMiD51g5BIQP2SrGDLJc5Sa4NVwtPiB7EUOuZdPFdBo+o0LTHPa0hmPXkxt3uJq7pNSvDimt/t1XLxovUVW2ejBCPgpQnhE8Y+TYoXV6i7AxMAQrj61+Lnh3CSCayquSk9x1wHnQTaH2dG6H5JKd6hvvc03ss+faMAXfZ+hKS7ROibZgGj0iSWoZudjHthz+vInqS23TFFr+j/j0ibzUtT8x7k6PchCwGa1itLKvPjN7giIIRG0ILCylnWZ71DkjiHDW0MjUJsr HYQkb5xq ofiMebnT+elmIYk5eJcK5wraGnK6nDTU/JiDHboNycW8Uu7mWz2x0SjfRqGBt9vRLEjUozHHGhJ2rjC1AdKZ90Mw1ebg9Xqy7CjBpjyN3Ut6r5ukOf0LYcAIVYRLCHL/bVYDVPS/EJUf+xEmGjT73dUKUVtCY0WcoU6sur6RpXqXRbzoJ+U9LfSdkjvZPt/3015Ev4NPR0Y5TgAR9pLpmQF4WlgGM2kR/ef5DyCcARPyo++HZ9kAu00w0mAnotNIsP3VknvwDQqSgX2rLBT0wG+HtIKNUUaE0ExdJwSevsXYDE5pODXdQKUiqU92ZOMbb1/NMw9g8xFdoPkwxcabmgLg/B3ACIqcXGWugGoVeIUTYP0k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 9 Oct 2023 15:37:48 +0800 Haibo Li wrote: > when the checked address is illegal,the corresponding shadow address > from kasan_mem_to_shadow may have no mapping in mmu table. > Access such shadow address causes kernel oops. > Here is a sample about oops on arm64(VA 39bit) > with KASAN_SW_TAGS and KASAN_OUTLINE on: > > [ffffffb80aaaaaaa] pgd=000000005d3ce003, p4d=000000005d3ce003, > pud=000000005d3ce003, pmd=0000000000000000 > Internal error: Oops: 0000000096000006 [#1] PREEMPT SMP > Modules linked in: > CPU: 3 PID: 100 Comm: sh Not tainted 6.6.0-rc1-dirty #43 > Hardware name: linux,dummy-virt (DT) > pstate: 80000005 (Nzcv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) > pc : __hwasan_load8_noabort+0x5c/0x90 > lr : do_ib_ob+0xf4/0x110 > ffffffb80aaaaaaa is the shadow address for efffff80aaaaaaaa. > The problem is reading invalid shadow in kasan_check_range. > > The generic kasan also has similar oops. > > It only reports the shadow address which causes oops but not > the original address. > > Commit 2f004eea0fc8("x86/kasan: Print original address on #GP") > introduce to kasan_non_canonical_hook but limit it to KASAN_INLINE. > > This patch extends it to KASAN_OUTLINE mode. Is 2f004eea0fc8 a suitable Fixes: target for this? If not, what is? Also, I'm assuming that we want to backport this fix into earlier kernel versions?