From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE319E95A91 for ; Mon, 9 Oct 2023 07:36:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68F226B01AE; Mon, 9 Oct 2023 03:36:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 63F5E6B01B3; Mon, 9 Oct 2023 03:36:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52E1F6B01F2; Mon, 9 Oct 2023 03:36:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 436226B01AE for ; Mon, 9 Oct 2023 03:36:57 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1CD40C0177 for ; Mon, 9 Oct 2023 07:36:57 +0000 (UTC) X-FDA: 81325116474.23.708CD20 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf23.hostedemail.com (Postfix) with ESMTP id 12EC2140015 for ; Mon, 9 Oct 2023 07:36:54 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cuorHarb; spf=pass (imf23.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696837015; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P11GtP8h5bZkmfO9QlBDjtnQW6u1oo0XCFakTqv8vWg=; b=TuAoy4MeK0FyOL8rFA9BLGj43gVBlRWMXFOVg3W6mnWmVjq6RxlFrGZMyC263p6FjJ0jkf SM7ZnDvgyD2KFZKixCNtq6gY4YZg1GC/gqEHJkmKhl93TYdSKQNM45GfW7Qf4tzFhcHORz fSz0ccJ4BT8VLqb+hrGr1C28c9M1iPw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696837015; a=rsa-sha256; cv=none; b=l3c8k61sjaGiXMMSKjQOkNuESWtZmB9wJ3E79DLQ/1xxGawDHZaGJBW25WbOr3Rt1zeztI nBhHSbIIPrDbVGAAvHWrX3figasUgz+uDF45SdeG4FZggJ78y+6cRef7ngOZLJHWp+BbAH IOOxBnMln8Uk1Slc8ue1zK8+pk5mKh0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cuorHarb; spf=pass (imf23.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 2BFD3CE1091; Mon, 9 Oct 2023 07:36:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16153C433C8; Mon, 9 Oct 2023 07:36:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696837010; bh=cyOr9wKSZbKTmoYhGi29W/BehcsluNpyqFhmV/79LkU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cuorHarbeq5vdYq06nmPq8nGX2pDzlhYY2aIguVOKLx86qrspW9qfoRixSiD2oG1N BX1bPZiKVWe177iMU3qJ145/6+2QVdLkcYwZxGa8AO5oMtIqJfoIk3nVEGqVXjIFOK veC1rvqC5QOFNQ1rskp5a1QGWowZeU/MLKC+k7IX27yaqQPwaC/2E0+1aTIIPnF7Zi jRQ0blTp93aKHoihZBYvcrr6adET4DoQoSOx+8sYbZ4o9kQCrjGdrCzmS/dXLNJkwz 3hZTLiNv/d324k7T+CNsBKZE4Ai4/PYv3wZJOz/fGp/BoLGTd6qJlk9ik3kuHHAfUA f5I0X9VQZ9jOA== Date: Mon, 9 Oct 2023 09:36:43 +0200 From: Christian Brauner To: David Howells Cc: Hugh Dickins , Jens Axboe , Al Viro , Christoph Hellwig , Christian Brauner , David Laight , Matthew Wilcox , Jeff Layton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH next] iov_iter: fix copy_page_from_iter_atomic() Message-ID: <20231009-bannen-hochwasser-3f0268372b80@brauner> References: <356ef449-44bf-539f-76c0-7fe9c6e713bb@google.com> <20230925120309.1731676-9-dhowells@redhat.com> <20230925120309.1731676-1-dhowells@redhat.com> <1809398.1696238751@warthog.procyon.org.uk> <231155.1696663754@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <231155.1696663754@warthog.procyon.org.uk> X-Rspamd-Queue-Id: 12EC2140015 X-Rspam-User: X-Stat-Signature: n97mga75tax7pyj1drsz1sik8gbexrgx X-Rspamd-Server: rspam03 X-HE-Tag: 1696837014-561845 X-HE-Meta: U2FsdGVkX1/QYgzSZyaTIxPtaTydUf369C2erS3cf4Ts3vtvs9bPVLyczC3PKd1eUo5yShUlE7YEwMOUKteTwyrlrRiryJZeMgeb+NAmfq8c6rGS0KGwrhu5T8MuOOfusrL7d+uSBF4HNWK60peG6HLio7WgH2N7TZKDJrPpfGDzQD+hrGgEVkP0TO3EoapV6o7zX0elSVSy8kCCEzCe1cf6PpoPvY9i50OIBvvh7ZhoJNO5syZh79IfijPCbkVoDo8BndSaN1SYue+hXWRLmGmV8Z1mL+2DqjZ1aqLHyl6Z68T1VDS39bNQaoZHZmFOTjCrLb+t85U+DcHz9N+indJ0/DN4s5mAxUwtbzE1p7d1BrsyyHjKvIZAZ+UHLyY6SvJ2Qtfo0ph/Ek+GwHvVX5/YoHjr+IgKrQaDsEAg6negR0iT8t82D2kzLjKVuG5uP412frQobXw6Mt/QvmIeiPp5kXtLvLIIu+mh+StksV+TIfaLVD+lhIarXgWMHt7Yi7uv8U2zsdTMG/Ct3KIdNTHkSaxJv7eGTXOAssmIj6p6tL5KfNRB5DMKe9b2FeySk34tNojVsQ9f4QOXf25RDdoYFudhjg0dAKC5nQEZQ8Z3uiKluXL3kNHshjvdzBYsxVDWrlHP1bbnsa4RgYtIiDIdBwSDkaca1DxAVIjEE2NpohuVcZHj4bVMr87IleVnEkIZ+3txe6h+LJZ9sinA7XqU8nguFw56YHSZaLztSg5vyrmz37vhX7kIPHDbSYG+K+wIFjQDpRxKU4Cowt0cJdUpxGkl2zJKsgYh3OtJRsGob/3tQu+j/GMB+hzxTXFIc4mtToUlgHheHpz9l0R9jXTiWFt/66V0wRmEqrH0i8xY9p0HXV9Z/9NDBJTwwsGGvmVquxzjpziOm/RjI7OhL/v32H/HMtXxg/P6DGki6YW487/FxnBFm16mdLP42aKZn+QS3cCg5OxQJMHzTWL Yc3CmSOQ MaM8xWj4Tuy7HZaxROdf9IF4GNCbN/zzN1CTdnltZ2KqT83Ejw7QZ7iEe1CHIGX7GCe9w+pNxW4tRZtH+c0rNlhAZk46+xtGrj4XzpRravAi4XS2uIL2p/dT55HE0vgpRZpRtMQwI/bSWwQXKHVin+3wtGaKglBGxavTslXEfcG/XJdGIrQ5CYHKL4GpuNdCy2omfqsWB3BBRbF0sVLBWytXpruZHzvEdEHAE/eWdvgTWXmi7c2pXdhwWEk99KNIhXD3XsdjF6Bx0yqA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Oct 07, 2023 at 08:29:14AM +0100, David Howells wrote: > Hugh Dickins wrote: > > > - __copy_from_iter(p, n, i); > > + n = __copy_from_iter(p, n, i); > > Yeah, that looks right. Can you fold it in, Christian? Of course. Folded into c9eec08bac96 ("iov_iter: Don't deal with iter->copy_mc in memcpy_from_iter_mc()") on vfs.iov_iter.