From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 993F4E95A62 for ; Sat, 7 Oct 2023 20:10:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C65EB8D0011; Sat, 7 Oct 2023 16:10:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C14498D0001; Sat, 7 Oct 2023 16:10:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B03938D0011; Sat, 7 Oct 2023 16:10:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A2F288D0001 for ; Sat, 7 Oct 2023 16:10:33 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6E654802AE for ; Sat, 7 Oct 2023 20:10:33 +0000 (UTC) X-FDA: 81319757946.14.63AEE71 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf23.hostedemail.com (Postfix) with ESMTP id C5CA1140017 for ; Sat, 7 Oct 2023 20:10:30 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Dbv8D4br; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696709430; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QhvT/v+xOgO7ppjZR4pzVQjzgc5cF+dgYIoxdPuAFgY=; b=GYAGcoxyXXu+6nH4idwXmyQvV68twysaaUoV9CQEa1GQheTd0izYoExgWJ7oFmXh730LXA 1YvgjUAtJTNOX8IkB2t19yYvJC3Br4WLZDlplhnG9jMG5sqxt2y4zYbxaRFkyOjK6W8tij y3fwxvhXjzPUrDMpykoCPzjB6qSh6sc= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Dbv8D4br; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696709430; a=rsa-sha256; cv=none; b=UBiPibKCuUxmDAquBuPGgAmApsEa94WYuiSVqYf5PD0QGWSVgXYlgv6Nu85ZAllXyNBGMq sWHb3hbHGDU7J45Hb6PIsbMdrWBKYtHCxamLNK0lXWN+9lofB53PxUghxBcmtHAdVrkvBF h+l4w+Bi6A1hL/8Wa/IFRI+VVe9Bjw4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 3870BB80B39; Sat, 7 Oct 2023 20:10:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80B99C433C7; Sat, 7 Oct 2023 20:10:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696709427; bh=EI+Jf8MyoFRrRMDhTXvbJDTwh+ESwYKlXTuaakRtzs0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Dbv8D4brUV7WGJZolzIPMHeTV5YeDeayiREoz1J72BdJbAs8Osmyg6iRzym6AR8BM MX6vFlyHHpidaODVwIl0EF82M5nA0sj69YH8TClpwIJh7aWfRBa3rLm8rQlugexkm9 teawuemJYPXm0hS9+OWrEkw1L+PCvjNpxCBUv6PEd7BCbXPTafyWSw+YoGP0ql3Mjq TsvRiFU8BeWmog7Opy9wDzrYNY6PfMB8915xJU83Pg0wQ+hSIbyZRlpdpItKak91La /mPN5mXFSuVIxBdldqxTCtWTiHxf0u3MhpYWPEFlFpheXGLUvgvL4SGvDqZi1lhN+k VvgOU9jLJbQkQ== From: SeongJae Park To: SeongJae Park Cc: Andrew Morton , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/1] mm/damon/sysfs: check DAMOS regions update progress from before_terminate() Date: Sat, 7 Oct 2023 20:10:24 +0000 Message-Id: <20231007201024.3576-1-sj@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231007200432.3110-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: C5CA1140017 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: ywzzskfcpsahmrowzig1tp5rffp6u6a7 X-HE-Tag: 1696709430-632306 X-HE-Meta: U2FsdGVkX19r7/zUg1+MhCiiHE0ylusTwHgw/Z4ZGbHP7CR9yXoFZEVypCdvfYfGG9fQJ2LXCAwAxIB4lHLlplW22Bt30WwqmcoCcmWt8ardER5Fc6Qz0zgo3QGwsxXSlLugybIsB7YWA3t0iq8LQcKMvli9mwggYd/9rL1nlvqnQQOvObIaXl/78fQIBLQn2ORwDthZH8MdWFkwEIeHhAB726vEiaBWgsSMA5F7mjnnhgmZm5UzFpLOgKji3vhXVqlq5aDLfmWBTf1bZ62SEUpU9Pl55cH/Lts7eZvFKe/MRzGsHf5Q4TBz2OW4Y6o6dkKcFiU0KJQS3lRQw1dqAnOLtle9dP9jTBFdZq1IgqWASHZtozo55cLEkidFs82ihjPFnD7m3vil3rPXJnDHSQfgigzCFzIqYD2wf1aumRu0kz1325sx4KPKzKDzZoJsxCZ95UbGz8K/dSEOr82IYack0o056k5B7LQPiG2BNqJbLhND+XckGI9oOR69lEJNZG0I8OJjnudNicuvSkdSJaQrYxZBLP8Jc2SpajF/oTGxxt/171PjXpC/GMFG6kFmxOEIl6X7Hqcp/b9H/msdwuqp4O6GqpbKi4K+bXJFHENTh3LoWXOeofbhHjSuvcIDaGszi3uEZw7p2BVv6cWWYopHzWFzw3lBeixIxOxdP/N7R4cKto70yDCzTmVqmzu010d8eMMJzQzeI9+xz2iwCuHFrtC5QOut3EkFEUT43zFJZImNR/yU8RvPEG5aG1u3CRIXqIHLWb4aOAEJrumrKzbzE9TePqfdWraopTkvun9jCZwsYgxcjlK602w4/qCRZLGg7wdtjGIvaJqlXlJeKslsV8TiEOIFhHpk6idpR1LmaTIAINMMkBHYBubVm3sQGYu0+Qnte5cZs/x7fV/HCohP4C0zR/FeeOZFYRXr7S01aa7oNgRBWmTM37THlt7tKjLvsDoJ8DLR5StuGPD qBgjnu6H zckyJD2p0VBzGZclOq8IJ6kVZ2QatrnrdVVurCicOIec1iCMUrPVMKd7t+6D1wSnQR7JjEHYA9+N8TV1nZASrdmGK6z/pFsvyG6hx9wSsorr3rF/w6mqW16znth4IeSTeInqvhZb3zZ0uZDmpmedOs79hDkZ6BRCSXD415D99xGw9JyliFWGoXGp+BvaNUWhJX7uE71eKQKjkJAvkLYF1qexqjTkhH0bmbk2ANIaR7YmFPI+riAql6qx1wSCj49uvYLlY32QYQT0tm/i6qDAi3Y8z970F7/HtQpGS+F1DjlCmB47LbBmVVyMcLl4KWfqwj+4DimXP4EidKDpmzJET7+8jKQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, On Sat, 7 Oct 2023 20:04:32 +0000 SeongJae Park wrote: > DAMON_SYSFS can receive DAMOS tried regions update request while kdamond > is already out of the main loop and before_terminate callback > (damon_sysfs_before_terminate() in this case) is not yet called. And > damon_sysfs_handle_cmd() can further be finished before the callback is > invoked. Then, damon_sysfs_before_terminate() unlocks damon_sysfs_lock, > which is not locked by anyone. This happens because the callback > function assumes damon_sysfs_cmd_request_callback() should be called > before it. Check if the assumption was true before doing the unlock, to > avoid this problem. > > Fixes: f1d13cacabe1 ("mm/damon/sysfs: implement DAMOS tried regions update command") > Cc: # 6.2.x And this will not cleanly applied to 6.5.y, since this is based on latest mm-unstable tree. I will send a backport once this is merged into the mainline. Thanks, SJ [...]