From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 259DFE94120 for ; Fri, 6 Oct 2023 21:17:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5EBCB6B007E; Fri, 6 Oct 2023 17:17:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 59BD36B008A; Fri, 6 Oct 2023 17:17:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 463506B0095; Fri, 6 Oct 2023 17:17:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 34E966B007E for ; Fri, 6 Oct 2023 17:17:59 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 00EDD1A0227 for ; Fri, 6 Oct 2023 21:17:58 +0000 (UTC) X-FDA: 81316299078.26.AE794E1 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf24.hostedemail.com (Postfix) with ESMTP id 37F53180008 for ; Fri, 6 Oct 2023 21:17:57 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=QHDQxPsr; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696627077; a=rsa-sha256; cv=none; b=i312aKGlZF8q8uAXXoDljce+nf89iWSW+ZWb8jpp+p5P2hYOojUiIDAt2GUKQM6Q46BBUk EZ6844mG77NFNG2rWeKmrNCF8bgfCCmj9jjFLl9EJ4iZ0FFohX0yzjnCWts6JghQcJDeFT Mf3X9VhrCwvGmxJXDzdCqjskOx8KTJE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=QHDQxPsr; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696627077; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z8og0TxztvOaaJ/ZCStgyVq6is623do7lSQYZJ6WW2k=; b=EkA5V0ufORauls5fQF9z8StTSpEsivIVsTzcngA/uVI/tXC/yrlq4VVXzpZQ6k9RhQN9cn iBpVJGmHyeCABnBZLDvLtkR7SaxYl9JsRb4ZVcTRKSoCv0bmqH0ZhApI7tIHEWpfaWJbvb fYocm25AjNES5efudejQL9DFahVUlt4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 88160B82A5A; Fri, 6 Oct 2023 21:17:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94C5BC433C7; Fri, 6 Oct 2023 21:17:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1696627074; bh=KTcEpRR2Wu8nzit7cMEeg3GCHgDJhR8cJMCV1xbmfls=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QHDQxPsrNvXZf4P+vLtc92DHv2/mc+/TbzRW2tYEn4c18ojOEaoLXAy/vj2iYftxz s8lnIjRmN1yack7WXGS/mREdmrYMNqp+e32g3J2oHjrs0WaL8A/61QQGI3JrLd5YhF UDwDaQDetcG/FzUlvyiyOwriGtdKC/E8KehEAY+k= Date: Fri, 6 Oct 2023 14:17:50 -0700 From: Andrew Morton To: "zhaoyang.huang" Cc: Roman Gushchin , Minchan Kim , Roman Gushchin , Joonsoo Kim , , , Zhaoyang Huang , Subject: Re: [PATCHv5] mm: optimization on page allocation when CMA enabled Message-Id: <20231006141750.5423083520f74bc0746fd249@linux-foundation.org> In-Reply-To: <1683782550-25799-1-git-send-email-zhaoyang.huang@unisoc.com> References: <1683782550-25799-1-git-send-email-zhaoyang.huang@unisoc.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 37F53180008 X-Stat-Signature: hw5wzff8kdoj5wp13sugfo3xf6qopqh8 X-HE-Tag: 1696627077-365314 X-HE-Meta: U2FsdGVkX192+lZ/9a6qlllRwdIVwql+o5gQUdA2eIm/VUWCtq/YyRaF3FJAnY7GJuiJUW4RcwB3mv6HVeAu/v8jaJcARmbeq8hgbgafw1LGS4OFhbY3ZC+mGWaNto0KA4rfTdVkQwBcmtzs4NV4BzzgqUjERTme+ev0v6ZwxuDJ6Fse9/rhcmbhNHP6s4pIctUlkxTtXQtx9wQq4KYhC3fHJYxMH+2y6ekvjsdxCVmtYqNUkI1agD1z06byZTb2oh8pjPo1zi5Mmtn1IJ/7dsiliMqdJHaQz3YCTOEyYesEOSUN64gaRW9KmU9iqJRA790kOalkXQBbQmoKDLNjr0jEbaRI5QAnx+DQL2veTIVUXD1bzEbV/xaoO2IkzhJes6VS75G+NmScK6OELSb/5vKccOibFzbNZtfly8U+mWRQ9qEm9CJM5U/HNHwYkpoWXjHdrPpAENUnecy6fWPohGOEk9AVQc3NXpe7o0R2G1bijaPi1aKRS6FG7xOyTdEJNYaxu6v0+Z9NpI3CT4Ik2eFIVa8qBmHF4YdRCrCyJGcxSsAlLZ8BxeMtE9+q3YvakN05D0d8y+IzeJLmO4vrscySfTA6RTo3Pu1h04WgABfi7MaFRBek5xYHs6xGGU4IAWa194lHs34fgrD0c88JQskZsb2Pa/nUvP94AmIH1waGJlyYYNJ+JCnR7dTax1waXfjIlxyuet2m4sYlVMD7uBh/kvsiiJKU5S1RYS56VprLpYoNCMRP5W92MW22q4fM0fDs1x7zDs+VeX+uvC5BhDOriFfQ3sUvkZUGmVH50+8Pb710J6y9sblsLNYXoIxVnDnTKb4LJye7jOBHTmgnYHx2B4MUfEWQJLxtGwyfM45f1q3zjrgfRj/cV2NDsj8YSdaImKxc6XUgDDPy7W9KifOwTfAO+UT0FaOJuNlSKnDKChVAXYaMXenjlrnq1AXqAQ+PCA5hwvJhmtAYw4g 7YFsTe1J 457/mVrbL2XQV3ybemADLRpqdsrBBhArxl6bXkyefOPUc+oZpW6xfS5d/7HTPmfEyny4l2MPH5+1nVXRJIJ8t4J6po1WX//eaEz6QFyzkQM0kpGRA9VsFUJQRE3XI0kartOE9WKAarDAqAHEUaKAOkJkawL2lLSV+6ApONp37GkMLTIoHNP3/Fis4b3cYRZZqtQcsexonNET5jgsZfpT5erQAj1TpQgyg1/32uzJsd6ubErgYi/oUIcnxAOKC6fU3OXyPqjJefNz7s869hVo++x/LUUB+uFDJKuz8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 11 May 2023 13:22:30 +0800 "zhaoyang.huang" wrote: > From: Zhaoyang Huang > > Let us look at the timeline of scenarios below with WMARK_LOW=25MB WMARK_MIN=5MB > (managed pages 1.9GB). We can find that CMA begin to be used until 'C' under the > method of 'fixed 2 times of free cma over free pages' which could have the > scenario 'A' and 'B' into a fault state, that is, free UNMOVABLE & RECLAIMABLE > pages is lower than corresponding watermark without reclaiming which should be > deemed as against current memory policy. This commit try to solve this by > checking zone_watermark_ok again with removing CMA pages which could lead to a > proper time point of CMA's utilization. > > -- Free_pages > | > | > -- WMARK_LOW > | > -- Free_CMA > | > | > -- > > Free_CMA/Free_pages(MB) A(12/30) --> B(12/25) --> C(12/20) > fixed 1/2 ratio N N Y > this commit Y Y Y > Roman previously asked : Also I'm a bit concerned about potential performance implications. : Would be great to provide some benchmarks or some data. Probably it's : ok because of we have pcp caches on top, but I'm not 100% sure. Are you able to perform such testing and tell us the result? Thanks.