From: Andrew Morton <akpm@linux-foundation.org>
To: "zhaoyang.huang" <zhaoyang.huang@unisoc.com>
Cc: Roman Gushchin <guro@fb.com>, Minchan Kim <minchan@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>,
Zhaoyang Huang <huangzhaoyang@gmail.com>, <ke.wang@unisoc.com>
Subject: Re: [PATCHv5] mm: optimization on page allocation when CMA enabled
Date: Fri, 6 Oct 2023 14:17:50 -0700 [thread overview]
Message-ID: <20231006141750.5423083520f74bc0746fd249@linux-foundation.org> (raw)
In-Reply-To: <1683782550-25799-1-git-send-email-zhaoyang.huang@unisoc.com>
On Thu, 11 May 2023 13:22:30 +0800 "zhaoyang.huang" <zhaoyang.huang@unisoc.com> wrote:
> From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
>
> Let us look at the timeline of scenarios below with WMARK_LOW=25MB WMARK_MIN=5MB
> (managed pages 1.9GB). We can find that CMA begin to be used until 'C' under the
> method of 'fixed 2 times of free cma over free pages' which could have the
> scenario 'A' and 'B' into a fault state, that is, free UNMOVABLE & RECLAIMABLE
> pages is lower than corresponding watermark without reclaiming which should be
> deemed as against current memory policy. This commit try to solve this by
> checking zone_watermark_ok again with removing CMA pages which could lead to a
> proper time point of CMA's utilization.
>
> -- Free_pages
> |
> |
> -- WMARK_LOW
> |
> -- Free_CMA
> |
> |
> --
>
> Free_CMA/Free_pages(MB) A(12/30) --> B(12/25) --> C(12/20)
> fixed 1/2 ratio N N Y
> this commit Y Y Y
>
Roman previously asked
: Also I'm a bit concerned about potential performance implications.
: Would be great to provide some benchmarks or some data. Probably it's
: ok because of we have pcp caches on top, but I'm not 100% sure.
Are you able to perform such testing and tell us the result?
Thanks.
next prev parent reply other threads:[~2023-10-06 21:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 5:22 zhaoyang.huang
2023-10-06 21:17 ` Andrew Morton [this message]
2023-10-08 7:54 ` Zhaoyang Huang
2023-10-10 0:14 ` Andrew Morton
2023-10-10 1:31 ` Roman Gushchin
2023-10-10 1:42 ` Zhaoyang Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231006141750.5423083520f74bc0746fd249@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=huangzhaoyang@gmail.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=ke.wang@unisoc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=roman.gushchin@linux.dev \
--cc=zhaoyang.huang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox