From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 367D4E94116 for ; Fri, 6 Oct 2023 21:08:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4FA228001A; Fri, 6 Oct 2023 17:08:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AAB780008; Fri, 6 Oct 2023 17:08:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 371FD8001A; Fri, 6 Oct 2023 17:08:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 27E2D80008 for ; Fri, 6 Oct 2023 17:08:43 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D72BC1A018D for ; Fri, 6 Oct 2023 21:08:42 +0000 (UTC) X-FDA: 81316275684.24.6F8F334 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf17.hostedemail.com (Postfix) with ESMTP id E72BD40027 for ; Fri, 6 Oct 2023 21:08:40 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=nYSvxJye; dmarc=none; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696626521; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e6F7cGvBpwGU9Yz82K3RACDJqvDAlfzAXpJFt8LKedc=; b=TAMmna2SIk8axyxnKj2tXQ8oN5rP2goUaXybMQLA9GCgIe0g1IIXFCP5waV+NBt6SLRKUF Y/+JswI6nOYfMNHVYiXshJv4Uj0Av8bRnPjXuYqezHYR59TYX7UwiO9SBJJS157lH4z+bB JE5fhLsj7spZfedHHocdH2m1nsFb9iw= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=nYSvxJye; dmarc=none; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696626521; a=rsa-sha256; cv=none; b=K2fK2XrwJOVnDOW+J7kb/vbk3/kTcCtp0IRIAuN6aA9T8FNv2GoaG0wZ8lvhmQkGtdVyVN jyrIegRuaPl3kxk8LpxRdryuDeZquFsxfLL3CwPR5nqoRMtbQAA22NVWk4jKfXJYjz32Kz hB+832XqTn6XcsKmTSOO6eFBQB261tk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 62D92B829F3; Fri, 6 Oct 2023 21:08:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7EE07C433C7; Fri, 6 Oct 2023 21:08:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1696626518; bh=9BZJKDvYId5mTUI/VJ4lTfM8ilKtayFSoGbiLtqREq0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nYSvxJyec3IzHIU6njiyA9wPXgtaeINBNOahtcTtBy9+2BT8dPfyxfbLnT1/krQks 9bwzY9MoB2+3vdaH94yQsrezbRC1C2xKLTOHrlZBTSE6si1q1G+T0x8rU1a5rpGh9z QWIZna64U8bKGxeKGJKvJvq4f9Lt9hCpOQ5E1/ok= Date: Fri, 6 Oct 2023 14:08:34 -0700 From: Andrew Morton To: Suren Baghdasaryan Cc: "Liam R. Howlett" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jann Horn , Lorenzo Stoakes , Vlastimil Babka , Matthew Wilcox , stable@vger.kernel.org Subject: Re: [PATCH v3 2/3] mmap: Fix error paths with dup_anon_vma() Message-Id: <20231006140834.07110f7008677c646af1694d@linux-foundation.org> In-Reply-To: References: <20230929183041.2835469-1-Liam.Howlett@oracle.com> <20230929183041.2835469-3-Liam.Howlett@oracle.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: stqj9y8bfmi4xozowfadf6dt6yr5tp3s X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E72BD40027 X-HE-Tag: 1696626520-166565 X-HE-Meta: U2FsdGVkX1/X7AoYBCBEyM998KCZsFpybg+dEge0W1lyTIxlrC2eS4l7QvoICFIO+DBPbZB4fzlJmUttFzqim2vL9cc0D6GYs1IwXVJPXS8sFZdWLd6U8x7N08baIIykPqObllpmXDGmtnS7x52aRb7uwtib6wq1xBci/LEJy77WibYncGxQcddKD7UFgKmZclL8vFx4bYtzQkyYMv8QPz/5kLs1xqep4Mzv+x4FFBSZt9J/4cxkOAeem6JOnpfNL/wKY7p0E/qvHRNtHFtJj9ffPWkLNYhGpDz9qW116m3VnslKGsQGVeEUiAstpe7iQLEIOzJBY7VSAsAochHghFvIUTBWiZZSElgFz5eajHcKw1lYP35E2BIxgHUS7Yn51SY0+egKpjMN3loaoo+nebYILgoB8tN3k6kQC5NlcQdeO0qr8DmMpd7LH7f9jnOZSdNF/a3eVNRg+uApXX2T6IHDUvP6GcRziA7tkCAj3tUO57CoN86wh3S6WhEsvsISLHR+IPQxu5jBtLagzG5YpVsyW+r0m8Jbh7gOhKin+0msnZ3lRcPFyl3U9vbq4vvY9k9cwzd3nAaH0KYrEyQbaSugncfVpDH4gRCiGJ8hbSQrT2U8D2BELRf9+kBLhrOQz/kJJ8ppuSCSFLElBtTwA66sNgC5oUblGNkkSoMyBleyEFNsm97rcHb5/nlqXJG5wZbvuCfkcHJ3mvHEUmfqd5eCz9GNhUjs3G3BLucBPlwPU7SJAkLBAboAHtPHwREKYN+FZDQ9A2QErzR8tgoGopzMeO1m7udh7NRhA/p2hLMu9FxXYXpKHvayGCwY3M65prSNvbNlbz75TJDul04P6mSGJAK1Zj2A2WOs+L+Q8Ok7wLzzicIDi61I9bACTu2hzue1yH6qFyt/w3fumnRVyAieGnc9Mm2Mk198OWEhQXxT0rwSD38RRkf9Ldbzt2hEZy/fo8pouLk70wkBYTV SnABRNOV yUp9Y972KAiSwsLqcYqD06E13MnPUy4RdVW6ZWMTk5CWBvzdWoWrEDIbFabWdbgDH5klgmTU2rfk3aPtirHeiBNiopSZ0uyMClBbeQHp8Bz/4KhamO1qO6FQTl421D+3A73s6c3m22FyCTjg2N49aaG0WFpbo+2qwXl5QgBIFDuxKO0nS9uN5KONi8d9x1CQ98xoDzmzw4J8DhhyjaRoxas+SwPulhFQxweB1Z8syutru99S+qClJzs0CsR3zyYv4qU59NuH1D6rEoaftPORHQuPFMfHjdUkuCCHgehLbeSlZgZdisnien//zGw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 3 Oct 2023 09:21:22 -0700 Suren Baghdasaryan wrote: > > @@ -633,7 +641,7 @@ int vma_expand(struct vma_iterator *vmi, struct vm_area_struct *vma, > > > > remove_next = true; > > vma_start_write(next); > > - ret = dup_anon_vma(vma, next); > > + ret = dup_anon_vma(vma, next, &anon_dup); > > if (ret) > > return ret; > > Shouldn't the above be changed to a "goto nomem" instead of "return ret" ? It looks OK to me as-is - dup_anon_vma() leaves anon_dup==NULL when it returns error.