From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67FFEE92FCF for ; Fri, 6 Oct 2023 00:53:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9B188D00C1; Thu, 5 Oct 2023 20:53:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C2DD48D0028; Thu, 5 Oct 2023 20:53:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4F658D00C1; Thu, 5 Oct 2023 20:53:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 900F68D0028 for ; Thu, 5 Oct 2023 20:53:45 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 52009140818 for ; Fri, 6 Oct 2023 00:53:45 +0000 (UTC) X-FDA: 81313214010.17.551C2BA Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf06.hostedemail.com (Postfix) with ESMTP id E45E1180002 for ; Fri, 6 Oct 2023 00:53:41 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-03-30 header.b=CI5UvmIn; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=h6V+cRyK; dmarc=pass (policy=none) header.from=oracle.com; spf=pass (imf06.hostedemail.com: domain of mike.kravetz@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696553622; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t+phEla56z1FPRMX9nYIWYeZjXxGfc8Dr+IQSt8Y/xE=; b=IU4wRMfV7Er2QcFaWB2CqU2DYEHobnBhYMG9+8LLmWyyXK1GLMt5h21jfx8l4lSei/A0qt cSglpJZhyitPofNYs9Phf3xnYjWpKfxyDZ0MQ6Kml2hwFRiwt7QI0waSfaz45pS/o9cP4b b//SDhhsrvShEQ6tMcKi76IYTdJL5wU= ARC-Authentication-Results: i=2; imf06.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-03-30 header.b=CI5UvmIn; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=h6V+cRyK; dmarc=pass (policy=none) header.from=oracle.com; spf=pass (imf06.hostedemail.com: domain of mike.kravetz@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1696553622; a=rsa-sha256; cv=pass; b=jBgHGEJloxV7rdVJ8CVUbWAwXz45dtMfnUy30YpSV48dLXYHhWG/4cz8v4X9DRam936b6k AbeM1ykWIUNbf8SYbEQjTZKI+qchnd1f532PY1f4YYheYM9sKRWGoWJckwlRdkKn1DYgy8 TnpJlnpd1DKJ2CC2fet0fkXcPgEyE8E= Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 395J1wSU014481; Fri, 6 Oct 2023 00:53:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2023-03-30; bh=t+phEla56z1FPRMX9nYIWYeZjXxGfc8Dr+IQSt8Y/xE=; b=CI5UvmInkgf+ke3rH3HnPWoqO9EnSg9DHG0Da+fBH0XcBBMtrZl0MQRhezyo8okmBtmB I4s7VwBzJPGVB1KbuL2JDoW8gRnRKJUK6MOTzir0Kt9h5xvsBkc+YfW358ZolVFxinb3 b6JdyZKlPBU/BmhZdoTNbBA6M8L3yrVI1D0+oiNaErzkYuABE7AUxqZ9eZB8s2zymdqD G/4UYim4uK4ktD9NMQ4Dxtd7zDwFGh+6wPDuVqlIeOv7V8585hCcqCWTvMyA/IOppwhO ssKADYuLIHuBnzXOT2NmZrleD6kgG+GQlm15g5QNlo7h2TaBII99elh07rIpqeOj2AD7 5Q== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3tea92av15-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 06 Oct 2023 00:53:33 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3960IiPv010167; Fri, 6 Oct 2023 00:38:32 GMT Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04lp2044.outbound.protection.outlook.com [104.47.74.44]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3thcx7pbc6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 06 Oct 2023 00:38:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GoF8xGndOYWAaEu6pKqy59g/qHEXe2wmM3EYfYdLo9Gcs6+JOHJHIMs0EtIzXRIWDJXgpsJETcwtzYjJe0GP9Fe+YYc1tv3RMeNWRNLiJdsFIpTWI+NFjy8QmSAeMBOeG2TAtGtKlRkj3teBkEcGCg7xhiqKQv5C3E4GwNvjPqX2mGCHIzXOATCRuQDVfJb1hgwm9wr6qYKId6JJ9cGgqXCCmmtdN6STit42DE8ZkXXpQq5mQRCykeYI2PRKB5HnQwq8CkbTqNAR+C8YiuB4ubzQu4NtT54RLQUraDRLk2r/r5hCekRooz1NqPE0M9+F9TNvjTUAA/uqI42HJdKivw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t+phEla56z1FPRMX9nYIWYeZjXxGfc8Dr+IQSt8Y/xE=; b=KtU9POz/n5wpnLLYD/y025X9j/JJPHApGUA0vICRWVHHZLqgYeJedBPHRqbr5GQS5CBkdvIy3Fu25gi7KdSE7zaCGBqx7i7nJTccfqsW7zNCwljZ1/9CO0R9rXUWuimZBxUrnwSGdlcrBTy851nL4KOXzMCPjIOR93M8dQWFGF4iow01NI9n/ricauWxdbDRZYfaHjSSsOkC5/q2fZq9cebhDpuAtlTaEcOtOv3jfuxCpfPIA55/fdX+ovJW5QQwBO1fEJ3OdDefWVSWwTn6jpGC4D1iGM7IFiEfwQaUrGqL2TKveHoBMLpYfwSpa9Q62TYHpw6Gz/IShFM4kWGe5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t+phEla56z1FPRMX9nYIWYeZjXxGfc8Dr+IQSt8Y/xE=; b=h6V+cRyKIHOPTuSsGTS7iCohcxqiV9tye4ovwBxh8h5AYnwM/5DnDcTbwZtzsvlMPWdPSU7GMP5/fW5Ud4lk6QQCoYuhH6K3pKVg3Hq3n8R2PTH+lk2iuLvn89fJhZtzsGcfxoc1ZgfuxkyzfhP/4tMvBk2B583i6ct3VRMzwVk= Received: from BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) by SJ0PR10MB6432.namprd10.prod.outlook.com (2603:10b6:a03:486::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.37; Fri, 6 Oct 2023 00:38:30 +0000 Received: from BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::59f7:ec45:eb41:d8c2]) by BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::59f7:ec45:eb41:d8c2%6]) with mapi id 15.20.6838.033; Fri, 6 Oct 2023 00:38:30 +0000 Date: Thu, 5 Oct 2023 17:38:26 -0700 From: Mike Kravetz To: Frank van der Linden Cc: linux-mm@kvack.org, muchun.song@linux.dev, akpm@linux-foundation.org Subject: Re: [PATCH] mm, hugetlb: remove HUGETLB_CGROUP_MIN_ORDER Message-ID: <20231006003826.GA251100@monkey> References: <20231004153248.3842997-1-fvdl@google.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231004153248.3842997-1-fvdl@google.com> X-ClientProxiedBy: MW4PR03CA0105.namprd03.prod.outlook.com (2603:10b6:303:b7::20) To BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR10MB4196:EE_|SJ0PR10MB6432:EE_ X-MS-Office365-Filtering-Correlation-Id: 728a5c33-9130-4f97-8cd4-08dbc6049003 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VfjTT6WgyHR31u3mNZL92HzQ/+P8KY2vPyAVI4KxhUyMa+ZKCaYchgFzjCk+243UDmaRgpfppwHRFf569wmXhnFJz5aXV9utUTloufji+rU8JlgSirTNbxmY3udzOdivc0NDu77BfqyVJiFqXiIy8reEShsfHfBTU8eA1619gqxbB6Uwn45I5JgbodBA3m3VLekbIg8h4fU7ggFCchiin+VPiSpgY1mr4VTTqh5PjMsfj8J5fhr1fCbl3uPJGEPVbhT88lI7+EWLrRLhIN0rIE+vNdtdbh+TO4NGnJIa5a564hKi+SyOiKyovokkbGFqE1hptgJABy+t2I7hsLSHQzUwjA80o3HmCvifYh5tki0MDblt7AZDceP+jm9WyNEPmzv/Y5BAi0mf9faAV0y2HfEmi3/oE378mW/L+iPUHuih8kk/m7XPbfSkyreYeRMDVYxr5Kt+F2vRapzPOx9r2Z5sE+e+ykq3+2SIaRz+NflJBXG7EZOYpCbcTwa2eTP/Zx1P83EFH1m1XM+IPgCej2W/sPd2AtWji5ge7CErlNlOhY3FUadY9qRu4pcWIPQ5 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4196.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7916004)(136003)(346002)(366004)(39860400002)(376002)(396003)(230922051799003)(64100799003)(186009)(451199024)(1800799009)(66556008)(66476007)(316002)(6916009)(66946007)(41300700001)(6512007)(9686003)(33656002)(53546011)(1076003)(26005)(6666004)(6506007)(38100700002)(6486002)(83380400001)(478600001)(86362001)(33716001)(44832011)(2906002)(8676002)(8936002)(4326008)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nrG3V8FDfVf5JUEAWbmuewhe3acNDp+4ZC5RzzPHAw1BLyVPw2SbTulAu8e5?= =?us-ascii?Q?xdlI947gE7w/+y07wKd8qWjwPCcVHcpxpobZtfz8akaOMao4RSj9jR5NeTVv?= =?us-ascii?Q?jWwPuE3lhQnK+o4lMELieYNAlEGMbWeELRvoZmphMAQRdPljaZwQE51FFr2L?= =?us-ascii?Q?OUvkIvg8EGkHrCy3zuOxWFxiMZM9HD56iTnvDxc7sL70+oQvA9WjwT0shh4A?= =?us-ascii?Q?Ja5A1rKMnbFrK+ONpznro//ZaNPIGtTyOx3ciGFxhhLQGdFg1KQ3cfnZePsM?= =?us-ascii?Q?pf+N/FmzAqMTSwIFiSOdcFGaRBUex/a4FNNL4/poacrqjkvqkXRXlvzF/ZIG?= =?us-ascii?Q?yT+Ptj+9t8hEFJc6wfqLOCFQO42GpKMQZSk9FHL22NtWa26haFIeVItidPXA?= =?us-ascii?Q?0JyaHcXbBTJ82wQ1eqBsekb5+umtn/pvjHTF0jmseCQ9onBPSe3yQ1jTxtNo?= =?us-ascii?Q?NY5lJ4CcNK3ylVzj+Kg2EdwtPwpdGRg4mD80Su3yNGvAfGbZM8Hk6kAhTdAK?= =?us-ascii?Q?63Bmi3/jNxDX4ZyFxZKluKv2GQIzQd1DLo6JOayiK357weDoisHEGvN67pKs?= =?us-ascii?Q?eqETBA4rE+6gf8DmpmMDfakMiUjq0nVJLPrAdaEmZGDl8oqz3vP4UoccGFdF?= =?us-ascii?Q?PkTLbbIAmSdlvsPvuWThigcefjBHvqUxWzr0JOxBILjiecWvmEahuMBqpIWL?= =?us-ascii?Q?zJO3NYOtT0RUKxpUaaLb+RzkGSfXcT/E+jj2Mif4hqq3EPAZduSoIeXg+1O+?= =?us-ascii?Q?rmFLYPnw0DtsPZJEfTaHOE+U5JAwXGoZ2HRraLeHHEAyqZImAEzlIXf27KTN?= =?us-ascii?Q?eXxl0rU5hSGI0sisKjPrmvpLvES++Mw9iX2JyG20EW87R24Bod6lo7YC1tIH?= =?us-ascii?Q?qVGOVOc6YG3sfn6/VC93c5ENnv1bUz7QU29QwH3pU9UWrktquArDFX8Qtl1/?= =?us-ascii?Q?NkfjRcBH5voIVaRVey7qdE/a9cTlO+qCJeAn7GYnqhX40bgeX8EEvAMGV2nK?= =?us-ascii?Q?RAprbLSN3mB9PxQZC44GZcVzGi9ez6zyIjNXPNd37j+1+4DFLBnrO0MJ/dEl?= =?us-ascii?Q?qLtKGGJD1n55u0VCjK6E/y3yv4+K9ioHlYL13/0jZC9p9N7YqmQlJdSnO+IG?= =?us-ascii?Q?gYNv/tVVz1VDSxNWz5HKihINp7LusvvL1u+uKGqOxtI+y26qGicJ/k0OnoSw?= =?us-ascii?Q?lQoja39t7YkKiEkM/hkPvqFTmk7XRX2ttj6fa8tbD0nbrkaCLDXWiRbv62OV?= =?us-ascii?Q?x4hzdqLIrim+sXLg4C2AI8LzRLkHwWDmMMBOUV3BQi52JY8xFaLm2sf9L0wy?= =?us-ascii?Q?A33ZVl5uj/uopQy3PeWpYvd1S9gN+xrgm9xiwf3+mQzs6mCl4P9SWFpAZpfd?= =?us-ascii?Q?69M7Flb3GEPUN/GeFqGLSAgRta4MmrsZXaXzaeZoXnkoZ7PQrWJON/alu9dm?= =?us-ascii?Q?kSwwnZHEN50kXzXnjMpyS771UkDGZvtVB5OhmD4J02VZn8ia8ahnwCEfmZ2Z?= =?us-ascii?Q?PbBgVw9sOu0RuZObNRjeUPbKXkwiXHFJH9KjtTyUpNH7xukimrnpMEHH7Gp/?= =?us-ascii?Q?si/GrU//WsD9Amf8aXdwTvjbrpy7p9UhQv4vRFYw?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 8j3QPGg61jGJHSK5vDeRugwGvbtv81grWArvy/CSGH5u17E8mN0GQ0aTB5pwf7sKV6GZKrZ6gypmLTFUlZIJPSIl7I8dPY+Qkj+bozMxkTCrK5ia9PmBYGwzuX+qnf3rF50NwESJjhTdkt1+yxlRt99KDddXgk5AONfuFHVZbJ7Os1zKLzOjTr9pdKbWJ4I5DxyVemzjFqIcGoOXL6Y5z63VUEneXuqCQFYYhGblepoGtmQJb4ncwhgN+Wuu+r11KwwEez2yX3y5L3JjAswZmIaWsf+PSYlikb+bkYG+GmzHikoGWF6Qo4IFWq0tJKJZacM19nnNyCXJx/FAZo0QoPql5bjUvnLBB6D/86atKKtMWgMeqPxvt0Zrda4YbEnb4vU1Z21B55AIr7EUTSsfi0CzNgy3PDzx5vhYLjpEFS1UqP8Od6qQ0fLtQIvBZ4Mu0IKmiZ+e62glvoXiPlz0mQ6Jx+/VTVehRyr02FkYPa15WBwar/1Zp2GJsYPKFgJjlLq3Y16cQ3ishIGWLVpifaywFbHrZzat3L9F0KcTFctAOMQfK63MW3yXSKNbhMHYFB2il+PkraJ56Hu9J3Hcy6cy03bT1k0FbSf573XC+FRuGN4hn7TzKjZhh02d24SikbuZclNw7tpoDin+gdYdrzzF2epBBe7Bf5WxVQujN6vroNeCah5XfFjbQvd9PjesMydb/QSlfvHPACiDitWO9rF0dxYCa/W6BHIhmCouvutrtG+hsEUNdF+ZSHtTI4Hq89OJlGnw+3gsibAGdY8PykIV+f8UTPViICVKpSJTrDYFv7W9ScN093EefJdxUIr0jXAx72jA/UHkHmCYABIw5AqegLzn1uOgJE260TIgIrA= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 728a5c33-9130-4f97-8cd4-08dbc6049003 X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2023 00:38:30.4109 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: end/3/g7+RUTt4rsq+oOEO7Viq2/mhPhtC7HzWAD7sXGWS11a8fzJEKLMFKNDSjk7EHqYZBtp7rZNZsKh2TpzA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB6432 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-05_18,2023-10-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 phishscore=0 bulkscore=0 suspectscore=0 mlxlogscore=582 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310060003 X-Proofpoint-GUID: QiZNX9AtU5nQFUZrqkQFBz-yWJX9SIus X-Proofpoint-ORIG-GUID: QiZNX9AtU5nQFUZrqkQFBz-yWJX9SIus X-Rspamd-Queue-Id: E45E1180002 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: tmzfo9trfjj3oyxeja9gte3q5sk8b3wg X-HE-Tag: 1696553621-638937 X-HE-Meta: U2FsdGVkX1/7LfP2eaDZA0KV6YsXXCkDB2Y93yDZEzYQn9sreomPeQOUg42HJl7bdDDtTdVIza9G0WyDOsTWT/PfT/Gz0pfdnM1yZDF4JUbr+JA513i0X9HYlDQj8rz/C3+NmuA0lNpgPGabG7G6Yy08YS1XnBtePLVoOl5hAfWlZ60OWqMy1YG3h8ndHTpPXiP0nR6Wk2DFXFzlc4GTH0ANXIxAS5zTbTTXl+l0z7/pb14+EkjMTiA3Jbp/Sn24oGQ0qLfj9qAKnTA1KbxrB7DxZe/UTE2yFeeLxNDPLbEJmRtZguVvlwagsNgJ68wXVxMbiBtNVr53C1AuU/7HyVVyXvVgAVnW4mYXxgyezN7J+4LRJwApuTwx1srRbdheOgAn2A6dEEIp5DoBcRy0750BX1I8eSKfXU3UbVqCyNKd67rlx7dyspjCp2jSfBC+aW69RWck/4VxhheUFsC4mcnnDt+ZMhVJYnnZjAywGRa83amIBV0KKQRisuMf+sgQuE3SARgfQ4/VUkaYkwEhyagS3OArWtb7/r3c7naIsmQjovZazcYLv+PZhAjY+ZqveLCdf2VWZvgLdkCLfISBqILAuEfXpi6wFkr5KTgzxiCkAbS+lxt3yVeSEKgxlBa9tBmpxZ00WiMLZlkiw4C02a/JVP5LIBVjQ7HuT1I5gH9jLFlfzrHiTN45ZHFFF+QDCbQVYHtss5+eyha4cIoU0PJ2uVSttczDvTXujeKftFe7PaNukHos6dTy/EhdJIfa+4yYyY7GEmlo1tnk4PoOPqnBZBeiAS8H3hlINxho/pvMXVEC9wuZFVBvpD+12AljB/FzmQ2N0cavBIsCrbnXoPZEhNkHfWvfKCdbnbn4YIyJ2TYc2hGHeYi19RzMfpFf2cYQx+IMqH/pD+h2d7g2ho7mqU+j8MiOZ3gPFxsYKOs7g2mryYvsvJHtstC8llPe7OBXe2sBxIXQS87gtHe HIGqEULj nV6tkwWynecBFKIMM0WM2sDv90txwDnxkeRHeOUiG7/YnwH2I8c5HEiXdpef613SM79xSg75SMAkCEaE2twr71wmrMuV3PNZSC2XswLyhWD6RgVHVGMhjXuL3A0Jb5f2KWnnZvqZDxbKVQD2rZ4xEVS1N7kbvSGenwsh3je8DWBZoIhNyp0agT/LXix+aJP3wuc3Havck52XVIS5Xa/3yP15VSVo1LBaYZvtwvPHzlQc1qjdOAOTJ45icC7kBOclVjQMZjweT6ud5/z/N5hGHRMZz3gx/I7G/EdRWr59shmyL/Nc4Uxlo1VBYbr4j3fnvaykG20Qa0EHDd9XNxMWWvy8ER1Uq5JzMsvJzm0JpiMTUYPaTOeWz+3HYc9CVtuUnH/yLBg78zSLpgUxlVkXYNLso1o9bhYfqO5vIk+8NE4wmHXuYx/zoft1EO/+AZlTyKb7nQbBU/6a+A6Ib8YEWkcbMBIONntGZZx9vxxcU23Oxa/pjU2OW3LQKCw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/04/23 15:32, Frank van der Linden wrote: > Originally, hugetlb_cgroup was the only hugetlb user of tail page > structure fields. So, the code defined and checked against > HUGETLB_CGROUP_MIN_ORDER to make sure pages weren't too small > to use. > > However, by now, tail page #2 is used to store hugetlb > hwpoison and subpool information as well. In other words, > without that tail page hugetlb doesn't work. When I first read this, I thought we might be exposed today. But, I see that currently order must be > 0 so we are covered. > Acknowledge this fact by getting rid of HUGETLB_CGROUP_MIN_ORDER > and checks against it. Instead, just check for the minimum viable > page order at hstate creation time. IIUC, we do lose the ability to run with an order 1 hstate. Correct? The minimum must now be 2. I do not think is worth worrying about. And, the code checking for the VERY unlikely case where order could be big enough to to be valid, but too small for cgroups was strange. I think this is a nice simplification. > Signed-off-by: Frank van der Linden > --- > include/linux/hugetlb_cgroup.h | 11 ----------- > mm/hugetlb.c | 2 +- > mm/hugetlb_cgroup.c | 20 ++------------------ > 3 files changed, 3 insertions(+), 30 deletions(-) Reviewed-by: Mike Kravetz -- Mike Kravetz