From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E08AEE7C4F4 for ; Thu, 5 Oct 2023 07:52:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 414CC8D00B6; Thu, 5 Oct 2023 03:52:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C4B28D0002; Thu, 5 Oct 2023 03:52:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28C9C8D00B6; Thu, 5 Oct 2023 03:52:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1475E8D0002 for ; Thu, 5 Oct 2023 03:52:34 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B12871CA634 for ; Thu, 5 Oct 2023 07:52:33 +0000 (UTC) X-FDA: 81310640586.18.D2AC55D Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by imf30.hostedemail.com (Postfix) with ESMTP id 748608000B for ; Thu, 5 Oct 2023 07:52:30 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Tx9FHXab; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf30.hostedemail.com: domain of lkp@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696492351; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=MDSzeQyooprU0xEpAiCa28mB6xgnASM07uot/Zq0PZE=; b=E/LFS4KSipa5kvlm3j6iv2QH1jquora4rjllRX8GgsbVIY7FhgJ+j+RzkZhfGo/kDCTe7V GJfJ10VUjbhPfspnB4hvXGTfDpG4mEb0zdXOOQZ1Ho9xGfNvaCskXXCjPujLOHTI72nkCt GrF9I6wtFsphe20iHOOoNlt4Urkapgg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Tx9FHXab; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf30.hostedemail.com: domain of lkp@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696492351; a=rsa-sha256; cv=none; b=ykCOVkfb7up4US8uE2JtfC774e+CzCRn64y6DapdYNRwW3Su11piAClt4ZEAJJd1Sgfp69 zUjS8tUNVH1GBnYGleDHhgoPfT3SHJrbEMzsLCSTuV3aEKZ4NVH5WUI7XkhEu59SgynnQ/ SJlEUmXChKWYZtN3PYoFByVB0QqgZ9M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696492350; x=1728028350; h=date:from:to:cc:subject:message-id:mime-version: content-transfer-encoding; bh=bOIx5ZvNkmWlVrlxC5CEUCIBAFH5iBa1kgKwJPBRaeU=; b=Tx9FHXab6GqkxJPd0H0ZGCv3+spQZMYD6m2KHB6lyrEMCCCIP9PsDh/D 0dJICAM0tRIvxgcfgjTUOi4GF7vNW+z4bd7kAAs6wovCp5C+fUpOIJNtk DQC8T/8/pVee5mjlj7wABRsDuPluty1Hn+gf+8l/hXy2UoTa8cSwabZcx PzcfcCwt+1fGNI50v3f5iyIKJc/YBjwPuwM7bzqBzSYDWgKmSxpY9vJdW Q5csiJBNHcjopBAliIyMlVsFTbQI190FnIeLc9A/RpJUORsmr5DSWU/Ib J7ddyIp3gZzoGJHG/BdQKrsokhlKx++TH/gaqCTpe/DqRK+1gIWRoAcQ1 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10853"; a="449924518" X-IronPort-AV: E=Sophos;i="6.03,202,1694761200"; d="scan'208";a="449924518" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2023 00:52:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10853"; a="842295651" X-IronPort-AV: E=Sophos;i="6.03,202,1694761200"; d="scan'208";a="842295651" Received: from lkp-server02.sh.intel.com (HELO c3b01524d57c) ([10.239.97.151]) by FMSMGA003.fm.intel.com with ESMTP; 05 Oct 2023 00:52:26 -0700 Received: from kbuild by c3b01524d57c with local (Exim 4.96) (envelope-from ) id 1qoJ9k-000LBA-19; Thu, 05 Oct 2023 07:52:24 +0000 Date: Thu, 5 Oct 2023 15:51:35 +0800 From: kernel test robot To: Alex Deucher Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Christian =?iso-8859-1?Q?K=F6nig?= Subject: [linux-next:master 9799/9984] drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c:274: warning: Function parameter or member 'gart_placement' not described in 'amdgpu_gmc_gart_location' Message-ID: <202310051547.40nm4Sif-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 748608000B X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 8ake87i7wo9ubn86hcuobgqmhp6p3su1 X-HE-Tag: 1696492350-841707 X-HE-Meta: U2FsdGVkX192GQg62ll5pY1gwee3HFPurk3DEkHoxmBzJXqpcyvy6LHWhgQymTaqOjRbJzeW5Gc0NaJM9I8aLCNcFUWXXPJ4QvaCG2mvuNcBy82KMQUcnCLklHQZpwbyIzSYOXRgvefgNOF81C9/G4NSUZMODT6Pdo63MR9mCJ/4h/Ushsi1iHvvVgeiHZPmkBcVvDVAOu9durtqbzmUfGYz+OaJBk79lUgvns1d/PrHUQoRHrJmCeMuPTsl75uwL9kckhhKj+T0R4QTYVCCxJmEQsnjYcA/oHnNingXquFQ5of1/FZZkUkbnAV/XURTUsE7JTB2N6SgeBg5yquz2AqEGNSoQC/S/bjCr33KPqE/Vsuh5Hy+a12EECLspjWU98jiauvBFRUtW3r/gqqP7FG0TvQ9zIiqbEoetbd/nf4U8DI6qgzqWJYk6qDVZoU1/BQgRvTSOPP7R9tIp/01qPNtaR57RrL/3Lt5h/hKEUcOgjAr8rKx4oF2GKhgW7nxHVeNlYaH4l21CDF+UQikiAufCib4/rBwWHVJGs3U6OXUEptwhNpVqs1lJJXi522ouzu+83gPt8lBRU+q0sGZ0UhfFyUNjKN1sP0SD6ydcXSMM48ecUAXN0YEMuxpXtD8niuod9laDHaFAsuGtGB4Qgd82Mru8URQC6LuqCkuHbKySt18lTV7BcPShVnOSsapFHHPkPXaFffZxA15FYQps+JWvJtQcRYnWyKyHcRuD3+jVyqbrDdg6kgdwmmZmleRsBW0ljHrvYJkEt5JhoB+DpNOXj1TtHi2MTIv62YHHR/VXVV3K2DgOqPDw5kBIcrVGOYLRaT4usAwmIM0Oj5jPtQ7dKB9bqb4sUsY/MxAgxUgocRShqG3Q+wWWOA6ETkblaAPCKQX+/OKkhAJcu2FjMLNg86TVdYg9H+7Z31Okp6dXtmHP/k7Pk56xbNdnko6Va+fitl8wEoiyTxZU0x fK3GzNqG XYTGLzLm+KYjBeOvey6BOVc/BOmg7tGm/16vPM/KhgNwz97l/JG7WP0GJmRh38UPspLVs27RBh3vuRiN0dNaJNsN0XOEG3k+UN2P7Xx8v3/xhp5NoAtm/egUonE+FSJ1CcTk1awA7tRKeS6I0ZGDo5gK0RKJV48gWAv74Ovgxh8F0shHS7LCMeBquP8+rUY5eZOPCe0epKPBvEBodfW9TWQN2YGMEEX9ktbTTyuu9aC5quau8RXqC8ZiLh+GQrprT4SM8amCYsrQdZ38eG9CaFzFzyVqFUw/rgs/RkDXWy96mCoEf1kHrV95mMYtgsIrA+1A07ySOMr77B8PXTsZMGu6+nBZ3+vWOBPK/DfvBMUH0NqZg5DVWgx84kg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 7d730f1bf6f39ece2d9f3ae682f12e5b593d534d commit: 917f91d8d8e866965f2193d7962e064a4d139d8d [9799/9984] drm/amdgpu/gmc: add a way to force a particular placement for GART config: i386-randconfig-s002-20211104 (https://download.01.org/0day-ci/archive/20231005/202310051547.40nm4Sif-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231005/202310051547.40nm4Sif-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202310051547.40nm4Sif-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c:274: warning: Function parameter or member 'gart_placement' not described in 'amdgpu_gmc_gart_location' vim +274 drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c f527f310bb6aa9 Oak Zeng 2020-09-15 261 961c75cf203179 Christian König 2018-08-23 262 /** 961c75cf203179 Christian König 2018-08-23 263 * amdgpu_gmc_gart_location - try to find GART location 961c75cf203179 Christian König 2018-08-23 264 * 53c9c89ac118c9 Rajneesh Bhardwaj 2020-04-05 265 * @adev: amdgpu device structure holding all necessary information 53c9c89ac118c9 Rajneesh Bhardwaj 2020-04-05 266 * @mc: memory controller structure holding memory information 961c75cf203179 Christian König 2018-08-23 267 * 961c75cf203179 Christian König 2018-08-23 268 * Function will place try to place GART before or after VRAM. 961c75cf203179 Christian König 2018-08-23 269 * If GART size is bigger than space left then we ajust GART size. 961c75cf203179 Christian König 2018-08-23 270 * Thus function will never fails. 961c75cf203179 Christian König 2018-08-23 271 */ 917f91d8d8e866 Alex Deucher 2023-09-14 272 void amdgpu_gmc_gart_location(struct amdgpu_device *adev, struct amdgpu_gmc *mc, 917f91d8d8e866 Alex Deucher 2023-09-14 273 enum amdgpu_gart_placement gart_placement) 961c75cf203179 Christian König 2018-08-23 @274 { ec210e3226dc0b Christian König 2018-08-24 275 const uint64_t four_gb = 0x100000000ULL; 961c75cf203179 Christian König 2018-08-23 276 u64 size_af, size_bf; f2d9bbc9968997 Emily Deng 2018-10-10 277 /*To avoid the hole, limit the max mc address to AMDGPU_GMC_HOLE_START*/ f2d9bbc9968997 Emily Deng 2018-10-10 278 u64 max_mc_address = min(adev->gmc.mc_mask, AMDGPU_GMC_HOLE_START - 1); 961c75cf203179 Christian König 2018-08-23 279 0be655d1c6c6a9 Christian König 2018-08-23 280 /* VCE doesn't like it when BOs cross a 4GB segment, so align 0be655d1c6c6a9 Christian König 2018-08-23 281 * the GART base on a 4GB boundary as well. 0be655d1c6c6a9 Christian König 2018-08-23 282 */ 6fdd68b14a943e Alex Deucher 2018-06-19 283 size_bf = mc->fb_start; f2d9bbc9968997 Emily Deng 2018-10-10 284 size_af = max_mc_address + 1 - ALIGN(mc->fb_end + 1, four_gb); 0be655d1c6c6a9 Christian König 2018-08-23 285 0be655d1c6c6a9 Christian König 2018-08-23 286 if (mc->gart_size > max(size_bf, size_af)) { 961c75cf203179 Christian König 2018-08-23 287 dev_warn(adev->dev, "limiting GART\n"); 0be655d1c6c6a9 Christian König 2018-08-23 288 mc->gart_size = max(size_bf, size_af); 961c75cf203179 Christian König 2018-08-23 289 } 0be655d1c6c6a9 Christian König 2018-08-23 290 917f91d8d8e866 Alex Deucher 2023-09-14 291 switch (gart_placement) { 917f91d8d8e866 Alex Deucher 2023-09-14 292 case AMDGPU_GART_PLACEMENT_HIGH: 917f91d8d8e866 Alex Deucher 2023-09-14 293 mc->gart_start = max_mc_address - mc->gart_size + 1; 917f91d8d8e866 Alex Deucher 2023-09-14 294 break; 917f91d8d8e866 Alex Deucher 2023-09-14 295 case AMDGPU_GART_PLACEMENT_LOW: 917f91d8d8e866 Alex Deucher 2023-09-14 296 mc->gart_start = 0; 917f91d8d8e866 Alex Deucher 2023-09-14 297 break; 917f91d8d8e866 Alex Deucher 2023-09-14 298 case AMDGPU_GART_PLACEMENT_BEST_FIT: 917f91d8d8e866 Alex Deucher 2023-09-14 299 default: 5f232bd79b2417 Christian König 2018-08-24 300 if ((size_bf >= mc->gart_size && size_bf < size_af) || 5f232bd79b2417 Christian König 2018-08-24 301 (size_af < mc->gart_size)) 961c75cf203179 Christian König 2018-08-23 302 mc->gart_start = 0; 0be655d1c6c6a9 Christian König 2018-08-23 303 else f2d9bbc9968997 Emily Deng 2018-10-10 304 mc->gart_start = max_mc_address - mc->gart_size + 1; 917f91d8d8e866 Alex Deucher 2023-09-14 305 break; 917f91d8d8e866 Alex Deucher 2023-09-14 306 } ec210e3226dc0b Christian König 2018-08-24 307 feabaad8aae0f6 Christian König 2018-09-14 308 mc->gart_start &= ~(four_gb - 1); 961c75cf203179 Christian König 2018-08-23 309 mc->gart_end = mc->gart_start + mc->gart_size - 1; 961c75cf203179 Christian König 2018-08-23 310 dev_info(adev->dev, "GART: %lluM 0x%016llX - 0x%016llX\n", 961c75cf203179 Christian König 2018-08-23 311 mc->gart_size >> 20, mc->gart_start, mc->gart_end); 961c75cf203179 Christian König 2018-08-23 312 } d76364fc7fde36 Christian König 2018-08-24 313 :::::: The code at line 274 was first introduced by commit :::::: 961c75cf203179d0c546722290bf4b1147e5feb1 drm/amdgpu: move amdgpu_device_(vram|gtt)_location :::::: TO: Christian König :::::: CC: Alex Deucher -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki