From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEF9FE936FF for ; Thu, 5 Oct 2023 05:27:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F8518D00B2; Thu, 5 Oct 2023 01:27:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 380E28D0002; Thu, 5 Oct 2023 01:27:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2218D8D00B2; Thu, 5 Oct 2023 01:27:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0EC578D0002 for ; Thu, 5 Oct 2023 01:27:40 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C56F0C0144 for ; Thu, 5 Oct 2023 05:27:39 +0000 (UTC) X-FDA: 81310275438.06.D765C08 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id 13DD24002A for ; Thu, 5 Oct 2023 05:27:37 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BbpCpY2Q; spf=pass (imf27.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696483658; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H0lfQkgdDfaiVClJZp9LkcXyladFrG2avn9zOGq3R2k=; b=q+IA1GKB1aWcOlFfZ9xJ5nTPny6FkGX144GwTa0fu0S28Q3kPgQE1jB5Va3mm+H5MgH9lu y0FIcgREf+FyZZHksvIYmeXf5QSDq3eddSZKLAPB5iyajHIc0IZ/RgjX4qs+ZUdrxo8D39 5UY0fw9zELdWZ4Bg1CVDlFV9tmdK5iY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BbpCpY2Q; spf=pass (imf27.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696483658; a=rsa-sha256; cv=none; b=2KP5+OcXkmykRqzuF0xKgu9QJPB2zUdCH4lKSpCij/3y4KANZvhbk6fNC4+jU5urBAWBmU 10rqrl4b7FDXvO6BQCwrM5HQBoeAPdgv7IRmPpxqT7IRHSvh6DUXZ/Lw01OReybCQHKnmi jgPySZhFyQBVnet54pgL3/ZTC1htth4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id DF087617EE; Thu, 5 Oct 2023 05:27:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2146C43391; Thu, 5 Oct 2023 05:27:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696483656; bh=hXymtCmkQgS1mz4WN4LARQgIXsgfg8oCoZqTgfgSt/M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BbpCpY2Q0zEwY41GucwBsBZTdMge6AGCY7bXU/clMyyCXKJTV0EDLKXZQhP6Gmvyb i7tzzZViGYUX1/BLXHrp9MgUNcssHkKZ+E07sMIo2XQd9Xhgj8wBFQLGyOjD2kEs17 PxOhx0u+oKdQ8lrzOhlumXDQrrVIpZHitXF+j0a79GixClpVIz2eZl61qc1UDcG73I FDMmfOiG2H8IzEuKKw/M7PogaSgM8X2WZc5kjl+Dp1+hjjwCugO78vBqHSBJRgrtI8 iiiR0aNTydrnms7VNPMV5M6X+tEx0k+2XJsejW9H5dww52kR9ESsW7JTvRKWQR81qv y9fkPnEwbon1w== Date: Thu, 5 Oct 2023 08:26:22 +0300 From: Mike Rapoport To: "Edgecombe, Rick P" Cc: "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "deller@gmx.de" , "mcgrof@kernel.org" , "bjorn@kernel.org" , "davem@davemloft.net" , "nadav.amit@gmail.com" , "linux@armlinux.org.uk" , "netdev@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "hca@linux.ibm.com" , "catalin.marinas@arm.com" , "kent.overstreet@linux.dev" , "puranjay12@gmail.com" , "palmer@dabbelt.com" , "linux-s390@vger.kernel.org" , "chenhuacai@kernel.org" , "tsbogend@alpha.franken.de" , "linux-trace-kernel@vger.kernel.org" , "mpe@ellerman.id.au" , "linux-parisc@vger.kernel.org" , "x86@kernel.org" , "mark.rutland@arm.com" , "christophe.leroy@csgroup.eu" , "linuxppc-dev@lists.ozlabs.org" , "rostedt@goodmis.org" , "will@kernel.org" , "dinguyen@kernel.org" , "naveen.n.rao@linux.ibm.com" , "sparclinux@vger.kernel.org" , "linux-modules@vger.kernel.org" , "bpf@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "song@kernel.org" , "linux-mm@kvack.org" , "loongarch@lists.linux.dev" , "akpm@linux-foundation.org" Subject: Re: [PATCH v3 03/13] mm/execmem, arch: convert simple overrides of module_alloc to execmem Message-ID: <20231005052622.GD3303@kernel.org> References: <20230918072955.2507221-1-rppt@kernel.org> <20230918072955.2507221-4-rppt@kernel.org> <607927885bb8ca12d4cd5787f01207c256cc8798.camel@intel.com> <00277a3acb36d2309156264c7e8484071bc91614.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <00277a3acb36d2309156264c7e8484071bc91614.camel@intel.com> X-Rspamd-Queue-Id: 13DD24002A X-Rspam-User: X-Stat-Signature: jeamifg3ogm9oteknqxwaqxmpheoug5x X-Rspamd-Server: rspam01 X-HE-Tag: 1696483657-907546 X-HE-Meta: U2FsdGVkX194w4J3QhmieXrgInrcWGJLGjUcy8CrUI69gKvN5rjt8GyGBVB9HIo80Wr3q31Q6RNc/0ARcf9K+84HHcrl6hOcvhkCqAW9Sg9AwQ5Ve1e4vg9gqe/9lI+HN6e9oAJe/sRfI6nV/89PzscY9CELLuwETuNIBPsVqMzF3pxzVDYP3h1yGX+IF3/WlbEi4hwltZpUWKbqHPiIcYYcPfAWoPzHv1xa6jL63LkuwVTJucHSrNuKRKHGPUbEQ5huW48UAMWdAFOvT7Hgf4+BSaNtDm6RxsbbJeLD7VXPOw123BspZNbDZ/8UORktpPAGNjhuMFTQOBxWxYa7vTie3Xv2DwN8N5/qhd7zC/AjlhUBMgYdzDoDdjPT7eu1UXVn95R+fD8KKOVrXkINSf9uU1zBkGMeZpoV5ZjHocffxyqywU3aqFUN/LR5vZqA1mEJjHNl5cmp9MN5il2Hgti5XlFAKwUDvnDssDWZWlVeoR9Hx+mtwnsI+N3MvpBw3GgS4eAmv06hs4X/LhKBZvwwK1mQpu3wn9HHQ6p6f6SgSDPGUvbVVzoxaYgqMGsyCKQqonYGIq+QdWSHYyyUepSI3gKE1P3OqPay0keAEwra+1wEtamK80oAKYTr8DgnOfrkj+yQfRkhdmdiALHJ702hDkBod9UZF3Qohl55ILoHz72LMNhPXPAxK6dj5yjtLo3ZLMU+gMh5lUkweCN6JVOHUReH6rSMD4S3ajfhFEiKeCX/dNu/B8SVekHJEVGPTOd/DtOyNQXVunU6qEOiHbrTLm2JvRRWkVJRJzJEb6RLo58pbZzpymB+J6Z+0zEktA4mX8THz65lF2yL9JYG2UaT1/BMGA/tHX9eNcAwUAnbT+E5HacOGfNUhkN9FbZKGyy9ZJgNtvE0EnKALx+znskvRNNW3Y5FoD4sMVmhJotg0d6uWj8xeIeUV2WMK9QIf/oOOaqWr6ypK4th77u 4x2iKdUP Ojx0hCTHvpLQ8GAlU7kXlswb6XQNhVFRy0Bi+hI2Kt/uyKzklTVnXSDRuA9OEpeaqfwnih/OBsbgEDa6yWlJJJW9yNkwEpkjNZVKHaSugtefZPC9egl0HuxuzeN0jBFvMQWSzer2Xw5rfG+bQTEHz4o2NRFD7gPXqpmO6XqWVOMuGlhYQkzQ4nwMaLCgaSM9bBET8ucd0X3VMFyOCKzpVRV2FHpQwMhsnzwlTLJLbMWtQkSm1J86C8ta97l/vmFTqghLnWpPTW0HJH1MnWf9EwWWScs8NIdOmDfG6f+e3BDBLNaxQ5+PYPbigPt9JIUMoTzjRuhWn7m0Ls6OIBIZRcaF7RtvQQ8fWQofZgsQk9pnvzw8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.015089, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 04, 2023 at 03:39:26PM +0000, Edgecombe, Rick P wrote: > On Tue, 2023-10-03 at 17:29 -0700, Rick Edgecombe wrote: > > It seems a bit weird to copy all of this. Is it trying to be faster > > or > > something? > > > > Couldn't it just check r->start in execmem_text/data_alloc() path and > > switch to EXECMEM_DEFAULT if needed then? The execmem_range_is_data() > > part that comes later could be added to the logic there too. So this > > seems like unnecessary complexity to me or I don't see the reason. > > I guess this is a bad idea because if you have the full size array > sitting around anyway you might as well use it and reduce the > exec_mem_alloc() logic. That's was the idea, indeed. :) > Just looking at it from the x86 side (and > similar) though, where there is actually only one execmem_range and it > building this whole array with identical data and it seems weird. Right, most architectures have only one range, but to support all variants that we have, execmem has to maintain the whole array. -- Sincerely yours, Mike.