From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 125E0E7B5EE for ; Wed, 4 Oct 2023 11:10:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04C1A6B01F1; Wed, 4 Oct 2023 07:10:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F3E2C6B01F2; Wed, 4 Oct 2023 07:10:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E05D56B01F3; Wed, 4 Oct 2023 07:10:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D1C376B01F1 for ; Wed, 4 Oct 2023 07:10:06 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 87E34160345 for ; Wed, 4 Oct 2023 11:10:06 +0000 (UTC) X-FDA: 81307509612.20.CA0BB8C Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by imf06.hostedemail.com (Postfix) with ESMTP id 79A18180004 for ; Wed, 4 Oct 2023 11:10:03 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gDJZc5iq; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf06.hostedemail.com: domain of lkp@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696417804; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=6Z0A6H9CBk76CBtyXWSbef4bE1YPr8HxCwT3LlmFWRc=; b=gLH5cA6Gl9PKKFM/2CBZbZwMHztRHJhBrfmYObCV3wWX0O3SoufJqSEB2mkv5ISmGIJlMN tz1J7PYtMOLlu1yNv5Z1JXocvOiQH3OUkKjpDBmMSEapIgSopIDa28/DW3AscJq1l/9lQs SjIsnjHLNIKWAlN5YMimirLR262V8c0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gDJZc5iq; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf06.hostedemail.com: domain of lkp@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696417804; a=rsa-sha256; cv=none; b=btudobIZpfTYZPZLe0TEOgqPZfCr0HkegLkpav2IlJUsB+xD1RzUs602OfDT0DY70lvxwq MVfDAQzvzUQmW/JW+GWdNQiTy8fGlS6NI3qbkliOwfxGx+n8oqeS2wlkYF1HIqcCTtaUkl Y/BwWjKv0Do/xtVsSTj9QrSTPhNbGzo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696417803; x=1727953803; h=date:from:to:cc:subject:message-id:mime-version; bh=Lxjb5CmhFqoDj7WOHqPuW1nIvM+2t7fBcK2UxyN8viw=; b=gDJZc5iqDBWyXR2LWLnZgdoSR38wLiPjbs8LDIHYDbRMrYviN17/escO VmNtL9ffguUtponV0EQZj4YIi9v7shNxxiDq/Phm4UFvFeXxzLgvZL85u FCL6GSdq/+bzxQjbLcY+AKiyqE1hTZa8LsqjGTL+4Fnr/C/YN7GYjMUTg nbu2bt1qswVt12pwF5lG/Ky1N/eopBhRRZeVqQUm6/NQRJ5gmr7vTdHZ8 aHhphVCBSlijPgxFSEjn0vpOMXfjMfdJ4bhl9P/tDhwyjRJBBF5/M8TwW YWwEhWzsSHdN/h2/XA/7XDdIpbRCtaN6YpzRQTu/OROgGFH5g1BYGJiS6 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10852"; a="385957046" X-IronPort-AV: E=Sophos;i="6.03,200,1694761200"; d="scan'208";a="385957046" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2023 04:10:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10852"; a="867299197" X-IronPort-AV: E=Sophos;i="6.03,200,1694761200"; d="scan'208";a="867299197" Received: from lkp-server02.sh.intel.com (HELO c3b01524d57c) ([10.239.97.151]) by fmsmga002.fm.intel.com with ESMTP; 04 Oct 2023 04:09:59 -0700 Received: from kbuild by c3b01524d57c with local (Exim 4.96) (envelope-from ) id 1qnzlN-000Hh4-1N; Wed, 04 Oct 2023 11:09:57 +0000 Date: Wed, 4 Oct 2023 19:08:58 +0800 From: kernel test robot To: Vlastimil Babka Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-mm@kvack.org Subject: [vbabka:slab-remove-slab-v1r0 19/22] mm/memcontrol.c:2888:5: warning: no previous prototype for function 'memcg_alloc_slab_cgroups' Message-ID: <202310041934.vgOzHUvw-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Queue-Id: 79A18180004 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 7pjets7i5on5r4oazuacw5imweht74sn X-HE-Tag: 1696417803-171790 X-HE-Meta: U2FsdGVkX1/TUsEDKtdR/WyC58IGgBuduY8jmtUlzVL6ocUhLMZouHGin1Gi/7eETfwu8fIHJphtAo7H+2coQ8NvYdYzoJleqNmBdeJtto/WNrlOO0KaHQ+iVnVpg83rZ3mSwDdRHOQXgLkX2JsWTK3Ow3mKkZhlUrsumQkjPAF8xDh3ZV9F8Hi8XeHoy3JgTj92cbNOAxXK4ZlweYgtmc1oos0XTEZDmv8L6AGTiDLZyDPNdSQ9TokChhDMF9Rrgv54hp3hUOKJYtV81c7TIMffYo0Yf3BB4cGN2wz+PYfeK2/SPp4s9XGYfFzjoySv53PVYKw3r1nAYYKiVroB1Yp/SirGmWPIHId0YFnvS+II9WWZw59xQ/6CkP2e9DCNburHXt1aTOiurYKHdfcNffpixYymnb5l+wM7rrSRVGZTbszWlQIUrgyd0n0czgxPT2HqFhUVMOukT2eFTxYOVL691ajwoIA6i3X+d98frxvn53dzSwUHwyxx6AciZvWXB+v+VPKJEFJDnI/0NS3rDU2t30o0sJAHe9l2EuSV9QAdXqlgXvQKwM2HtnDnZciC+gNb+qM+AAC+8O3yZYQCdL0SL57QjjEmB11EUJd1YNTJfX33vQY4oXm+4lWpKfKyYIZZhyEsg0yOKOoSpfM2VPNboj8eCcYsKf4HtCbTsl4+X6HXJu7EXciRKgraErDwHqrnk6DZzZH1X/lcEUqBT/b5VpH3a6QMbNKx5EHC0JDI1oVeF7viWLYUMhFmr8iB75kazsMqsItYo70hlCYLK9BVT3VM8KZhbI2ylFMZxs+FmfwHUfFx4pmqA92I8OOrqrMHy4RwrNFrnJPC38r/OI7KT9FdtMkxBvHp4kffHWEJNckbjob2KITBpzPe3AqGWikZLaNws+yXA48PCuFmfUenBoPFyon6qFJUQxuX7CQwH+qkYaFvU258v5IniCJmOxtYyt4vMUO+tKDos6p 5vVVXiL3 Uxsp4nZ+rxnIPIUL4zeIRVAAhQNla/3VpaDHc9NgaOV5VpUfpmJwOY+GoxolPV8ZajraYEpytlsNBBva8Wo/XlF5g/b5ZmHmJJki1zR9SUHlYyYP/kB+Cp6/mm/1PL05QMPpK3wq7LDvymif5OIwqLNuYIuLZB5cT6e9r9aM3onQThHTEgO0ch7cTwCqZsZoYlB7icDm9zuaJyE05Ll9A/yih+PdmV/OoA2/skYM2jdOpo0cnef7sMTUOWoWoHPwUnlS+RLBpnT3NF9km4K4aol8oPpKIMiZpJsMWFjzgSS5Xef8K7fgVL32Zo6GW4PJM9GXIjJdVGacChiWOgUecx6tZR5dr99DCFZob X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/linux.git slab-remove-slab-v1r0 head: 7a5cf1bc55d1877eb85656dd530301fd55599feb commit: 69d9aaa43fff253c195b3f53537855bcfa14939a [19/22] mm/slab: move memcg related functions from slab.h to slub.c config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20231004/202310041934.vgOzHUvw-lkp@intel.com/config) compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231004/202310041934.vgOzHUvw-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202310041934.vgOzHUvw-lkp@intel.com/ All warnings (new ones prefixed by >>): >> mm/memcontrol.c:2888:5: warning: no previous prototype for function 'memcg_alloc_slab_cgroups' [-Wmissing-prototypes] int memcg_alloc_slab_cgroups(struct slab *slab, struct kmem_cache *s, ^ mm/memcontrol.c:2888:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int memcg_alloc_slab_cgroups(struct slab *slab, struct kmem_cache *s, ^ static >> mm/memcontrol.c:3163:6: warning: no previous prototype for function 'mod_objcg_state' [-Wmissing-prototypes] void mod_objcg_state(struct obj_cgroup *objcg, struct pglist_data *pgdat, ^ mm/memcontrol.c:3163:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void mod_objcg_state(struct obj_cgroup *objcg, struct pglist_data *pgdat, ^ static 2 warnings generated. vim +/memcg_alloc_slab_cgroups +2888 mm/memcontrol.c a7ebf564de325e Waiman Long 2021-12-10 2887 4b5f8d9a895ada Vlastimil Babka 2021-11-02 @2888 int memcg_alloc_slab_cgroups(struct slab *slab, struct kmem_cache *s, 4b5f8d9a895ada Vlastimil Babka 2021-11-02 2889 gfp_t gfp, bool new_slab) 10befea91b61c4 Roman Gushchin 2020-08-06 2890 { 4b5f8d9a895ada Vlastimil Babka 2021-11-02 2891 unsigned int objects = objs_per_slab(s, slab); 2e9bd483159939 Roman Gushchin 2021-02-24 2892 unsigned long memcg_data; 10befea91b61c4 Roman Gushchin 2020-08-06 2893 void *vec; 10befea91b61c4 Roman Gushchin 2020-08-06 2894 41eb5df1cbc9b3 Waiman Long 2021-06-28 2895 gfp &= ~OBJCGS_CLEAR_MASK; 10befea91b61c4 Roman Gushchin 2020-08-06 2896 vec = kcalloc_node(objects, sizeof(struct obj_cgroup *), gfp, 4b5f8d9a895ada Vlastimil Babka 2021-11-02 2897 slab_nid(slab)); 10befea91b61c4 Roman Gushchin 2020-08-06 2898 if (!vec) 10befea91b61c4 Roman Gushchin 2020-08-06 2899 return -ENOMEM; 10befea91b61c4 Roman Gushchin 2020-08-06 2900 2e9bd483159939 Roman Gushchin 2021-02-24 2901 memcg_data = (unsigned long) vec | MEMCG_DATA_OBJCGS; 4b5f8d9a895ada Vlastimil Babka 2021-11-02 2902 if (new_slab) { 2e9bd483159939 Roman Gushchin 2021-02-24 2903 /* 4b5f8d9a895ada Vlastimil Babka 2021-11-02 2904 * If the slab is brand new and nobody can yet access its 4b5f8d9a895ada Vlastimil Babka 2021-11-02 2905 * memcg_data, no synchronization is required and memcg_data can 4b5f8d9a895ada Vlastimil Babka 2021-11-02 2906 * be simply assigned. 2e9bd483159939 Roman Gushchin 2021-02-24 2907 */ 4b5f8d9a895ada Vlastimil Babka 2021-11-02 2908 slab->memcg_data = memcg_data; 4b5f8d9a895ada Vlastimil Babka 2021-11-02 2909 } else if (cmpxchg(&slab->memcg_data, 0, memcg_data)) { 2e9bd483159939 Roman Gushchin 2021-02-24 2910 /* 4b5f8d9a895ada Vlastimil Babka 2021-11-02 2911 * If the slab is already in use, somebody can allocate and 4b5f8d9a895ada Vlastimil Babka 2021-11-02 2912 * assign obj_cgroups in parallel. In this case the existing 2e9bd483159939 Roman Gushchin 2021-02-24 2913 * objcg vector should be reused. 2e9bd483159939 Roman Gushchin 2021-02-24 2914 */ 10befea91b61c4 Roman Gushchin 2020-08-06 2915 kfree(vec); 2e9bd483159939 Roman Gushchin 2021-02-24 2916 return 0; 2e9bd483159939 Roman Gushchin 2021-02-24 2917 } 10befea91b61c4 Roman Gushchin 2020-08-06 2918 2e9bd483159939 Roman Gushchin 2021-02-24 2919 kmemleak_not_leak(vec); 10befea91b61c4 Roman Gushchin 2020-08-06 2920 return 0; 10befea91b61c4 Roman Gushchin 2020-08-06 2921 } 10befea91b61c4 Roman Gushchin 2020-08-06 2922 :::::: The code at line 2888 was first introduced by commit :::::: 4b5f8d9a895ada8e0abb58ccd35d9fe229e3a595 mm/memcg: Convert slab objcgs from struct page to struct slab :::::: TO: Vlastimil Babka :::::: CC: Vlastimil Babka -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki