From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8031E7AD78 for ; Tue, 3 Oct 2023 16:48:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51D576B016C; Tue, 3 Oct 2023 12:48:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CAEE6B016D; Tue, 3 Oct 2023 12:48:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3930E6B016E; Tue, 3 Oct 2023 12:48:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 293CF6B016C for ; Tue, 3 Oct 2023 12:48:40 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D66051203EF for ; Tue, 3 Oct 2023 16:48:39 +0000 (UTC) X-FDA: 81304733958.14.287AF87 Received: from mail-vk1-f173.google.com (mail-vk1-f173.google.com [209.85.221.173]) by imf18.hostedemail.com (Postfix) with ESMTP id 1D5A21C0024 for ; Tue, 3 Oct 2023 16:48:36 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=Gv0RIRqg; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf18.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.221.173 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696351717; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7fQqegtPGr2l/qfGLLeKHAsEgJgKMskDcYWjAE5QgNs=; b=EvE+NQyAa3X7t/Du1hwvLD+Ebt5esMCcu0ndZUIy6pPJOsP8aly0/aSxPjmKU/AhsJRbLe ZgEl5hYjBWAkBGtErp+JIzXK1evjvuCLpCDx5vEnPB1cBByld77Y1fK2ewGmAj2zOMcI89 V8Ec72NGZai/x1zdyiTaa8H6MkxDnws= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=Gv0RIRqg; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf18.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.221.173 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696351717; a=rsa-sha256; cv=none; b=a8/pRsY4/uDqbXRJ3G0I3EDa1VQ+uMovxxQj2Z3l26tQtBRLEpxo04zdVWJvKlknX3qlKp Vxgkma6N1ewjROmsmK1CkX3aHdFdFpsccYUha7AgSwr4S23swq3J+YIJb7uQI1mFMoPIax eHViQcd+aLI0E4osQRjNi9dE4kkYhpM= Received: by mail-vk1-f173.google.com with SMTP id 71dfb90a1353d-49abb53648aso518388e0c.0 for ; Tue, 03 Oct 2023 09:48:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1696351716; x=1696956516; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7fQqegtPGr2l/qfGLLeKHAsEgJgKMskDcYWjAE5QgNs=; b=Gv0RIRqg5kRpu1DVkUvyM6aHGPnVAVQeIqMvoz8oTU6ktU2xDgUk97G1kXnLB6nL2A y8mv/WMvLSi5I4ZYkY7QsM6FLYWXZz7zF++ztmrjQscU7AeDp8ysi/LWxdv3wTIXMW+I V58eJWPLCbWHq1geCZ2KdJXAvtC3NXNgjf5B8weJbvvz3ltQEjV5TAsA7mF3wKgPS0Hu ZagJyKmxOmmdOlD59dQ6B0JMBom7YawkwATaAS4cQdsGjTBNgI6ncm6EN8tq/5OqEjn1 AzwwS9YcRcGCbSXlHbgy3l++C4o32UrLingODvDqA4pBoinDretR5JG0Z/5aSqGV0m8U 5QiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696351716; x=1696956516; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7fQqegtPGr2l/qfGLLeKHAsEgJgKMskDcYWjAE5QgNs=; b=dvdDTg/iHiGfE7Xev7EGTdvG3z0+N8kwzrb0mDyzEyRnZpDPdgIg4uSyFFjfU61BjP imFEHsLG8ZWvl5ztc0Ijc624B+l1319Jh54djmkArk40+aCY5+x64b72o3n+Lz/ZQ1MP FnJG01xOtd+blSKIHIo/Jp1vIT9GUCbWdW/HqcDfBLaRINNAzTN4/rIlV2ZDgawet6wU 00wI9trB5khYyYK4iPs6sNAEqYCmWxEUlDOkfwUYwlBB385jAfTs2Vn7JiU+wI3btNVy +5kQ6ClLI6PyVT+UT7J0RrHcl1rs+A47YV8NoBSfdHCx6Vk1EUxVjPkoeyGTQk7RDjGm QGDg== X-Gm-Message-State: AOJu0YybvTSVHIR8ie6VV2Xeg1yW7hgVDUTSGyjNfIZOfbkg/ya0tzmO VbAgplPKdx0nxhKL7+uCC7eoBw== X-Google-Smtp-Source: AGHT+IEzXIwhhXIHlbSduWagnxX4PLiRp03xXdD5h2lcmYMEvKP7eJDYYCtQTx7mB+AMKvyGeBlo6Q== X-Received: by 2002:a1f:e043:0:b0:490:b58e:75a9 with SMTP id x64-20020a1fe043000000b00490b58e75a9mr10316947vkg.4.1696351716094; Tue, 03 Oct 2023 09:48:36 -0700 (PDT) Received: from localhost ([2620:10d:c091:400::5:753d]) by smtp.gmail.com with ESMTPSA id g12-20020ac8480c000000b00415268abe26sm570941qtq.8.2023.10.03.09.48.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 09:48:35 -0700 (PDT) Date: Tue, 3 Oct 2023 12:48:35 -0400 From: Johannes Weiner To: Roman Gushchin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Michal Hocko , Shakeel Butt , Muchun Song , Dennis Zhou , Andrew Morton , David Rientjes , Vlastimil Babka Subject: Re: [PATCH v1 1/5] mm: kmem: optimize get_obj_cgroup_from_current() Message-ID: <20231003164835.GA20979@cmpxchg.org> References: <20230929180056.1122002-1-roman.gushchin@linux.dev> <20230929180056.1122002-2-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230929180056.1122002-2-roman.gushchin@linux.dev> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1D5A21C0024 X-Stat-Signature: thfq4hjdr5zbrzk5puxekz4sacstk86f X-HE-Tag: 1696351716-509865 X-HE-Meta: U2FsdGVkX18a1x3uUCJN4SHlExPUvym1A0HjstPvj5BNzcQ3QikqyPj8K7RxVJO0QGyG8b3/AQaXr0dzUQbVw98yb4gadUrxRc9jBvS5JhLL/g8YO+I4602no5y3sdSWRClFXv+zMkpJ6wI8gDVWbEDzJyWgeZuvy/Xc+HqmflhkySL43eGQDv9ZpQMV42JM6bn0qGgwEqY4ogKsshDc3KA0w9AeDo8KmFxG+Izk85LqpXGDd9Fqk6V9PXQGdYFXt7+LQs5GPsSzqWm+QizC2O2/SVX8UtnwsexoPp0zaJWjh6nXiDhRTuBQqucTuqRqs8phjXGP/N7NvHRmqoO7qfME1m6fZc41yhHqdix/R/ePj9mlFwoNLx4L1C6AGQTyRkiHzMKaOf7NBpvMM/9qnxiroTOUwdTZBnyOzD1yHLbX7fY1T5dCCDS7ze1SF+2thB/5tio0aQ+KAAxgNeq3P2jGta/AouF7HavFEsSZQqGsBCxF6Gy+hbm4Ug69NSJvdpp2g/8oj9vLPpoqxrXdyX97ODdShuvCPO/d/qlB2OkI4vXAujjjSkkQQAp1L3sBUAGumwu41l963daB2X2iVmCmv69S8mj+BrEP0tpALbQQB84FZruXakrfqB5Sflj/hKi7bA+G/hXtZ+OFNTLHkCseC89zTm9VM7XrSh9BUDyuJWwgxvdPohlVSTwHAsUZBWnCzcFEdQfEZlHZO4nmf7A+sv5c55i7qdfIQkAjmsbvyQlnzwerDdwsH8kGfNt+U0hhnKLSnr+DZI/OAYIlH64TNlEf5+iI10raE4swwaCjoPyig2PbfJ7YpAQ3tg02nrBQaJHABXU7f49RN5dfWkE7ovcs6ppfR7UjOEdlQL9Mxj/wynHkW5RMRMJm29FZt6uIkPUWII8uqmkefgUdcfdm9bWK12livYB4hedSuYlB6THfovxWhrx1wQxwecWCDmCckl2bSruXkMGVWO0 l1U6rkmW pieiPiVwA0sUojH4Aa6aB8lmQFSnRjFkwnFKM+KCOLBH7bSyMG69i4RyyFC93a6T0RjncCQO4I0e3gaS0qbD3skFBibheSRYKN4qlGZlD2DIDGLceiqfcLNkZ4DzNCXMpDT0ZRtyk9J19sRBPU4P5gNNv0+2MoIZ7hTgCEhVTB0NyRIkDtWVYZf9X2/CpwVwOaEKYuqC1B0Uq2L0hei5aHUCkDMeudbsf1yOPMawgZSqfTuZSK3Y/zGEgRrzOPQZTsm4lFo/OxbxoMF/sGQ2UImI7CumtQLOymBgaCUHBCPv05Scmjt/2hT11XHSipwEgr4u6VM3wnLMuSNnaVSvt7uVtjVnlJQgP4+LbLxMbiXydHXN979WpNAuT+dpWvyIo1G6/TUa3wd0uRQ7wHfBWmz6M8fDXXLxnHcUSkGGKKNDpHvrM+eSJe4qjBQSChdeRn77iodWHKNXxCuYbWYsuSV1ZnSYKd9HJAI7W7ZJXd0Wf0OMhyu1zM9p4/caBlZ4t+5aGUvljgJD92xjzkPgr5+aT4JiSXjnjSAUPQ78sH7QJpeWcn9/KTYl0JmrNb1KjDson X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 29, 2023 at 11:00:51AM -0700, Roman Gushchin wrote: > Manually inline memcg_kmem_bypass() and active_memcg() to speed up > get_obj_cgroup_from_current() by avoiding duplicate in_task() checks > and active_memcg() readings. > > Also add a likely() macro to __get_obj_cgroup_from_memcg(): > obj_cgroup_tryget() should succeed at almost all times except a very > unlikely race with the memcg deletion path. > > Signed-off-by: Roman Gushchin (Cruise) > Acked-by: Shakeel Butt Acked-by: Johannes Weiner