From: Johannes Weiner <hannes@cmpxchg.org>
To: Roman Gushchin <roman.gushchin@linux.dev>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, Michal Hocko <mhocko@kernel.org>,
Shakeel Butt <shakeelb@google.com>,
Muchun Song <muchun.song@linux.dev>,
Dennis Zhou <dennis@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH v1 1/5] mm: kmem: optimize get_obj_cgroup_from_current()
Date: Tue, 3 Oct 2023 12:48:35 -0400 [thread overview]
Message-ID: <20231003164835.GA20979@cmpxchg.org> (raw)
In-Reply-To: <20230929180056.1122002-2-roman.gushchin@linux.dev>
On Fri, Sep 29, 2023 at 11:00:51AM -0700, Roman Gushchin wrote:
> Manually inline memcg_kmem_bypass() and active_memcg() to speed up
> get_obj_cgroup_from_current() by avoiding duplicate in_task() checks
> and active_memcg() readings.
>
> Also add a likely() macro to __get_obj_cgroup_from_memcg():
> obj_cgroup_tryget() should succeed at almost all times except a very
> unlikely race with the memcg deletion path.
>
> Signed-off-by: Roman Gushchin (Cruise) <roman.gushchin@linux.dev>
> Acked-by: Shakeel Butt <shakeelb@google.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
next prev parent reply other threads:[~2023-10-03 16:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 18:00 [PATCH v1 0/5] mm: improve performance of accounted kernel memory allocations Roman Gushchin
2023-09-29 18:00 ` [PATCH v1 1/5] mm: kmem: optimize get_obj_cgroup_from_current() Roman Gushchin
2023-10-03 16:48 ` Johannes Weiner [this message]
2023-09-29 18:00 ` [PATCH v1 2/5] mm: kmem: add direct objcg pointer to task_struct Roman Gushchin
2023-10-03 16:59 ` Johannes Weiner
2023-09-29 18:00 ` [PATCH v1 3/5] mm: kmem: make memcg keep a reference to the original objcg Roman Gushchin
2023-09-29 18:00 ` [PATCH v1 4/5] mm: kmem: scoped objcg protection Roman Gushchin
2023-09-29 18:00 ` [PATCH v1 5/5] percpu: " Roman Gushchin
2023-10-04 18:32 ` [PATCH v1 0/5] mm: improve performance of accounted kernel memory allocations Michal Koutný
2023-10-04 19:02 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003164835.GA20979@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=dennis@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox