From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA9C7E7AD41 for ; Tue, 3 Oct 2023 13:21:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FD398D0074; Tue, 3 Oct 2023 09:21:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2AE278D0003; Tue, 3 Oct 2023 09:21:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 175448D0074; Tue, 3 Oct 2023 09:21:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 06FDB8D0003 for ; Tue, 3 Oct 2023 09:21:36 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AA7BB402F2 for ; Tue, 3 Oct 2023 13:21:35 +0000 (UTC) X-FDA: 81304212150.04.FB8B76A Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf30.hostedemail.com (Postfix) with ESMTP id 4C23180018 for ; Tue, 3 Oct 2023 13:21:33 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=MvDWSdDZ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=51K0h5Ya; spf=pass (imf30.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696339293; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iozkCg85Ccozy8MyCle8fR6zkI5m8e4LQYBL4ht/UCc=; b=llCGNIB0qJaKNyGxVa9sjwOoY3Vjg04vJoN2p6678OJvgY/axVhL+i1CpGorcYaW/YYcS/ cRBY9zCTkgqd0om20Ha7hJZczqfCaWQ7uhUc6+PPX6p2N6MyT2OrvFmA+u0yicg+tkaKsL JadI9u2V5PShJcW4zpTT0YnQBdV3tjo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696339293; a=rsa-sha256; cv=none; b=hdYdsVyr5g0E86r0qN/9r+VcI5VwlTOCR8yq9XZjT5a/p5fspRX+GZZw7DFG6nU+kuomlv j08xCBOS5cSuLg+3qcWoHEOaWmvhcI1QVYQfc7LG46RncjumwQzDuFdMDUxoVtQsQ1G83s T5Qtg+bNf2SvKSGsSKms0/AZ60YHAQs= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=MvDWSdDZ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=51K0h5Ya; spf=pass (imf30.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EFB6B2188C; Tue, 3 Oct 2023 13:21:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1696339291; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iozkCg85Ccozy8MyCle8fR6zkI5m8e4LQYBL4ht/UCc=; b=MvDWSdDZHoI5Z8yy34FreQsOactXQbXnmKhrjaC36zgWmJFPP7cpJWAif38fdw3Rp7tu3F VGjQGp/fSV1dz4Mgda5z0dsoy+E3ihzbtgGUJe4MihO/KicX3+apT66ewfpseXWtUuTNmq GZnAuXtF3JAbLU3BNxo+/FNqSMnOaZg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1696339291; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iozkCg85Ccozy8MyCle8fR6zkI5m8e4LQYBL4ht/UCc=; b=51K0h5Yaz9ZwJey9g5fagh6ZQx+yCjsMBrgvMLKyaXCpGLMKKkN3qZgj75B7Cwa577Bjry GdFPkR//rU3RiqAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DD95A132D4; Tue, 3 Oct 2023 13:21:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8dIRNlsVHGVWNQAAMHmgww (envelope-from ); Tue, 03 Oct 2023 13:21:31 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 5AE2FA07CC; Tue, 3 Oct 2023 15:21:31 +0200 (CEST) Date: Tue, 3 Oct 2023 15:21:31 +0200 From: Jan Kara To: Hugh Dickins Cc: Andrew Morton , Christian Brauner , Carlos Maiolino , Chuck Lever , Jan Kara , Matthew Wilcox , Johannes Weiner , Axel Rasmussen , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 5/8] shmem: shmem_acct_blocks() and shmem_inode_acct_blocks() Message-ID: <20231003132131.j4mnrryyftbmzvtb@quack3> References: <9124094-e4ab-8be7-ef80-9a87bdc2e4fc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9124094-e4ab-8be7-ef80-9a87bdc2e4fc@google.com> X-Rspamd-Queue-Id: 4C23180018 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: q9b9naah4syu77jur3z1q76ryc58i19p X-HE-Tag: 1696339293-943206 X-HE-Meta: U2FsdGVkX1/UaGN3zzY6b+ODX6n0GtpudLg32u52Uc29MxdzUqdswoY3FwThr4gdIG7KJWO2xw0fh/iUR3na7Fp2EvgJmmJDxsUZfmW/bFbEmMC7duC9mpVSL4poNxRnmV+8FuNM2T9KokzbQ4kbIcKm/N7sqGbEKTdX3NDJz5xJ2/5zK1Wi0HjWlrnFYMYUqEdr1TsqwredZwjy0EA8+BKhPFJzve1SsLwAJoMXwb6gFbkwzhOfupH6V1DZwDZKse2NVsxp8xcYoRHEeZ7oGHqhbufR1kLR2c75XC4wfMi7WWlrBEz008bs7I7sYMN3jKpJmsNnFQxhabcB/jRZLqJ3Ue5ap/5BDo0i4CeEFaFkgfSnrYzbjhBoLkFuVQXMKsHOYsofmwuq0IdiyI1nZbzz8Dlk44pGqF2V+54sWpVXnBWDxLWTrTagnscApNyMh2XP9+Bxhsdg7hcf31/weAdssEL5DYmzyk9G4+FJhrTai00zh/vIGbiHwIp4uJDPkqfd0H9fF5Z3RpKVv+FW+lpyEl9x7atSIJIeeCAa1DhLP1jRDxWaHhgUWVUoFMesa/U3jn8TQhfTCpoyCEJeSMBX8KhlBHXykg8Hygt7+QLPN6nc4MCGSpLsW1HSWyYjHcV3FaDSBrsy4USOY268aucQ9Z1Yl+hwrECZ2BoigauGY59vQlC1Af2ktmEGa2S5QChGHccDQUROIkSgEDbvOdBJN2NAr0xEyX5Gh9EEneBuNDN7Y9fMFPkIe7aERf2AHdK12Lj1Br08JuelGNMm+vMkL65Fo2yAsY0PH0IUOYaZbhXmwqp9YW62jdjzGEeHZnhp7Q2/gUAMtDx9M8zWYz0/QMsuoszRMnsgBLz6qEn15e0w+G6JJnXQC/6q7dJcYy5jWsBKJYK4mBUjW3IBcXLrxkWSf5FfKZwuuaa2GtrfpRnSrbfYrswbZzerBn19oaJzpalGuP3nFV/m0WC 1hhQ060L NVEDbHYH1ShXTy40pxKi1ulWsf7CULCrsUirz4rPag7i0ROi2swHSpALRCE7YlOgu2dh1NSI+2EfeGCfwGMFkfq0eNxjxGtK/Y0vSROnrvNh0k4LIKlHmZDagcSDgy5nJzbQK5rlRrNvYEQPXqomcMjJhOp47PAOyl3uxQSrUKRQVTUrlNgfJybNv5KBfM9GcnlNCfasXBsvqyDctDGe6PDeMWjZxJtZgezYsmpZ0Zs+cKw00xyMykwwepHKzCevoElZSmH+0sl2Sbl8FTab4eLbAeineG4/RriuOyaCflIDl731MZMKPFSj1CQLUcjPm/IUY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 29-09-23 20:30:03, Hugh Dickins wrote: > By historical accident, shmem_acct_block() and shmem_inode_acct_block() > were never pluralized when the pages argument was added, despite their > complements being shmem_unacct_blocks() and shmem_inode_unacct_blocks() > all along. It has been an irritation: fix their naming at last. > > Signed-off-by: Hugh Dickins OK. Feel free to add: Reviewed-by: Jan Kara Honza > --- > mm/shmem.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index caee8ba841f7..63ba6037b23a 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -189,10 +189,10 @@ static inline int shmem_reacct_size(unsigned long flags, > /* > * ... whereas tmpfs objects are accounted incrementally as > * pages are allocated, in order to allow large sparse files. > - * shmem_get_folio reports shmem_acct_block failure as -ENOSPC not -ENOMEM, > + * shmem_get_folio reports shmem_acct_blocks failure as -ENOSPC not -ENOMEM, > * so that a failure on a sparse tmpfs mapping will give SIGBUS not OOM. > */ > -static inline int shmem_acct_block(unsigned long flags, long pages) > +static inline int shmem_acct_blocks(unsigned long flags, long pages) > { > if (!(flags & VM_NORESERVE)) > return 0; > @@ -207,13 +207,13 @@ static inline void shmem_unacct_blocks(unsigned long flags, long pages) > vm_unacct_memory(pages * VM_ACCT(PAGE_SIZE)); > } > > -static int shmem_inode_acct_block(struct inode *inode, long pages) > +static int shmem_inode_acct_blocks(struct inode *inode, long pages) > { > struct shmem_inode_info *info = SHMEM_I(inode); > struct shmem_sb_info *sbinfo = SHMEM_SB(inode->i_sb); > int err = -ENOSPC; > > - if (shmem_acct_block(info->flags, pages)) > + if (shmem_acct_blocks(info->flags, pages)) > return err; > > might_sleep(); /* when quotas */ > @@ -447,7 +447,7 @@ bool shmem_charge(struct inode *inode, long pages) > { > struct address_space *mapping = inode->i_mapping; > > - if (shmem_inode_acct_block(inode, pages)) > + if (shmem_inode_acct_blocks(inode, pages)) > return false; > > /* nrpages adjustment first, then shmem_recalc_inode() when balanced */ > @@ -1671,7 +1671,7 @@ static struct folio *shmem_alloc_and_acct_folio(gfp_t gfp, struct inode *inode, > huge = false; > nr = huge ? HPAGE_PMD_NR : 1; > > - err = shmem_inode_acct_block(inode, nr); > + err = shmem_inode_acct_blocks(inode, nr); > if (err) > goto failed; > > @@ -2572,7 +2572,7 @@ int shmem_mfill_atomic_pte(pmd_t *dst_pmd, > int ret; > pgoff_t max_off; > > - if (shmem_inode_acct_block(inode, 1)) { > + if (shmem_inode_acct_blocks(inode, 1)) { > /* > * We may have got a page, returned -ENOENT triggering a retry, > * and now we find ourselves with -ENOMEM. Release the page, to > -- > 2.35.3 > -- Jan Kara SUSE Labs, CR