From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43DE9E75455 for ; Tue, 3 Oct 2023 13:07:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A964D8D006F; Tue, 3 Oct 2023 09:07:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A47228D0003; Tue, 3 Oct 2023 09:07:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90EE08D006F; Tue, 3 Oct 2023 09:07:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 833CF8D0003 for ; Tue, 3 Oct 2023 09:07:40 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 47E971402FE for ; Tue, 3 Oct 2023 13:07:40 +0000 (UTC) X-FDA: 81304177080.29.947AFCE Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf10.hostedemail.com (Postfix) with ESMTP id 362B7C0104 for ; Tue, 3 Oct 2023 13:06:37 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QcRQPssu; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=LlKeH0O8; dmarc=none; spf=pass (imf10.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696338398; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hBW6aALkPO3CT6TaCsu8tN/6UcJj9gFut487AL5616w=; b=rKwWYTXLRR3+Qnfo5brHiTQFUSYw4H73VtzQx0jib37jFtkShdkr7tllWe/qGhtV/B80zu whIbGgi1tvyIsw00wwCEX2CwWV5TonGKTzsccOdCLQG1hdvTubYgqPkrZ1ulpXjQg+HWhM CVEsdC59/yst4nxK1IJAcjRUpStaRes= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QcRQPssu; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=LlKeH0O8; dmarc=none; spf=pass (imf10.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696338398; a=rsa-sha256; cv=none; b=ro4xTGmejQHQsabPw09Z7X+Q/SWL2xzTHSl3mOan45AJrs45gW6zOPg/gDVWQu1XhDe5wZ Xr1BBxvLVejtdqyVAopf6KcuhKkHfCu0/YCS8lGQNmunYXmGqgeMPeYMM5cbpFkjrCeiip zvqkidF1zQ+duKzZE7SLkaeBL7vOdEQ= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C0E9A1F45B; Tue, 3 Oct 2023 13:06:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1696338395; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hBW6aALkPO3CT6TaCsu8tN/6UcJj9gFut487AL5616w=; b=QcRQPssugIvbxgWLAS2VGtKXSx5CY+ZdaiiMLY/XHjeNBNDY9OvYCcKBYgNN59N2Ca9Ujt v9DWcdQk/XBqS9rfr/U1yUBwv7XK0fJXdts9d4QEXRdZPW4OIqFv1d/7TioCl6X+rIlGnE /8kAOQVAL1yabk1Ph3hrWl1Knj/wMvc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1696338395; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hBW6aALkPO3CT6TaCsu8tN/6UcJj9gFut487AL5616w=; b=LlKeH0O8KpUR1zRBRWw/IGDhqnN8yAglhJMlsJSXEM9+ntps/cNngnCnQkSIL9gIP8APUw MHCgdFAKRgkXWnAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B0EBD132D4; Tue, 3 Oct 2023 13:06:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id HSUnK9sRHGUvLgAAMHmgww (envelope-from ); Tue, 03 Oct 2023 13:06:35 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 3C9D0A07CC; Tue, 3 Oct 2023 15:06:35 +0200 (CEST) Date: Tue, 3 Oct 2023 15:06:35 +0200 From: Jan Kara To: Hugh Dickins Cc: Andrew Morton , Christian Brauner , Carlos Maiolino , Chuck Lever , Jan Kara , Matthew Wilcox , Johannes Weiner , Axel Rasmussen , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/8] shmem: shrink shmem_inode_info: dir_offsets in a union Message-ID: <20231003130635.hn2ljuorlf7rdodx@quack3> References: <86ebb4b-c571-b9e8-27f5-cb82ec50357e@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86ebb4b-c571-b9e8-27f5-cb82ec50357e@google.com> X-Rspam-User: X-Stat-Signature: wdh5a4h8med1eufzmid3edmgama5pca1 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 362B7C0104 X-HE-Tag: 1696338397-212036 X-HE-Meta: U2FsdGVkX1/KMH8U1a2sH8I99a5433yZHmcCxPm1g48JpyaAWEfPOSy/gc7JlG8/uk42QLiQhc7dUa8hpOmQD8cy0XVDS5NF/dAWCxkUZA6FEn85j3wBVWuAEHv5yVSArBwnX0zv+6woED6aX2Hi0/ggKyva6rTE/k/H4niWc5RTc7VU2oSTFhcnVZvecW1EpFS8ts/5S4WSUSFljtGclOqDunh3etsnnssVZrNbYIchb1AW1XU4id1ldrMX9VmZfnCvaBITHBcWi4+QQRRygPYQJrWmtByHn79w4T0o60vh9uGUctDgm5m2VBNlMalSamramgtAb/r3e3FgK9uSyWP2aOM/6m4pJBnli7wJGcRN2Hs3szx4072dKlrj2YFtFADaw4ITmpiguO9mHMrnWOCESbji/Se04x2cT6dKXr3DMKjQFnSn+HmBIHrS/7uh48rKsUYdoHo3dcRF+FxVojy/G64h4beWuFy8+Vi81RMhov6Vj/fGQJTGuyrKvIE7Vk1J1dLXDV6O1MPbCFEicFHCYg0OQtkZ/7eDcW6aD7LaMLZHYN98qGZJMj6hu0g5L2clsaWAX0corZktcPWLIbq5ebzff34c0nkdXHeEd+jACeJ+Xm35G6X6kPyPxZj/sGdwR/LW6Q62lEhhLzM0BfDedtjz+yx82YyucLubd/+9YA2ZfEAPAWl+HUwKNwvQwfI5yDf4RyzHHCQkJ13kRTogmTMlUPwx7eLBIjMZp0s29Lk6ovga6Ag8IxaBJNGT968ZPZ4atbZvGdiD7jucl+bmClKmfIh9RIPNMWWCPJbTHZL3T5V0HFhQPCEco7nORTXdBlcTMWYfFwCPh/OFUYbmVWgB5MWDrp3f7gbTITYIj8XSBwJbDwaE0q9KT91hdkoxCAuwlSW7yBdhxBww2//WzP1uIkBOstQYMT5HAP8S5pVR4G+4BXKyF7yvak8GaW2LnxuTxxwgVMOc3jZ A1rdu6lB n6Lt6Fp/S+uemf+dD9133/5170ZRu8tXZGB6Bwkv7u1cZAa5NZzfANxVZpWHRY1d5W1S5xfH3iafuaPNcTcuMqvNkryUYBtAOaPcgREYYBa+mlqQouu4EzAdfwypUhbLsCQspfQYgO7tNwE50YNuTYxudGMZB9KdobzDfIzmda4TWxXAd8kybb3iammQDWWPxpwAsDvbKDRn44pm/0YCC1pvbN86xpAUNSGlPEC9IDUlgAcPqmBf3joGj7tzpnIVFR16tB5nkvcCI+JfgqQ2OxyoIThq5JsYLkuIGBzM9A1F2E9ny8ozJuRgaSkUo+s7U6P6N X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 29-09-23 20:25:38, Hugh Dickins wrote: > Shave 32 bytes off (the 64-bit) shmem_inode_info. There was a 4-byte > pahole after stop_eviction, better filled by fsflags. And the 24-byte > dir_offsets can only be used by directories, whereas shrinklist and > swaplist only by shmem_mapping() inodes (regular files or long symlinks): > so put those into a union. No change in mm/shmem.c is required for this. > > Signed-off-by: Hugh Dickins Looks good to me. Feel free to add: Reviewed-by: Jan Kara Honza > --- > include/linux/shmem_fs.h | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/include/linux/shmem_fs.h b/include/linux/shmem_fs.h > index 6b0c626620f5..2caa6b86106a 100644 > --- a/include/linux/shmem_fs.h > +++ b/include/linux/shmem_fs.h > @@ -23,18 +23,22 @@ struct shmem_inode_info { > unsigned long flags; > unsigned long alloced; /* data pages alloced to file */ > unsigned long swapped; /* subtotal assigned to swap */ > - pgoff_t fallocend; /* highest fallocate endindex */ > - struct list_head shrinklist; /* shrinkable hpage inodes */ > - struct list_head swaplist; /* chain of maybes on swap */ > + union { > + struct offset_ctx dir_offsets; /* stable directory offsets */ > + struct { > + struct list_head shrinklist; /* shrinkable hpage inodes */ > + struct list_head swaplist; /* chain of maybes on swap */ > + }; > + }; > + struct timespec64 i_crtime; /* file creation time */ > struct shared_policy policy; /* NUMA memory alloc policy */ > struct simple_xattrs xattrs; /* list of xattrs */ > + pgoff_t fallocend; /* highest fallocate endindex */ > + unsigned int fsflags; /* for FS_IOC_[SG]ETFLAGS */ > atomic_t stop_eviction; /* hold when working on inode */ > - struct timespec64 i_crtime; /* file creation time */ > - unsigned int fsflags; /* flags for FS_IOC_[SG]ETFLAGS */ > #ifdef CONFIG_TMPFS_QUOTA > struct dquot *i_dquot[MAXQUOTAS]; > #endif > - struct offset_ctx dir_offsets; /* stable entry offsets */ > struct inode vfs_inode; > }; > > -- > 2.35.3 > -- Jan Kara SUSE Labs, CR